Page MenuHomePhabricator
Feed Advanced Search

Apr 8 2019

Fabien committed rABC3d178846ff10: FreeBSD: Document Python 3 requirement for 'gmake check' (authored by Murray Nesbitt <github@nesbitt.ca>).
FreeBSD: Document Python 3 requirement for 'gmake check'
Apr 8 2019, 18:23
Fabien closed D2649: FreeBSD: Document Python 3 requirement for 'gmake check'.
Apr 8 2019, 18:23
Fabien committed rABC3b290495f311: doc: split FreeBSD build instructions out of build-unix.md (authored by steverusso <steverusso@protonmail.com>).
doc: split FreeBSD build instructions out of build-unix.md
Apr 8 2019, 16:48
Fabien closed D2648: doc: split FreeBSD build instructions out of build-unix.md.
Apr 8 2019, 16:48
Fabien committed rABC314819a24be7: Drop support for OpenBSD (authored by Fabien).
Drop support for OpenBSD
Apr 8 2019, 16:46
Fabien closed D2461: Drop support for OpenBSD.
Apr 8 2019, 16:46
Fabien committed rABCa48b9f299778: Make c++14 standard the default for compilation (authored by Fabien).
Make c++14 standard the default for compilation
Apr 8 2019, 16:44
Fabien closed D2462: Make c++14 standard the default for compilation.
Apr 8 2019, 16:44
Herald added a reviewer for D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory: deadalnix.
Apr 8 2019, 15:32
Fabien updated the test plan for D2735: Add scripted-diffs verification into arcanist.
Apr 8 2019, 13:13
Fabien updated the diff for D2735: Add scripted-diffs verification into arcanist.

Use arcanist facilities to run the script from the root directory.
Make the check insensible to the linter formatting.

Apr 8 2019, 13:10
Fabien accepted D2784: Remove unused parameter `validFeeEstimates` from `CTxMempool::addUnchecked`.
Apr 8 2019, 08:34
Fabien accepted D2785: Fix comment in CheckInputs to match changed code.
Apr 8 2019, 07:46
Fabien updated the diff for D2462: Make c++14 standard the default for compilation.

Rebase

Apr 8 2019, 07:26
Fabien committed rABCe4eb195755c9: Fix signrawtransaction failing when a wallet URI is specified (authored by Fabien).
Fix signrawtransaction failing when a wallet URI is specified
Apr 8 2019, 07:24
Fabien closed D2771: Fix signrawtransaction failing when a wallet URI is specified.
Apr 8 2019, 07:24
Fabien committed rABC646b7a6ae44d: [CI] Add an option to build and run unit tests with debug enabled (authored by Fabien).
[CI] Add an option to build and run unit tests with debug enabled
Apr 8 2019, 07:23
Fabien closed D2776: [CI] Add an option to build and run unit tests with debug enabled.
Apr 8 2019, 07:23

Apr 5 2019

Fabien committed rABC193d2b9c296a: Fix Windows build errors introduced in D2765 (authored by practicalswift <practicalswift@users.noreply.github.com>).
Fix Windows build errors introduced in D2765
Apr 5 2019, 20:52
Fabien closed D2779: Fix Windows build errors introduced in D2765.
Apr 5 2019, 20:52
Fabien updated the summary of D2779: Fix Windows build errors introduced in D2765.
Apr 5 2019, 20:50
Herald added a reviewer for D2779: Fix Windows build errors introduced in D2765: deadalnix.
Apr 5 2019, 20:48
Fabien committed rABC4c92f4c7b84f: Format the php files (authored by Fabien).
Format the php files
Apr 5 2019, 16:02
Fabien closed D2760: Format the php files.
Apr 5 2019, 16:02
Herald added a reviewer for D2776: [CI] Add an option to build and run unit tests with debug enabled: deadalnix.
Apr 5 2019, 15:58
Fabien added inline comments to D2764: [LINTER] Enforce custom coding standard for PHP files.
Apr 5 2019, 10:22
Fabien updated the diff for D2764: [LINTER] Enforce custom coding standard for PHP files.

Exclude object operator from the strict indentation check

Apr 5 2019, 10:15
Fabien updated the diff for D2760: Format the php files.

Indent multiline statements outside of a control block

Apr 5 2019, 10:13
Fabien updated the diff for D2462: Make c++14 standard the default for compilation.

Also include instructions for windows build. If the build is done
with WSL as per the instructions there will be no issue, but when
building from another linux the compiler version may vary.

Apr 5 2019, 09:24
Fabien updated the diff for D2462: Make c++14 standard the default for compilation.

Move the compiler warning to the build instructions

Apr 5 2019, 09:18
Fabien added a comment to D2735: Add scripted-diffs verification into arcanist.

It will not conflict with other linters because it is run before the linters.
It will conflict with other programs accessing the tree at the same time the same way that git checkout would do.

Apr 5 2019, 08:41

Apr 4 2019

Fabien updated the diff for D2771: Fix signrawtransaction failing when a wallet URI is specified.

Rebase

Apr 4 2019, 15:17
Fabien committed rABC92d66e964a47: [Target v0.19] Deprecate and add test for signrawtransaction (authored by Fabien).
[Target v0.19] Deprecate and add test for signrawtransaction
Apr 4 2019, 15:15
Fabien closed D2009: [Target v0.19] Deprecate and add test for signrawtransaction.
Apr 4 2019, 15:15
Fabien added a comment to D2771: Fix signrawtransaction failing when a wallet URI is specified.

signrawtransaction is now deprecated on core, so the issue cannot happen anymore.
Up to the removal of the RPC the URI was not forwarded, and I couldn't find anything related to the issue in core, I suppose the issue has never been found or never occurred.
@florian also told me that he did some research and couldn't find anything either.

Apr 4 2019, 15:14
Fabien updated the diff for D2009: [Target v0.19] Deprecate and add test for signrawtransaction.

Rebase

Apr 4 2019, 14:45
Fabien committed rABCcffcc6a78558: Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc (authored by Fabien).
Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc
Apr 4 2019, 12:37
Fabien closed D2763: Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc.
Apr 4 2019, 12:37
Herald added a reviewer for D2771: Fix signrawtransaction failing when a wallet URI is specified: deadalnix.
Apr 4 2019, 12:16
Fabien accepted D2770: Add tip to the create Debian VM instructions.
Apr 4 2019, 08:53
Fabien updated the diff for D2764: [LINTER] Enforce custom coding standard for PHP files.

Exclude comment blocks from strict alignment

Apr 4 2019, 07:32
Fabien added inline comments to D2760: Format the php files.
Apr 4 2019, 07:30
Fabien updated the diff for D2760: Format the php files.

Fix comment alignment

Apr 4 2019, 07:29
Fabien updated the summary of D2760: Format the php files.
Apr 4 2019, 06:21

Apr 3 2019

Fabien accepted D2711: Document method for reviewers to verify chainTxData.

Updating the txrate can be added later to the release process with no drawback, and I agree with Jason that it has low value.

Apr 3 2019, 14:44
Fabien accepted D2645: Reject headers building on invalid chains by tracking invalidity.
Apr 3 2019, 07:46

Apr 2 2019

Fabien updated the diff for D2009: [Target v0.19] Deprecate and add test for signrawtransaction.

Rebase

Apr 2 2019, 19:29
Fabien accepted D2719: Backport remaining changes from Core PR 10742.
Apr 2 2019, 19:26
Fabien accepted D2732: [rpc] getblockchaininfo: add size_on_disk, prune_target_size, automatic_pruning.
Apr 2 2019, 19:22
Fabien updated the diff for D2462: Make c++14 standard the default for compilation.

Rebase and reword release notes as suggested

Apr 2 2019, 19:14
Fabien added inline comments to D2732: [rpc] getblockchaininfo: add size_on_disk, prune_target_size, automatic_pruning.
Apr 2 2019, 17:49
Fabien requested changes to D2732: [rpc] getblockchaininfo: add size_on_disk, prune_target_size, automatic_pruning.

This deserves an entry in the release notes

Apr 2 2019, 15:16
Fabien accepted D2748: Add schnorr sign benchmark.
Apr 2 2019, 14:59
Fabien accepted D2749: Add schnorr verify benchmark.
Apr 2 2019, 14:59
Fabien accepted D2746: Merge #10275: [rpc] Allow fetching tx directly from specified block in getrawtransaction.
Apr 2 2019, 14:49
Herald added a reviewer for D2764: [LINTER] Enforce custom coding standard for PHP files: deadalnix.
Apr 2 2019, 12:54
Fabien updated the diff for D2760: Format the php files.

Update formatting to something close to phabricator standard

Apr 2 2019, 12:46
Fabien updated the diff for D2464: Use c++14 generic std::rbegin() and std::rend() instead of class methods.

Rebase

Apr 2 2019, 09:52
Fabien accepted D2761: Bump version numbers to 0.19.3.
Apr 2 2019, 09:45
Fabien updated the diff for D2463: Migrate MakeUnique to c++14 std::make_unique.

Rebase

Apr 2 2019, 09:36
Fabien committed rABCbe1b951a84b0: Fix arc liberate complaining about concatenation in constant definition (authored by Fabien).
Fix arc liberate complaining about concatenation in constant definition
Apr 2 2019, 09:02
Fabien closed D2759: Fix arc liberate complaining about concatenation in constant definition.
Apr 2 2019, 09:02
Fabien committed rABC9d53b39b2564: [LINTER] Escape the % char in the description of PythonFormatLinter (authored by Fabien).
[LINTER] Escape the % char in the description of PythonFormatLinter
Apr 2 2019, 09:02
Fabien closed D2757: [LINTER] Escape the % char in the description of PythonFormatLinter.
Apr 2 2019, 09:01
Fabien updated the diff for D2009: [Target v0.19] Deprecate and add test for signrawtransaction.

Rebase

Apr 2 2019, 08:54
Fabien updated the summary of D2009: [Target v0.19] Deprecate and add test for signrawtransaction.
Apr 2 2019, 08:52
Herald added a reviewer for D2763: Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc: deadalnix.
Apr 2 2019, 08:51
Fabien updated the diff for D2462: Make c++14 standard the default for compilation.

Rebase and add an entry in the release notes

Apr 2 2019, 07:40
Fabien added a comment to D2462: Make c++14 standard the default for compilation.

I will add the entry if you think it's useful.
I have been asking myself about this, but thought it was unnecessary because it's not user facing.

Apr 2 2019, 07:33

Apr 1 2019

Fabien planned changes to D2760: Format the php files.

I will define a custom ruleset to make it closer to original's standard.

Apr 1 2019, 19:41
Herald added a reviewer for D2760: Format the php files: deadalnix.
Apr 1 2019, 16:12
Herald added a reviewer for D2759: Fix arc liberate complaining about concatenation in constant definition: deadalnix.
Apr 1 2019, 13:12
Fabien accepted D2758: Lint everything.
Apr 1 2019, 11:33
Fabien updated the test plan for D2735: Add scripted-diffs verification into arcanist.
Apr 1 2019, 09:45
Fabien updated the diff for D2735: Add scripted-diffs verification into arcanist.

Run the script directly instead of writing first to a file.
Check that the working tree is clean before calling git checkout.
Improve the error message if the script returns an error.

Apr 1 2019, 09:44

Mar 31 2019

Fabien added a comment to D2735: Add scripted-diffs verification into arcanist.

A linter runs once per file, which is not the expected workflow here as the check covers the entire working tree.

Mar 31 2019, 18:52
Herald added a reviewer for D2757: [LINTER] Escape the % char in the description of PythonFormatLinter: deadalnix.
Mar 31 2019, 08:13

Mar 30 2019

Fabien committed rABCc018bd540341: [LINTER] Enforce a minimum version for autopep8 (authored by Fabien).
[LINTER] Enforce a minimum version for autopep8
Mar 30 2019, 14:37
Fabien closed D2754: [LINTER] Enforce a minimum version for autopep8.
Mar 30 2019, 14:37
Fabien requested changes to D2755: [secp256k1] add schnorr sign jni binding.

The diff title is is about schnorr_verify but the content is about schnorr_sig.
Maybe you can look at the tests from libsecp256k1 to add the missing failing cases.

Mar 30 2019, 10:14
Fabien requested changes to D2746: Merge #10275: [rpc] Allow fetching tx directly from specified block in getrawtransaction.

Can you add an entry in the release notes for the new rpc param ?

Mar 30 2019, 09:16
Fabien committed rABC463c4d9d59ea: [CI] Improve performance when running the tests (authored by Fabien).
[CI] Improve performance when running the tests
Mar 30 2019, 09:13
Fabien closed D2753: [CI] Improve performance when running the tests.
Mar 30 2019, 09:12
Fabien committed rABC2e36d9883c05: Improve teamcity agent setup documentation and service script (authored by Fabien).
Improve teamcity agent setup documentation and service script
Mar 30 2019, 09:09
Fabien closed D2751: Improve teamcity agent setup documentation and service script.
Mar 30 2019, 09:09
Fabien updated the diff for D2754: [LINTER] Enforce a minimum version for autopep8.

Accomodate autopep8 version being outputted to sdtout or stderr depending on the version.
Allow for a.b or a.b.c numbering scheme.

Mar 30 2019, 08:59

Mar 29 2019

Fabien planned changes to D2754: [LINTER] Enforce a minimum version for autopep8.
Mar 29 2019, 19:26
Fabien updated the summary of D2754: [LINTER] Enforce a minimum version for autopep8.
Mar 29 2019, 11:19
Herald added a reviewer for D2754: [LINTER] Enforce a minimum version for autopep8: deadalnix.
Mar 29 2019, 10:13
Herald added a reviewer for D2753: [CI] Improve performance when running the tests: deadalnix.
Mar 29 2019, 07:54
Fabien accepted D2752: Allow setting an env variable to skip tests in build.sh.
Mar 29 2019, 07:34
Fabien updated the diff for D2751: Improve teamcity agent setup documentation and service script.

Make clear what commands need to be run as root

Mar 29 2019, 07:07
Fabien added inline comments to D2751: Improve teamcity agent setup documentation and service script.
Mar 29 2019, 07:04
Fabien retitled D2751: Improve teamcity agent setup documentation and service script from Iprove teamcity agent setup documentation and service script to Improve teamcity agent setup documentation and service script.
Mar 29 2019, 06:58

Mar 28 2019

Herald added a reviewer for D2751: Improve teamcity agent setup documentation and service script: deadalnix.
Mar 28 2019, 22:30
Herald added a reviewer for D2750: [CMAKE] Move .h files transformed from .ui to the form subdirectory: deadalnix.
Mar 28 2019, 15:14
Fabien updated the diff for D2735: Add scripted-diffs verification into arcanist.

Rebase

Mar 28 2019, 12:22
Fabien committed rABCf00d08b715e9: [LINTER] Integrate lint-locale-dependence.sh into arcanist (authored by Fabien).
[LINTER] Integrate lint-locale-dependence.sh into arcanist
Mar 28 2019, 12:12
Fabien closed D2705: [LINTER] Integrate lint-locale-dependence.sh into arcanist.
Mar 28 2019, 12:12
Fabien committed rABC272aedf4f881: Fix a potential segfault in the seeder (authored by Fabien).
Fix a potential segfault in the seeder
Mar 28 2019, 11:34