- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Apr 8 2019
Use arcanist facilities to run the script from the root directory.
Make the check insensible to the linter formatting.
Rebase
Apr 5 2019
Exclude object operator from the strict indentation check
Indent multiline statements outside of a control block
Also include instructions for windows build. If the build is done
with WSL as per the instructions there will be no issue, but when
building from another linux the compiler version may vary.
Move the compiler warning to the build instructions
It will not conflict with other linters because it is run before the linters.
It will conflict with other programs accessing the tree at the same time the same way that git checkout would do.
Apr 4 2019
Rebase
signrawtransaction is now deprecated on core, so the issue cannot happen anymore.
Up to the removal of the RPC the URI was not forwarded, and I couldn't find anything related to the issue in core, I suppose the issue has never been found or never occurred.
@florian also told me that he did some research and couldn't find anything either.
Rebase
Exclude comment blocks from strict alignment
Apr 3 2019
Updating the txrate can be added later to the release process with no drawback, and I agree with Jason that it has low value.
Apr 2 2019
Rebase
Rebase and reword release notes as suggested
This deserves an entry in the release notes
Update formatting to something close to phabricator standard
Rebase
Rebase
Rebase
Rebase and add an entry in the release notes
I will add the entry if you think it's useful.
I have been asking myself about this, but thought it was unnecessary because it's not user facing.
Apr 1 2019
I will define a custom ruleset to make it closer to original's standard.
Run the script directly instead of writing first to a file.
Check that the working tree is clean before calling git checkout.
Improve the error message if the script returns an error.
Mar 31 2019
A linter runs once per file, which is not the expected workflow here as the check covers the entire working tree.
Mar 30 2019
The diff title is is about schnorr_verify but the content is about schnorr_sig.
Maybe you can look at the tests from libsecp256k1 to add the missing failing cases.
Can you add an entry in the release notes for the new rpc param ?
Accomodate autopep8 version being outputted to sdtout or stderr depending on the version.
Allow for a.b or a.b.c numbering scheme.
Mar 29 2019
Make clear what commands need to be run as root
Mar 28 2019
Rebase