Feed Advanced Search
Sep 27 2019
Sep 27 2019
[CMAKE] Always build obj/build.h
Fabien updated the diff for D4167: Add support for Glibc version 2.28.
Fix autotools detection by moving the check before the CFLAGS enforce LFS.
Fix glibc_compat.cpp comment confusion between LFS and LFN.
Fabien planned changes to D4167: Add support for Glibc version 2.28.
Build fails with autotools (is_same(off_t, off64_t) returns true on linux32 platform ???).
Fabien added inline comments to D4148: Use only 3 levels for defining the version.
Fabien updated the diff for D4148: Use only 3 levels for defining the version.
Rebase and address feedback.
Fabien added a comment to D4167: Add support for Glibc version 2.28.
Note to reviewers:
Sep 26 2019
Sep 26 2019
Fabien committed rABCcd0f483aa801: [CMAKE] Detect if the compiler supports visibility function attribute (authored by Fabien).
[CMAKE] Detect if the compiler supports visibility function attribute
[CMAKE] Install executables
Fabien added inline comments to D4152: [CMAKE] Detect if the compiler supports visibility function attribute.
Fabien added inline comments to D4146: [CMAKE] Install executables.
Fabien requested changes to D4154: Merge #13158: [Qt]: Improve sendcoinsdialog readability.
Note the missing translations.
Fabien requested changes to D4150: Merge #12218: net: Move misbehaving logging to net logging category.
Not sure about the pfrom to pfrom->GetId() reversal, that seems to make the call more verbose for no good reason. The pfrom form is the one used constantly in net_processing.cpp.
Sep 25 2019
Sep 25 2019
[CMAKE] Install the man pages
[CMAKE] Add the check-security target
[CMAKE] Add the check-symbols target
Fabien requested changes to D3714: Added a script for creating Github release drafts.
Fabien added inline comments to D4120: Added a script to generate chainparams constants from intermediate files.
Fabien requested changes to D4120: Added a script to generate chainparams constants from intermediate files.
Fabien updated the diff for D4147: [CMAKE] Install the man pages.
Fix copy/paste error.
Sep 24 2019
Sep 24 2019
Fabien added inline comments to D4148: Use only 3 levels for defining the version.
Fabien updated the test plan for D4148: Use only 3 levels for defining the version.
Fabien added inline comments to D4148: Use only 3 levels for defining the version.
Fabien committed rABCe36935e09971: [CMAKE] Consistently find and use the python interpreter (authored by Fabien).
[CMAKE] Consistently find and use the python interpreter
Fabien committed rABC46261be23880: [CMAKE] Migrate the python header generation scripts to python 3 (authored by Fabien).
[CMAKE] Migrate the python header generation scripts to python 3
Fabien committed rABC71191d04adaa: [CMAKE] Only change obj/build.h if the content has changed (authored by Fabien).
[CMAKE] Only change obj/build.h if the content has changed
Fabien requested changes to D4120: Added a script to generate chainparams constants from intermediate files.
Fabien requested changes to D3714: Added a script for creating Github release drafts.
Please fix the remaining linter issues.
Fabien updated the diff for D4137: [CMAKE] Add the check-security target.
Rebase and don't run security checks on target which are not intended to be installed.
Fabien updated the diff for D4136: [CMAKE] Add the check-symbols target.
Rebase on top of D4144.
Update comment as per feedback.
Do not check bench or test binaries, that are not intended to be installed.
Fabien updated the diff for D4144: [CMAKE] Consistently find and use the python interpreter.
Search python once.
Fabien retitled D4144: [CMAKE] Consistently find and use the python interpreter from [CMAKE] Consistently find the python interpreter to [CMAKE] Consistently find and use the python interpreter.
Fabien planned changes to D4144: [CMAKE] Consistently find and use the python interpreter.
Fabien planned changes to D4137: [CMAKE] Add the check-security target.
Fabien planned changes to D4136: [CMAKE] Add the check-symbols target.
Sep 23 2019
Sep 23 2019
Fabien added inline comments to D4134: wallet: Use shared pointer to retain wallet instance.
Fabien added inline comments to D4116: [CMAKE] Only change obj/build.h if the content has changed.
Fabien updated the diff for D4116: [CMAKE] Only change obj/build.h if the content has changed.
Address feedback.
Fabien committed rABC317e1eaef78d: [CMAKE] Fix linux cross compilation with the glibc compatibility (authored by Fabien).
[CMAKE] Fix linux cross compilation with the glibc compatibility
Fabien committed rABC093479065d92: [CMAKE] Remove useless dependency for the check-rpcauth target (authored by Fabien).
[CMAKE] Remove useless dependency for the check-rpcauth target
Fabien requested changes to D4134: wallet: Use shared pointer to retain wallet instance.
Sep 22 2019
Sep 22 2019
Fabien requested changes to D4130: scripted-diff: batch-recase BanMan variables.
Fabien updated the summary of D4130: scripted-diff: batch-recase BanMan variables.
Fabien updated the summary of D4127: banman: add thread annotations and mark members const where possible.
Fabien requested changes to D4125: net: move BanMan to its own files.
Sep 20 2019
Sep 20 2019
Fabien requested changes to D4114: banman: create and split out banman.
Fabien updated the diff for D4116: [CMAKE] Only change obj/build.h if the content has changed.
Enquote path to git executable.
Fabien updated the diff for D4116: [CMAKE] Only change obj/build.h if the content has changed.
Don't assume git.
Fabien added inline comments to D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.
[CMAKE] Always build obj/build.h
Fabien requested changes to D4112: Merge #13079: Fix rescanblockchain rpc to properly report progress.
The test plan is not testing the issue is fixed.
The behavior is changed when there is a partial rescan with some stop height, not a full rescan.