What do you think backporting PR12172 (D2957) and https://github.com/bitcoin/bitcoin/pull/12842 alongside this diff? This will avoid having open issues in the codebase.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
May 7 2019
May 7 2019
Fabien requested changes to D2960: Merge #10489: build: silence gcc7's implicit fallthrough warning.
Can you also add it to src/CMakeLists.txt ?
Please update the test plan, make check does not cover the behavior change.
Note to other reviewers: the bugfix PR12377 has already been backported in D2545
May 6 2019
May 6 2019
Herald added a reviewer for D2949: [CMAKE] Fix the prl conversion script linking against lib_NOTFOUND: deadalnix.
Herald added a reviewer for D2948: [CMAKE] Fix the prl conversion script library path issue: deadalnix.
Herald added a reviewer for D2947: [CMAKE] Determine the Qt library directory from a public variable: deadalnix.
The original PR contains tabs alignment fixes on the rpc helps which are not ported here, I'm not sure if this is deliberate or not. I leave this up to you.
Fabien committed rABC6bb649a50f6a: test: Plug memory leaks and stack-use-after-scope (authored by Fabien).
test: Plug memory leaks and stack-use-after-scope
Fix a memory leak in DoS_tests
Fabien updated the diff for D2880: [LINTER] Revive the locale dependent functions linter in arcanist.
Rebase
Fabien committed rABC4adac02d223b: [CMAKE] Make RelWithDebInfo the default CMake configuration (authored by Fabien).
[CMAKE] Make RelWithDebInfo the default CMake configuration
Fabien updated the diff for D2892: [CMAKE] Add an option to enable the glibc compatibility features.
Check for rt lib
May 5 2019
May 5 2019
@deadalnix As mentioned in the summary, it has already been ported. You added the test in D1771 with the fix included.
May 4 2019
May 4 2019
Tested OK
Use angle bracket in include for qt tests
The issue is that the modification in test_bitcoin is incompatible with avalanche_tests implementation and DoS_tests since D2919 (it leads to double free, crashing the tests).
May 3 2019
May 3 2019
Rebase on top of D2919
Fabien committed rABCe96aa00b34db: Use angle bracket in include for remaining qt files (authored by Fabien).
Use angle bracket in include for remaining qt files
Fabien committed rABCbd1c7fb8a430: Use angle bracket in include for qt pages, widgets and views (authored by Fabien).
Use angle bracket in include for qt pages, widgets and views
Fabien committed rABCd4ffefd870eb: Use angle bracket in include for qt model files (authored by Fabien).
Use angle bracket in include for qt model files
Fabien committed rABCd65e93b70a69: Use angle bracket in include for qt dialog files (authored by Fabien).
Use angle bracket in include for qt dialog files
Fabien committed rABC69b4b5c786dd: Use angle bracket in include for qt/bitcoin* files (authored by Fabien).
Use angle bracket in include for qt/bitcoin* files
Address feedback
Herald added a reviewer for D2915: Use angle bracket in include for qt pages, widgets and views: deadalnix.
May 2 2019
May 2 2019
Fabien requested changes to D2900: Add developer notes about blocking GUI code and src/interfaces/README.md.
Ok let this move forward and clean it later
May 1 2019
May 1 2019
Fabien committed rABCba2462d27ac2: [LINTER] Remove the lint-format-strings.sh script (authored by Fabien).
[LINTER] Remove the lint-format-strings.sh script
Fabien committed rABC93e2cadf33ff: [LINTER] Move the string formatting function list to the python script (authored by Fabien).
[LINTER] Move the string formatting function list to the python script
Fix typo in file name: FormaStringLinter.php => FormatStringLinter.php
Apr 30 2019
Apr 30 2019
Fabien committed rABCb96fa03b4204: [CI] Make gitian builds run on multiple cpus (authored by Fabien).
[CI] Make gitian builds run on multiple cpus
Fabien committed rABCa6a9e5a86421: [LINTER] Improve lint-format-strings.sh performance (authored by Fabien).
[LINTER] Improve lint-format-strings.sh performance
Fabien updated the diff for D2880: [LINTER] Revive the locale dependent functions linter in arcanist.
Fix nits
Fabien requested changes to D2890: Merge #11578: net: Add missing lock in ProcessHeadersMessage(...).
LookupBlockIndex()'s first line is an AssertLockHeld(cs_main), so whether the lock is already held or the path is not covered by any test.
Fabien updated the diff for D2892: [CMAKE] Add an option to enable the glibc compatibility features.
Rebase
Herald added a reviewer for D2892: [CMAKE] Add an option to enable the glibc compatibility features: deadalnix.
Apr 29 2019
Apr 29 2019
Apr 29 2019, 08:59 ยท Restricted Project
Apr 26 2019
Apr 26 2019
Herald added a reviewer for D2882: [LINTER] Move the string formatting function list to the python script: deadalnix.
Add newline at end of line
Herald added a reviewer for D2880: [LINTER] Revive the locale dependent functions linter in arcanist: deadalnix.