In D3331#80339, @markblundeberg wrote:

Note: in principle in this Diff, I could take out the two remaining *uses* of this flag as well, from MANDATORY_SCRIPT_VERIFY_FLAGS and from GetNextBlockScriptFlags (aka GetBlockScriptFlags). At the moment they are removed in the follow-up diff D3332.

If I did this, then D3332 would be basically a pure test-cleanup diff that quite manifestly doesn't touch any consensus code.

Looks good

Checked throught the Diff again, looks good to me.

This looks good to me. I played around with this a bit, it all seems to work.

Remove added newline

Did another pass over the Diff today, it looks good to me.

Looks good to me.

Looks good overall, I noted a couple minor nits.

Add more reviewers

Abandon in favor of D3194

Abandon in favor of D3194

Abandon in favor of D3194

Abandon in favor of D3194

Update script test comments per Mark's suggestion
Rebase

@deadalnix I don't have a clear understanding of what you want.

This is the same as D3148, D3065, and D3160 squashed into one change.

Update test plan
Improve description
Rebase on D3065

Rename test class

Rename functional test

Rebase on D3065

Restore functional test portion that test accepting blocks containing Segwit recovery transactions.

Add dependency to description.

Edit description.

Change functional test to run at "current" time.
Rebase on updated D3248

Add unit tests for "0 left on stack" case with segwit recovery disallowed.
Clarify descriptions of script tests so that it's easier to see tests with the flag enabled.

@deadalnix I am trying to follow the step you outlined here: https://reviews.bitcoinabc.org/D3065#72372

To do: add to standard flags.

Work in progress
Rebase on D3148

I will rebase this on top of D3148 as-per @deadalnix review comment.

Keep flag name in scriptflags.cpp list

Remove duplicate test cases

Rebase

Rebase

Don't rename flag in script tests.
Rebase on master.

Looks good to me. I checked it against the core PR, and current Core code.

Re-comment auto-test generating #define
Rebase on master

In the review of D3100, @markblundeberg had suggested renaming the flag. This Diff does that.

Fix description nit and rebase.

Improve comments in checkdatasig_tests.cpp

Remove test bloat.
Make comments in checkdatasig_tests.cpp more precise.
Rebase on master.

Added duplicate CHECKDATASIG tests with flag off to script_tests.cpp to generate auto test cases.

In D3100#73242, @markblundeberg wrote:

I'm also thinking that maybe all the script tests that include the CHECKDATASIG script flag should stop referring to it, except for tests of sigops counting. However if other implementations are relying on those flags being in script_tests.json then maybe they should be kept.

Remove redundant brackets and rebase.