Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Jul 23 2019

jasonbcox accepted D3713: Add license blurb to server_tests.

Jul 23 2019, 00:56

Jul 22 2019

jasonbcox requested changes to D3710: Move PHPCS config file where it is used.

Really confused about where the direction of this is heading. See D3288 which renamed away from a similar name, and in a location that used to be here but was actually better (arcanist/linter/ rather than arcanist/). What's the correct name/location and why?

Jul 22 2019, 21:12

jasonbcox committed rABC276d2c34945d: Migrate build configs from TeamCity to build-configurations.sh (authored by jasonbcox).

Migrate build configs from TeamCity to build-configurations.sh

Jul 22 2019, 20:51

jasonbcox closed D3706: Migrate build configs from TeamCity to build-configurations.sh.

Jul 22 2019, 20:50

jasonbcox accepted D3707: Merge #11997: [tests] util_tests.cpp: actually check ignored args.

Jul 22 2019, 20:08

jasonbcox accepted D3708: miliseconds => milliseconds.

Jul 22 2019, 20:07

jasonbcox accepted D3678: Nits in Qt test.

Jul 22 2019, 20:07

jasonbcox accepted D3703: test: Move linters to test/lint, add readme.

Jul 22 2019, 20:06

jasonbcox updated the diff for D3706: Migrate build configs from TeamCity to build-configurations.sh.

Remove ASAN_OPTIONS as it's no longer needed.

Jul 22 2019, 20:02

jasonbcox added inline comments to D3706: Migrate build configs from TeamCity to build-configurations.sh.

Jul 22 2019, 20:02

jasonbcox accepted D3701: Merge #11879: [tests] remove redundant univalue_tests.cpp.

Jul 22 2019, 18:47

jasonbcox closed T579: Backport Core PR 13016, a subtask of T580: Backport Core PR 13930, as Resolved.

Jul 22 2019, 18:41 · Restricted Project

jasonbcox closed T579: Backport Core PR 13016 as Resolved.

Jul 22 2019, 18:41 · Bootcamp, Restricted Project

jasonbcox requested review of D3706: Migrate build configs from TeamCity to build-configurations.sh.

Jul 22 2019, 18:40

jasonbcox updated the test plan for D3706: Migrate build configs from TeamCity to build-configurations.sh.

Jul 22 2019, 18:40

jasonbcox committed rABC26b57a9147f5: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks (authored by jasonbcox).

scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks

Jul 22 2019, 18:37

jasonbcox closed D3693: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks.

Jul 22 2019, 18:37

jasonbcox planned changes to D3706: Migrate build configs from TeamCity to build-configurations.sh.

Jul 22 2019, 18:25

jasonbcox updated the diff for D3706: Migrate build configs from TeamCity to build-configurations.sh.

Fix: Needs to be able to be run from different directories

Jul 22 2019, 18:25

jasonbcox updated the test plan for D3706: Migrate build configs from TeamCity to build-configurations.sh.

Jul 22 2019, 18:20

jasonbcox planned changes to D3706: Migrate build configs from TeamCity to build-configurations.sh.

Jul 22 2019, 18:17

jasonbcox updated the diff for D3706: Migrate build configs from TeamCity to build-configurations.sh.

Remove set -u as it's unnecessary and prevents showing a useful error message

Jul 22 2019, 18:17

jasonbcox planned changes to D3706: Migrate build configs from TeamCity to build-configurations.sh.

Jul 22 2019, 18:06

jasonbcox created D3706: Migrate build configs from TeamCity to build-configurations.sh.

Jul 22 2019, 18:06

jasonbcox closed T572: Backport Core PR 10279 as Resolved.

Jul 22 2019, 16:24 · Backport

jasonbcox closed T572: Backport Core PR 10279, a subtask of T560: Backport Core PR 11041, as Resolved.

Jul 22 2019, 16:24 · Backport

jasonbcox closed T572: Backport Core PR 10279, a subtask of T579: Backport Core PR 13016, as Resolved.

Jul 22 2019, 16:24 · Bootcamp, Restricted Project

jasonbcox committed rABC39f8c32faa2d: [Part 5 of 5] Add a CChainState class to clarify internal interfaces (authored by jasonbcox).

[Part 5 of 5] Add a CChainState class to clarify internal interfaces

Jul 22 2019, 16:24

jasonbcox closed D1972: [Part 5 of 5] Add a CChainState class to clarify internal interfaces.

Jul 22 2019, 16:23

jasonbcox accepted D3197: Make Teamcity agent setup easier.

Jul 22 2019, 16:17

jasonbcox accepted D3702: QA: Fix race condition in wallet_encryption test.

Jul 22 2019, 15:06

Jul 19 2019

jasonbcox created D3700: Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction.

Jul 19 2019, 23:34

Jul 18 2019

jasonbcox created D3694: Update the github issue template to include disclosure policy.

Jul 18 2019, 18:30

jasonbcox created D3693: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks.

Jul 18 2019, 17:28

jasonbcox committed rABC440b7dd61e8d: [test_runner] Fix unidash option for junit output to be one character (authored by jasonbcox).

[test_runner] Fix unidash option for junit output to be one character

Jul 18 2019, 16:32

jasonbcox closed D3692: [test_runner] Fix unidash option for junit output to be one character.

Jul 18 2019, 16:31

jasonbcox committed rABC17c55af363ab: [gitian-build] Fix repo directory to point at bitcoin-abc (authored by jasonbcox).

[gitian-build] Fix repo directory to point at bitcoin-abc

Jul 18 2019, 01:37

jasonbcox closed D3686: [gitian-build] Fix repo directory to point at bitcoin-abc.

Jul 18 2019, 01:37

jasonbcox committed rABC1074449cb5db: [gitian-build] Bump default memory setting (authored by jasonbcox).

[gitian-build] Bump default memory setting

Jul 18 2019, 01:36

jasonbcox closed D3688: [gitian-build] Bump default memory setting.

Jul 18 2019, 01:36

jasonbcox committed rABC241b84a9d7c9: [gitian-build] Default the number of jobs to the number of CPUs (authored by jasonbcox).

[gitian-build] Default the number of jobs to the number of CPUs

Jul 18 2019, 01:35

jasonbcox closed D3687: [gitian-build] Default the number of jobs to the number of CPUs.

Jul 18 2019, 01:35

jasonbcox added inline comments to D3690: [test_runner] Fix junitoutput typo.

Jul 18 2019, 01:32

jasonbcox created D3692: [test_runner] Fix unidash option for junit output to be one character.

Jul 18 2019, 01:32

jasonbcox committed rABC463b1c7d5a3d: [test_runner] Fix junitoutput typo (authored by jasonbcox).

[test_runner] Fix junitoutput typo

Jul 18 2019, 01:28

jasonbcox closed D3690: [test_runner] Fix junitoutput typo.

Jul 18 2019, 01:28

jasonbcox committed rABC1f0ae2d1ccc9: Fix a bug where the TeamCity build only reports one of the test_runner runs (authored by jasonbcox).

Fix a bug where the TeamCity build only reports one of the test_runner runs

Jul 18 2019, 01:26

jasonbcox closed D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.

Jul 18 2019, 01:26

jasonbcox added inline comments to D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.

Jul 18 2019, 01:25

Jul 17 2019

jasonbcox requested review of D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.

Jul 17 2019, 22:08

jasonbcox updated the test plan for D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.

Jul 17 2019, 22:08

jasonbcox updated the summary of D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.

Jul 17 2019, 21:56

jasonbcox planned changes to D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.

Jul 17 2019, 21:48

jasonbcox created D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.

Jul 17 2019, 21:48

jasonbcox created D3690: [test_runner] Fix junitoutput typo.

Jul 17 2019, 21:28

jasonbcox retitled D3686: [gitian-build] Fix repo directory to point at bitcoin-abc from Fix gitian-build.py repo directory to point at bitcoin-abc to [gitian-build] Fix repo directory to point at bitcoin-abc.

Jul 17 2019, 18:50

jasonbcox created D3688: [gitian-build] Bump default memory setting.

Jul 17 2019, 18:49

jasonbcox created D3687: [gitian-build] Default the number of jobs to the number of CPUs.

Jul 17 2019, 18:41

jasonbcox abandoned D3679: Remove config as a class member of BlockAssembler.

Jul 17 2019, 18:26

jasonbcox updated the summary of D3471: Merge #9868: Abstract out the command line options for block assembly.

Jul 17 2019, 18:18

jasonbcox updated the diff for D3471: Merge #9868: Abstract out the command line options for block assembly.

Rebase
Remove ComputeMaxGeneratedBlockSize() as it's no longer needed

Jul 17 2019, 18:17

jasonbcox created D3686: [gitian-build] Fix repo directory to point at bitcoin-abc.

Jul 17 2019, 17:07

jasonbcox updated the summary of D3471: Merge #9868: Abstract out the command line options for block assembly.

Jul 17 2019, 16:29

jasonbcox abandoned D3683: Remove config as a class member of BlockAssembler.

Jul 17 2019, 16:29

jasonbcox abandoned D3682: Refactor TestForBlock() to take config as a parameter.

Jul 17 2019, 16:28

jasonbcox abandoned D3681: Refactor addPriorityTxs to take config as a parameter.

Jul 17 2019, 16:28

jasonbcox abandoned D3680: Refactor adding package txs to use config as a parameter.

Jul 17 2019, 16:28

jasonbcox retitled D3679: Remove config as a class member of BlockAssembler from Refactor CreateNewBlock() to use a config parameter instead of the class member to Remove config as a class member of BlockAssembler.

Jul 17 2019, 16:28

jasonbcox updated the diff for D3679: Remove config as a class member of BlockAssembler.

Pulled in D3680 - D3683 to make the API consistent. This removes the config member all in one go.

Jul 17 2019, 16:27

jasonbcox accepted D3685: Merge #11495: [trivial] Make namespace explicit for is_regular_file.

Jul 17 2019, 00:10

Jul 16 2019

jasonbcox accepted D3464: [rpc] Add logging RPC.

Jul 16 2019, 23:14

jasonbcox accepted D3684: Merge #11626: rpc: Make `logging` RPC public.

Jul 16 2019, 23:00

jasonbcox accepted D3350: [script_tests] improve test coverage of minimal push rules.

Jul 16 2019, 22:06

jasonbcox accepted D3636: [wallet] [rpc] Add loadwallet RPC.

Jul 16 2019, 21:55

jasonbcox accepted D3670: [tests] [qt] Add tests for address book manipulation via EditAddressDialog.

Jul 16 2019, 21:50

jasonbcox accepted D3658: Merge #10845: Remove unreachable code.

Jul 16 2019, 21:49

jasonbcox requested changes to D3589: [5 of 5] Style cleanup..

system.h/cpp needs to be backported first

Jul 16 2019, 21:45

jasonbcox requested changes to D3588: [4 of 5] scripted-diff: Rename CBlockDiskPos to FlatFilePos..

This is clearly missing at least one (if not more) backports. See ReadRawBlockFromDisk in the original PR.

Jul 16 2019, 21:43

jasonbcox accepted D3587: [3 of 5] Move CDiskBlockPos from chain to flatfile..

Jul 16 2019, 21:32

jasonbcox added a comment to D3587: [3 of 5] Move CDiskBlockPos from chain to flatfile..

In D3587#85317, @nakihito wrote:

In D3587#84811, @markblundeberg wrote:

Note: alternatively we could keep the split and rename diskblockpos.h to flatfilepos.h and put the ToString() implementation in a .cpp file also, or ...?

I'm not totally sure if it's worth splitting up the two, the main thing seems to have been getting it out of chain.h.

For now I'm in favor of merging the two since it would make backports easier. After we've caught up, then it may be worthwhile to reconsider.

Jul 16 2019, 21:28

jasonbcox updated the summary of D3471: Merge #9868: Abstract out the command line options for block assembly.

Jul 16 2019, 21:12

jasonbcox updated the diff for D3471: Merge #9868: Abstract out the command line options for block assembly.

Rebase on D3683

Jul 16 2019, 21:12

jasonbcox created D3683: Remove config as a class member of BlockAssembler.

Jul 16 2019, 18:22

jasonbcox created D3682: Refactor TestForBlock() to take config as a parameter.

Jul 16 2019, 18:16

jasonbcox created D3681: Refactor addPriorityTxs to take config as a parameter.

Jul 16 2019, 18:11

jasonbcox created D3680: Refactor adding package txs to use config as a parameter.

Jul 16 2019, 17:34

jasonbcox created D3679: Remove config as a class member of BlockAssembler.

Jul 16 2019, 16:38

jasonbcox requested changes to D3678: Nits in Qt test.

Jul 16 2019, 14:50

jasonbcox accepted D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..

Jul 16 2019, 14:50

jasonbcox requested changes to D3670: [tests] [qt] Add tests for address book manipulation via EditAddressDialog.

Jul 16 2019, 03:20

jasonbcox accepted D3669: [qt] Display more helpful message when adding a send address has failed.

Jul 16 2019, 03:13

jasonbcox accepted D3666: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage.

Jul 16 2019, 03:08

jasonbcox accepted D3668: Add purpose arg to Wallet::getAddress.

Jul 16 2019, 03:06

jasonbcox accepted D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..

Jul 16 2019, 03:01

jasonbcox updated the test plan for D1972: [Part 5 of 5] Add a CChainState class to clarify internal interfaces.

Jul 16 2019, 02:59

jasonbcox updated the diff for D1972: [Part 5 of 5] Add a CChainState class to clarify internal interfaces.

Rebase
Fix missing portions of the backport

Jul 16 2019, 02:59

jasonbcox commandeered D1972: [Part 5 of 5] Add a CChainState class to clarify internal interfaces.

Jul 16 2019, 02:14

jasonbcox accepted D3677: Error messages in LoadBlockIndexGuts() use __func__ instead of hardcoding function name..

Jul 16 2019, 02:12

jasonbcox committed rABC4e467915935e: Merge #12298: Refactor HaveKeys to early return on false result (authored by jasonbcox).

Merge #12298: Refactor HaveKeys to early return on false result

Jul 16 2019, 02:11

jasonbcox closed D3657: Merge #12298: Refactor HaveKeys to early return on false result.

Jul 16 2019, 02:11