Feed Advanced Search
Aug 2 2019
Aug 2 2019
jasonbcox requested changes to D3794: Add a message to static_assert.
jasonbcox committed rABCb65a8234808a: Merge #10825: net: set regtest JSON-RPC port to 18443 to avoid conflict with… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10825: net: set regtest JSON-RPC port to 18443 to avoid conflict with…
jasonbcox updated the diff for D3774: Merge #12780: Reduce variable scopes.
Rebase + fix
Jul 31 2019
Jul 31 2019
jasonbcox requested changes to D3757: Use a regex to determine the list of sources for check-rpc-mappings.
Jul 30 2019
Jul 30 2019
jasonbcox updated the summary of D3776: Remove dead code in BasicTestingSetup.
Jul 26 2019
Jul 26 2019
jasonbcox added inline comments to D3732: Added a script to generate chainparams intermediate files.
jasonbcox updated the diff for D3732: Added a script to generate chainparams intermediate files.
- Fixed make check-devtools to iterate over a list of devtools tests
- Simplified cmake check-devtools to work in a similar way as the make build, making it easier to add tests.
jasonbcox committed rABC7111ebbfc2f2: [tests] rename TestNode to TestP2PConn in tests (authored by John Newbery <john@johnnewbery.com>).
[tests] rename TestNode to TestP2PConn in tests
jasonbcox closed T680: Backport Core PR 12431, a subtask of T676: Backport Core PR 13517 (qa: Remove need to handle the network thread in tests), as Resolved.
jasonbcox committed rABCd28f9f8d8813: Merge #12431: Only call NotifyBlockTip when chainActive changes (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12431: Only call NotifyBlockTip when chainActive changes
Jul 25 2019
Jul 25 2019
jasonbcox added a parent task for T669: Removing comparison test framework: T679: Backport Core PR 13512.
jasonbcox added a subtask for T679: Backport Core PR 13512: T669: Removing comparison test framework.
jasonbcox requested changes to D3749: [CI] Enable the undefined behaviour sanitizer.
Bump version to 0.19.12
jasonbcox edited subtasks for T677: Backport Core PR 13747, added: T678: Backport Core PR 13715; removed: T676: Backport Core PR 13517 (qa: Remove need to handle the network thread in tests).
jasonbcox added a comment to T677: Backport Core PR 13747.
Note that this backport supersedes https://github.com/bitcoin/bitcoin/pull/13715/files
jasonbcox triaged T676: Backport Core PR 13517 (qa: Remove need to handle the network thread in tests) as High priority.
Updated seeds
Update manpages for 0.19.11 release
Update chainparams
jasonbcox committed rABCc1776d323e08: Merge #12545: test: Use wait_until to ensure ping goes out (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12545: test: Use wait_until to ensure ping goes out
jasonbcox updated the diff for D3733: Merge #12545: test: Use wait_until to ensure ping goes out.
Fix nits
jasonbcox updated the diff for D3471: Merge #9868: Abstract out the command line options for block assembly.
Feedback + rebase
jasonbcox committed rABC19ba4062aa85: Merge #12659: Improve Fatal LevelDB Log Messages (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12659: Improve Fatal LevelDB Log Messages
Jul 24 2019
Jul 24 2019
jasonbcox committed rABC90d399fa8d9f: Restrict CTransaction size assertion to x86 (authored by jasonbcox).
Restrict CTransaction size assertion to x86
jasonbcox requested changes to D3727: Format mm files.
jasonbcox requested changes to D3731: Make ScriptError a C++11 first class enum.
The rest looks good.
jasonbcox added inline comments to D3732: Added a script to generate chainparams intermediate files.
jasonbcox planned changes to D3502: Added a script to generate chainparams constants header files.
Splitting this off into other diffs since a two-part design facilitates compartmentalized review anyway. Part 1 is D3732
jasonbcox committed rABCf380cead5ef1: Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction
jasonbcox updated the diff for D3700: Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction.
Feedback
jasonbcox committed rABC07e01424630f: [teamcity/build] Fix a bug where CONFIGURE_FLAGS would not parse multiple flags… (authored by jasonbcox).
[teamcity/build] Fix a bug where CONFIGURE_FLAGS would not parse multiple flags…
jasonbcox requested changes to D3709: Don't replay the gitian initial setup at each build.
Jul 23 2019
Jul 23 2019
jasonbcox updated the diff for D3700: Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction.
Added static assertions to check sizes at compile time
jasonbcox requested changes to D3720: Pass WalletModel down to SendCoinsEntry by construct.
jasonbcox requested changes to D3719: Use nullptr instead of 0 in various places in Qt code.
jasonbcox planned changes to D3714: Added a script for creating Github release drafts.