Page MenuHomePhabricator
Feed Advanced Search

Oct 11 2019

jasonbcox committed rABCd6393cf929f5: Update chainparams (authored by jasonbcox).
Update chainparams
Oct 11 2019, 03:46
jasonbcox closed D4235: Update chainparams.
Oct 11 2019, 03:46
jasonbcox committed rABC2f6b0e6eb1ac: Update seeds (authored by jasonbcox).
Update seeds
Oct 11 2019, 03:45
jasonbcox closed D4233: Update seeds.
Oct 11 2019, 03:45
jasonbcox created D4242: [gitian-build] Split apart building and signing the build.
Oct 11 2019, 03:43
jasonbcox created D4241: [gitian-build] Rename ambiguous --sign argument.
Oct 11 2019, 03:36
jasonbcox created D4240: [gitian-build] Remove ambiguous buildsign argument.
Oct 11 2019, 03:30

Oct 10 2019

jasonbcox created D4237: Update manpages for 0.20.4 release.
Oct 10 2019, 18:22
jasonbcox created D4235: Update chainparams.
Oct 10 2019, 18:16
jasonbcox updated the summary of D4233: Update seeds.
Oct 10 2019, 17:35
jasonbcox created D4233: Update seeds.
Oct 10 2019, 17:33
jasonbcox requested review of D4232: [gitian-build] Move manifest files to output directory.
Oct 10 2019, 16:24
jasonbcox requested review of D4231: [gitian-build] Refactor to calculate output directories in fewer places.
Oct 10 2019, 16:05
jasonbcox planned changes to D4232: [gitian-build] Move manifest files to output directory.
Oct 10 2019, 13:56
jasonbcox planned changes to D4231: [gitian-build] Refactor to calculate output directories in fewer places.
Oct 10 2019, 13:56
jasonbcox updated the test plan for D4232: [gitian-build] Move manifest files to output directory.
Oct 10 2019, 02:46
jasonbcox updated the test plan for D4231: [gitian-build] Refactor to calculate output directories in fewer places.
Oct 10 2019, 02:46
jasonbcox updated the summary of D4232: [gitian-build] Move manifest files to output directory.
Oct 10 2019, 02:46
jasonbcox created D4232: [gitian-build] Move manifest files to output directory.
Oct 10 2019, 02:46
jasonbcox updated the test plan for D4231: [gitian-build] Refactor to calculate output directories in fewer places.
Oct 10 2019, 02:44
jasonbcox created D4231: [gitian-build] Refactor to calculate output directories in fewer places.
Oct 10 2019, 02:40

Oct 9 2019

jasonbcox committed rSTAGINGcdddac09dfb4: [build-configurations] Make BUILD_DIR configurable (authored by jasonbcox).
[build-configurations] Make BUILD_DIR configurable
Oct 9 2019, 20:12
jasonbcox committed rSTAGING79eec8bc0714: [build-configurations] Resurface the more informative error message when… (authored by jasonbcox).
[build-configurations] Resurface the more informative error message when…
Oct 9 2019, 20:12
jasonbcox committed rSTAGING54cbf5636d1b: Minor improvements to github-release script (authored by jasonbcox).
Minor improvements to github-release script
Oct 9 2019, 20:10
jasonbcox committed rSTAGING4a4b489b0d84: Change CI builds to use utf-8 encoding (authored by jasonbcox).
Change CI builds to use utf-8 encoding
Oct 9 2019, 20:10
jasonbcox committed rSTAGING7af048cfc2b0: Added support for `export LC_ALL=C.UTF-8` to the shell linter (authored by jasonbcox).
Added support for `export LC_ALL=C.UTF-8` to the shell linter
Oct 9 2019, 20:10
jasonbcox committed rSTAGINGf2c61fd8c087: Updated release-process to use github-release.sh (authored by jasonbcox).
Updated release-process to use github-release.sh
Oct 9 2019, 20:10
jasonbcox committed rSTAGINGa3ec2f6a0686: Added more explicit instructions for release tagging (authored by jasonbcox).
Added more explicit instructions for release tagging
Oct 9 2019, 20:10
jasonbcox committed rSTAGING84b63b2cde4d: Bump version to 0.20.4 (authored by jasonbcox).
Bump version to 0.20.4
Oct 9 2019, 20:10
jasonbcox committed rSTAGING5ab2f96ed68d: Add phpcs exclusion for strict_types declararion (authored by jasonbcox).
Add phpcs exclusion for strict_types declararion
Oct 9 2019, 20:10
jasonbcox committed rSTAGING65e770d8d5b5: Added a script for creating Github release drafts (authored by jasonbcox).
Added a script for creating Github release drafts
Oct 9 2019, 20:10
jasonbcox requested changes to D4224: Rename some seeder options.

+1 to release notes

Oct 9 2019, 00:20

Oct 8 2019

jasonbcox committed rABCcdddac09dfb4: [build-configurations] Make BUILD_DIR configurable (authored by jasonbcox).
[build-configurations] Make BUILD_DIR configurable
Oct 8 2019, 21:45
jasonbcox closed D4213: [build-configurations] Make BUILD_DIR configurable.
Oct 8 2019, 21:45

Oct 7 2019

jasonbcox committed rABC79eec8bc0714: [build-configurations] Resurface the more informative error message when… (authored by jasonbcox).
[build-configurations] Resurface the more informative error message when…
Oct 7 2019, 18:44
jasonbcox closed D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.
Oct 7 2019, 18:44
jasonbcox added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.

Good point on the composability aspect. I started to notice issues arising from the current design while working on D4213. It's more clear to me now that a composable design would make it more robust in addition to providing the caller with more customization of the build.

Oct 7 2019, 17:13
jasonbcox updated the diff for D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.

Fix according to feedback

Oct 7 2019, 17:10
jasonbcox updated the diff for D4213: [build-configurations] Make BUILD_DIR configurable.

Fix failing check-java tests

Oct 7 2019, 17:04
jasonbcox planned changes to D4213: [build-configurations] Make BUILD_DIR configurable.
Oct 7 2019, 16:28
jasonbcox updated the diff for D4213: [build-configurations] Make BUILD_DIR configurable.

Prevent re-runs of setup bleeding the default value previously set on BUILD_DIR

Oct 7 2019, 16:28

Oct 4 2019

jasonbcox accepted D4207: Bump wallet version for pre split keypool.

Considering the error message, I would prefer that this is merged with D4206. Landing immediately after is acceptable as long as the diffs don't cross release boundaries, but why risk it in the first place?

Oct 4 2019, 21:57
jasonbcox accepted D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.
Oct 4 2019, 21:45
jasonbcox added inline comments to D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.
Oct 4 2019, 21:35
jasonbcox updated the diff for D4213: [build-configurations] Make BUILD_DIR configurable.

Simplify build dir creation

Oct 4 2019, 21:12
jasonbcox updated the test plan for D4213: [build-configurations] Make BUILD_DIR configurable.
Oct 4 2019, 21:10
jasonbcox updated the diff for D4213: [build-configurations] Make BUILD_DIR configurable.

Fixed a bug where non-existant build dir would fail

Oct 4 2019, 21:09
jasonbcox updated the summary of D4195: Added a land bot script.
Oct 4 2019, 21:04
jasonbcox updated the diff for D4195: Added a land bot script.
  • Rebase on D4213 and take advantage of it to make this script more robust.
  • Cleanup the repo state, especially in the case of failures.
Oct 4 2019, 21:04
jasonbcox created D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.
Oct 4 2019, 21:01
jasonbcox created D4213: [build-configurations] Make BUILD_DIR configurable.
Oct 4 2019, 20:53
jasonbcox added a comment to D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.
  1. Reduced code ownership.
  2. Reduced cognitive load on merge conflicts.
Oct 4 2019, 16:40
jasonbcox accepted D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.
Oct 4 2019, 16:21

Oct 3 2019

jasonbcox added inline comments to D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.
Oct 3 2019, 23:28
jasonbcox triaged T689: Backport of Core PR13131 as Low priority.
Oct 3 2019, 23:22 · Restricted Project
jasonbcox triaged T688: Backport Core PR13235 as High priority.
Oct 3 2019, 23:15 · Restricted Project
jasonbcox closed T416: October backport session as Resolved.
Oct 3 2019, 22:02 · Backport
jasonbcox closed T445: December backports as Resolved.
Oct 3 2019, 22:01 · Restricted Project
jasonbcox closed T569: Backport PR12843, a subtask of T446: Backport Core PR 12904, as Resolved.
Oct 3 2019, 22:01 · Restricted Project
jasonbcox closed T569: Backport PR12843 as Resolved.
Oct 3 2019, 22:01
jasonbcox closed T446: Backport Core PR 12904, a subtask of T445: December backports, as Resolved.
Oct 3 2019, 22:00 · Restricted Project
jasonbcox closed T446: Backport Core PR 12904 as Resolved.
Oct 3 2019, 22:00 · Restricted Project
jasonbcox closed T623: Backport Core PR 13023 as Resolved.

D3436

Oct 3 2019, 21:59
jasonbcox closed T663: Automate updating assume valid chainparams, a subtask of T646: Release Automation, as Resolved.
Oct 3 2019, 21:58 · Restricted Project, Restricted Project
jasonbcox closed T663: Automate updating assume valid chainparams as Resolved.
Oct 3 2019, 21:58 · Restricted Project, Restricted Project
jasonbcox accepted D4208: Added translations for new send coins dialog box.
Oct 3 2019, 21:55
jasonbcox requested changes to D4208: Added translations for new send coins dialog box.

Where did these translations come from? (should be in summary)

Oct 3 2019, 20:55
jasonbcox accepted D4201: Separate HaveKey function that checks whether a key is in a keystore.
Oct 3 2019, 20:51
jasonbcox requested changes to D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.
Oct 3 2019, 00:39
jasonbcox accepted D4179: Return void instead of bool for functions that cannot fail.
Oct 3 2019, 00:24

Oct 2 2019

jasonbcox accepted D4204: Relayout comment in sign.h.
Oct 2 2019, 23:50
jasonbcox accepted D3464: [rpc] Add logging RPC.
Oct 2 2019, 23:49
jasonbcox updated the test plan for D4195: Added a land bot script.
Oct 2 2019, 16:35
jasonbcox updated the diff for D4195: Added a land bot script.

Minor fixes

Oct 2 2019, 16:32
jasonbcox committed rABC54cbf5636d1b: Minor improvements to github-release script (authored by jasonbcox).
Minor improvements to github-release script
Oct 2 2019, 16:29
jasonbcox closed D4196: Minor improvements to github-release script.
Oct 2 2019, 16:29
jasonbcox updated the diff for D4196: Minor improvements to github-release script.

Fix nit

Oct 2 2019, 15:51
jasonbcox created D4196: Minor improvements to github-release script.
Oct 2 2019, 00:39
jasonbcox planned changes to D4195: Added a land bot script.
Oct 2 2019, 00:25
jasonbcox created D4195: Added a land bot script.
Oct 2 2019, 00:25

Oct 1 2019

jasonbcox abandoned D4194: Add a build-make-check config for testing and sanity checks.
Oct 1 2019, 23:35
jasonbcox created D4194: Add a build-make-check config for testing and sanity checks.
Oct 1 2019, 23:34
jasonbcox accepted D4151: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH.
Oct 1 2019, 22:07
jasonbcox requested changes to D4151: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH.
Oct 1 2019, 21:26
jasonbcox accepted D4174: utils: Convert Windows args to utf-8 string.
Oct 1 2019, 20:26
jasonbcox abandoned D3453: [ibd.sh] Add chainwork sanity check.
Oct 1 2019, 20:25
jasonbcox abandoned D3471: Merge #9868: Abstract out the command line options for block assembly.
Oct 1 2019, 20:25
jasonbcox requested changes to D3308: Merge #9894: remove 'label' filter for rpc command help.

Putting this off my queue until more work is done on D3950's dependencies.

Oct 1 2019, 19:01
jasonbcox committed rABC4a4b489b0d84: Change CI builds to use utf-8 encoding (authored by jasonbcox).
Change CI builds to use utf-8 encoding
Oct 1 2019, 18:56
jasonbcox closed D4184: Change CI builds to use utf-8 encoding.
Oct 1 2019, 18:56
jasonbcox committed rABC7af048cfc2b0: Added support for `export LC_ALL=C.UTF-8` to the shell linter (authored by jasonbcox).
Added support for `export LC_ALL=C.UTF-8` to the shell linter
Oct 1 2019, 18:55
jasonbcox closed D4183: Added support for `export LC_ALL=C.UTF-8` to the shell linter.
Oct 1 2019, 18:55
jasonbcox requested changes to D4151: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH.
Oct 1 2019, 18:44
jasonbcox committed rABCf2c61fd8c087: Updated release-process to use github-release.sh (authored by jasonbcox).
Updated release-process to use github-release.sh
Oct 1 2019, 18:36
jasonbcox committed rABC84b63b2cde4d: Bump version to 0.20.4 (authored by jasonbcox).
Bump version to 0.20.4
Oct 1 2019, 18:36
jasonbcox committed rABCa3ec2f6a0686: Added more explicit instructions for release tagging (authored by jasonbcox).
Added more explicit instructions for release tagging
Oct 1 2019, 18:36
jasonbcox closed D4180: Added more explicit instructions for release tagging.
Oct 1 2019, 18:35
jasonbcox closed D4181: Updated release-process to use github-release.sh.
Oct 1 2019, 18:35
jasonbcox closed D4177: Bump version to 0.20.4.
Oct 1 2019, 18:28
jasonbcox updated the diff for D4183: Added support for `export LC_ALL=C.UTF-8` to the shell linter.

Rebase + Fix according to feedback

Oct 1 2019, 18:10