Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Mar 26 2019

jasonbcox updated the diff for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

Massively improved test coverage (see updated summary)

Mar 26 2019, 04:53

Mar 25 2019

jasonbcox reassigned T466: Backport Core PR11593 to fix http/rpc race condition from jasonbcox to nakihito.

Mar 25 2019, 21:15 · Backport, Restricted Project

jasonbcox committed rABCfe7f30d365c1: Fix seeder in the gitian build (authored by jasonbcox).

Fix seeder in the gitian build

Mar 25 2019, 19:56

jasonbcox closed D2733: Fix seeder in the gitian build.

Mar 25 2019, 19:55

jasonbcox accepted D2732: [rpc] getblockchaininfo: add size_on_disk, prune_target_size, automatic_pruning.

Mar 25 2019, 19:54

jasonbcox requested changes to D2711: Document method for reviewers to verify chainTxData.

I'm not sure if this should be part of our release process.

Mar 25 2019, 19:48

Herald added a reviewer for D2733: Fix seeder in the gitian build: Restricted Project.

Mar 25 2019, 18:16

jasonbcox accepted D2705: [LINTER] Integrate lint-locale-dependence.sh into arcanist.

Mar 25 2019, 17:55

jasonbcox requested changes to D2730: Merge #10858: [RPC] Add "warnings" field to getblockchaininfo and unify "warnings" field in get*info RPCs.

The title and summary of this diff are highly confusing. I know it was just a copy from the PR description, but please update all mentions of errors to warnings to match the change in decision they made in the PR (see comments of the original PR).

Mar 25 2019, 17:53

jasonbcox accepted D2009: [Target v0.19] Deprecate and add test for signrawtransaction.

Mar 25 2019, 17:44

jasonbcox requested changes to D2732: [rpc] getblockchaininfo: add size_on_disk, prune_target_size, automatic_pruning.

Mar 25 2019, 17:29

jasonbcox added inline comments to D2711: Document method for reviewers to verify chainTxData.

Mar 25 2019, 17:28

jasonbcox requested changes to D1936: Move handling for `-maxtxfee` to the config object.

Mar 25 2019, 17:25

jasonbcox committed rABC624f189f44bd: Added better error reporting for running individual functional tests (authored by jasonbcox).

Added better error reporting for running individual functional tests

Mar 25 2019, 16:54

jasonbcox closed D2696: Added better error reporting for running individual functional tests.

Mar 25 2019, 16:54

jasonbcox committed rABC723f52765f37: Update manpages (authored by jasonbcox).

Update manpages

Mar 25 2019, 16:53

jasonbcox closed D2726: Update manpages.

Mar 25 2019, 16:53

jasonbcox committed rABC7fd6095e4604: Update chainparams for 0.19.2 release (authored by jasonbcox).

Update chainparams for 0.19.2 release

Mar 25 2019, 16:52

jasonbcox closed D2725: Update chainparams for 0.19.2 release.

Mar 25 2019, 16:52

Mar 23 2019

jasonbcox added inline comments to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

Mar 23 2019, 00:36

jasonbcox updated the diff for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

Greatly simplify the test by using a precomputed block + other feedback incorporated.

Mar 23 2019, 00:32

Mar 22 2019

jasonbcox added inline comments to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

Mar 22 2019, 23:32

jasonbcox added inline comments to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

Mar 22 2019, 22:12

jasonbcox committed rABC568a8f9c4b09: Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints

Mar 22 2019, 22:08

jasonbcox closed D2723: Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints.

Mar 22 2019, 22:08

jasonbcox committed rABC9ae3baa3bba1: Add some release notes (authored by jasonbcox).

Add some release notes

Mar 22 2019, 22:03

jasonbcox closed D2724: Add some release notes.

Mar 22 2019, 22:03

jasonbcox requested changes to D2705: [LINTER] Integrate lint-locale-dependence.sh into arcanist.

Mar 22 2019, 22:02

jasonbcox accepted D2704: [LINTER] Display the line number in the lint-locale-dependence.sh linter.

Mar 22 2019, 21:47

jasonbcox updated the diff for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

Lint

Mar 22 2019, 20:43

Herald added a reviewer for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint: Restricted Project.

Mar 22 2019, 19:49

jasonbcox updated the diff for D2723: Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints.

Rebase

Mar 22 2019, 19:45

jasonbcox committed rABC379dd8366d10: Merge #8665: Assert all the things! (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #8665: Assert all the things!

Mar 22 2019, 19:43

jasonbcox closed D2722: Merge #8665: Assert all the things!.

Mar 22 2019, 19:43

jasonbcox updated the diff for D2724: Add some release notes.

Rebase again

Mar 22 2019, 19:39

jasonbcox accepted D2685: [secp256k1] fix java secp256k1 test.

secp256k1 tests are passing on TeamCity now :)

Mar 22 2019, 19:10

jasonbcox updated the diff for D2724: Add some release notes.

Rebase

Mar 22 2019, 18:28

jasonbcox requested changes to D2685: [secp256k1] fix java secp256k1 test.

Please wait until I've updated the TeamCity config.

Mar 22 2019, 00:46

jasonbcox committed rABCcbc12967970f: Added build-secp256k1.sh for running secp tests in TeamCity (authored by jasonbcox).

Added build-secp256k1.sh for running secp tests in TeamCity

Mar 22 2019, 00:43

jasonbcox closed D2686: Added build-secp256k1.sh for running secp tests in TeamCity.

Mar 22 2019, 00:43

Herald added a reviewer for D2726: Update manpages: deadalnix.

Mar 22 2019, 00:38

Herald added a reviewer for D2725: Update chainparams for 0.19.2 release: Restricted Project.

Mar 22 2019, 00:33

Herald added a reviewer for D2724: Add some release notes: deadalnix.

Mar 22 2019, 00:19

Mar 21 2019

jasonbcox added inline comments to D2723: Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints.

Mar 21 2019, 21:27

Herald added a reviewer for D2723: Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints: Restricted Project.

Mar 21 2019, 18:44

Herald added a reviewer for D2722: Merge #8665: Assert all the things!: Restricted Project.

Mar 21 2019, 18:10

jasonbcox committed rABC1000e62d1f8a: Backport VerifyResult enum class (authored by jasonbcox).

Backport VerifyResult enum class

Mar 21 2019, 16:35

jasonbcox closed D2718: Backport VerifyResult enum class.

Mar 21 2019, 16:35

jasonbcox committed rABCb51031caa043: Backport FlushStateMode enum class (authored by jasonbcox).

Backport FlushStateMode enum class

Mar 21 2019, 16:33

jasonbcox closed D2716: Backport FlushStateMode enum class.

Mar 21 2019, 16:33

jasonbcox committed rABCbb492d7f8fba: Backport ThresholdState enum class (authored by jasonbcox).

Backport ThresholdState enum class

Mar 21 2019, 16:32

jasonbcox closed D2715: Backport ThresholdState enum class.

Mar 21 2019, 16:32

jasonbcox committed rABCa07b6bc7a128: Backport HelpMessageMode enum class (authored by jasonbcox).

Backport HelpMessageMode enum class

Mar 21 2019, 16:30

jasonbcox closed D2714: Backport HelpMessageMode enum class.

Mar 21 2019, 16:30

jasonbcox committed rABCae4d2b98623e: Backport BlockSource enum class (authored by jasonbcox).

Backport BlockSource enum class

Mar 21 2019, 16:29

jasonbcox closed D2713: Backport BlockSource enum class.

Mar 21 2019, 16:29

jasonbcox added inline comments to D2686: Added build-secp256k1.sh for running secp tests in TeamCity.

Mar 21 2019, 16:10

jasonbcox accepted D2721: Fix braces in qt/clientmodel.cpp.

Mar 21 2019, 16:09

jasonbcox committed rABC9b29a548adb3: Backport RetFormat enum class (authored by jasonbcox).

Backport RetFormat enum class

Mar 21 2019, 16:08

jasonbcox closed D2712: Backport RetFormat enum class.

Mar 21 2019, 16:08

jasonbcox added inline comments to D2686: Added build-secp256k1.sh for running secp tests in TeamCity.

Mar 21 2019, 02:06

jasonbcox retitled D2686: Added build-secp256k1.sh for running secp tests in TeamCity from [WIP] Added build-secp256k1.sh for running secp tests in TeamCity to Added build-secp256k1.sh for running secp tests in TeamCity.

Mar 21 2019, 00:21

Mar 20 2019

jasonbcox added inline comments to D2686: Added build-secp256k1.sh for running secp tests in TeamCity.

Mar 20 2019, 23:10

jasonbcox updated the test plan for D2686: Added build-secp256k1.sh for running secp tests in TeamCity.

Mar 20 2019, 23:04

jasonbcox updated the diff for D2686: Added build-secp256k1.sh for running secp tests in TeamCity.

Fix various bugs

Mar 20 2019, 22:59

jasonbcox abandoned D2699: Merge #10742: scripted-diff: Use scoped enumerations (C++11, "enum class").

Split up this diff into:
D2712
D2713
D2714
D2715
D2716
D2718
D2719

Mar 20 2019, 22:45

jasonbcox created D2719: Backport remaining changes from Core PR 10742.

Mar 20 2019, 22:42

jasonbcox updated the summary of D2686: Added build-secp256k1.sh for running secp tests in TeamCity.

Mar 20 2019, 22:11

Herald added a reviewer for D2718: Backport VerifyResult enum class: Restricted Project.

Mar 20 2019, 21:51

jasonbcox accepted D2717: Allow for running secp256k1 java build/tests out of tree.

Mar 20 2019, 21:37

Herald added a reviewer for D2716: Backport FlushStateMode enum class: Restricted Project.

Mar 20 2019, 21:29

Herald added a reviewer for D2715: Backport ThresholdState enum class: Restricted Project.

Mar 20 2019, 21:19

Herald added a reviewer for D2714: Backport HelpMessageMode enum class: Restricted Project.

Mar 20 2019, 20:57

Herald added a reviewer for D2713: Backport BlockSource enum class: Restricted Project.

Mar 20 2019, 20:49

Herald added a reviewer for D2712: Backport RetFormat enum class: Restricted Project.

Mar 20 2019, 20:39

jasonbcox planned changes to D2699: Merge #10742: scripted-diff: Use scoped enumerations (C++11, "enum class").

Fabien has also requested that I break this diff up by enum. I will do that, as this diff is rather long.

Mar 20 2019, 20:10

jasonbcox accepted D2702: qa: Improve getchaintxstats functional test.

Mar 20 2019, 17:00

jasonbcox added inline comments to D2711: Document method for reviewers to verify chainTxData.

Mar 20 2019, 16:57

jasonbcox closed T564: Backport Core PR 11027, a subtask of T562: Backport Core PR 10275, as Resolved.

Mar 20 2019, 16:29 · Backport

jasonbcox closed T564: Backport Core PR 11027 as Resolved.

Mar 20 2019, 16:29 · Backport

jasonbcox committed rABCe3b6fe0ed1ba: Merge #11027: [RPC] Only return hex field once in getrawtransaction (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #11027: [RPC] Only return hex field once in getrawtransaction

Mar 20 2019, 16:29

jasonbcox closed D2709: Merge #11027: [RPC] Only return hex field once in getrawtransaction.

Mar 20 2019, 16:29

jasonbcox closed T563: Backport Core PR 11565 as Resolved.

Mar 20 2019, 16:24 · Backport

jasonbcox closed T563: Backport Core PR 11565, a subtask of T560: Backport Core PR 11041, as Resolved.

Mar 20 2019, 16:24 · Backport

jasonbcox committed rABC1d6970e88741: Merge #11565: Make listsinceblock refuse unknown block hash (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #11565: Make listsinceblock refuse unknown block hash

Mar 20 2019, 16:23

jasonbcox closed D2703: Merge #11565: Make listsinceblock refuse unknown block hash.

Mar 20 2019, 16:23

jasonbcox requested changes to D1936: Move handling for `-maxtxfee` to the config object.

Mar 20 2019, 01:43

jasonbcox requested changes to D2133: Move shared qt/bitcoind initialization steps to shared functions..

This directly conflicts with T417. I don't think this change is worth it.

Mar 20 2019, 01:33

Mar 19 2019

Herald added a reviewer for D2709: Merge #11027: [RPC] Only return hex field once in getrawtransaction: Restricted Project.

Mar 19 2019, 17:09

jasonbcox accepted D2698: [LINTER] build: Add linter for checking accidental locale dependence.

Mar 19 2019, 16:45

jasonbcox accepted D2706: refactor: remove usage of locale dependent std::isspace.

Mar 19 2019, 16:21

jasonbcox accepted D2707: Fix braces in utilstrencodings.

Mar 19 2019, 16:10

jasonbcox accepted D2708: Fix braces in netbase.cpp.

Mar 19 2019, 16:05

jasonbcox triaged T565: Backport Core PR 11529 as High priority.

Mar 19 2019, 01:08 · Backport

jasonbcox triaged T564: Backport Core PR 11027 as Normal priority.

Mar 19 2019, 01:06 · Backport

jasonbcox added inline comments to D2702: qa: Improve getchaintxstats functional test.

Mar 19 2019, 00:43

jasonbcox requested changes to D2702: qa: Improve getchaintxstats functional test.

Mar 19 2019, 00:29

Herald added a reviewer for D2703: Merge #11565: Make listsinceblock refuse unknown block hash: Restricted Project.

Mar 19 2019, 00:24

jasonbcox requested changes to D2702: qa: Improve getchaintxstats functional test.

Missing the refactor in rpc/blockchain.cpp

Mar 19 2019, 00:02

Mar 18 2019

jasonbcox triaged T563: Backport Core PR 11565 as High priority.

Mar 18 2019, 23:53 · Backport