Page MenuHomePhabricator
Feed Advanced Search

Nov 18 2019

jasonbcox updated the diff for D4462: Use local instance of ArgsManager in getarg_tests.

Remove unnecessary ClearArgs()

Nov 18 2019, 20:00
jasonbcox planned changes to D4462: Use local instance of ArgsManager in getarg_tests.
Nov 18 2019, 19:55
jasonbcox created D4462: Use local instance of ArgsManager in getarg_tests.
Nov 18 2019, 19:49
jasonbcox committed rABC1a2facc2cf99: Add checkpoints for graviton upgrade (authored by jasonbcox).
Add checkpoints for graviton upgrade
Nov 18 2019, 18:19
jasonbcox closed D4452: Add checkpoints for graviton upgrade.
Nov 18 2019, 18:18
jasonbcox committed rABCcfc48b787dae: [github-release] Add optional param to specify release notes path (authored by jasonbcox).
[github-release] Add optional param to specify release notes path
Nov 18 2019, 18:16
jasonbcox closed D4433: [github-release] Add optional param to specify release notes path.
Nov 18 2019, 18:16
jasonbcox accepted D4460: Add Windows shutdown handler.
Nov 18 2019, 17:45

Nov 15 2019

jasonbcox accepted D4418: Add simple unit tests for parse_name().
Nov 15 2019, 18:51
jasonbcox requested changes to D4418: Add simple unit tests for parse_name().
Nov 15 2019, 18:27
jasonbcox requested changes to D4418: Add simple unit tests for parse_name().
Nov 15 2019, 17:17
jasonbcox accepted D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.
Nov 15 2019, 17:14
jasonbcox requested changes to D4453: [CI] Remove functional tests with graviton activation.

I think it would be better to replace this with the next upgrade, even if it does nothing for now. Otherwise, we have to re-implement this later.

Nov 15 2019, 17:12
jasonbcox created D4452: Add checkpoints for graviton upgrade.
Nov 15 2019, 14:59
jasonbcox accepted D4451: fix txvalidationcache_tests to not rely on NULLDUMMY.
Nov 15 2019, 14:44
jasonbcox updated the diff for D4279: Added autopatch script for patching and rebasing phabricator diffs.

Fixed according to feedback

Nov 15 2019, 01:28

Nov 14 2019

jasonbcox accepted D4444: [CI] Add a new build configuration to run tests with cmake and ninja.
Nov 14 2019, 23:23
jasonbcox added a comment to D4433: [github-release] Add optional param to specify release notes path.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 22:52
jasonbcox added a comment to D4433: [github-release] Add optional param to specify release notes path.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 22:51
jasonbcox updated the diff for D4433: [github-release] Add optional param to specify release notes path.

test update please ignore

Nov 14 2019, 22:51
jasonbcox requested changes to D4444: [CI] Add a new build configuration to run tests with cmake and ninja.
Nov 14 2019, 22:49
jasonbcox updated the diff for D4433: [github-release] Add optional param to specify release notes path.

Rebase

Nov 14 2019, 22:19
jasonbcox accepted D4300: Integrate gArgs and chainparams into the Seeder.

There's still more work to do to de-dup netMagic, etc from the rest of the seeder, but this is a start.

Nov 14 2019, 22:07
jasonbcox committed rABCbb1d9f0716c7: Added missing instructions for OSX gitian building (authored by jasonbcox).
Added missing instructions for OSX gitian building
Nov 14 2019, 21:58
jasonbcox closed D4435: Added missing instructions for OSX gitian building.
Nov 14 2019, 21:58
jasonbcox added inline comments to D4436: Add unit tests for CSeederNode::ProcessMessage().
Nov 14 2019, 18:25
jasonbcox requested changes to D4418: Add simple unit tests for parse_name().

Splitting up the tests made a big difference. This is getting better.

Nov 14 2019, 17:59
jasonbcox requested changes to D4436: Add unit tests for CSeederNode::ProcessMessage().
Nov 14 2019, 17:35
jasonbcox accepted D4443: [CI] Rename build.sh to build_autotools.sh.
Nov 14 2019, 17:12
jasonbcox accepted D4440: Various nits in cuckoocache.h.
Nov 14 2019, 00:33
jasonbcox retitled D4440: Various nits in cuckoocache.h from Various nits un cuckoocache.h to Various nits in cuckoocache.h.
Nov 14 2019, 00:32

Nov 13 2019

jasonbcox accepted D4417: Add a separate executable for seeder tests.
Nov 13 2019, 00:56
jasonbcox updated the summary of D4435: Added missing instructions for OSX gitian building.
Nov 13 2019, 00:48
jasonbcox created D4435: Added missing instructions for OSX gitian building.
Nov 13 2019, 00:47

Nov 12 2019

jasonbcox accepted D4434: Add/update copyright lines to top of seeder code.
Nov 12 2019, 21:52
jasonbcox requested review of D4433: [github-release] Add optional param to specify release notes path.
Nov 12 2019, 19:30
jasonbcox updated the test plan for D4433: [github-release] Add optional param to specify release notes path.
Nov 12 2019, 19:29
jasonbcox planned changes to D4433: [github-release] Add optional param to specify release notes path.
Nov 12 2019, 19:19
jasonbcox created D4433: [github-release] Add optional param to specify release notes path.
Nov 12 2019, 19:19
jasonbcox accepted D4423: Get rid of ambiguous OutputType::NONE value.
Nov 12 2019, 00:28

Nov 11 2019

jasonbcox accepted D4425: [CMAKE] Avoid dependencies when building native bin during cross build.
Nov 11 2019, 22:47
jasonbcox accepted D4384: [CMAKE] Actually build the DMG image.
Nov 11 2019, 21:38
jasonbcox accepted D4427: Fix unecessary copies in rpcwallet.cpp.
Nov 11 2019, 17:43

Nov 9 2019

jasonbcox committed rABC03d22b4335e1: Bump version to 0.20.7 (authored by jasonbcox).
Bump version to 0.20.7
Nov 9 2019, 19:13
jasonbcox closed D4414: Bump version to 0.20.7.
Nov 9 2019, 19:13
jasonbcox added inline comments to D4418: Add simple unit tests for parse_name().
Nov 9 2019, 01:32
jasonbcox requested changes to D4417: Add a separate executable for seeder tests.
Nov 9 2019, 01:18

Nov 8 2019

jasonbcox requested changes to D4415: [CI] Allow to pass addditional arguments to bitcoind.
Nov 8 2019, 21:01
jasonbcox accepted D4379: [CMAKE] Prepare the application bundle for localization.
Nov 8 2019, 20:27
jasonbcox created D4414: Bump version to 0.20.7.
Nov 8 2019, 19:55
jasonbcox requested changes to D4413: Add a separate executible for seeder tests.
Nov 8 2019, 19:42
jasonbcox accepted D4412: [CI] Run the thread sanitizer as part of the CI.
Nov 8 2019, 18:21
jasonbcox added inline comments to D4279: Added autopatch script for patching and rebasing phabricator diffs.
Nov 8 2019, 17:17
jasonbcox committed rABC831f364fd261: Updated manpages for 0.20.6 release (authored by jasonbcox).
Updated manpages for 0.20.6 release
Nov 8 2019, 17:09
jasonbcox closed D4410: Updated manpages for 0.20.6 release.
Nov 8 2019, 17:09
jasonbcox committed rABC86502f11a2b3: Updated chainparams (authored by jasonbcox).
Updated chainparams
Nov 8 2019, 17:08
jasonbcox closed D4409: Updated chainparams.
Nov 8 2019, 17:08
jasonbcox committed rABCfaadb6f85297: Updated seeds (authored by jasonbcox).
Updated seeds
Nov 8 2019, 17:07
jasonbcox closed D4411: Updated seeds.
Nov 8 2019, 17:07
jasonbcox committed rABC947c1bc5e02b: Added a release note regarding builds needing python 3.5 (authored by jasonbcox).
Added a release note regarding builds needing python 3.5
Nov 8 2019, 17:06
jasonbcox closed D4408: Added a release note regarding builds needing python 3.5.
Nov 8 2019, 17:06
jasonbcox added a comment to D4279: Added autopatch script for patching and rebasing phabricator diffs.

I've also updated the summary to provide rationale for why this script should be one piece, as it may not be obvious at first glance.

Nov 8 2019, 00:57
jasonbcox retitled D4279: Added autopatch script for patching and rebasing phabricator diffs from Added a rebase script for automation purposes to Added autopatch script for patching and rebasing phabricator diffs.
Nov 8 2019, 00:56
jasonbcox updated the diff for D4279: Added autopatch script for patching and rebasing phabricator diffs.

Rename to autopatch in order to not confuse rebasing being the primary goal of the script.

Nov 8 2019, 00:49

Nov 7 2019

jasonbcox requested changes to D4384: [CMAKE] Actually build the DMG image.
Nov 7 2019, 23:42
jasonbcox created D4411: Updated seeds.
Nov 7 2019, 23:30
jasonbcox created D4410: Updated manpages for 0.20.6 release.
Nov 7 2019, 22:41
jasonbcox created D4409: Updated chainparams.
Nov 7 2019, 22:39
jasonbcox accepted D4383: [CMAKE] Complete the dist directory to prepare for the DMG image build.
Nov 7 2019, 22:33
jasonbcox created D4408: Added a release note regarding builds needing python 3.5.
Nov 7 2019, 22:22
jasonbcox planned changes to D4279: Added autopatch script for patching and rebasing phabricator diffs.
Nov 7 2019, 22:06
jasonbcox accepted D4382: [CMAKE] Build the background dist image on native OSX.
Nov 7 2019, 19:59
jasonbcox accepted D4381: [CMAKE] Add the background image to the dist directory.
Nov 7 2019, 19:54
jasonbcox added inline comments to D4379: [CMAKE] Prepare the application bundle for localization.
Nov 7 2019, 19:53
jasonbcox accepted D4379: [CMAKE] Prepare the application bundle for localization.
Nov 7 2019, 19:52
jasonbcox requested changes to D4300: Integrate gArgs and chainparams into the Seeder.
Nov 7 2019, 19:26
jasonbcox requested changes to D4381: [CMAKE] Add the background image to the dist directory.
Nov 7 2019, 19:19
jasonbcox accepted D4380: [CMAKE] Create a distribution directory with translations.
Nov 7 2019, 19:12
jasonbcox requested changes to D4379: [CMAKE] Prepare the application bundle for localization.
Nov 7 2019, 18:13

Nov 5 2019

jasonbcox added a comment to D4279: Added autopatch script for patching and rebasing phabricator diffs.

Is it a rebase script, or an arc patch script?

Nov 5 2019, 23:54
jasonbcox accepted D4394: Integrate util/system's CInit into RNGState.
Nov 5 2019, 23:33
jasonbcox accepted D4393: Abstract out seeding/extracting entropy into RNGState::MixExtract.
Nov 5 2019, 23:21
jasonbcox accepted D4392: Add thread safety annotations to RNG state.
Nov 5 2019, 23:09
jasonbcox accepted D4391: Rename some hardware RNG related functions.
Nov 5 2019, 23:08
jasonbcox accepted D4390: Automatically initialize RNG on first use..
Nov 5 2019, 23:06
jasonbcox accepted D4389: Don't log RandAddSeedPerfmon details.
Nov 5 2019, 22:56
jasonbcox accepted D4387: Use FRC::randbytes instead of reading >32 bytes from RNG.
Nov 5 2019, 22:50
jasonbcox accepted D4378: [CMAKE] Use native strip on OSX.
Nov 5 2019, 16:37
jasonbcox accepted D4364: Upgrade mac_alias to 2.0.7.
Nov 5 2019, 16:35
jasonbcox accepted D4376: depends: biplist 1.0.3.
Nov 5 2019, 16:33
jasonbcox accepted D4363: [depends] mac_alias 2.0.6, ds_store 1.1.2.
Nov 5 2019, 16:32
jasonbcox accepted D4377: build: depends: Switch to python3.
Nov 5 2019, 16:29
jasonbcox accepted D4373: test: Remove python3.4 workaround in feature_dbcrash.
Nov 5 2019, 01:28
jasonbcox accepted D4372: build: Require python 3.5.

Reviewer note: The code changed in test_framework/script.py does not appear in our codebase. We'll need to keep an eye out for slow backports that might introduce it.

Nov 5 2019, 01:16
jasonbcox accepted D4368: [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table.
Nov 5 2019, 01:04
jasonbcox committed rABCf608f71e57d5: Run all extended tests on master for build-default (authored by jasonbcox).
Run all extended tests on master for build-default
Nov 5 2019, 00:26
jasonbcox closed D4371: Run all extended tests on master for build-default.
Nov 5 2019, 00:26

Nov 4 2019

jasonbcox accepted D4375: scripted-diff: Update copyright in ./test.
Nov 4 2019, 22:49
jasonbcox accepted D4374: Display the default values as part of the test_runner.py help.
Nov 4 2019, 22:46
jasonbcox abandoned D4367: Added a build config to explicitly run all extended tests.

After more testing, it's clearly best to drop this in favor of D4371

Nov 4 2019, 22:10