Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
May 13 2019
Add missing include directory.
Fix missing include directory.
The dependency is only required for the test plan to pass.
Remove extra variable.
Move all the static build code into a single section.
I think more and more stuff should be better organized. Core doesn't seem to care about separating stuff out much.
Sorry, I must've forgotten to put the dependency in. Added now. Will fix the test plan later tonight.
May 12 2019
I think these should be left in place.
Where is part 1 ? Why doesn't this depends on part 1 ?
ARM64 is typically called AArch64 and 32 just ARM
It's not clear that this depends on any way on the diff you say it depends on.
It is clear you are aware this patches does many things at once, because you enumerate them in the description.
This invent a new way to configure things for no apparent reason.
move release notes into main doc
May 11 2019
Note 13197 should be backported fairly soon too (T650)
Adding tests to test/functional/wallet_basic.py for insufficient balance
Note: FlameGraph performance testing shows that this code changes CPU usage by GetBalance at 7.88% of total before this change, and CheckBalance at 0.10% after this change. (Only 45% of CPU was used by bitcoind/bitcoin-cli in my test; most of the rest is idle.) This is for a wallet with many thousands of UTXOs.