Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

May 13 2019

teamcity added a comment to D3031: [CMAKE] Cleanup the OSX platform file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 13 2019, 10:26
teamcity added a comment to D3034: [CMAKE] Disable OpenGL in Qt static build for OSX.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 13 2019, 10:24
Herald added a reviewer for D3034: [CMAKE] Disable OpenGL in Qt static build for OSX: deadalnix.
May 13 2019, 10:23
teamcity added a comment to D3033: [CMAKE] Add missing files to build bitcoin-qt on OSX.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 13 2019, 10:21
Herald added a reviewer for D3033: [CMAKE] Add missing files to build bitcoin-qt on OSX: deadalnix.
May 13 2019, 10:20
teamcity added a comment to D3032: [CMAKE] Fix bitcoind cross build for OSX.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 13 2019, 10:16
Herald added a reviewer for D3032: [CMAKE] Fix bitcoind cross build for OSX: deadalnix.
May 13 2019, 10:16
teamcity added a comment to D3031: [CMAKE] Cleanup the OSX platform file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 13 2019, 10:13
Herald added a reviewer for D3031: [CMAKE] Cleanup the OSX platform file: deadalnix.
May 13 2019, 10:12
teamcity added a comment to D2997: [CMAKE] Add support for Miniupnpc.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 13 2019, 09:59
teamcity added a comment to D3015: [CMAKE] Add support for libqrencode.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 13 2019, 09:52
teamcity added a comment to D2997: [CMAKE] Add support for Miniupnpc.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 13 2019, 09:45
Fabien updated the diff for D2997: [CMAKE] Add support for Miniupnpc.

Add missing include directory.

May 13 2019, 09:44
teamcity added a comment to D3015: [CMAKE] Add support for libqrencode.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 13 2019, 09:38
Fabien added inline comments to D3015: [CMAKE] Add support for libqrencode.
May 13 2019, 09:38
Fabien updated the diff for D3015: [CMAKE] Add support for libqrencode.

Fix missing include directory.

May 13 2019, 09:37
teamcity added a comment to D3020: [CMAKE] Add cross compiling support for ARM32 and ARM64.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 13 2019, 09:28
teamcity added a comment to D3019: [CMAKE] Add cross build toolchain files for PC Linux platform.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 13 2019, 09:25
teamcity added a comment to D3020: [CMAKE] Add cross compiling support for ARM32 and ARM64.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 13 2019, 09:14
Fabien updated the diff for D3020: [CMAKE] Add cross compiling support for ARM32 and ARM64.

Rename files.

May 13 2019, 09:14
teamcity added a comment to D3017: [CMAKE] Add QT plugins according to the target platform.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 13 2019, 09:11
teamcity added a comment to D3019: [CMAKE] Add cross build toolchain files for PC Linux platform.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 13 2019, 09:11
Fabien added a comment to D3019: [CMAKE] Add cross build toolchain files for PC Linux platform.

The dependency is only required for the test plan to pass.

May 13 2019, 09:11
Fabien updated the diff for D3019: [CMAKE] Add cross build toolchain files for PC Linux platform.

Remove extra variable.

May 13 2019, 09:11
teamcity added a comment to D3017: [CMAKE] Add QT plugins according to the target platform.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 13 2019, 08:57
Fabien added inline comments to D3017: [CMAKE] Add QT plugins according to the target platform.
May 13 2019, 08:56
Fabien updated the diff for D3017: [CMAKE] Add QT plugins according to the target platform.

Move all the static build code into a single section.
Fix comments.

May 13 2019, 08:56
teamcity added a comment to D3030: [CMAKE] Fix missing protobuf include directory.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 13 2019, 08:21
Fabien committed rABC53b3b14bb0f1: [CMAKE] Fix the prl conversion script library path issue (authored by Fabien).
[CMAKE] Fix the prl conversion script library path issue
May 13 2019, 08:07
Fabien closed D2948: [CMAKE] Fix the prl conversion script library path issue.
May 13 2019, 08:07
teamcity added a comment to D3030: [CMAKE] Fix missing protobuf include directory.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 13 2019, 08:07
Herald added a reviewer for D3030: [CMAKE] Fix missing protobuf include directory: deadalnix.
May 13 2019, 08:06
schancel added a comment to D3013: [rpc] Move tojson.h into blockchain.h.

I think more and more stuff should be better organized. Core doesn't seem to care about separating stuff out much.

May 13 2019, 02:53
teamcity added a comment to D3013: [rpc] Move tojson.h into blockchain.h.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 13 2019, 01:41
teamcity added a comment to D3013: [rpc] Move tojson.h into blockchain.h.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 13 2019, 01:26
markblundeberg updated the diff for D3013: [rpc] Move tojson.h into blockchain.h.

add static

May 13 2019, 01:26
markblundeberg added a comment to D3013: [rpc] Move tojson.h into blockchain.h.
In D3013#71305, @schancel wrote:

I think these should be left in place.

May 13 2019, 01:17
nakihito added a comment to D3024: [tests] Remove unused variables.

Sorry, I must've forgotten to put the dependency in. Added now. Will fix the test plan later tonight.

May 13 2019, 00:10
nakihito updated the summary of D3024: [tests] Remove unused variables.
May 13 2019, 00:10

May 12 2019

schancel added inline comments to D3013: [rpc] Move tojson.h into blockchain.h.
May 12 2019, 23:48
schancel requested changes to D3013: [rpc] Move tojson.h into blockchain.h.

I think these should be left in place.

May 12 2019, 23:47
deadalnix requested changes to D3025: [Wallet] CheckBalance instead of GetBalance for 13% faster sendtoaddress.
May 12 2019, 23:30
deadalnix requested changes to D3024: [tests] Remove unused variables.

Where is part 1 ? Why doesn't this depends on part 1 ?

May 12 2019, 23:29
deadalnix requested changes to D3020: [CMAKE] Add cross compiling support for ARM32 and ARM64.

ARM64 is typically called AArch64 and 32 just ARM

May 12 2019, 23:27
deadalnix requested changes to D3019: [CMAKE] Add cross build toolchain files for PC Linux platform.

It's not clear that this depends on any way on the diff you say it depends on.

May 12 2019, 23:26
deadalnix requested changes to D3017: [CMAKE] Add QT plugins according to the target platform.
May 12 2019, 23:22
deadalnix accepted D2948: [CMAKE] Fix the prl conversion script library path issue.
May 12 2019, 23:14
deadalnix requested changes to D3018: [CMAKE] Fix CMake cross build for OSX.

It is clear you are aware this patches does many things at once, because you enumerate them in the description.

May 12 2019, 23:13
deadalnix requested changes to D3015: [CMAKE] Add support for libqrencode.

This invent a new way to configure things for no apparent reason.

May 12 2019, 22:21
Nico Guiton <nico@bitframe.org> committed rABC19618b5e6247: Merge #10045: [trivial] Fix typos in comments (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #10045: [trivial] Fix typos in comments
May 12 2019, 20:39
Diffusion closed D3022: Merge #10045: [trivial] Fix typos in comments.
May 12 2019, 20:39
markblundeberg updated subscribers of T651: Backport PR 11687 "External wallet files".
May 12 2019, 14:22 · Restricted Project
markblundeberg renamed T568: Backport PR12718 "[Tests] Require exact match in assert_start_raises_init_error" from Backport PR12718 to Backport PR12718 "[Tests] Require exact match in assert_start_raises_init_error".
May 12 2019, 13:47 · Restricted Project
markblundeberg triaged T651: Backport PR 11687 "External wallet files" as Normal priority.
May 12 2019, 13:17 · Restricted Project
schancel updated the summary of D3027: [mining] Delete accuratelyAddPackageTxns and its associates.
May 12 2019, 06:27
teamcity added a comment to D3029: [move] move TxCoinAgePriority to it's sole usage location..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 12 2019, 06:23
teamcity added a comment to D3029: [move] move TxCoinAgePriority to it's sole usage location..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 12 2019, 06:09
Herald added a reviewer for D3029: [move] move TxCoinAgePriority to it's sole usage location.: deadalnix.
May 12 2019, 06:08
teamcity added a comment to D3028: [mempool] remove `CompareTxMemPoolEntryByAncestorFee` as it is no longer needed.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 12 2019, 05:49
Fabien committed rABC99eb5a8bff6d: build: Remove -I for everything but project root (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
build: Remove -I for everything but project root
May 12 2019, 05:40
Fabien closed D3016: build: Remove -I for everything but project root.
May 12 2019, 05:39
teamcity added a comment to D3028: [mempool] remove `CompareTxMemPoolEntryByAncestorFee` as it is no longer needed.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 12 2019, 05:35
Herald added a reviewer for D3028: [mempool] remove `CompareTxMemPoolEntryByAncestorFee` as it is no longer needed: deadalnix.
May 12 2019, 05:34
markblundeberg added inline comments to D3012: Backport current GetDifficulty logic (& tests) from Core.
May 12 2019, 04:55
teamcity added a comment to D3027: [mining] Delete accuratelyAddPackageTxns and its associates.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 12 2019, 03:12
teamcity added a comment to D3027: [mining] Delete accuratelyAddPackageTxns and its associates.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 12 2019, 02:57
Herald added a reviewer for D3027: [mining] Delete accuratelyAddPackageTxns and its associates: deadalnix.
May 12 2019, 02:56
schancel accepted D3012: Backport current GetDifficulty logic (& tests) from Core.
May 12 2019, 02:29
markblundeberg added a subtask for T540: Backport Core PR12755: T568: Backport PR12718 "[Tests] Require exact match in assert_start_raises_init_error".
May 12 2019, 01:45 · Restricted Project
markblundeberg added a parent task for T568: Backport PR12718 "[Tests] Require exact match in assert_start_raises_init_error": T540: Backport Core PR12755.
May 12 2019, 01:45 · Restricted Project
markblundeberg added a parent task for T447: Backport Core PR 12902: T540: Backport Core PR12755.
May 12 2019, 01:40 · Restricted Project
markblundeberg added a subtask for T540: Backport Core PR12755: T447: Backport Core PR 12902.
May 12 2019, 01:40 · Restricted Project
teamcity added a comment to D3026: Merge #10267: New -includeconf argument for including external configuration files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 12 2019, 01:21
markblundeberg added a subtask for T650: Backport Core PR 13197 "util: warn about ignored recursive -includeconf calls": T540: Backport Core PR12755.
May 12 2019, 01:16
markblundeberg added a parent task for T540: Backport Core PR12755: T650: Backport Core PR 13197 "util: warn about ignored recursive -includeconf calls".
May 12 2019, 01:16 · Restricted Project
teamcity added a comment to D3026: Merge #10267: New -includeconf argument for including external configuration files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 12 2019, 01:07
markblundeberg updated the diff for D3026: Merge #10267: New -includeconf argument for including external configuration files.

move release notes into main doc

May 12 2019, 01:06

May 11 2019

teamcity added a comment to D3026: Merge #10267: New -includeconf argument for including external configuration files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 11 2019, 23:58
markblundeberg planned changes to D3026: Merge #10267: New -includeconf argument for including external configuration files.
May 11 2019, 23:55
markblundeberg added a comment to D3026: Merge #10267: New -includeconf argument for including external configuration files.

Note 13197 should be backported fairly soon too (T650)

May 11 2019, 23:55
markblundeberg triaged T650: Backport Core PR 13197 "util: warn about ignored recursive -includeconf calls" as Normal priority.
May 11 2019, 23:50
markblundeberg added a subtask for T650: Backport Core PR 13197 "util: warn about ignored recursive -includeconf calls": T541: Backport Core PR10267 to support includeconf.
May 11 2019, 23:50
markblundeberg added a parent task for T541: Backport Core PR10267 to support includeconf: T650: Backport Core PR 13197 "util: warn about ignored recursive -includeconf calls".
May 11 2019, 23:50 · Restricted Project
markblundeberg created T650: Backport Core PR 13197 "util: warn about ignored recursive -includeconf calls".
May 11 2019, 23:50
teamcity added a comment to D3026: Merge #10267: New -includeconf argument for including external configuration files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 11 2019, 23:44
markblundeberg added a revision to T541: Backport Core PR10267 to support includeconf: D3026: Merge #10267: New -includeconf argument for including external configuration files.
May 11 2019, 23:43 · Restricted Project
markblundeberg added a task to D3026: Merge #10267: New -includeconf argument for including external configuration files: T541: Backport Core PR10267 to support includeconf.
May 11 2019, 23:43
Herald added a reviewer for D3026: Merge #10267: New -includeconf argument for including external configuration files: deadalnix.
May 11 2019, 23:43
teamcity added a comment to D3025: [Wallet] CheckBalance instead of GetBalance for 13% faster sendtoaddress.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 11 2019, 08:42
teamcity added a comment to D3025: [Wallet] CheckBalance instead of GetBalance for 13% faster sendtoaddress.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 11 2019, 08:28
jtoomim updated the diff for D3025: [Wallet] CheckBalance instead of GetBalance for 13% faster sendtoaddress.

Adding tests to test/functional/wallet_basic.py for insufficient balance

May 11 2019, 08:27
teamcity added a comment to D3025: [Wallet] CheckBalance instead of GetBalance for 13% faster sendtoaddress.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 11 2019, 06:57
jtoomim added a comment to D3025: [Wallet] CheckBalance instead of GetBalance for 13% faster sendtoaddress.

Note: FlameGraph performance testing shows that this code changes CPU usage by GetBalance at 7.88% of total before this change, and CheckBalance at 0.10% after this change. (Only 45% of CPU was used by bitcoind/bitcoin-cli in my test; most of the rest is idle.) This is for a wallet with many thousands of UTXOs.

May 11 2019, 06:55
teamcity added a comment to D3025: [Wallet] CheckBalance instead of GetBalance for 13% faster sendtoaddress.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 11 2019, 06:43
Herald added a reviewer for D3025: [Wallet] CheckBalance instead of GetBalance for 13% faster sendtoaddress: deadalnix.
May 11 2019, 06:41
markblundeberg accepted D3022: Merge #10045: [trivial] Fix typos in comments.
May 11 2019, 04:57

May 10 2019

teamcity added a comment to D3024: [tests] Remove unused variables.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 22:24
teamcity added a comment to D3024: [tests] Remove unused variables.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 22:10
Herald added a reviewer for D3024: [tests] Remove unused variables: Restricted Project.
May 10 2019, 22:09
teamcity added a comment to D3023: [tests] Remove unused and duplicate imports.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 21:57
First
Prev
Next