Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Thu, Jul 11
Just remove the tooltip message entirely.
Squashed my commits...
THis fix for MSVC is not backported.
This is reintroducing global state, so no.
This is looking more like something, but:
1/ Naming is terrible, not even descriptive of anything.
2/ It seems strange to me that you need to rely on bitcoin-cli, when both bitcoin-cli and the test framework - this last one being in python, there may even be code that is reusable - manage to fetch the infos directly. Calling into the shell brings a ton fo baggage, especially since, presumably, this will be called from a shell to begin with.
3/ This require a fulling synced node for mainnet and testnet on the same machine running the script.
4/ It doesn't look like there is a way to only update mainnet or testnet.
Wed, Jul 10
There is a tool that can do this automatically and exaustively. Use it.
I'll just pretend that never saw this.
Looks good otherwise.
Better pull before rebasing...
developer notes were done in D2941
Abandoning in favor of D3502
Apparently @generated applies anywhere in the file. Fixed by splitting the string in generate_bestchainparams.py so that the file is not recognized as generated.