Page MenuHomePhabricator
Feed All Stories

Thu, Jul 11

teamcity added a comment to D3651: Place sanitizers log into their own directory.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Thu, Jul 11, 17:22
teamcity added a comment to D3651: Place sanitizers log into their own directory.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Thu, Jul 11, 17:16
Fabien created D3651: Place sanitizers log into their own directory.
Thu, Jul 11, 17:16
teamcity added a comment to D3650: Fix null pointer dereference in SendCoinsEntry.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Thu, Jul 11, 16:17
teamcity added a comment to D3650: Fix null pointer dereference in SendCoinsEntry.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Thu, Jul 11, 16:10
Fabien updated the diff for D3650: Fix null pointer dereference in SendCoinsEntry.

Just remove the tooltip message entirely.

Thu, Jul 11, 16:10
Fabien updated the summary of D3650: Fix null pointer dereference in SendCoinsEntry.
Thu, Jul 11, 15:55
jasonbcox committed rABCca4461867b79: Remove criptolayer.net from seeder lists (authored by jasonbcox).
Remove criptolayer.net from seeder lists
Thu, Jul 11, 14:51
jasonbcox closed D3639: Remove criptolayer.net from seeder lists.
Thu, Jul 11, 14:51
Fabien accepted D3641: Wrap generation of randomized outpoint in tests.
Thu, Jul 11, 12:09
teamcity added a comment to D3649: Avoid std::locale/imbue in DateTimeStrFormat.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Thu, Jul 11, 11:38
deadalnix accepted D3649: Avoid std::locale/imbue in DateTimeStrFormat.
Thu, Jul 11, 11:32
teamcity added a comment to D3649: Avoid std::locale/imbue in DateTimeStrFormat.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Thu, Jul 11, 11:31
Fabien updated the diff for D3649: Avoid std::locale/imbue in DateTimeStrFormat.

Squashed my commits...

Thu, Jul 11, 11:31
deadalnix requested changes to D3649: Avoid std::locale/imbue in DateTimeStrFormat.

THis fix for MSVC is not backported.

Thu, Jul 11, 11:19
deadalnix requested changes to D3650: Fix null pointer dereference in SendCoinsEntry.

This is reintroducing global state, so no.

Thu, Jul 11, 11:13
deadalnix committed rABC9c0570bf057e: outpt => output (authored by deadalnix).
outpt => output
Thu, Jul 11, 11:12
deadalnix closed D3642: outpt => output.
Thu, Jul 11, 11:12
deadalnix added inline comments to D3648: Use size_t for stack index in OP_MULTISIG.
Thu, Jul 11, 09:43
teamcity added a comment to D3650: Fix null pointer dereference in SendCoinsEntry.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Thu, Jul 11, 09:04
teamcity added a comment to D3650: Fix null pointer dereference in SendCoinsEntry.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Thu, Jul 11, 08:58
Fabien created D3650: Fix null pointer dereference in SendCoinsEntry.
Thu, Jul 11, 08:58
Fabien accepted D3642: outpt => output.

Thanks, it was on my todo list.

Thu, Jul 11, 08:08
teamcity added a comment to D3649: Avoid std::locale/imbue in DateTimeStrFormat.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Thu, Jul 11, 08:04
teamcity added a comment to D3649: Avoid std::locale/imbue in DateTimeStrFormat.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Thu, Jul 11, 07:55
Fabien created D3649: Avoid std::locale/imbue in DateTimeStrFormat.
Thu, Jul 11, 07:55
markblundeberg added inline comments to D3648: Use size_t for stack index in OP_MULTISIG.
Thu, Jul 11, 02:00
deadalnix accepted D3630: [wallet] setup wallet background flushing in WalletInit directly.
Thu, Jul 11, 01:49
teamcity added a comment to D3648: Use size_t for stack index in OP_MULTISIG.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Thu, Jul 11, 01:32
teamcity added a comment to D3648: Use size_t for stack index in OP_MULTISIG.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Thu, Jul 11, 01:26
deadalnix created D3648: Use size_t for stack index in OP_MULTISIG.
Thu, Jul 11, 01:26
deadalnix requested changes to D3502: Added a script to generate chainparams constants header files.

This is looking more like something, but:
1/ Naming is terrible, not even descriptive of anything.
2/ It seems strange to me that you need to rely on bitcoin-cli, when both bitcoin-cli and the test framework - this last one being in python, there may even be code that is reusable - manage to fetch the infos directly. Calling into the shell brings a ton fo baggage, especially since, presumably, this will be called from a shell to begin with.
3/ This require a fulling synced node for mainnet and testnet on the same machine running the script.
4/ It doesn't look like there is a way to only update mainnet or testnet.

Thu, Jul 11, 00:46
nakihito abandoned D3640: Merge #10481: Decodehextx scripts sanity check.
Thu, Jul 11, 00:16
teamcity added a comment to D3647: Enforce the use of TxId when constructing COutPoint.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Thu, Jul 11, 00:00

Wed, Jul 10

deadalnix accepted D3638: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal.
Wed, Jul 10, 23:59
deadalnix accepted D3639: Remove criptolayer.net from seeder lists.
Wed, Jul 10, 23:57
deadalnix requested changes to D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..

There is a tool that can do this automatically and exaustively. Use it.

Wed, Jul 10, 23:56
teamcity added a comment to D3646: Use txid in bloom tests.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Jul 10, 23:52
deadalnix requested changes to D3640: Merge #10481: Decodehextx scripts sanity check.

I'll just pretend that never saw this.

Wed, Jul 10, 23:52
teamcity added a comment to D3645: Update rpcwallet.cpp to use TxId.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Jul 10, 23:50
teamcity added a comment to D3647: Enforce the use of TxId when constructing COutPoint.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Jul 10, 23:49
deadalnix created D3647: Enforce the use of TxId when constructing COutPoint.
Wed, Jul 10, 23:49
teamcity added a comment to D3646: Use txid in bloom tests.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Jul 10, 23:46
deadalnix created D3646: Use txid in bloom tests.
Wed, Jul 10, 23:46
teamcity added a comment to D3644: Use TxId in miner_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Jul 10, 23:43
teamcity added a comment to D3645: Update rpcwallet.cpp to use TxId.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Jul 10, 23:41
deadalnix created D3645: Update rpcwallet.cpp to use TxId.
Wed, Jul 10, 23:41
teamcity added a comment to D3644: Use TxId in miner_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Jul 10, 23:37
deadalnix created D3644: Use TxId in miner_tests.cpp.
Wed, Jul 10, 23:36
teamcity added a comment to D3643: Factor out outpoint generation in transaction_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Jul 10, 23:32
teamcity added a comment to D3643: Factor out outpoint generation in transaction_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Jul 10, 23:26
deadalnix created D3643: Factor out outpoint generation in transaction_tests.cpp.
Wed, Jul 10, 23:26
teamcity added a comment to D3642: outpt => output.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Jul 10, 23:24
teamcity added a comment to D3642: outpt => output.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Jul 10, 23:18
deadalnix created D3642: outpt => output.
Wed, Jul 10, 23:18
teamcity added a comment to D3641: Wrap generation of randomized outpoint in tests.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Jul 10, 22:47
teamcity added a comment to D3641: Wrap generation of randomized outpoint in tests.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Jul 10, 22:41
deadalnix created D3641: Wrap generation of randomized outpoint in tests.
Wed, Jul 10, 22:41
nakihito requested review of D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..

base58.cpp change wes made in D624 and then the code was moved to a different file in D3577.
The majority of other changes were made in D873.

Wed, Jul 10, 22:06
teamcity added a comment to D3640: Merge #10481: Decodehextx scripts sanity check.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Jul 10, 21:56
teamcity added a comment to D3640: Merge #10481: Decodehextx scripts sanity check.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Jul 10, 21:46
nakihito created D3640: Merge #10481: Decodehextx scripts sanity check.
Wed, Jul 10, 21:45
deadalnix committed rABC2be0a84fdf49: use TxId properly in coincontroldialog (authored by deadalnix).
use TxId properly in coincontroldialog
Wed, Jul 10, 21:28
deadalnix closed D3637: use TxId properly in coincontroldialog.
Wed, Jul 10, 21:28
teamcity added a comment to D3639: Remove criptolayer.net from seeder lists.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Jul 10, 21:09
teamcity added a comment to D3639: Remove criptolayer.net from seeder lists.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Jul 10, 21:03
jasonbcox created D3639: Remove criptolayer.net from seeder lists.
Wed, Jul 10, 21:03
jasonbcox accepted D3637: use TxId properly in coincontroldialog.
Wed, Jul 10, 19:59
Fabien committed rABC4c69be0a19a8: [wallet] Fix potential memory leak in CreateWalletFromFile (authored by John Newbery <john@johnnewbery.com>).
[wallet] Fix potential memory leak in CreateWalletFromFile
Wed, Jul 10, 19:34
Fabien closed D3629: [wallet] Fix potential memory leak in CreateWalletFromFile.
Wed, Jul 10, 19:34
teamcity added a comment to D3629: [wallet] Fix potential memory leak in CreateWalletFromFile.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Jul 10, 19:29
jasonbcox requested changes to D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..

Looks good otherwise.

Wed, Jul 10, 19:26
teamcity added a comment to D3629: [wallet] Fix potential memory leak in CreateWalletFromFile.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Jul 10, 19:23
Harbormaster failed remote builds in B6807: Diff 10211 for D3629: [wallet] Fix potential memory leak in CreateWalletFromFile!
Wed, Jul 10, 19:18
teamcity added a comment to D3629: [wallet] Fix potential memory leak in CreateWalletFromFile.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Wed, Jul 10, 19:18
teamcity added a comment to D3629: [wallet] Fix potential memory leak in CreateWalletFromFile.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Jul 10, 19:16
Fabien updated the diff for D3629: [wallet] Fix potential memory leak in CreateWalletFromFile.

Better pull before rebasing...

Wed, Jul 10, 19:16
teamcity added a comment to D3629: [wallet] Fix potential memory leak in CreateWalletFromFile.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Wed, Jul 10, 19:05
Harbormaster failed remote builds in B6806: Diff 10210 for D3629: [wallet] Fix potential memory leak in CreateWalletFromFile!
Wed, Jul 10, 19:05
teamcity added a comment to D3629: [wallet] Fix potential memory leak in CreateWalletFromFile.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Jul 10, 19:04
Fabien updated the diff for D3629: [wallet] Fix potential memory leak in CreateWalletFromFile.

Rebase

Wed, Jul 10, 19:04
jasonbcox abandoned D3443: Added fetch-chainparams.py to fetch chainparam block values from a node using HTTP RPC.
Wed, Jul 10, 18:38
markblundeberg closed T436: Backport core PR 10286, a subtask of T437: Backport core PR 11738, as Resolved.
Wed, Jul 10, 18:33 · Restricted Project
markblundeberg closed T436: Backport core PR 10286, a subtask of T638: Backport Core PR 11738 (fix hang in sendrawtransaction), as Resolved.
Wed, Jul 10, 18:33
markblundeberg closed T436: Backport core PR 10286, a subtask of T626: Backport Core PR 12988, as Resolved.
Wed, Jul 10, 18:33
markblundeberg closed T436: Backport core PR 10286 as Resolved.

developer notes were done in D2941

Wed, Jul 10, 18:33 · Restricted Project
jasonbcox updated the summary of D3502: Added a script to generate chainparams constants header files.
Wed, Jul 10, 18:26
jasonbcox abandoned D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.

Abandoning in favor of D3502

Wed, Jul 10, 18:25
jasonbcox abandoned D3152: Added release.sh script for generating a release commit.
Wed, Jul 10, 18:24
teamcity added a comment to D3502: Added a script to generate chainparams constants header files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Jul 10, 18:23
jasonbcox updated the summary of D3502: Added a script to generate chainparams constants header files.
Wed, Jul 10, 18:21
teamcity added a comment to D3638: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Wed, Jul 10, 18:20
Harbormaster failed remote builds in B6804: Diff 10208 for D3638: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal!
Wed, Jul 10, 18:20
jasonbcox updated the test plan for D3502: Added a script to generate chainparams constants header files.
Wed, Jul 10, 18:19
teamcity added a comment to D3502: Added a script to generate chainparams constants header files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Jul 10, 18:18
teamcity added a comment to D3634: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where defined..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Wed, Jul 10, 18:14
markblundeberg closed T626: Backport Core PR 12988, a subtask of T623: Backport Core PR 13023, as Resolved.
Wed, Jul 10, 18:13
markblundeberg closed T626: Backport Core PR 12988 as Resolved.

see D3638

Wed, Jul 10, 18:13
teamcity added a comment to D3502: Added a script to generate chainparams constants header files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Wed, Jul 10, 18:13
jasonbcox updated the diff for D3502: Added a script to generate chainparams constants header files.

Apparently @generated applies anywhere in the file. Fixed by splitting the string in generate_bestchainparams.py so that the file is not recognized as generated.

Wed, Jul 10, 18:13