Page MenuHomePhabricator
Feed All Stories

Sep 6 2019

Harbormaster failed remote builds in B7357: Diff 11146 for D4021: Merge #13149: Handle unsuccessful fseek(...):s!
Sep 6 2019, 18:23
teamcity added a comment to D4021: Merge #13149: Handle unsuccessful fseek(...):s.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Sep 6 2019, 18:23
teamcity added a comment to D4021: Merge #13149: Handle unsuccessful fseek(...):s.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 18:22
nakihito created D4021: Merge #13149: Handle unsuccessful fseek(...):s.
Sep 6 2019, 18:22
teamcity added a comment to D3934: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 18:06
teamcity added a comment to D4020: Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 18:03
teamcity added a comment to D3934: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 17:57
nakihito updated the diff for D3934: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.

Fixed comment formatting and removed extra new line.

Sep 6 2019, 17:57
teamcity added a comment to D4020: Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 17:56
nakihito created D4020: Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan.
Sep 6 2019, 17:55
jasonbcox requested changes to D3934: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.
Sep 6 2019, 17:53
teamcity added a comment to D3694: Update the github issue template to include disclosure policy.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 17:48
teamcity added a comment to D3694: Update the github issue template to include disclosure policy.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 17:39
jasonbcox updated the diff for D3694: Update the github issue template to include disclosure policy.

Rebase + use email instead of Reddit

Sep 6 2019, 17:39
fpelliccioni added a comment to D4009: zmq: log outbound message high water mark when reusing socket.
In D4009#94136, @Fabien wrote:
Sep 6 2019, 17:36
teamcity added a comment to D4017: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...).

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 17:32
teamcity added a comment to D4014: [CI] Make IBD a standard build configuration.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 17:32
Fabien requested review of D4014: [CI] Make IBD a standard build configuration.
Sep 6 2019, 17:27
jasonbcox accepted D4017: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...).
Sep 6 2019, 17:25
teamcity added a comment to D4017: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...).

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 17:25
jasonbcox requested changes to D4014: [CI] Make IBD a standard build configuration.
Sep 6 2019, 17:22
teamcity added a comment to D4014: [CI] Make IBD a standard build configuration.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 17:20
Fabien updated the diff for D4014: [CI] Make IBD a standard build configuration.

Address comments.

Sep 6 2019, 17:20
teamcity added a comment to D4019: Merge #13747: tests: Skip P2PConnection's is_closing() check when not available.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 17:20
nakihito requested review of D3542: Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak.
Sep 6 2019, 17:16
nakihito requested review of D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.
Sep 6 2019, 17:14
teamcity added a comment to D4019: Merge #13747: tests: Skip P2PConnection's is_closing() check when not available.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 17:13
jasonbcox created D4019: Merge #13747: tests: Skip P2PConnection's is_closing() check when not available.
Sep 6 2019, 17:12
teamcity added a comment to D3914: Merge #12853: qa: Match full plain text by default.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 17:09
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 17:08
teamcity added a comment to D4016: Pull leveldb subtree.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 17:03
teamcity added a comment to D3914: Merge #12853: qa: Match full plain text by default.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 17:02
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 17:02
Fabien requested changes to D4009: zmq: log outbound message high water mark when reusing socket.

Something's wrong in this backport, it fails the build (see https://build.bitcoinabc.org/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=18761&_focus=1157)

Sep 6 2019, 17:02
Harbormaster failed remote builds in B7345: Diff 11133 for D4009: zmq: log outbound message high water mark when reusing socket!
Sep 6 2019, 16:59
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 16:59
teamcity added a comment to D4009: zmq: log outbound message high water mark when reusing socket.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Sep 6 2019, 16:59
jasonbcox closed T678: Backport Core PR 13715, a subtask of T677: Backport Core PR 13747, as Resolved.
Sep 6 2019, 16:58
jasonbcox closed T678: Backport Core PR 13715 as Resolved.
Sep 6 2019, 16:58
jasonbcox closed T676: Backport Core PR 13517 (qa: Remove need to handle the network thread in tests), a subtask of T678: Backport Core PR 13715, as Resolved.
Sep 6 2019, 16:58
jasonbcox closed T676: Backport Core PR 13517 (qa: Remove need to handle the network thread in tests) as Resolved.
Sep 6 2019, 16:58
Harbormaster failed remote builds in B7348: Diff 11136 for D4018: Do not construct out-of-bound pointers in SHA2 code!
Sep 6 2019, 16:54
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 16:54
teamcity added a comment to D4018: Do not construct out-of-bound pointers in SHA2 code.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Sep 6 2019, 16:54
jasonbcox updated the diff for D3914: Merge #12853: qa: Match full plain text by default.

Rebase + fix according to feedback

Sep 6 2019, 16:54
teamcity added a comment to D4018: Do not construct out-of-bound pointers in SHA2 code.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 16:53
teamcity added a comment to D4017: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...).

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Sep 6 2019, 16:53
Harbormaster failed remote builds in B7347: Diff 11135 for D4017: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...)!
Sep 6 2019, 16:52
teamcity added a comment to D4017: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...).

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 16:51
teamcity added a comment to D4016: Pull leveldb subtree.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 16:51
jasonbcox accepted D4018: Do not construct out-of-bound pointers in SHA2 code.
Sep 6 2019, 16:50
teamcity added a comment to D4009: zmq: log outbound message high water mark when reusing socket.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 16:49
jasonbcox updated the diff for D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

One last lint issue in ibd.sh...

Sep 6 2019, 16:47
jasonbcox updated the diff for D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Rebase + fix lint issues

Sep 6 2019, 16:45
fpelliccioni created D4018: Do not construct out-of-bound pointers in SHA2 code.
Sep 6 2019, 16:37
fpelliccioni created D4017: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...).
Sep 6 2019, 16:35
fpelliccioni created D4016: Pull leveldb subtree.
Sep 6 2019, 16:35
fpelliccioni updated the diff for D4009: zmq: log outbound message high water mark when reusing socket.

Summary fixed.

Sep 6 2019, 16:21
fpelliccioni added a comment to D4009: zmq: log outbound message high water mark when reusing socket.

Can you fix the summary? looks like some of it got cut off.

Sep 6 2019, 16:19
fpelliccioni updated the summary of D4009: zmq: log outbound message high water mark when reusing socket.
Sep 6 2019, 16:18
fpelliccioni updated the summary of D4009: zmq: log outbound message high water mark when reusing socket.
Sep 6 2019, 16:17
fpelliccioni committed rABC4ab217db8523: [rebase] threads: fix unitialized members in sched_param (authored by Cory Fields <cory-nospam-@coryfields.com>).
[rebase] threads: fix unitialized members in sched_param
Sep 6 2019, 16:12
fpelliccioni closed D4008: [rebase] threads: fix unitialized members in sched_param.
Sep 6 2019, 16:12
fpelliccioni committed rABC55441ec79bdb: Update univalue subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Update univalue subtree
Sep 6 2019, 16:09
fpelliccioni closed D4007: Update univalue subtree.
Sep 6 2019, 16:09
fpelliccioni committed rABC85bc68c4608a: Merge leveldb subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Merge leveldb subtree
Sep 6 2019, 16:07
fpelliccioni closed D4006: Merge leveldb subtree.
Sep 6 2019, 16:07
fpelliccioni committed rABC707568ec5670: Bump leveldb subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Bump leveldb subtree
Sep 6 2019, 16:03
fpelliccioni closed D4004: Bump leveldb subtree.
Sep 6 2019, 16:03
jasonbcox accepted D3984: [LINTER] Enforce using C++ style for void parameters.
Sep 6 2019, 16:02
jasonbcox closed T679: Backport Core PR 13512, a subtask of T676: Backport Core PR 13517 (qa: Remove need to handle the network thread in tests), as Resolved.
Sep 6 2019, 15:58
jasonbcox closed T679: Backport Core PR 13512 as Resolved.
Sep 6 2019, 15:58
jasonbcox committed rABCe45a75f391a1: Merge #13517: qa: Remove need to handle the network thread in tests (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13517: qa: Remove need to handle the network thread in tests
Sep 6 2019, 15:52
jasonbcox closed D4012: Merge #13517: qa: Remove need to handle the network thread in tests.
Sep 6 2019, 15:52
Fabien accepted D4012: Merge #13517: qa: Remove need to handle the network thread in tests.
Sep 6 2019, 15:51
jasonbcox accepted D4015: Bugfix: NSIS: Exclude Makefile* from docs.
Sep 6 2019, 15:50
jasonbcox updated the summary of D4012: Merge #13517: qa: Remove need to handle the network thread in tests.
Sep 6 2019, 15:47
jasonbcox updated the summary of D4012: Merge #13517: qa: Remove need to handle the network thread in tests.
Sep 6 2019, 15:46
jasonbcox closed T669: Removing comparison test framework, a subtask of T679: Backport Core PR 13512, as Resolved.
Sep 6 2019, 15:42
jasonbcox closed T669: Removing comparison test framework as Resolved.
Sep 6 2019, 15:42
jasonbcox committed rABC7fe97790bd89: Merge #11818: I accidentally [deliberately] killed it [the… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #11818: I accidentally [deliberately] killed it [the…
Sep 6 2019, 15:42
jasonbcox closed D4002: Merge #11818: I accidentally [deliberately] killed it [the ComparisonTestFramework].
Sep 6 2019, 15:42
jasonbcox requested changes to D4014: [CI] Make IBD a standard build configuration.
Sep 6 2019, 15:39
teamcity added a comment to D4015: Bugfix: NSIS: Exclude Makefile* from docs.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 15:39
teamcity added a comment to D4012: Merge #13517: qa: Remove need to handle the network thread in tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 15:32
teamcity added a comment to D4015: Bugfix: NSIS: Exclude Makefile* from docs.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 15:31
Fabien created D4015: Bugfix: NSIS: Exclude Makefile* from docs.
Sep 6 2019, 15:28
teamcity added a comment to D4012: Merge #13517: qa: Remove need to handle the network thread in tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 15:25
jasonbcox committed rABCad3f7f55012f: Merge #13512: [qa] mininode: Expose connection state through is_connected (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13512: [qa] mininode: Expose connection state through is_connected
Sep 6 2019, 15:24
jasonbcox closed D4011: Merge #13512: [qa] mininode: Expose connection state through is_connected.
Sep 6 2019, 15:24
teamcity added a comment to D4012: Merge #13517: qa: Remove need to handle the network thread in tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 15:21
jasonbcox committed rABC27ebde13667a: Fix incorrectly backported return statements in mininode.py (authored by jasonbcox).
Fix incorrectly backported return statements in mininode.py
Sep 6 2019, 15:15
jasonbcox closed D4010: Fix incorrectly backported return statements in mininode.py.
Sep 6 2019, 15:15
teamcity added a comment to D4012: Merge #13517: qa: Remove need to handle the network thread in tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 15:14
jasonbcox updated the diff for D4012: Merge #13517: qa: Remove need to handle the network thread in tests.

Merged in D4013 to fix flaky feature_assumevalid

Sep 6 2019, 15:14
jasonbcox abandoned D4013: Merge #13715: tests: fixes mininode's P2PConnection sending messages on closing transport.

Abandoning to include this change in D4012.

Sep 6 2019, 15:11
teamcity added a comment to D3993: [CI] Refactor the build configuration by moving out tests from the build.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 13:48
teamcity added a comment to D3993: [CI] Refactor the build configuration by moving out tests from the build.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 13:41
Fabien updated the diff for D3993: [CI] Refactor the build configuration by moving out tests from the build.

Rebase on top of D4014 and address feedbacks.

Sep 6 2019, 13:41
Fabien updated the summary of D3993: [CI] Refactor the build configuration by moving out tests from the build.
Sep 6 2019, 12:56