Build Bitcoin-ABC / Diffs / Diff Testing started.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jan 13 2020
Jan 13 2020
Harbormaster failed remote builds in B8904: Diff 15408 for D4927: [CI] Use ninja targets instead of calling binaries!
Fix typo CURRENT_BINARY_DIR => CMAKE_CURRENT_BINARY_DIR.
The test runner does have it's temp directory in the build directory (it was the case before this patch because of the relative path; now it's explicitly made relative to CMAKE_CURRENT_BINARY_DIR).
Since it's a prefix path, the final directory name is still generated by test_runner.py which prevents name collisions when it runs multiple times in the same build dir.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Redo release notes
In D4900#118882, @markblundeberg wrote:Out of curiosity, why are we backporting these when Core doesn't have them in their master?
I don't think this is moving in the right direction. We just simply can't pack everything into the cmake build and expect that approach to scale.
Ok after a few pass I now get it. The validation.cpp change is not good, IMO, the the rest is pretty solid but would need some polish.
The release notes needs to be updated.
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABCd9ec54f9a496: Merge #13142: Separate IsMine from solvability (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13142: Separate IsMine from solvability
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC8dc344a1d63d: move ScriptExecutionMetrics to its own file (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
move ScriptExecutionMetrics to its own file
markblundeberg added a revision to T704: sigChecks implementation: D4918: move ScriptExecutionMetrics to its own file.
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABCf3dea985535c: move MANDATORY_SCRIPT_VERIFY_FLAGS to policy.h (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
move MANDATORY_SCRIPT_VERIFY_FLAGS to policy.h
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC5c92e06b6a0d: [tests] remove test_bitcoin.h dependency on txmempool.h (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
[tests] remove test_bitcoin.h dependency on txmempool.h
I think 2 is an excellent idea!
teamcity added a comment to D4928: [CI] Increase the coverage for the build-diff and build-master configs.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Harbormaster failed remote builds in B8902: Diff 15402 for D4928: [CI] Increase the coverage for the build-diff and build-master configs!
teamcity added a comment to D4928: [CI] Increase the coverage for the build-diff and build-master configs.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Harbormaster failed remote builds in B8901: Diff 15401 for D4927: [CI] Use ninja targets instead of calling binaries!
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Harbormaster failed remote builds in B8899: Diff 15399 for D4925: [CI] Split build-default into build-diff and build-master!
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Rebase.
Harbormaster failed remote builds in B8897: Diff 15397 for D4924: [CI] Add a configuration to build and run the benchmarks!
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Out of curiosity, why are we backporting these when Core doesn't have them in their master?
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fix integration test which wa spartially erroneously commented
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Note: As far as closures go, CScriptCheck is slightly weird because it saves (some of) the results into the closure, rather than returning them.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fix -Wshadow warnings
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
deadalnix committed rABC7b282ccdf412: test: add "diamond" unit test to MempoolAncestryTests (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: add "diamond" unit test to MempoolAncestryTests
deadalnix committed rABC49330c5d3cd2: scripted-diff: Remove unused first argument to addUnchecked (authored by MarcoFalke <falke.marco@gmail.com>).
scripted-diff: Remove unused first argument to addUnchecked
I am thinking of making two changes here:
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
update tests
Or should it be called GetVirtualSizeIncrement instead of GetIncrementalVirtualSize ?
Fabien committed rABCa3de297b55ec: Free BerkeleyEnvironment instances when not in use (authored by Russell Yanofsky <russ@yanofsky.org>).
Free BerkeleyEnvironment instances when not in use
Fabien committed rABC82fe6a22e7ce: Fix the abc-p2p-compactblocks when running whith UBSAN (authored by Fabien).
Fix the abc-p2p-compactblocks when running whith UBSAN
Fix extra parenthesis in python .format()
I have a feeling this needs some tests...
Build Bitcoin-ABC / Diffs / Diff Testing passed.
This could be integrated into the mentioned Diffs, but I figured the mathematical concepts here are a bit weird and deserve a separate think.