Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Feb 11 2020

teamcity added a comment to D5254: Fix LockDirectory test failure when the Junit logger is enabled.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 09:06
Fabien requested changes to D5243: Add new post-fork ancestor and descendants limit..
Feb 11 2020, 09:03
teamcity added a comment to D5254: Fix LockDirectory test failure when the Junit logger is enabled.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 08:53
teamcity added a comment to D5254: Fix LockDirectory test failure when the Junit logger is enabled.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 08:47
Fabien updated the diff for D5254: Fix LockDirectory test failure when the Junit logger is enabled.

Add comment (from D5232).

Feb 11 2020, 08:47
teamcity added a comment to D5254: Fix LockDirectory test failure when the Junit logger is enabled.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 08:43
Fabien created D5254: Fix LockDirectory test failure when the Junit logger is enabled.
Feb 11 2020, 08:43
markblundeberg added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Macro lolfail:

Feb 11 2020, 08:08
teamcity added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Feb 11 2020, 08:06
teamcity added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Feb 11 2020, 08:02
markblundeberg added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
In D5214#126782, @teamcity wrote:
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Feb 11 2020, 07:58
teamcity added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 07:58
teamcity added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 07:58
teamcity added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Feb 11 2020, 07:53
teamcity added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 07:48
teamcity added a comment to D5253: Bump automatic replay protection to Nov 2020 upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 07:48
markblundeberg updated the summary of D5252: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.
Feb 11 2020, 07:40
markblundeberg updated the summary of D5252: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.
Feb 11 2020, 07:40
markblundeberg updated the summary of D5253: Bump automatic replay protection to Nov 2020 upgrade.
Feb 11 2020, 07:38
markblundeberg added a comment to D5253: Bump automatic replay protection to Nov 2020 upgrade.

Opening this now to take suggestions on names. :-)

Feb 11 2020, 07:38
teamcity added a comment to D5253: Bump automatic replay protection to Nov 2020 upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 07:37
markblundeberg created D5253: Bump automatic replay protection to Nov 2020 upgrade.
Feb 11 2020, 07:37
teamcity added a comment to D5238: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 07:26
teamcity added a comment to D5238: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 07:16
markblundeberg updated the diff for D5238: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex.

update comment

Feb 11 2020, 07:16
markblundeberg added inline comments to D5238: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex.
Feb 11 2020, 07:15
markblundeberg added inline comments to D5232: util_tests.test_LockDirectory: avoid exit in forked process.
Feb 11 2020, 05:55
markblundeberg updated the test plan for D5252: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.
Feb 11 2020, 05:42
teamcity added a comment to D5252: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 05:32
markblundeberg added a comment to D5251: Merge #17455: tests: Update valgrind suppressions.

(the 5 remaining reachable leaked blocks are: 4 from leveldb, 1 from LogInstance)

Feb 11 2020, 05:25
teamcity added a comment to D5252: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Feb 11 2020, 05:23
teamcity updated the summary of D5252: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.
Feb 11 2020, 05:23
teamcity added a comment to D5252: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 05:23
markblundeberg created D5252: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.
Feb 11 2020, 05:23
teamcity added a comment to D5251: Merge #17455: tests: Update valgrind suppressions.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 05:21
markblundeberg added a reviewer for D5251: Merge #17455: tests: Update valgrind suppressions: Fabien.
Feb 11 2020, 05:13
markblundeberg updated the test plan for D5251: Merge #17455: tests: Update valgrind suppressions.
Feb 11 2020, 05:13
markblundeberg updated the test plan for D5251: Merge #17455: tests: Update valgrind suppressions.
Feb 11 2020, 05:12
teamcity added a comment to D5251: Merge #17455: tests: Update valgrind suppressions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 05:12
teamcity added a comment to D5251: Merge #17455: tests: Update valgrind suppressions.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Feb 11 2020, 05:12
teamcity updated the summary of D5251: Merge #17455: tests: Update valgrind suppressions.
Feb 11 2020, 05:12
markblundeberg created D5251: Merge #17455: tests: Update valgrind suppressions.
Feb 11 2020, 05:11
Mengerian added a comment to D5245: [qa] Test that mempool reverts to pre-phonon policies.

Nit: Filename "abc-phonos-disconnectpool.py" should change phonos -> phonon

Feb 11 2020, 04:13
deadalnix closed T743: Build Bitcoin-ABC / Master / Health Checks / Bitcoin-ABC Check Seeds is broken. as Wontfix.

Patch doesn't touch the seeds.

Feb 11 2020, 04:05
teamcity assigned T743: Build Bitcoin-ABC / Master / Health Checks / Bitcoin-ABC Check Seeds is broken. to deadalnix.
Feb 11 2020, 04:03
teamcity triaged T743: Build Bitcoin-ABC / Master / Health Checks / Bitcoin-ABC Check Seeds is broken. as Unbreak Now! priority.
Feb 11 2020, 04:03
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 03:36
teamcity added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 03:25
markblundeberg updated the diff for D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

update per comments; still todo: virtualsize test

Feb 11 2020, 03:24
nakihito requested review of D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Feb 11 2020, 02:43
markblundeberg added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
In D5214#126699, @teamcity wrote:
Build Bitcoin-ABC / Diffs / Diff Testing failed.

Snippet of first build failure:

[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_directory
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_relative
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing2
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.psbt_updater_test
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.parse_hd_keypath
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.rescan
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.importwallet_rescan
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.coin_mark_dirty_immature_credit
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ComputeTimeSmart
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.LoadReceiveRequests
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ListCoins
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.wallet_disableprivkeys
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_name
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_purpose
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_destdata
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.no_dest_fails
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.passphrase
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.encrypt
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.decrypt
[01:42:52] :	 [Step 1/1] Running 454 test cases...
[01:42:52] :	 [Step 1/1] 
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:58]W:	 [Step 1/1] corrupted double-linked list
[01:42:58] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365../src/test/util_tests.cpp(1368):  [1;31;49merror: in "util_tests/test_LockDirectory": check processstatus == 0 has failed [11 != 0] [0;39;49m
[01:43:04]W:	 [Step 1/1] 
[01:43:04]W:	 [Step 1/1]  [1;31;49m*** 1 failure is detected in the test module "Bitcoin ABC unit tests with next upgrade activated"
[01:43:04]W:	 [Step 1/1]  [0;39;49m
[01:43:04]W:	 [Step 1/1] Process exited with code 201
[01:43:04]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

Feb 11 2020, 02:18
teamcity added a comment to D5250: Remove updating chainparams from release process.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 02:06
teamcity added a comment to D5250: Remove updating chainparams from release process.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 01:57
jasonbcox created D5250: Remove updating chainparams from release process.
Feb 11 2020, 01:57
Harbormaster failed remote builds in B9410: Diff 16249 for D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command!
Feb 11 2020, 01:43
teamcity added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Feb 11 2020, 01:43
teamcity added a comment to D4442: Seeder bans nodes not following the correct chain.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 01:40
teamcity added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 01:38
nakihito planned changes to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Feb 11 2020, 01:38
nakihito updated the diff for D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Rebased.

Feb 11 2020, 01:38
teamcity added a comment to D4442: Seeder bans nodes not following the correct chain.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 11 2020, 01:31
nakihito planned changes to D4442: Seeder bans nodes not following the correct chain.
Feb 11 2020, 01:31
nakihito updated the diff for D4442: Seeder bans nodes not following the correct chain.

Rebased and CheckForCheckpoint() -> RequestBlocksAfterCheckpoint().

Feb 11 2020, 01:31
nakihito retitled D4442: Seeder bans nodes not following the correct chain from Seeder filters nodes by chainparams to Seeder bans nodes not following the correct chain.
Feb 11 2020, 01:24
deadalnix committed rABC3d26d0c747cb: [cmake] Add the suite name to the test runner. (authored by deadalnix).
[cmake] Add the suite name to the test runner.
Feb 11 2020, 00:36
deadalnix closed D5247: [cmake] Add the suite name to the test runner..
Feb 11 2020, 00:36
jasonbcox accepted D5241: Make parse_name() properly fail when the query name is longer than 255 characters.
Feb 11 2020, 00:28
jasonbcox accepted D5247: [cmake] Add the suite name to the test runner..
Feb 11 2020, 00:26
jasonbcox updated the test plan for D5246: Use a temporary datadir and non-default RPC port when testing seeds.
Feb 11 2020, 00:25
markblundeberg added inline comments to D5244: Enable new ancestor/descendants chains limit at fork.
Feb 11 2020, 00:14
teamcity added a comment to D5248: Add update-seeds to automated-commits.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 11 2020, 00:02

Feb 10 2020

teamcity added a comment to D5241: Make parse_name() properly fail when the query name is longer than 255 characters.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 10 2020, 23:58
jasonbcox planned changes to D5248: Add update-seeds to automated-commits.
Feb 10 2020, 23:53
teamcity added a comment to D5248: Add update-seeds to automated-commits.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 10 2020, 23:53
jasonbcox created D5248: Add update-seeds to automated-commits.
Feb 10 2020, 23:53
teamcity added a comment to D5247: [cmake] Add the suite name to the test runner..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 10 2020, 23:51
teamcity added a comment to D5241: Make parse_name() properly fail when the query name is longer than 255 characters.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 10 2020, 23:49
nakihito updated the diff for D5241: Make parse_name() properly fail when the query name is longer than 255 characters.

Added clarifying comment and changed to test to check immediately beyond the character limit.

Feb 10 2020, 23:49
teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 10 2020, 23:44
teamcity added a comment to D5247: [cmake] Add the suite name to the test runner..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 10 2020, 23:40
deadalnix created D5247: [cmake] Add the suite name to the test runner..
Feb 10 2020, 23:40
teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 10 2020, 23:35
jasonbcox requested review of D5246: Use a temporary datadir and non-default RPC port when testing seeds.
Feb 10 2020, 23:34
nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Squashed some tests together, extracted some setup code, and fixed some comments.

Feb 10 2020, 23:34
teamcity added a comment to D5243: Add new post-fork ancestor and descendants limit..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 10 2020, 23:34
jasonbcox planned changes to D5246: Use a temporary datadir and non-default RPC port when testing seeds.
Feb 10 2020, 23:33
nakihito added inline comments to D4436: Add unit tests for CSeederNode::ProcessMessage().
Feb 10 2020, 23:32
nakihito planned changes to D5241: Make parse_name() properly fail when the query name is longer than 255 characters.
Feb 10 2020, 23:28
teamcity added a comment to D5243: Add new post-fork ancestor and descendants limit..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 10 2020, 23:24
dagurval updated the diff for D5243: Add new post-fork ancestor and descendants limit..

Header inclusion order, explicit SetMTP, rename test

Feb 10 2020, 23:24
teamcity added a comment to D5246: Use a temporary datadir and non-default RPC port when testing seeds.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Feb 10 2020, 23:20
teamcity added a comment to D5246: Use a temporary datadir and non-default RPC port when testing seeds.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Feb 10 2020, 23:11
jasonbcox created D5246: Use a temporary datadir and non-default RPC port when testing seeds.
Feb 10 2020, 23:10
dagurval committed rABC65fa46b73131: Move mempool policy constants to policy/mempool.h (authored by dagurval).
Move mempool policy constants to policy/mempool.h
Feb 10 2020, 22:35
dagurval closed D5242: Move mempool policy constants to policy/mempool.h.
Feb 10 2020, 22:35
jasonbcox added inline comments to D5243: Add new post-fork ancestor and descendants limit..
Feb 10 2020, 22:34
dagurval planned changes to D5245: [qa] Test that mempool reverts to pre-phonon policies.

Marking as planned changes due to issues with parent diff

Feb 10 2020, 22:33
jasonbcox added inline comments to D5243: Add new post-fork ancestor and descendants limit..
Feb 10 2020, 22:32
deadalnix requested changes to D5243: Add new post-fork ancestor and descendants limit..

You need to update the cmake build.

Feb 10 2020, 22:29
jasonbcox requested changes to D4436: Add unit tests for CSeederNode::ProcessMessage().
Feb 10 2020, 22:23
First
Prev
Next