Feed All Stories
Oct 1 2020
Oct 1 2020
teamcity added a comment to D7602: remove walletmodel circular dependency.
PiRK updated the diff for D7602: remove walletmodel circular dependency.
remove the circular dependency using interfaces
deadalnix requested changes to D7698: [backport#17369] Refactor: Move encryption code between KeyMan and Wallet.
This is busted
onyxadjusting edited a custom field on onyxadjusting.
soldbyanil edited a custom field on soldbyanil.
soldbyanil edited a custom field on soldbyanil.
Fabien committed rABC46191a3f4926: [SECP256K1] Install a prebuilt cmake version on OSX (authored by Fabien).
[SECP256K1] Install a prebuilt cmake version on OSX
123hpcomsetup edited a custom field on 123hpcomsetup.
teamcity added a comment to D7697: [backport#17373] wallet: Various fixes and cleanup to keypool handling in LegacyScriptPubKeyMan and CWallet.
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
majcosta committed rABC532d58920b54: [backport#17518] refactor, wallet: Nuke coincontrol circular dependency (authored by Samuel Dobson <dobsonsa68@gmail.com>).
[backport#17518] refactor, wallet: Nuke coincontrol circular dependency
teamcity added a comment to D7698: [backport#17369] Refactor: Move encryption code between KeyMan and Wallet.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
[Automated] Update timing.json
teamcity added a comment to D7698: [backport#17369] Refactor: Move encryption code between KeyMan and Wallet.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
teamcity updated the summary of D7698: [backport#17369] Refactor: Move encryption code between KeyMan and Wallet.
majcosta requested review of D7698: [backport#17369] Refactor: Move encryption code between KeyMan and Wallet.
majcosta committed rABCacadeec0ee78: [backport#16766] wallet: Make IsTrusted scan parents recursively (authored by Samuel Dobson <dobsonsa68@gmail.com>).
[backport#16766] wallet: Make IsTrusted scan parents recursively
teamcity added a comment to D7697: [backport#17373] wallet: Various fixes and cleanup to keypool handling in LegacyScriptPubKeyMan and CWallet.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
[Automated] Update chainparams
Rest looks good
majcosta updated the diff for D7695: [backport#16766] wallet: Make IsTrusted scan parents recursively.
edited release-notes.md
majcosta committed rABC37b9f1079b16: [backport#17648] doc: rename wallet-tool references to bitcoin-wallet (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#17648] doc: rename wallet-tool references to bitcoin-wallet
teamcity triaged T1082: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
teamcity added a comment to D7697: [backport#17373] wallet: Various fixes and cleanup to keypool handling in LegacyScriptPubKeyMan and CWallet.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
teamcity added a comment to D7694: [backport#17518] refactor, wallet: Nuke coincontrol circular dependency.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
jasonbcox requested changes to D7695: [backport#16766] wallet: Make IsTrusted scan parents recursively.
majcosta published D7695: [backport#16766] wallet: Make IsTrusted scan parents recursively for review.
jasonbcox committed rABC19ef8d7b391c: Remove erroneous checks in wallet_balance test (authored by jasonbcox).
Remove erroneous checks in wallet_balance test
teamcity triaged T1081: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Unbreak Now! priority.
jasonbcox requested review of D7696: Remove erroneous checks in wallet_balance test.
majcosta committed rABCcc35ed039d0e: [refactor] make the finalized BlockIndex* a private member of CChainState (authored by majcosta).
[refactor] make the finalized BlockIndex* a private member of CChainState
teamcity added a comment to D7694: [backport#17518] refactor, wallet: Nuke coincontrol circular dependency.
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Sep 30 2020
Sep 30 2020
majcosta committed rABCc6b38e8b94bb: [backport#17237 1/2] wallet: Lock address type in ReserveDestination (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
[backport#17237 1/2] wallet: Lock address type in ReserveDestination
teamcity added a comment to D7694: [backport#17518] refactor, wallet: Nuke coincontrol circular dependency.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
teamcity updated the summary of D7694: [backport#17518] refactor, wallet: Nuke coincontrol circular dependency.
majcosta requested review of D7694: [backport#17518] refactor, wallet: Nuke coincontrol circular dependency.
teamcity added a comment to D7689: [backport#17237 1/2] wallet: Lock address type in ReserveDestination.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
majcosta updated the diff for D7690: [backport#17237 2/2] wallet: LearnRelatedScripts only if KeepDestination.
forgot to rebase, my bad
majcosta committed rABC903e524b88fd: [backport#17553] wallet: Remove out of date comments for… (authored by Samuel Dobson <dobsonsa68@gmail.com>).
[backport#17553] wallet: Remove out of date comments for…
teamcity added a comment to D7693: [backport#17648] doc: rename wallet-tool references to bitcoin-wallet.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
teamcity updated the summary of D7693: [backport#17648] doc: rename wallet-tool references to bitcoin-wallet.
majcosta requested review of D7693: [backport#17648] doc: rename wallet-tool references to bitcoin-wallet.
deadalnix requested changes to D7690: [backport#17237 2/2] wallet: LearnRelatedScripts only if KeepDestination.
This is apparently busted.
teamcity added a comment to D7692: [backport#17553] wallet: Remove out of date comments for CalculateMaximumSignedTxSize.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
teamcity updated the summary of D7692: [backport#17553] wallet: Remove out of date comments for CalculateMaximumSignedTxSize.
majcosta updated the diff for D7689: [backport#17237 1/2] wallet: Lock address type in ReserveDestination.
renamed a couple constructor parameters to avoid shadowing warning from gcc
jasonbcox committed rABC78322dfdfa3c: Merge #17568: wallet: fix when sufficient preset inputs and… (authored by fanquake <fanquake@gmail.com>).
Merge #17568: wallet: fix when sufficient preset inputs and…
jasonbcox committed rABCd54de8344d7a: Merge #16293: test: Make test cases separate functions (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #16293: test: Make test cases separate functions
teamcity added a comment to D7690: [backport#17237 2/2] wallet: LearnRelatedScripts only if KeepDestination.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
jasonbcox requested changes to D7689: [backport#17237 1/2] wallet: Lock address type in ReserveDestination.
See build failure
teamcity added a comment to D7689: [backport#17237 1/2] wallet: Lock address type in ReserveDestination.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
teamcity added a comment to D7691: Merge #17568: wallet: fix when sufficient preset inputs and subtractFeeFromOutputs.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
teamcity updated the summary of D7691: Merge #17568: wallet: fix when sufficient preset inputs and subtractFeeFromOutputs.
majcosta committed rABC149452d5eee5: [backport#17371 2/2] Refactor: Require scriptPubKey to get wallet… (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#17371 2/2] Refactor: Require scriptPubKey to get wallet…
majcosta committed rABC7fd581bc771c: [backport#17371 1/2] Accumulate result UniValue in SignTransaction (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#17371 1/2] Accumulate result UniValue in SignTransaction
jasonbcox updated the diff for D7688: Merge #16293: test: Make test cases separate functions.
Fixed according to feedback
teamcity added a comment to D7690: [backport#17237 2/2] wallet: LearnRelatedScripts only if KeepDestination.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
teamcity updated the summary of D7690: [backport#17237 2/2] wallet: LearnRelatedScripts only if KeepDestination.
majcosta requested review of D7690: [backport#17237 2/2] wallet: LearnRelatedScripts only if KeepDestination.
teamcity added a comment to D7689: [backport#17237 1/2] wallet: Lock address type in ReserveDestination.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
teamcity updated the summary of D7689: [backport#17237 1/2] wallet: Lock address type in ReserveDestination.
majcosta requested review of D7689: [backport#17237 1/2] wallet: Lock address type in ReserveDestination.
majcosta committed rABCa93566bb87fb: [backport#17444] wallet: Avoid showing GUI popups on RPC errors (take 2) (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#17444] wallet: Avoid showing GUI popups on RPC errors (take 2)
teamcity added a comment to D7686: [backport#17371 1/2] Accumulate result UniValue in SignTransaction.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
majcosta requested changes to D7688: Merge #16293: test: Make test cases separate functions.
Please clean up those hashes from the summary. Sometimes they collide with PR numbers when grepping and it's annoying.
jasonbcox updated the summary of D7688: Merge #16293: test: Make test cases separate functions.