Page MenuHomePhabricator
Feed All Stories

Fri, Oct 16

PiRK committed rABCb49197b499e3: [gui] intro: inform caller if intro was shown (authored by Sjors Provoost <sjors@sprovoost.nl>).
[gui] intro: inform caller if intro was shown
Fri, Oct 16, 15:18
teamcity updated the summary of D7957: bitcoin-wallet: Add a missing closing parenthesis in the help.
Fri, Oct 16, 15:04
PiRK requested review of D7957: bitcoin-wallet: Add a missing closing parenthesis in the help.
Fri, Oct 16, 15:04
PiRK closed D7953: [gui] add explicit prune setter.
Fri, Oct 16, 14:55
PiRK committed rABCfc149ad0c4a4: [gui] add explicit prune setter (authored by Sjors Provoost <sjors@sprovoost.nl>).
[gui] add explicit prune setter
Fri, Oct 16, 14:55
PiRK closed D7952: [node] add forceSetArg to interface.
Fri, Oct 16, 14:53
PiRK committed rABC508e069b7887: [node] add forceSetArg to interface (authored by Sjors Provoost <sjors@sprovoost.nl>).
[node] add forceSetArg to interface
Fri, Oct 16, 14:53
deadalnix accepted D7956: [gui] intro: enable pruning by default unless disk is big.
Fri, Oct 16, 14:29
deadalnix accepted D7955: [gui] intro: add prune preference.
Fri, Oct 16, 14:28
deadalnix accepted D7954: [gui] intro: inform caller if intro was shown.
Fri, Oct 16, 14:27
PiRK closed D7949: tests: add a test for the 'servicesnames' RPC field.
Fri, Oct 16, 14:27
PiRK committed rABCb32a7d9aef00: tests: add a test for the 'servicesnames' RPC field (authored by darosior <darosior@protonmail.com>).
tests: add a test for the 'servicesnames' RPC field
Fri, Oct 16, 14:27
PiRK closed D7948: rpc/net: decode the services flags in a new entry.
Fri, Oct 16, 14:26
PiRK committed rABCe5b0e658a2f3: rpc/net: decode the services flags in a new entry (authored by darosior <darosior@gmail.com>).
rpc/net: decode the services flags in a new entry
Fri, Oct 16, 14:26
deadalnix accepted D7953: [gui] add explicit prune setter.
Fri, Oct 16, 14:25
deadalnix accepted D7952: [node] add forceSetArg to interface.
Fri, Oct 16, 14:24
PiRK updated the summary of D7956: [gui] intro: enable pruning by default unless disk is big.
Fri, Oct 16, 14:23
teamcity updated the summary of D7956: [gui] intro: enable pruning by default unless disk is big.
Fri, Oct 16, 14:22
PiRK requested review of D7956: [gui] intro: enable pruning by default unless disk is big.
Fri, Oct 16, 14:21
PiRK updated the summary of D7955: [gui] intro: add prune preference.
Fri, Oct 16, 14:12
teamcity updated the summary of D7955: [gui] intro: add prune preference.
Fri, Oct 16, 14:11
PiRK requested review of D7955: [gui] intro: add prune preference.
Fri, Oct 16, 14:11
PiRK updated the summary of D7954: [gui] intro: inform caller if intro was shown.
Fri, Oct 16, 14:05
teamcity updated the summary of D7954: [gui] intro: inform caller if intro was shown.
Fri, Oct 16, 13:59
PiRK requested review of D7954: [gui] intro: inform caller if intro was shown.
Fri, Oct 16, 13:59
Fabien planned changes to D7951: [CI] Add a configuration for running on native OSX agents.
Fri, Oct 16, 13:57
Fabien updated the diff for D7951: [CI] Add a configuration for running on native OSX agents.

Fix templates being an array

Fri, Oct 16, 13:57
PiRK updated the summary of D7953: [gui] add explicit prune setter.
Fri, Oct 16, 13:56
PiRK updated the summary of D7953: [gui] add explicit prune setter.
Fri, Oct 16, 13:53
teamcity updated the summary of D7953: [gui] add explicit prune setter.
Fri, Oct 16, 13:53
PiRK requested review of D7953: [gui] add explicit prune setter.
Fri, Oct 16, 13:52
teamcity updated the summary of D7952: [node] add forceSetArg to interface.
Fri, Oct 16, 13:50
PiRK requested review of D7952: [node] add forceSetArg to interface.
Fri, Oct 16, 13:50
Fabien planned changes to D7951: [CI] Add a configuration for running on native OSX agents.
Fri, Oct 16, 13:43
Fabien requested review of D7951: [CI] Add a configuration for running on native OSX agents.
Fri, Oct 16, 13:43
PiRK abandoned D7950: add forceSetArg and pruner setter to node interface.

Please don't smash together things that are unrelated It makes review harder and only has downsides (harder to revert, one change may block the other for no reason, etc...)

Fri, Oct 16, 13:32
Fabien closed D7943: Fix a potential use after move.
Fri, Oct 16, 13:24
Fabien committed rABC59239db2aa64: Fix a potential use after move (authored by Fabien).
Fix a potential use after move
Fri, Oct 16, 13:24
Fabien closed D7947: Fix missing lock in the chain interface.
Fri, Oct 16, 13:23
Fabien committed rABCa1d59f5a1455: Fix missing lock in the chain interface (authored by Fabien).
Fix missing lock in the chain interface
Fri, Oct 16, 13:23
deadalnix requested changes to D7950: add forceSetArg and pruner setter to node interface.

Please don't smash together things that are unrelated It makes review harder and only has downsides (harder to revert, one change may block the other for no reason, etc...)

Fri, Oct 16, 13:22
deadalnix accepted D7947: Fix missing lock in the chain interface.

Good catch.

Fri, Oct 16, 13:20
teamcity updated the summary of D7950: add forceSetArg and pruner setter to node interface.
Fri, Oct 16, 13:17
PiRK requested review of D7950: add forceSetArg and pruner setter to node interface.
Fri, Oct 16, 13:16
deadalnix accepted D7943: Fix a potential use after move.
Fri, Oct 16, 13:15
Fabien accepted D7949: tests: add a test for the 'servicesnames' RPC field.
Fri, Oct 16, 12:38
Fabien accepted D7948: rpc/net: decode the services flags in a new entry.
Fri, Oct 16, 12:37
PiRK updated the summary of D7949: tests: add a test for the 'servicesnames' RPC field.
Fri, Oct 16, 09:29
PiRK requested review of D7949: tests: add a test for the 'servicesnames' RPC field.
Fri, Oct 16, 09:28
PiRK updated the diff for D7948: rpc/net: decode the services flags in a new entry.

improve release notes by specifying the name of the new field

Fri, Oct 16, 09:05
teamcity updated the summary of D7948: rpc/net: decode the services flags in a new entry.
Fri, Oct 16, 09:02
PiRK requested review of D7948: rpc/net: decode the services flags in a new entry.
Fri, Oct 16, 09:02
PiRK closed D7946: fix gen-manpages.sh to take into account shorter `bitcoind --version` line.
Fri, Oct 16, 08:09
PiRK committed rABC6398509bca66: fix gen-manpages.sh to take into account shorter `bitcoind --version` line (authored by PiRK).
fix gen-manpages.sh to take into account shorter `bitcoind --version` line
Fri, Oct 16, 08:09
PiRK closed D7933: log: harmonize bitcoind server logging.
Fri, Oct 16, 07:58
PiRK committed rABC3d50b09d9012: log: harmonize bitcoind server logging (authored by Jon Atack <jon@atack.com>).
log: harmonize bitcoind server logging
Fri, Oct 16, 07:58
Fabien accepted D7946: fix gen-manpages.sh to take into account shorter `bitcoind --version` line.
Fri, Oct 16, 07:48
PiRK closed D7930: GUI: Remove unused menu items for Windows and Linux.
Fri, Oct 16, 07:47
PiRK committed rABC5eef6d1194ec: GUI: Remove unused menu items for Windows and Linux (authored by GChuf <gasper.cefarin@gmail.com>).
GUI: Remove unused menu items for Windows and Linux
Fri, Oct 16, 07:47
Fabien added a comment to D7947: Fix missing lock in the chain interface.

@bot build-ubsan build-tsan

Fri, Oct 16, 07:46
Fabien requested review of D7947: Fix missing lock in the chain interface.
Fri, Oct 16, 07:45
PiRK updated the summary of D7946: fix gen-manpages.sh to take into account shorter `bitcoind --version` line.
Fri, Oct 16, 07:37
PiRK requested review of D7946: fix gen-manpages.sh to take into account shorter `bitcoind --version` line.
Fri, Oct 16, 07:36
PiRK closed D7932: Don't show addresses of P2PK in decoderawtransaction.
Fri, Oct 16, 07:10
PiRK committed rABCea7128a744c3: Don't show addresses of P2PK in decoderawtransaction (authored by nicolas.dorier <nicolas.dorier@gmail.com>).
Don't show addresses of P2PK in decoderawtransaction
Fri, Oct 16, 07:10
Fabien updated the diff for D7943: Fix a potential use after move.

Simplify comments and explain the intent rather than the code itself

Fri, Oct 16, 06:17
majcosta closed D7944: [backport#19202] log: remove deprecated `db` log category.
Fri, Oct 16, 01:05
majcosta committed rABCf7a31614ba34: [backport#19202] log: remove deprecated `db` log category (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#19202] log: remove deprecated `db` log category
Fri, Oct 16, 01:05
deadalnix accepted D7944: [backport#19202] log: remove deprecated `db` log category.
Fri, Oct 16, 01:00
deadalnix closed D7945: UTXO snapshot creation (dumptxoutset).
Fri, Oct 16, 00:59
deadalnix committed rABCa2fd700b8464: UTXO snapshot creation (dumptxoutset) (authored by James O'Beirne <james.obeirne@gmail.com>).
UTXO snapshot creation (dumptxoutset)
Fri, Oct 16, 00:59
jasonbcox accepted D7945: UTXO snapshot creation (dumptxoutset).
Fri, Oct 16, 00:56
teamcity updated the summary of D7945: UTXO snapshot creation (dumptxoutset).
Fri, Oct 16, 00:39
deadalnix requested review of D7945: UTXO snapshot creation (dumptxoutset).
Fri, Oct 16, 00:39
teamcity updated the summary of D7944: [backport#19202] log: remove deprecated `db` log category.
Fri, Oct 16, 00:29
majcosta requested review of D7944: [backport#19202] log: remove deprecated `db` log category.
Fri, Oct 16, 00:29

Thu, Oct 15

majcosta closed D7582: [backport#16443 3/3] Cover UTXO set access with lock annotations.
Thu, Oct 15, 23:58
majcosta committed rABC124054fe2dc7: [backport#16443 3/3] Cover UTXO set access with lock annotations (authored by James O'Beirne <james.obeirne@gmail.com>).
[backport#16443 3/3] Cover UTXO set access with lock annotations
Thu, Oct 15, 23:58
majcosta closed D7581: [backport#16443 2/3] refactor: have CCoins* data managed under CChainState.
Thu, Oct 15, 23:58
majcosta committed rABC74ade9cfe69c: [backport#16443 2/3] refactor: have CCoins* data managed under CChainState (authored by James O'Beirne <james.obeirne@gmail.com>).
[backport#16443 2/3] refactor: have CCoins* data managed under CChainState
Thu, Oct 15, 23:58
majcosta closed D7580: [backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip().
Thu, Oct 15, 23:57
majcosta committed rABC76953e642b2b: [backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip() (authored by James O'Beirne <james.obeirne@gmail.com>).
[backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip()
Thu, Oct 15, 23:57
majcosta closed D7579: [refactor] move ReadBlockFromDisk+ from validation.cpp.
Thu, Oct 15, 23:44
majcosta committed rABC05e860392659: [refactor] move ReadBlockFromDisk+ from validation.cpp (authored by majcosta).
[refactor] move ReadBlockFromDisk+ from validation.cpp
Thu, Oct 15, 23:44
deadalnix accepted D7579: [refactor] move ReadBlockFromDisk+ from validation.cpp.
Thu, Oct 15, 23:26
teamcity triaged T1115: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Unbreak Now! priority.
Thu, Oct 15, 23:11
majcosta updated the diff for D7579: [refactor] move ReadBlockFromDisk+ from validation.cpp.

oops, missing guys added

Thu, Oct 15, 23:10
deadalnix requested changes to D7579: [refactor] move ReadBlockFromDisk+ from validation.cpp.
Thu, Oct 15, 22:58
majcosta updated the diff for D7579: [refactor] move ReadBlockFromDisk+ from validation.cpp.

addressed comments

Thu, Oct 15, 22:43
majcosta updated the diff for D7581: [backport#16443 2/3] refactor: have CCoins* data managed under CChainState.

rebase

Thu, Oct 15, 22:29
deadalnix requested changes to D7579: [refactor] move ReadBlockFromDisk+ from validation.cpp.
Thu, Oct 15, 22:29
majcosta updated the diff for D7579: [refactor] move ReadBlockFromDisk+ from validation.cpp.

renamed new TU

Thu, Oct 15, 22:22
deadalnix requested changes to D7943: Fix a potential use after move.
Thu, Oct 15, 22:22
Fabien updated the diff for D7943: Fix a potential use after move.

Attempt to explain the flow

Thu, Oct 15, 22:16
deadalnix closed D7938: [wallet] Remove locked_chain from CWallet, its RPCs and tests.
Thu, Oct 15, 22:14
deadalnix committed rABC1cb2090b019b: [wallet] Remove locked_chain from CWallet, its RPCs and tests (authored by Antoine Riard <ariard@student.42.fr>).
[wallet] Remove locked_chain from CWallet, its RPCs and tests
Thu, Oct 15, 22:14
majcosta accepted D7938: [wallet] Remove locked_chain from CWallet, its RPCs and tests.
Thu, Oct 15, 22:01
deadalnix closed D7937: [wallet] Move methods from Chain::Lock interface to simple Chain.
Thu, Oct 15, 22:00
deadalnix committed rABC731b33f5dec6: [wallet] Move methods from Chain::Lock interface to simple Chain (authored by Antoine Riard <ariard@student.42.fr>).
[wallet] Move methods from Chain::Lock interface to simple Chain
Thu, Oct 15, 22:00
deadalnix accepted D7932: Don't show addresses of P2PK in decoderawtransaction.
Thu, Oct 15, 21:55