- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jun 8 2021
Jun 7 2021
Use the right clock for the job
Why not have two flags that can be set, -uaclientname, and -uaclientversion ?
Changed FormatSubVersion to FormatUserAgent and solely use FormatSubVersionUserAgent now
I don't know what caused the failure, I couldn't reproduce in a 100 loop on a similar debian, nor did it reproduce on CI.
Added the rational in the diff summary
Why?
Investigating the build failure
rebase (unrelated failure)
rebase to fix clang failure
fix clang warning
Can you expand a bit of what the problem is from setting the flag globally ? Without more details it's hard to see how having the option repeated in and here in every test is better than setting it once for all.
Also if it increases the test coverage then the tests are wrong, because these tests are not testing the -ecash flag.
Jun 6 2021
Changed to -uaclient, which sets the client name and version of the user agent, staying compatible with -uacomment
couldn't reproduce this failure. rebasing on latest master.
bummer. alright, how about D9638, then?
rebase on master
This honestly seems like a step backward. The thing throws JSONRPC errors, so that most certainly belong in the RPC stack.
rebase
that flakiness in script_tests.cpp is unrelated, restarting build
fixed feature_notifications.py without wallet
Depends on D9635
Jun 5 2021
Jun 4 2021
Abandoning in favor of D9634
Please consider D9634 for an alternative solution
Hopefully this won't be needed anymore