Page MenuHomePhabricator
Feed All Stories

Sep 13 2021

PiRK requested review of D10096: wallet: IsMine overloads require cs_wallet lock.
Sep 13 2021, 14:35
teamcity updated the summary of D10095: wallet: GetWalletTx requires cs_wallet lock.
Sep 13 2021, 14:33
PiRK requested review of D10095: wallet: GetWalletTx requires cs_wallet lock.
Sep 13 2021, 14:33
teamcity closed T1843: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Sep 13 2021, 14:24
teamcity updated the summary of D10094: -maxapsfee: follow-up fixes.
Sep 13 2021, 14:23
PiRK requested review of D10094: -maxapsfee: follow-up fixes.
Sep 13 2021, 14:22
Joey King <joseph.roy.king@gmail.com> closed D10093: [Cashtab] Ignore tx history for large-input txs.
Sep 13 2021, 14:05
Joey King <joseph.roy.king@gmail.com> committed rABC0c069e0070f3: [Cashtab] Ignore tx history for large-input txs (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Ignore tx history for large-input txs
Sep 13 2021, 14:05
Fabien accepted D10093: [Cashtab] Ignore tx history for large-input txs.
Sep 13 2021, 14:04
bytesofman updated the diff for D10093: [Cashtab] Ignore tx history for large-input txs.

Instead of removing txs, replace with empty box that links to explorer

Sep 13 2021, 13:59
bytesofman updated the diff for D10093: [Cashtab] Ignore tx history for large-input txs.

Removing line break irrelevant to this diff

Sep 13 2021, 13:11
bytesofman requested review of D10093: [Cashtab] Ignore tx history for large-input txs.
Sep 13 2021, 13:10
Fabien requested review of D10092: [avalanche] Pass a CKey to the proof builder.
Sep 13 2021, 12:59
PiRK requested review of D10091: rpc generate: print useful help and error message.
Sep 13 2021, 08:15
teamcity awarded D10090: Fix a compiler warning: unused GetDevURandom() a Haypence token.
Sep 13 2021, 08:06
PiRK added a comment to D10090: Fix a compiler warning: unused GetDevURandom().

@bot build-osx

Sep 13 2021, 08:05
teamcity updated the summary of D10090: Fix a compiler warning: unused GetDevURandom().
Sep 13 2021, 08:05
PiRK requested review of D10090: Fix a compiler warning: unused GetDevURandom().
Sep 13 2021, 08:05
LastmansBadBoy updated LastmansBadBoy.
Sep 13 2021, 06:42

Sep 11 2021

elizabeth10 updated elizabeth10.
Sep 11 2021, 07:10

Sep 10 2021

PiRK closed D10074: rpc: document returned error fields as optional if applicable.
Sep 10 2021, 16:41
PiRK committed rABC1241ef50e90d: rpc: document returned error fields as optional if applicable (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
rpc: document returned error fields as optional if applicable
Sep 10 2021, 16:40
majcosta accepted D10075: remove argName nBlocks from estimatefee RPC command registration.
Sep 10 2021, 15:38
majcosta accepted D10074: rpc: document returned error fields as optional if applicable.
Sep 10 2021, 15:37
teamcity triaged T1843: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Sep 10 2021, 10:40
PiRK closed D10089: Refactor OutputGroups to handle effective values, fees, and filtering.
Sep 10 2021, 10:12
PiRK committed rABCa0c263af35ee: Refactor OutputGroups to handle effective values, fees, and filtering (authored by Andrew Chow <achow101-github@achow101.com>).
Refactor OutputGroups to handle effective values, fees, and filtering
Sep 10 2021, 10:12
PiRK closed D10088: Use real value when calculating OutputGroup value.
Sep 10 2021, 10:11
PiRK committed rABC01e27ccd5146: Use real value when calculating OutputGroup value (authored by Andrew Chow <achow101-github@achow101.com>).
Use real value when calculating OutputGroup value
Sep 10 2021, 10:11
PiRK closed D10085: wallet: Don't override signing errors.
Sep 10 2021, 10:10
PiRK committed rABCf58d3ab83703: wallet: Don't override signing errors (authored by Fabian Jahr <fjahr@protonmail.com>).
wallet: Don't override signing errors
Sep 10 2021, 10:10
oddway updated oddway.
Sep 10 2021, 09:49
PiRK closed D10083: rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc).
Sep 10 2021, 08:26
PiRK committed rABC09c0f3c5929d: rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc) (authored by PiRK).
rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc)
Sep 10 2021, 08:26
teamcity closed T1842: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Sep 10 2021, 08:26
PiRK closed D10082: rpc: Limit echo to 10 args.
Sep 10 2021, 08:21
PiRK committed rABC378a70f4ead6: rpc: Limit echo to 10 args (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Limit echo to 10 args
Sep 10 2021, 08:21
PiRK closed D10081: refactor: Use C++11 range based for loops to simplify rpc code.
Sep 10 2021, 08:17
PiRK committed rABC16268cd74789: refactor: Use C++11 range based for loops to simplify rpc code (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Use C++11 range based for loops to simplify rpc code
Sep 10 2021, 08:17
PiRK closed D10080: rpc: Treat all args after a hidden arg as hidden as well.
Sep 10 2021, 08:14
PiRK committed rABCb46e1c9d15d1: rpc: Treat all args after a hidden arg as hidden as well (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Treat all args after a hidden arg as hidden as well
Sep 10 2021, 08:14
teamcity triaged T1842: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Sep 10 2021, 07:21
PiRK closed D10010: rpc: Update server to use new RPCHelpMan.
Sep 10 2021, 07:01
PiRK committed rABCc6a3bec649b9: rpc: Update server to use new RPCHelpMan (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Update server to use new RPCHelpMan
Sep 10 2021, 07:01
PiRK closed D10009: rpc: Add option to hide RPCArg.
Sep 10 2021, 07:00
PiRK committed rABC924c5621d6cc: rpc: Add option to hide RPCArg (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Add option to hide RPCArg
Sep 10 2021, 07:00
PiRK closed D10008: rpc: Assert that passed arg names are equal to hardcoded ones.
Sep 10 2021, 06:59
PiRK committed rABCf726df976df3: rpc: Assert that passed arg names are equal to hardcoded ones (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Assert that passed arg names are equal to hardcoded ones
Sep 10 2021, 06:59
PiRK closed D10007: rpc: Add CRPCCommand constructor which takes RPCHelpMan.
Sep 10 2021, 06:58
PiRK committed rABCb568655c01cc: rpc: Add CRPCCommand constructor which takes RPCHelpMan (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Add CRPCCommand constructor which takes RPCHelpMan
Sep 10 2021, 06:58
teamcity closed T1839: Build Bitcoin-ABC / Nightly Builds / Health Checks / Check Seeds is broken. as Resolved.
Sep 10 2021, 03:03

Sep 9 2021

majcosta accepted D10089: Refactor OutputGroups to handle effective values, fees, and filtering.
Sep 9 2021, 18:26
majcosta accepted D10088: Use real value when calculating OutputGroup value.
Sep 9 2021, 18:21
majcosta accepted D10085: wallet: Don't override signing errors.
Sep 9 2021, 18:20
majcosta accepted D10010: rpc: Update server to use new RPCHelpMan.
Sep 9 2021, 18:13
Fabien closed D10084: [avalanche] Add some test coverage for the buildavalancheproof RPC.
Sep 9 2021, 18:00
Fabien committed rABC25e6fd9b6a17: [avalanche] Add some test coverage for the buildavalancheproof RPC (authored by Fabien).
[avalanche] Add some test coverage for the buildavalancheproof RPC
Sep 9 2021, 18:00
Fabien closed D10078: [avalanche] Remove dead test code in the proof builder.
Sep 9 2021, 17:49
Fabien committed rABC151f44cb99f3: [avalanche] Remove dead test code in the proof builder (authored by Fabien).
[avalanche] Remove dead test code in the proof builder
Sep 9 2021, 17:48
PiRK planned changes to D10087: wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code.

Needs more investigation to make sure it fits with our codebase

Sep 9 2021, 16:36
Fabien accepted D10083: rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc).
Sep 9 2021, 16:05
Fabien accepted D10080: rpc: Treat all args after a hidden arg as hidden as well.
Sep 9 2021, 15:57
Fabien accepted D10010: rpc: Update server to use new RPCHelpMan.
Sep 9 2021, 15:57
PiRK accepted D10086: [avalanche] Add an error message for duplicated stakes in buildavalancheproof.
Sep 9 2021, 15:34
PiRK accepted D10084: [avalanche] Add some test coverage for the buildavalancheproof RPC.
Sep 9 2021, 15:32
PiRK accepted D10079: [avalanche] Consistently check ProofBuilder::addUTXO return value.
Sep 9 2021, 13:59
PiRK requested review of D10010: rpc: Update server to use new RPCHelpMan.

I fixed the dependency in the description

Sep 9 2021, 13:53
PiRK closed D10061: Add TX_INPUTS_NOT_STANDARD to TxValidationResult.
Sep 9 2021, 13:53
PiRK updated the summary of D10010: rpc: Update server to use new RPCHelpMan.
Sep 9 2021, 13:53
PiRK committed rABC74b9af263eda: Add TX_INPUTS_NOT_STANDARD to TxValidationResult (authored by Suhas Daftuar <sdaftuar@gmail.com>).
Add TX_INPUTS_NOT_STANDARD to TxValidationResult
Sep 9 2021, 13:53
Fabien accepted D10082: rpc: Limit echo to 10 args.
Sep 9 2021, 13:50
Fabien accepted D10081: refactor: Use C++11 range based for loops to simplify rpc code.
Sep 9 2021, 13:48
Fabien requested changes to D10010: rpc: Update server to use new RPCHelpMan.

This diff depends on itself.

Sep 9 2021, 13:46
teamcity updated the summary of D10089: Refactor OutputGroups to handle effective values, fees, and filtering.
Sep 9 2021, 13:46
PiRK requested review of D10089: Refactor OutputGroups to handle effective values, fees, and filtering.
Sep 9 2021, 13:44
teamcity updated the summary of D10088: Use real value when calculating OutputGroup value.
Sep 9 2021, 13:43
PiRK requested review of D10088: Use real value when calculating OutputGroup value.
Sep 9 2021, 13:43
Fabien accepted D10061: Add TX_INPUTS_NOT_STANDARD to TxValidationResult.
Sep 9 2021, 13:25
teamcity updated the summary of D10087: wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code.
Sep 9 2021, 13:17
PiRK requested review of D10087: wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code.
Sep 9 2021, 13:17
Fabien requested review of D10086: [avalanche] Add an error message for duplicated stakes in buildavalancheproof.
Sep 9 2021, 12:55
teamcity updated the summary of D10085: wallet: Don't override signing errors.
Sep 9 2021, 12:54
PiRK requested review of D10085: wallet: Don't override signing errors.
Sep 9 2021, 12:54
Fabien requested review of D10084: [avalanche] Add some test coverage for the buildavalancheproof RPC.
Sep 9 2021, 12:47
PiRK accepted D10078: [avalanche] Remove dead test code in the proof builder.
Sep 9 2021, 12:10
PiRK updated the summary of D10080: rpc: Treat all args after a hidden arg as hidden as well.
Sep 9 2021, 12:08
teamcity updated the summary of D10083: rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc).
Sep 9 2021, 12:07
PiRK requested review of D10083: rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc).
Sep 9 2021, 12:07
teamcity updated the summary of D10082: rpc: Limit echo to 10 args.
Sep 9 2021, 12:04
PiRK requested review of D10082: rpc: Limit echo to 10 args.
Sep 9 2021, 12:03
teamcity updated the summary of D10081: refactor: Use C++11 range based for loops to simplify rpc code.
Sep 9 2021, 12:02
PiRK requested review of D10081: refactor: Use C++11 range based for loops to simplify rpc code.
Sep 9 2021, 12:02
teamcity updated the summary of D10080: rpc: Treat all args after a hidden arg as hidden as well.
Sep 9 2021, 12:01
PiRK requested review of D10080: rpc: Treat all args after a hidden arg as hidden as well.
Sep 9 2021, 12:01
PiRK accepted D10077: [avalanche] Use an ordered container for stakes in the proof builder.
Sep 9 2021, 11:55
Fabien requested review of D10079: [avalanche] Consistently check ProofBuilder::addUTXO return value.
Sep 9 2021, 11:52
Fabien requested review of D10078: [avalanche] Remove dead test code in the proof builder.
Sep 9 2021, 11:42
PiRK accepted D10076: [avalanche] Sort the stakes inside a proof.

Sounds like a good plan. With a sorted container the state of the proof builder will be guaranteed to always be consistent.

Sep 9 2021, 11:40
Fabien updated the diff for D10077: [avalanche] Use an ordered container for stakes in the proof builder.

Fix bad rebase and remove commented code line.

Sep 9 2021, 11:33
teamcity added a comment to D10077: [avalanche] Use an ordered container for stakes in the proof builder.
Sep 9 2021, 11:25