If you want my opinion I would have simply set -x from the very beginning of the script (set -euxo pipefail) and only disable it around the sleep loop.
This script is intended to be run by the CI server, so every trace can be useful in case there is a bug in the script, and the detected parameters are no exception. This has a different purpose than an echo statement which is more of a UI for the script.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Sep 11 2019
Sep 11 2019
Fabien requested changes to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.
deadalnix requested changes to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Sep 10 2019
Sep 10 2019
nakihito requested review of D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.
Build Bitcoin-ABC / Diffs / Diff Testing started.
jasonbcox updated the diff for D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.
Rebased + fixed up verbose logging (set -x) on the new script.
jasonbcox committed rABCa858653e5efc: Merge #12853: qa: Match full plain text by default (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12853: qa: Match full plain text by default
nakihito added inline comments to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
release-process.md needs updating
jasonbcox requested changes to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Build Bitcoin-ABC / Diffs / Diff Testing started.
nakihito updated the summary of D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Build Bitcoin-ABC / Diffs / Diff Testing started.
nakihito updated the diff for D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Rebased off D4029 and added comment changes.
teamcity added a comment to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Added a script to test seeds
Added some release notes
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien committed rABC89c6acf0d2f4: [CI] Improve error catching and build log verbosity (authored by Fabien).
[CI] Improve error catching and build log verbosity
Fabien requested changes to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Any reason for not porting the comments changes ?
nakihito added a comment to D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
Will rebase off D4026 soon.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
- Removed --tag-commit as it's not necessary
- Minor improvements
- Lots of linting
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
nakihito updated the summary of D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Sep 9 2019
Sep 9 2019
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Added a note regarding various removals of deprecated features.
jasonbcox requested changes to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Clearing this off my queue. See Amaury's comment about CTOR.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fixes according to feedback
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Changed tests to call CreateNewBlock() with default params in as many places as possible. Improve existing tests so that a fallback empty block will not accidentally pass.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
nakihito requested review of D3750: Merge #12159: Use the character based overload for std::string::find..
Nico Guiton <nico@bitframe.org> committed rABC28c6e32e5d03: Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Nico Guiton <nico@bitframe.org> committed rABC4dc32c990aa6: Merge #12928: qt: Initialize non-static class members that were previously… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12928: qt: Initialize non-static class members that were previously…
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fixed import order
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.
Build Bitcoin-ABC / Diffs / Diff Testing started.
jasonbcox updated the diff for D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.
Fixes according to feedback.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
- Fixed braces everywhere.
- Rebased
- Also fixed up the bash location and added copyright.
- Fixed some lint errors.
jasonbcox committed rABCcb319c1dcdf4: Merge #13747: tests: Skip P2PConnection's is_closing() check when not available (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13747: tests: Skip P2PConnection's is_closing() check when not available
teamcity added a comment to D4019: Merge #13747: tests: Skip P2PConnection's is_closing() check when not available.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4019: Merge #13747: tests: Skip P2PConnection's is_closing() check when not available.
Build Bitcoin-ABC / Diffs / Diff Testing started.
jasonbcox updated the diff for D4019: Merge #13747: tests: Skip P2PConnection's is_closing() check when not available.
Rebase + nit
jasonbcox closed T684: Backport Core PR13916, a subtask of T685: Backport Core PR13399, as Resolved.
jasonbcox committed rABCbb86d8de9a17: Merge #13916: qa: wait_for_verack by default (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13916: qa: wait_for_verack by default