Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

May 27 2020

teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 27 2020, 17:01
majcosta requested review of D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".
May 27 2020, 17:00
majcosta added a reverting change for D6256: [backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency: D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".
May 27 2020, 17:00
majcosta added a reverting change for rABCa7a55fb3ac4f: [backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency: D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".
May 27 2020, 17:00
deadalnix committed rABC8a33d815de4c: [wallet] Move maxTxFee to wallet (authored by John Newbery <john@johnnewbery.com>).
[wallet] Move maxTxFee to wallet
May 27 2020, 16:23
deadalnix closed D6267: [wallet] Move maxTxFee to wallet.
May 27 2020, 16:23
jasonbcox requested changes to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.
May 27 2020, 16:21
deadalnix committed rABC6c784a612512: rpc: Uncouple non-wallet rpcs from maxTxFee global (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Uncouple non-wallet rpcs from maxTxFee global
May 27 2020, 16:16
deadalnix closed D6266: rpc: Uncouple non-wallet rpcs from maxTxFee global.
May 27 2020, 16:16
jasonbcox accepted D6267: [wallet] Move maxTxFee to wallet.
May 27 2020, 16:14
jasonbcox accepted D6266: rpc: Uncouple non-wallet rpcs from maxTxFee global.
May 27 2020, 16:01
teamcity added a comment to D6258: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 27 2020, 15:07
majcosta committed rABC7f8a7a1b1601: [backport#15842] refactor: replace isPotentialtip/waitForNotifications by… (authored by Antoine Riard <ariard@student.42.fr>).
[backport#15842] refactor: replace isPotentialtip/waitForNotifications by…
May 27 2020, 15:04
majcosta closed D6260: [backport#15842] refactor: replace isPotentialtip/waitForNotifications by higher method.
May 27 2020, 15:04
teamcity added a comment to D6258: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 27 2020, 15:00
majcosta committed rABC6a41e8229ce3: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction (authored by Antoine Riard <ariard@student.42.fr>).
[backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction
May 27 2020, 14:58
majcosta closed D6258: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction.
May 27 2020, 14:58
teamcity added a comment to D6258: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 27 2020, 14:57
deadalnix accepted D6258: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction.
May 27 2020, 14:56
teamcity added a comment to D6258: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 27 2020, 14:55
teamcity added a comment to D6258: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 27 2020, 14:55
teamcity added a comment to D6258: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 27 2020, 14:55
majcosta updated the diff for D6258: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction.

fixed comment

May 27 2020, 14:53
majcosta committed rABC6f4857cdbc11: [backport#15670] refactor: combine Chain… (authored by Antoine Riard <ariard@student.42.fr>).
[backport#15670] refactor: combine Chain…
May 27 2020, 14:49
majcosta closed D6257: [backport#15670] refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight.
May 27 2020, 14:49
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 27 2020, 14:46
teamcity closed T905: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
May 27 2020, 14:42
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 27 2020, 14:38
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 27 2020, 14:35
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 27 2020, 14:34
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 27 2020, 14:33
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 27 2020, 14:32
deadalnix updated the diff for D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Fixup fee rate in PSBT test because we account for signatures fully, while core uses segwit that account witness at 1/4th .

May 27 2020, 14:27
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
May 27 2020, 14:27
teamcity assigned T907: Build Bitcoin-ABC / Master / Bitcoin-ABC Master Autotools is broken. to majcosta.
May 27 2020, 14:25
teamcity triaged T907: Build Bitcoin-ABC / Master / Bitcoin-ABC Master Autotools is broken. as Unbreak Now! priority.
May 27 2020, 14:25
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
May 27 2020, 14:21
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 27 2020, 14:20
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 27 2020, 14:18
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 27 2020, 14:18
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 27 2020, 14:18
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 27 2020, 14:18
teamcity updated the summary of D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.
May 27 2020, 14:18
deadalnix requested review of D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.
May 27 2020, 14:18
majcosta committed rABCa7a55fb3ac4f: [backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency (authored by Russell Yanofsky <russ@yanofsky.org>).
[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency
May 27 2020, 14:17
majcosta closed D6256: [backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency.
May 27 2020, 14:16
majcosta committed rABC103cee9a7fca: [backport#15639] Remove access to node globals from wallet-linked code (authored by Russell Yanofsky <russ@yanofsky.org>).
[backport#15639] Remove access to node globals from wallet-linked code
May 27 2020, 14:16
majcosta closed D6255: [backport#15639] Remove access to node globals from wallet-linked code.
May 27 2020, 14:16
teamcity added a comment to D6267: [wallet] Move maxTxFee to wallet.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 27 2020, 14:11
teamcity added a comment to D6267: [wallet] Move maxTxFee to wallet.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 27 2020, 14:03
teamcity added a comment to D6267: [wallet] Move maxTxFee to wallet.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 27 2020, 14:01
teamcity added a comment to D6267: [wallet] Move maxTxFee to wallet.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 27 2020, 14:00
teamcity added a comment to D6267: [wallet] Move maxTxFee to wallet.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 27 2020, 14:00
teamcity added a comment to D6267: [wallet] Move maxTxFee to wallet.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 27 2020, 13:59
deadalnix updated the diff for D6267: [wallet] Move maxTxFee to wallet.

Fix nowallet build

May 27 2020, 13:59
teamcity added a comment to D6267: [wallet] Move maxTxFee to wallet.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 27 2020, 13:45
teamcity added a comment to D6267: [wallet] Move maxTxFee to wallet.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
May 27 2020, 13:34
teamcity added a comment to D6267: [wallet] Move maxTxFee to wallet.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 27 2020, 13:34
teamcity added a comment to D6267: [wallet] Move maxTxFee to wallet.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 27 2020, 13:32
teamcity added a comment to D6267: [wallet] Move maxTxFee to wallet.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 27 2020, 13:32
teamcity added a comment to D6267: [wallet] Move maxTxFee to wallet.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 27 2020, 13:32
teamcity added a comment to D6267: [wallet] Move maxTxFee to wallet.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 27 2020, 13:32
teamcity updated the summary of D6267: [wallet] Move maxTxFee to wallet.
May 27 2020, 13:32
deadalnix requested review of D6267: [wallet] Move maxTxFee to wallet.
May 27 2020, 13:32
teamcity added a comment to D6266: rpc: Uncouple non-wallet rpcs from maxTxFee global.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 27 2020, 13:03
teamcity added a comment to D6266: rpc: Uncouple non-wallet rpcs from maxTxFee global.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 27 2020, 12:56
teamcity added a comment to D6266: rpc: Uncouple non-wallet rpcs from maxTxFee global.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 27 2020, 12:55
teamcity added a comment to D6266: rpc: Uncouple non-wallet rpcs from maxTxFee global.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 27 2020, 12:53
teamcity added a comment to D6266: rpc: Uncouple non-wallet rpcs from maxTxFee global.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 27 2020, 12:53
teamcity added a comment to D6266: rpc: Uncouple non-wallet rpcs from maxTxFee global.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 27 2020, 12:53
teamcity added a comment to D6266: rpc: Uncouple non-wallet rpcs from maxTxFee global.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 27 2020, 12:53
teamcity updated the summary of D6266: rpc: Uncouple non-wallet rpcs from maxTxFee global.
May 27 2020, 12:53
deadalnix requested review of D6266: rpc: Uncouple non-wallet rpcs from maxTxFee global.
May 27 2020, 12:53
deadalnix added a comment to D6265: Add land bot dependencies to base image setup script.

Why would we want the land bot to use different dependencies that CI builds?

May 27 2020, 12:27
deadalnix requested changes to D5380: [seeder] Require good seeds to have latest checkpoint.

It seems very difficult to me to ensure this correct in any meaningful way. There are many moving pieces and they are not weel encapsulated and are done all at once.

May 27 2020, 12:21
deadalnix accepted D6255: [backport#15639] Remove access to node globals from wallet-linked code.
May 27 2020, 12:02
deadalnix requested changes to D6262: [backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion.

The test plan is not apropriate

May 27 2020, 11:51
deadalnix accepted D6261: [backport#16034] Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code).
May 27 2020, 11:49
deadalnix accepted D6260: [backport#15842] refactor: replace isPotentialtip/waitForNotifications by higher method.
May 27 2020, 11:48
deadalnix requested changes to D6259: [backport#15855] [refactor] interfaces: Add missing LockAnnotation for cs_main.

Test plan is not appropriate.

May 27 2020, 11:45
deadalnix requested changes to D6258: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction.
May 27 2020, 11:44
deadalnix accepted D6257: [backport#15670] refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight.
May 27 2020, 11:43
deadalnix accepted D6256: [backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency.
May 27 2020, 11:41
teamcity triaged T906: Build Bitcoin-ABC / Master / Health Checks / Bitcoin-ABC Check Seeds is broken. as Unbreak Now! priority.
May 27 2020, 03:03
teamcity added a comment to D6265: Add land bot dependencies to base image setup script.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 27 2020, 00:49
teamcity added a comment to D6265: Add land bot dependencies to base image setup script.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 27 2020, 00:44
teamcity added a comment to D6265: Add land bot dependencies to base image setup script.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 27 2020, 00:41
teamcity added a comment to D6265: Add land bot dependencies to base image setup script.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 27 2020, 00:34
teamcity added a comment to D6265: Add land bot dependencies to base image setup script.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 27 2020, 00:34
teamcity added a comment to D6265: Add land bot dependencies to base image setup script.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 27 2020, 00:34
jasonbcox requested review of D6265: Add land bot dependencies to base image setup script.
May 27 2020, 00:33

May 26 2020

teamcity added a comment to D6264: Add arcanist land bot workflow.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 26 2020, 23:12
teamcity added a comment to D6264: Add arcanist land bot workflow.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 26 2020, 23:08
teamcity added a comment to D6264: Add arcanist land bot workflow.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 26 2020, 23:06
jasonbcox updated the summary of D6264: Add arcanist land bot workflow.
May 26 2020, 23:00
teamcity added a comment to D6264: Add arcanist land bot workflow.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 26 2020, 22:58
teamcity added a comment to D6264: Add arcanist land bot workflow.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 26 2020, 22:58
teamcity added a comment to D6264: Add arcanist land bot workflow.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 26 2020, 22:57
jasonbcox requested review of D6264: Add arcanist land bot workflow.
May 26 2020, 22:57
teamcity assigned T905: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. to deadalnix.
May 26 2020, 22:44
First
Prev
Next