Page MenuHomePhabricator
Feed All Stories

Nov 24 2020

teamcity updated the summary of D8512: DNS seeds: wait for 5m instead of 11s if 1000+ peers are known.
Nov 24 2020, 12:05
Fabien requested review of D8512: DNS seeds: wait for 5m instead of 11s if 1000+ peers are known.
Nov 24 2020, 12:05
Fabien accepted D8511: Edits to BCHA page.
Nov 24 2020, 10:09
teamcity closed T1259: Build Bitcoin-ABC / Nightly Builds / Initial Block Download Tests / Initial Block Download is broken. as Resolved.
Nov 24 2020, 09:57
Fabien closed D8501: Just pass a TxId to AddInventoryKnown, rename to AddKnownTx.
Nov 24 2020, 09:46
Fabien committed rABC145650dc37f1: Just pass a TxId to AddInventoryKnown, rename to AddKnownTx (authored by Suhas Daftuar <sdaftuar@gmail.com>).
Just pass a TxId to AddInventoryKnown, rename to AddKnownTx
Nov 24 2020, 09:46
Fabien closed D8477: Add a prettier linter for the web tools.
Nov 24 2020, 09:45
Fabien committed rABC7577f721476c: Add a prettier linter for the web tools (authored by Fabien).
Add a prettier linter for the web tools
Nov 24 2020, 09:45
Giselle59415 updated Giselle59415.
Nov 24 2020, 09:09
ManderleyFineFurniture updated ManderleyFineFurniture.
Nov 24 2020, 09:01
wooden-pergola edited a custom field on wooden-pergola.
Nov 24 2020, 04:54
johnkuney requested review of D8511: Edits to BCHA page.
Nov 24 2020, 02:03
deadalnix accepted D8477: Add a prettier linter for the web tools.
Nov 24 2020, 00:20

Nov 23 2020

jasonbcox accepted D8501: Just pass a TxId to AddInventoryKnown, rename to AddKnownTx.
Nov 23 2020, 22:21
jasonbcox closed D8510: Update Electrum ABC link to point to repo maintained under bitcoin-abc Github.
Nov 23 2020, 22:05
jasonbcox committed rABCWEB0b55832151ce: Update Electrum ABC link to point to repo maintained under bitcoin-abc Github (authored by jasonbcox).
Update Electrum ABC link to point to repo maintained under bitcoin-abc Github
Nov 23 2020, 22:05
jasonbcox closed D8509: [buildbot] Set build status as passed when a target has no builds.
Nov 23 2020, 22:03
jasonbcox committed rABCf4ebfd31f403: [buildbot] Set build status as passed when a target has no builds (authored by jasonbcox).
[buildbot] Set build status as passed when a target has no builds
Nov 23 2020, 22:02
PiRK accepted D8510: Update Electrum ABC link to point to repo maintained under bitcoin-abc Github.
Nov 23 2020, 22:02
Fabien accepted D8509: [buildbot] Set build status as passed when a target has no builds.
Nov 23 2020, 22:00
jasonbcox requested review of D8510: Update Electrum ABC link to point to repo maintained under bitcoin-abc Github.
Nov 23 2020, 22:00
johnkuney closed D8505: Add landing page for electrum ABC wallet.
Nov 23 2020, 21:55
johnkuney committed rABCWEBd5d21827e14c: Add landing page for electrum ABC wallet (authored by johnkuney).
Add landing page for electrum ABC wallet
Nov 23 2020, 21:54
jasonbcox closed D8508: [buildbot] Build targets should default to success when no builds are queued.
Nov 23 2020, 21:53
jasonbcox committed rABC2fe36f9fec5e: [buildbot] Build targets should default to success when no builds are queued (authored by jasonbcox).
[buildbot] Build targets should default to success when no builds are queued
Nov 23 2020, 21:53
Fabien accepted D8508: [buildbot] Build targets should default to success when no builds are queued.
Nov 23 2020, 21:43
jasonbcox requested review of D8509: [buildbot] Set build status as passed when a target has no builds.
Nov 23 2020, 21:39
bytesofman accepted D8477: Add a prettier linter for the web tools.

Looks good to me. We may see additional needs here as more web repositories are added, but I think this is an appropriate starting point.

Nov 23 2020, 21:23
jasonbcox closed D8504: Add Electrum ABC to supported wallets.
Nov 23 2020, 21:20
jasonbcox committed rABCWEB6ce4130ca8f9: Add Electrum ABC to supported wallets (authored by jasonbcox).
Add Electrum ABC to supported wallets
Nov 23 2020, 21:20
jasonbcox requested review of D8508: [buildbot] Build targets should default to success when no builds are queued.
Nov 23 2020, 21:08
jasonbcox closed D8507: Run secp256k1 tests on diffs where changes to the library are made.
Nov 23 2020, 21:03
jasonbcox committed rABCf74c5b86af5c: Run secp256k1 tests on diffs where changes to the library are made (authored by jasonbcox).
Run secp256k1 tests on diffs where changes to the library are made
Nov 23 2020, 21:03
Fabien accepted D8507: Run secp256k1 tests on diffs where changes to the library are made.
Nov 23 2020, 20:56
jasonbcox requested review of D8507: Run secp256k1 tests on diffs where changes to the library are made.
Nov 23 2020, 20:00
jasonbcox accepted D8505: Add landing page for electrum ABC wallet.
Nov 23 2020, 19:56
jasonbcox closed D8483: Only run node-related builds on diffs where the node software has changed.
Nov 23 2020, 19:55
jasonbcox committed rABC665129e956ab: Only run node-related builds on diffs where the node software has changed (authored by jasonbcox).
Only run node-related builds on diffs where the node software has changed
Nov 23 2020, 19:55
Fabien updated the diff for D8477: Add a prettier linter for the web tools.

Add more extensions so we're future proof.

Nov 23 2020, 19:41
johnkuney updated the diff for D8505: Add landing page for electrum ABC wallet.

adding link to the github source

Nov 23 2020, 19:37
Fabien accepted D8483: Only run node-related builds on diffs where the node software has changed.
Nov 23 2020, 19:34
johnkuney abandoned D8506: Add landing page for electrum ABC wallet.

meant to add to 505 revision

Nov 23 2020, 19:26
johnkuney requested review of D8506: Add landing page for electrum ABC wallet.
Nov 23 2020, 19:23
Fabien updated the diff for D8477: Add a prettier linter for the web tools.

Use a globaly installed prettier and update doc accordingly.

Nov 23 2020, 19:19
Fabien planned changes to D8477: Add a prettier linter for the web tools.
Nov 23 2020, 19:00
jasonbcox requested changes to D8505: Add landing page for electrum ABC wallet.
Nov 23 2020, 18:58
johnkuney updated the summary of D8505: Add landing page for electrum ABC wallet.
Nov 23 2020, 18:47
johnkuney abandoned D8502: Add electrum wallet page.

Closing this as ended up building off D8504 instead. See D8505 instead

Nov 23 2020, 18:46
bytesofman added inline comments to D8477: Add a prettier linter for the web tools.
Nov 23 2020, 18:39
johnkuney requested review of D8505: Add landing page for electrum ABC wallet.
Nov 23 2020, 18:39
teamcity closed T1262: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
Nov 23 2020, 18:22
Mengerian requested changes to D8502: Add electrum wallet page.
Nov 23 2020, 18:21
Mengerian accepted D8504: Add Electrum ABC to supported wallets.

Looks good to me as an MVP.

Nov 23 2020, 18:16
teamcity triaged T1262: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
Nov 23 2020, 18:13
jasonbcox updated the diff for D8504: Add Electrum ABC to supported wallets.

Rebase

Nov 23 2020, 18:10
jasonbcox closed D8503: Use absolute paths for images on BCHA page.
Nov 23 2020, 18:09
jasonbcox committed rABCWEBf881e24b8931: Use absolute paths for images on BCHA page (authored by jasonbcox).
Use absolute paths for images on BCHA page
Nov 23 2020, 18:09
Mengerian accepted D8503: Use absolute paths for images on BCHA page.

Tested locally, looks good

Nov 23 2020, 18:07
deadalnix closed D8500: fix assert crash when specified change output spend size is unknown.
Nov 23 2020, 17:49
deadalnix committed rABC9e07ed780cf2: fix assert crash when specified change output spend size is unknown (authored by Gregory Sanders <gsanders87@gmail.com>).
fix assert crash when specified change output spend size is unknown
Nov 23 2020, 17:49
majcosta closed D8494: [refactoring] eliminate Boost::Optional for std::optional.
Nov 23 2020, 17:43
majcosta committed rABCa450bcafd954: [refactoring] eliminate Boost::Optional for std::optional (authored by majcosta).
[refactoring] eliminate Boost::Optional for std::optional
Nov 23 2020, 17:43
teamcity added a comment to D8483: Only run node-related builds on diffs where the node software has changed.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Nov 23 2020, 17:43
teamcity added a comment to D8483: Only run node-related builds on diffs where the node software has changed.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Nov 23 2020, 17:43
teamcity added a comment to D8483: Only run node-related builds on diffs where the node software has changed.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Nov 23 2020, 17:42
jasonbcox updated the diff for D8483: Only run node-related builds on diffs where the node software has changed.

Use the template on the clang builds. Even though changes to functional tests only will be a false positive,
catching changes to /cmake are important. Functional test only changes are not super common, so we
can live with this tradeoff to reduce maintenance overhead and reduce false negatives.

Nov 23 2020, 17:40
jasonbcox updated the diff for D8483: Only run node-related builds on diffs where the node software has changed.

Used a template where it makes sense. For the others, it doesn't make sense to run them when
only changes to the functional tests are made.

Nov 23 2020, 17:36
jasonbcox requested review of D8504: Add Electrum ABC to supported wallets.
Nov 23 2020, 17:23
jasonbcox requested review of D8503: Use absolute paths for images on BCHA page.
Nov 23 2020, 17:20
johnkuney updated the summary of D8502: Add electrum wallet page.
Nov 23 2020, 17:00
johnkuney requested review of D8502: Add electrum wallet page.
Nov 23 2020, 16:52
Fabien accepted D8500: fix assert crash when specified change output spend size is unknown.
Nov 23 2020, 16:21
teamcity updated the summary of D8501: Just pass a TxId to AddInventoryKnown, rename to AddKnownTx.
Nov 23 2020, 16:11
Fabien requested review of D8501: Just pass a TxId to AddInventoryKnown, rename to AddKnownTx.
Nov 23 2020, 16:11
teamcity updated the summary of D8500: fix assert crash when specified change output spend size is unknown.
Nov 23 2020, 15:44
deadalnix requested review of D8500: fix assert crash when specified change output spend size is unknown.
Nov 23 2020, 15:43
deadalnix accepted D8494: [refactoring] eliminate Boost::Optional for std::optional.
Nov 23 2020, 15:15
teamcity closed T1261: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Nov 23 2020, 14:53
teamcity triaged T1261: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Nov 23 2020, 14:44
deadalnix closed D8498: tests: Add RPCOverloadWrapper which overloads some disabled RPCs.
Nov 23 2020, 14:33
deadalnix committed rABCf24e79e45b2a: tests: Add RPCOverloadWrapper which overloads some disabled RPCs (authored by Andrew Chow <achow101-github@achow101.com>).
tests: Add RPCOverloadWrapper which overloads some disabled RPCs
Nov 23 2020, 14:32
deadalnix closed D8499: Fix a nit in wallet_keypool.py.
Nov 23 2020, 14:26
deadalnix committed rABC20d158fdf970: Fix a nit in wallet_keypool.py (authored by deadalnix).
Fix a nit in wallet_keypool.py
Nov 23 2020, 14:26
deadalnix closed D8497: [avalanche] Add facility to check proof against a view of the UTXO.
Nov 23 2020, 14:25
deadalnix committed rABCc56157bd36df: [avalanche] Add facility to check proof against a view of the UTXO (authored by deadalnix).
[avalanche] Add facility to check proof against a view of the UTXO
Nov 23 2020, 14:25
deadalnix closed D8496: Add primitive to generate random 160 bits numbers for tests.
Nov 23 2020, 14:23
deadalnix committed rABC12e963467450: Add primitive to generate random 160 bits numbers for tests (authored by deadalnix).
Add primitive to generate random 160 bits numbers for tests
Nov 23 2020, 14:23
teamcity triaged T1259: Build Bitcoin-ABC / Nightly Builds / Initial Block Download Tests / Initial Block Download is broken. as Unbreak Now! priority.
Nov 23 2020, 11:17
teamcity closed T1237: Build Bitcoin-ABC / Master / Make Generator is broken. as Resolved.
Nov 23 2020, 10:42
majcosta closed D8493: [cpp] move to C++17.
Nov 23 2020, 10:27
majcosta committed rABC1541dc4c01d3: [cpp] move to C++17 (authored by majcosta).
[cpp] move to C++17
Nov 23 2020, 10:27
Fabien updated the diff for D8477: Add a prettier linter for the web tools.

Don't lint everything but only the common web file extensions.

Nov 23 2020, 09:33
majcosta updated the diff for D8494: [refactoring] eliminate Boost::Optional for std::optional.

#include'd optional in interfaces/chain.h as not to rely on transitive inclusions

Nov 23 2020, 08:36
Fabien accepted D8499: Fix a nit in wallet_keypool.py.
Nov 23 2020, 08:36
Fabien accepted D8498: tests: Add RPCOverloadWrapper which overloads some disabled RPCs.
Nov 23 2020, 08:35
Fabien accepted D8497: [avalanche] Add facility to check proof against a view of the UTXO.
Nov 23 2020, 08:30
majcosta added inline comments to D8494: [refactoring] eliminate Boost::Optional for std::optional.
Nov 23 2020, 08:29
Fabien accepted D8496: Add primitive to generate random 160 bits numbers for tests.
Nov 23 2020, 08:21
organictextiles updated organictextiles.
Nov 23 2020, 07:02
eliteskinrejuvenation updated eliteskinrejuvenation.
Nov 23 2020, 04:29