Page MenuHomePhabricator
Feed Advanced Search

Oct 5 2018

schancel accepted D1884: net: don't retry failed oneshot connections forever.
Oct 5 2018, 22:07
schancel accepted D1888: Populate services in GetLocalAddress.
Oct 5 2018, 22:04
schancel requested changes to D1890: Added benchmark suite to cmake.
Oct 5 2018, 22:03
schancel accepted D1890: Added benchmark suite to cmake.
Oct 5 2018, 22:01
schancel updated the test plan for D1892: Add a test case to ensure mempool accounting is correct.
Oct 5 2018, 21:45
schancel updated the diff for D1892: Add a test case to ensure mempool accounting is correct.

Remove erroroneous inclusions

Oct 5 2018, 21:44
Herald added a reviewer for D1892: Add a test case to ensure mempool accounting is correct: Restricted Project.
Oct 5 2018, 21:42
schancel updated the diff for D1858: [qa] allow assert_fee to have a bit more wiggleroom.

Update for clarity

Oct 5 2018, 19:10
schancel added a comment to D1858: [qa] allow assert_fee to have a bit more wiggleroom.

Okay, so for fundrawtransaction, when fees are dropped, the first transaction sent in a series of fee checks is with a feerate of 100sat/kb. This results in a fee of 0.00000202. This is ceiled so as to not be under the minimum relay fee. It then proceeds to calculate expected fees based on multiples of this due to the dummy signatures that get added during fundraw transaction.

Oct 5 2018, 01:27
schancel reclaimed D1858: [qa] allow assert_fee to have a bit more wiggleroom.
Oct 5 2018, 01:11
schancel abandoned D1858: [qa] allow assert_fee to have a bit more wiggleroom.

I actually ended up fixing a different cause of the failure.

Oct 5 2018, 00:47

Oct 4 2018

schancel committed rABCfe6305d6b499: [qa] fundrawtransaction to use billable_size instead of count_bytes (authored by schancel).
[qa] fundrawtransaction to use billable_size instead of count_bytes
Oct 4 2018, 03:21
schancel closed D1868: [qa] fundrawtransaction to use billable_size instead of count_bytes.
Oct 4 2018, 03:21

Oct 3 2018

schancel triaged T422: Simplify Child Pays for Parent code drastically as Normal priority.
Oct 3 2018, 16:08
Herald added a reviewer for D1868: [qa] fundrawtransaction to use billable_size instead of count_bytes: Restricted Project.
Oct 3 2018, 05:09

Oct 2 2018

schancel planned changes to D1860: Introduce and track a billable size in addition to real txn size.

Needs a test

Oct 2 2018, 00:56

Oct 1 2018

schancel updated the diff for D1801: Begin using billable txn size for wallet and mining.

Rebase

Oct 1 2018, 22:28
schancel updated the summary of D1860: Introduce and track a billable size in addition to real txn size.
Oct 1 2018, 22:24
schancel retitled D1801: Begin using billable txn size for wallet and mining from Introduce a tx billable size that is independent from the total size to Implement billable size usage in mining, relaying, and wallet transaction creation.
Oct 1 2018, 22:23
schancel updated the summary of D1801: Begin using billable txn size for wallet and mining.
Oct 1 2018, 22:23
Herald added a reviewer for D1860: Introduce and track a billable size in addition to real txn size: Restricted Project.
Oct 1 2018, 22:22
Herald added a reviewer for D1859: [qa] use billable_size is testnode fee estimates: Restricted Project.
Oct 1 2018, 22:20
Herald added a reviewer for D1858: [qa] allow assert_fee to have a bit more wiggleroom: Restricted Project.
Oct 1 2018, 22:14
schancel committed rABCe9fa8fb7dc78: [ci] Check in existing gitian build script (authored by schancel).
[ci] Check in existing gitian build script
Oct 1 2018, 22:05
schancel closed D1839: [ci] Check in existing gitian build script.
Oct 1 2018, 22:05
schancel accepted D1849: Make prevector::resize() and other prevector operations much faster.
Oct 1 2018, 21:50
schancel updated subscribers of T316: Split TxID and TxHash and use them properly across the codebase.

@deadalnix Is this done?

Oct 1 2018, 21:27 · Bootcamp
schancel accepted D1854: Explicitly initialize prevector _union.
Oct 1 2018, 21:12

Sep 29 2018

schancel added inline comments to D1834: [refactor] Config handling refactoring in preparation for network-specific sections.
Sep 29 2018, 21:47
schancel updated the diff for D1839: [ci] Check in existing gitian build script.

Add terminal newline

Sep 29 2018, 17:59
Herald added a reviewer for D1839: [ci] Check in existing gitian build script: Restricted Project.
Sep 29 2018, 17:57

Sep 28 2018

schancel requested changes to D1834: [refactor] Config handling refactoring in preparation for network-specific sections.
Sep 28 2018, 21:46
schancel accepted D1838: Nits in rpc/rawtransaction.cpp.
Sep 28 2018, 21:30
schancel accepted D1837: Nits in net.cpp.
Sep 28 2018, 21:30
schancel accepted D1836: Nits in rpc/protocol.cpp.
Sep 28 2018, 21:28
schancel accepted D1835: Nits in rpc/abc.cpp.
Sep 28 2018, 21:28
schancel placed T77: Consider removing prevector and switching back to good 'ol vector (with possible .reserve calls) up for grabs.
Sep 28 2018, 21:25 · Bootcamp, Restricted Project
schancel placed T73: Consider switching over to pre-increment rather than post-increment operator++ operator-- up for grabs.
Sep 28 2018, 21:24 · Bootcamp
schancel added projects to T397: Added `trusted` to help of gettransaction RPC: Restricted Project, Bootcamp.
Sep 28 2018, 21:23 · Bootcamp, Restricted Project
schancel closed T84: 0.19 BCC unspendable @0 conf, even though "Spend unconfirmed change" checkbox checked. 1 conf = it worked. as Wontfix.

Closing this. If it's still an issue, reopen it.

Sep 28 2018, 21:23 · Restricted Project, Restricted Project
schancel closed T34: Doc build is broken, it needs to be fixed as Resolved.

Looks like I've completed this one. doc.bitcoinabc.org is up.

Sep 28 2018, 21:21
schancel closed T106: Phabricator fails to send emails to my email server as Resolved.
Sep 28 2018, 21:20
schancel claimed T83: Change default build artifacts names.
Sep 28 2018, 21:19
schancel claimed T68: Have the version in a unique location.
Sep 28 2018, 21:19
schancel closed T39: Implement CI on each diffs, a subtask of T37: Setup 3 stage testing, as Resolved.
Sep 28 2018, 21:18
schancel closed T39: Implement CI on each diffs as Resolved.
Sep 28 2018, 21:18
schancel closed T315: Remove partial transaction ordering requirement as Resolved.
Sep 28 2018, 21:17
schancel closed T315: Remove partial transaction ordering requirement, a subtask of T253: Canonical Transaction Ordering, as Resolved.
Sep 28 2018, 21:17
schancel closed T188: Ensure master builds also perform a build with the wallet disabled. as Resolved.
Sep 28 2018, 21:17
schancel closed T326: Script_tests.json handler should ensure pushed groups are the right size as Resolved.
Sep 28 2018, 21:17 · Bootcamp
schancel closed T335: Automate gitian builds as Resolved.
Sep 28 2018, 21:16
schancel closed T335: Automate gitian builds, a subtask of T258: Quality Assurance Improvements, as Resolved.
Sep 28 2018, 21:16
schancel closed T184: Backport core PR11183: [tests] Add P2P interface to TestNode as Resolved.
Sep 28 2018, 21:15
schancel closed T184: Backport core PR11183: [tests] Add P2P interface to TestNode, a subtask of T126: Backports from Bitcoin Core, as Resolved.
Sep 28 2018, 21:15
schancel closed T183: Backport Core PR11067: [qa] TestNode: Add wait_until_stopped helper method as Resolved.
Sep 28 2018, 21:15
schancel closed T183: Backport Core PR11067: [qa] TestNode: Add wait_until_stopped helper method, a subtask of T184: Backport core PR11183: [tests] Add P2P interface to TestNode, as Resolved.
Sep 28 2018, 21:15
schancel closed T182: Backport Core PR11121: TestNode tidyups as Resolved.
Sep 28 2018, 21:15
schancel closed T182: Backport Core PR11121: TestNode tidyups, a subtask of T183: Backport Core PR11067: [qa] TestNode: Add wait_until_stopped helper method, as Resolved.
Sep 28 2018, 21:15
schancel closed T330: Build Bitcoin-ABC :: Miscellany :: Doxygen Documentation is broken. as Resolved.
Sep 28 2018, 21:14
schancel closed T340: Build Bitcoin-ABC :: Miscellany :: BitcoinCash.org :: Staging is broken. as Resolved.
Sep 28 2018, 21:14
schancel closed T342: Build Bitcoin-ABC :: Master :: Nightly Builds :: Nightly is broken. as Resolved.
Sep 28 2018, 21:14
schancel closed T343: Build Bitcoin-ABC :: Master :: Nightly Builds :: Nightly - Linux is broken. as Resolved.
Sep 28 2018, 21:14
schancel closed T344: Build Bitcoin-ABC :: Master :: Nightly Builds :: Nightly - Win is broken. as Resolved.
Sep 28 2018, 21:13
schancel closed T345: Build Bitcoin-ABC :: Master :: Nightly Builds :: Nightly - OSX is broken. as Resolved.
Sep 28 2018, 21:13
schancel closed T350: Build Automated Deployments :: BitcoinABC.org :: BitcoinABC.org Master Deploy is broken. as Resolved.
Sep 28 2018, 21:13
schancel closed T372: Build Automated Deployments / BitcoinABC.org / BitcoinABC.org Master Deploy is broken. as Resolved.
Sep 28 2018, 21:13
schancel closed T373: Build Bitcoin-ABC / Master / Bitcoin-ABC Master is broken. as Resolved.
Sep 28 2018, 21:13
schancel closed T374: Build Bitcoin-ABC / Master / Nightly Builds / Nightly - OSX is broken. as Resolved.
Sep 28 2018, 21:13
schancel closed T375: Build Bitcoin-ABC / Master / Nightly Builds / Nightly - Linux is broken. as Resolved.
Sep 28 2018, 21:13
schancel closed T376: Build Bitcoin-ABC / Master / Nightly Builds / Nightly - Win is broken. as Resolved.
Sep 28 2018, 21:13
schancel closed T399: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Resolved.
Sep 28 2018, 21:13

Sep 27 2018

schancel committed rABC8e279dbc14ff: Fix fee estimate rounding errors (authored by schancel).
Fix fee estimate rounding errors
Sep 27 2018, 23:39
schancel closed D1815: Fix fee estimate rounding errors.
Sep 27 2018, 23:38
schancel committed rABC1254f95f79ec: Make sure to fund transactions with a ceil'd result (authored by schancel).
Make sure to fund transactions with a ceil'd result
Sep 27 2018, 23:21
schancel closed D1816: Make sure to fund transactions with a ceil'd result.
Sep 27 2018, 23:21
schancel committed rABCc0dff931b214: Remove minTxFee from wallet (authored by schancel).
Remove minTxFee from wallet
Sep 27 2018, 23:07
schancel closed D1800: Remove minTxFee from wallet.
Sep 27 2018, 23:06
schancel updated the diff for D1800: Remove minTxFee from wallet.

Remove whitespace change

Sep 27 2018, 22:39
schancel updated the diff for D1800: Remove minTxFee from wallet.

Rebase

Sep 27 2018, 22:33
schancel committed rSTAGINGba5f4570fb4a: Add callsign to .arcconfig for proper repo identification (authored by schancel).
Add callsign to .arcconfig for proper repo identification
Sep 27 2018, 19:05
schancel committed rSTAGING9d887dcc1bda: Rename DEFAULT_MIN_RELAY_TX_FEE for clarity (authored by schancel).
Rename DEFAULT_MIN_RELAY_TX_FEE for clarity
Sep 27 2018, 19:04
schancel committed rSTAGING2d73b06dd535: [qa] fix flakiness of bip68-sequence (authored by schancel).
[qa] fix flakiness of bip68-sequence
Sep 27 2018, 19:04
schancel committed rSTAGING44f7ceb5f303: Rename DEFAULT_BLOCK_MIN_TX_FEE for clarity (authored by schancel).
Rename DEFAULT_BLOCK_MIN_TX_FEE for clarity
Sep 27 2018, 19:04
schancel committed rSTAGING17962b1004a3: [qt] Add use available balance in send coins dialog (authored by CryptAxe <cryptaxe@gmail.com>).
[qt] Add use available balance in send coins dialog
Sep 27 2018, 19:04
schancel committed rSTAGINGab707c825e9a: [qa] rearrange assertion in wallet-accounts (authored by schancel).
[qa] rearrange assertion in wallet-accounts
Sep 27 2018, 19:04
schancel committed rSTAGINGafa6f7a2d3bc: [qa] wallet.py use billable_size (authored by schancel).
[qa] wallet.py use billable_size
Sep 27 2018, 19:04
schancel committed rSTAGING7422d6e77585: Update berkeley-db prefix search for osx (authored by schancel).
Update berkeley-db prefix search for osx
Sep 27 2018, 19:04
schancel committed rSTAGING0d5427fcf95e: [ci] fix build parallelization (authored by schancel).
[ci] fix build parallelization
Sep 27 2018, 19:04
schancel committed rSTAGING4f834d34a882: Fix make check on darwin (authored by schancel).
Fix make check on darwin
Sep 27 2018, 19:02
schancel committed rSTAGING84e6ae9138a0: [qa] fix flaky abc-magnetic-anomaly-activation.py (authored by schancel).
[qa] fix flaky abc-magnetic-anomaly-activation.py
Sep 27 2018, 18:59
schancel committed rSTAGINGcd3c01418d9e: Use ceiling division for fees when funding transactions (authored by schancel).
Use ceiling division for fees when funding transactions
Sep 27 2018, 18:58
schancel committed rSTAGING87d967d48f27: Move CFeeRate into its own source files (authored by schancel).
Move CFeeRate into its own source files
Sep 27 2018, 18:58
schancel committed rSTAGING3ac42e84f48b: [qa] make create_confirmed_utxos calculate fees (authored by schancel).
[qa] make create_confirmed_utxos calculate fees
Sep 27 2018, 18:58
schancel committed rSTAGING1462272d6178: [qa] add cashaddr module, and fix send_big_transactions (authored by schancel).
[qa] add cashaddr module, and fix send_big_transactions
Sep 27 2018, 18:57
schancel committed rSTAGING9e2c9735be30: [qa] move and rename mine_large_block from util to blocktools (authored by schancel).
[qa] move and rename mine_large_block from util to blocktools
Sep 27 2018, 18:57
schancel committed rSTAGING4271fd9c0bf4: [qa] Fix assertions in fundrawtransaction (authored by schancel).
[qa] Fix assertions in fundrawtransaction
Sep 27 2018, 18:57
schancel committed rSTAGINGf3949a1489cd: [qa] make fundrawtransaction test calculate fees properly (authored by schancel).
[qa] make fundrawtransaction test calculate fees properly
Sep 27 2018, 18:57
schancel committed rSTAGINGc99367a12f71: [qa] move create_confirmed_utxos to blocktools.py from util.py (authored by schancel).
[qa] move create_confirmed_utxos to blocktools.py from util.py
Sep 27 2018, 18:57
schancel committed rSTAGING4fcdb4c2f859: Make transaction ordering tests easier to debug (authored by schancel).
Make transaction ordering tests easier to debug
Sep 27 2018, 18:57
schancel committed rSTAGINGe10cafb55058: Revert "Remove unecessary header in amount.h" (authored by schancel).
Revert "Remove unecessary header in amount.h"
Sep 27 2018, 18:57