Page MenuHomePhabricator
Feed Advanced Search

Dec 10 2020

deadalnix accepted D8642: [seeder] Use GetTime() utility function instead of accessing ctime directly.
Dec 10 2020, 03:20
deadalnix updated the diff for D8640: [cmake] Allow to configure the linker used..

Add the lld dependency to the debian package build and to the edependency for CI

Dec 10 2020, 02:11
deadalnix requested review of D8640: [cmake] Allow to configure the linker used..
Dec 10 2020, 01:51
deadalnix accepted D8609: [CashTab] Adds webpack aliases and refactor imports.
Dec 10 2020, 01:35

Dec 9 2020

deadalnix accepted D6357: Dedup net message writing code in the seeder.
Dec 9 2020, 23:49
deadalnix accepted D8624: [seeder] Add a test to check outgoing messages in response to VERACK.
Dec 9 2020, 21:50
deadalnix accepted D8638: wallet: Never schedule MaybeCompactWalletDB when -flushwallet is off.
Dec 9 2020, 16:30
deadalnix accepted D8637: fuzz: Disable debug log file.
Dec 9 2020, 15:43
deadalnix accepted D8636: tests: Add deserialization fuzzing of SnapshotMetadata (utxo_snapshot). Increase fuzzing coverage..
Dec 9 2020, 15:42
deadalnix accepted D8635: Revert "Revert "fuzz: Add process_messages harness"".
Dec 9 2020, 14:37
deadalnix accepted D8634: Fix a fuzzer build failure and run the build on CI.
Dec 9 2020, 14:35
deadalnix requested changes to D8633: [refactor] use compile time string_view for DBKeys.

If you are going to do that, you need to add test for the serialization routines. I don't see what making these constexpr really benefit anything. The optimizer is likely able to do it anyways.

Dec 9 2020, 13:24
deadalnix accepted D8525: Fix a potential data race between CConman and the PeerLogicValidation.
Dec 9 2020, 12:15

Dec 8 2020

deadalnix accepted D8203: [backport#16400] refactor: Rewrite AcceptToMemoryPoolWorker() using smaller parts.

That's good stuff!

Dec 8 2020, 01:31
deadalnix accepted D7041: [refactor] remove const CChainParams& object from CWallet.
Dec 8 2020, 00:43
deadalnix requested changes to D6357: Dedup net message writing code in the seeder.

More of a question that a change request, but please double check this.

Dec 8 2020, 00:38

Dec 7 2020

deadalnix requested changes to D8624: [seeder] Add a test to check outgoing messages in response to VERACK.
Dec 7 2020, 23:43
deadalnix accepted D8623: [seeder] Use netmagic from chainparams instead of a cached global.
Dec 7 2020, 23:27
deadalnix closed D8610: [avalanche] Only select from peers which have an actual node attached.
Dec 7 2020, 17:59
deadalnix committed rABC04394e9ad825: [avalanche] Only select from peers which have an actual node attached (authored by deadalnix).
[avalanche] Only select from peers which have an actual node attached
Dec 7 2020, 17:59
deadalnix closed D8606: [avalanche] Refactor the PeerManager.
Dec 7 2020, 17:53
deadalnix committed rABCfa390b74b8f0: [avalanche] Refactor the PeerManager (authored by deadalnix).
[avalanche] Refactor the PeerManager
Dec 7 2020, 17:53
deadalnix updated the diff for D8606: [avalanche] Refactor the PeerManager.

Fix comments

Dec 7 2020, 16:50
deadalnix accepted D8614: walletdb: moveonly: Move BerkeleyBatch Cursor and Txn funcs to cpp.
Dec 7 2020, 13:15
deadalnix accepted D8613: walletdb: move IsWalletLoaded to walletdb.cpp.
Dec 7 2020, 13:14
deadalnix accepted D8612: walletdb: Add IsBDBWalletLoaded to look for BDB wallets specifically.
Dec 7 2020, 13:13
deadalnix accepted D8611: walletdb: Make SpliWalletFilePath non-static.
Dec 7 2020, 13:13

Dec 6 2020

deadalnix updated the diff for D8610: [avalanche] Only select from peers which have an actual node attached.

Minor operation reordering.

Dec 6 2020, 17:04
deadalnix requested review of D8610: [avalanche] Only select from peers which have an actual node attached.
Dec 6 2020, 16:54
deadalnix added a comment to D8609: [CashTab] Adds webpack aliases and refactor imports.

Why simply not adding src to the path?

Dec 6 2020, 13:32
deadalnix updated the diff for D8606: [avalanche] Refactor the PeerManager.

Fix merge conflict in processor.cpp

Dec 6 2020, 02:27
deadalnix closed D8607: [avalanche] Specify the proof to be used by the node via config.
Dec 6 2020, 02:17
deadalnix committed rABC995d70773735: [avalanche] Specify the proof to be used by the node via config (authored by deadalnix).
[avalanche] Specify the proof to be used by the node via config
Dec 6 2020, 02:17
deadalnix updated the diff for D8606: [avalanche] Refactor the PeerManager.

rebase

Dec 6 2020, 02:14
deadalnix closed D8604: [avalanche] Add nodes using a verifiable delegation instead of asserting the public key.
Dec 6 2020, 02:09
deadalnix committed rABC163c84491469: [avalanche] Add nodes using a verifiable delegation instead of asserting the… (authored by deadalnix).
[avalanche] Add nodes using a verifiable delegation instead of asserting the…
Dec 6 2020, 02:09
deadalnix requested review of D8607: [avalanche] Specify the proof to be used by the node via config.
Dec 6 2020, 01:50
deadalnix requested review of D8606: [avalanche] Refactor the PeerManager.
Dec 6 2020, 00:43

Dec 5 2020

deadalnix closed D8602: [avalanche] Add a mechanism to delegate proofs.
Dec 5 2020, 20:36
deadalnix committed rABC94d26b8cc9bc: [avalanche] Add a mechanism to delegate proofs (authored by deadalnix).
[avalanche] Add a mechanism to delegate proofs
Dec 5 2020, 20:36
deadalnix closed D8605: Bump DEFAULT_MAX_PEER_CONNECTIONS to 4096.
Dec 5 2020, 00:58
deadalnix committed rABC537d1a1e42c2: Bump DEFAULT_MAX_PEER_CONNECTIONS to 4096 (authored by deadalnix).
Bump DEFAULT_MAX_PEER_CONNECTIONS to 4096
Dec 5 2020, 00:58
deadalnix updated the diff for D8605: Bump DEFAULT_MAX_PEER_CONNECTIONS to 4096.

Fix warnings in bitcoin-qt and log due to an error in the the required descriptor count calcuation.

Dec 5 2020, 00:55

Dec 4 2020

deadalnix updated the diff for D8605: Bump DEFAULT_MAX_PEER_CONNECTIONS to 4096.

Reduce the max connection used by default in integration tests as to not exaust the available file descriptors when many nodes are running at once.

Dec 4 2020, 17:06
deadalnix requested review of D8605: Bump DEFAULT_MAX_PEER_CONNECTIONS to 4096.
Dec 4 2020, 16:50
deadalnix requested changes to D8587: [CashTab] Adds fbt strings to Wallet component on CashTab..
Dec 4 2020, 16:43
deadalnix requested changes to D8601: Re-enable SLPA transactions in CashTab and fix notification bug.

Can you change the diff title? These "Patching foo" is completely redundant. Yes, this is a patch. That tell us nothing about what this does. Failure to be specific is already having an impact on this diff, asyou are throwing in various other stuff that are "geographically" related, as in they happen in the same area of the code, but are semantically unrelated.

Dec 4 2020, 16:38
deadalnix closed D8599: Add a way to verify schnorr signatures from an array..
Dec 4 2020, 16:31
deadalnix committed rABC9e1b95bf8e46: Add a way to verify schnorr signatures from an array. (authored by deadalnix).
Add a way to verify schnorr signatures from an array.
Dec 4 2020, 16:31
deadalnix requested review of D8604: [avalanche] Add nodes using a verifiable delegation instead of asserting the public key.
Dec 4 2020, 16:28
deadalnix updated the diff for D8602: [avalanche] Add a mechanism to delegate proofs.

rebase

Dec 4 2020, 15:24
deadalnix closed D8603: [avalanche] Fix race condition during destruction in poll_and_response test.
Dec 4 2020, 15:23
deadalnix committed rABC2d043eb895c0: [avalanche] Fix race condition during destruction in poll_and_response test (authored by deadalnix).
[avalanche] Fix race condition during destruction in poll_and_response test
Dec 4 2020, 15:23
deadalnix requested review of D8599: Add a way to verify schnorr signatures from an array..

I don't see any reason to block this PR due to existing code that could be better.

Dec 4 2020, 15:21
deadalnix abandoned D8552: [avalanche] Fix race condition in the destruction of the Processor.

Superseeded by D8603

Dec 4 2020, 01:46
deadalnix requested review of D8603: [avalanche] Fix race condition during destruction in poll_and_response test.
Dec 4 2020, 01:46
deadalnix updated the diff for D8602: [avalanche] Add a mechanism to delegate proofs.

rebase

Dec 4 2020, 01:14
deadalnix requested changes to D8601: Re-enable SLPA transactions in CashTab and fix notification bug.
Dec 4 2020, 01:12
deadalnix requested review of D8602: [avalanche] Add a mechanism to delegate proofs.
Dec 4 2020, 01:08

Dec 3 2020

deadalnix requested review of D8599: Add a way to verify schnorr signatures from an array..
Dec 3 2020, 22:38
deadalnix accepted D8559: [CashTab] Add Fbt dependencies, init script and intl to App component.
Dec 3 2020, 20:10

Dec 2 2020

deadalnix requested changes to D8559: [CashTab] Add Fbt dependencies, init script and intl to App component.
Dec 2 2020, 23:47
deadalnix closed D8580: [avalanche] Use more sensible banscores.
Dec 2 2020, 22:19
deadalnix committed rABCbf4044fdd64d: [avalanche] Use more sensible banscores (authored by deadalnix).
[avalanche] Use more sensible banscores
Dec 2 2020, 22:19
deadalnix updated the diff for D8580: [avalanche] Use more sensible banscores.

Add circular dependency.

Dec 2 2020, 20:52
deadalnix requested review of D8580: [avalanche] Use more sensible banscores.
Dec 2 2020, 18:48
deadalnix requested changes to D8559: [CashTab] Add Fbt dependencies, init script and intl to App component.
Dec 2 2020, 15:30
deadalnix closed D8558: Bump version to 0.22.9.
Dec 2 2020, 14:00
deadalnix committed rABC9aa69123d865: Bump version to 0.22.9 (authored by jasonbcox).
Bump version to 0.22.9
Dec 2 2020, 14:00

Dec 1 2020

deadalnix accepted D8577: Fees from 83 sat/byte to 5 sat/byte.
Dec 1 2020, 22:51
deadalnix accepted D8575: Support backup API URLs.
Dec 1 2020, 22:36
deadalnix closed D8572: [avalanche] Allow to manually set the session key.
Dec 1 2020, 17:16
deadalnix committed rABC05ff28690054: [avalanche] Allow to manually set the session key (authored by deadalnix).
[avalanche] Allow to manually set the session key
Dec 1 2020, 17:16
deadalnix requested review of D8572: [avalanche] Allow to manually set the session key.
Dec 1 2020, 16:39
deadalnix requested changes to D8559: [CashTab] Add Fbt dependencies, init script and intl to App component.

Please use fbt. Our other stuff use fbt.

Dec 1 2020, 15:58
deadalnix accepted D8568: rpc: Fix named arguments in documentation.
Dec 1 2020, 15:16
deadalnix accepted D8553: rpc: Add generateblock to mine a custom set of transactions.
Dec 1 2020, 15:15
deadalnix accepted D8562: validation: Make LoadBlockIndex() a member of ChainstateManager.
Dec 1 2020, 15:13
deadalnix accepted D8563: validation: Make PruneOneBlockFile() a member of ChainstateManager.
Dec 1 2020, 15:12
deadalnix accepted D8564: validation: Make ProcessNewBlock*() members of ChainstateManager.
Dec 1 2020, 15:10
deadalnix accepted D8565: validation: Mark g_chainman DEPRECATED.
Dec 1 2020, 15:09
deadalnix accepted D8566: util: Add Assert identity function.
Dec 1 2020, 15:06
deadalnix accepted D8561: net: Pass chainman into PeerLogicValidation.
Dec 1 2020, 15:05
deadalnix accepted D8567: rpc: Avoid initialization-order-fiasco on static CRPCCommand tables.
Dec 1 2020, 14:34
deadalnix closed D8571: Do not unpark deep reorg automatically when avalanche is enabled.
Dec 1 2020, 13:50
deadalnix committed rABC4d966bd4b8dd: Do not unpark deep reorg automatically when avalanche is enabled (authored by deadalnix).
Do not unpark deep reorg automatically when avalanche is enabled
Dec 1 2020, 13:50
deadalnix closed D8569: [avalanche] Return more detailed errors codes.
Dec 1 2020, 13:31
deadalnix committed rABC805dc9158f4e: [avalanche] Return more detailed errors codes (authored by deadalnix).
[avalanche] Return more detailed errors codes
Dec 1 2020, 13:31
deadalnix closed D8570: [avalanche] log block acceptance and rejection.
Dec 1 2020, 13:21
deadalnix committed rABCa71432b68293: [avalanche] log block acceptance and rejection (authored by deadalnix).
[avalanche] log block acceptance and rejection
Dec 1 2020, 13:21
deadalnix requested review of D8571: Do not unpark deep reorg automatically when avalanche is enabled.
Dec 1 2020, 13:18
deadalnix requested changes to D8568: rpc: Fix named arguments in documentation.
Dec 1 2020, 13:10
deadalnix requested review of D8570: [avalanche] log block acceptance and rejection.
Dec 1 2020, 13:08
deadalnix requested review of D8569: [avalanche] Return more detailed errors codes.
Dec 1 2020, 12:55

Nov 30 2020

deadalnix accepted D8556: Fix buildavalancheproof RPC with bitcoin-cli.
Nov 30 2020, 19:13
deadalnix closed D8554: Limit the number of sigcheck added to a block when mining.
Nov 30 2020, 16:46
deadalnix committed rABC8db9095ba5d0: Limit the number of sigcheck added to a block when mining (authored by deadalnix).
Limit the number of sigcheck added to a block when mining
Nov 30 2020, 16:46
deadalnix updated the summary of D8554: Limit the number of sigcheck added to a block when mining.
Nov 30 2020, 16:42
deadalnix requested review of D8554: Limit the number of sigcheck added to a block when mining.
Nov 30 2020, 16:42
deadalnix requested review of D8552: [avalanche] Fix race condition in the destruction of the Processor.
Nov 30 2020, 02:50