Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Dec 29 2020

majcosta closed D8707: [WEBSITE] Remove the BCHN variant from the release page.
Dec 29 2020, 18:40
majcosta committed rABCWEB1d9c6bea315e: [WEBSITE] Remove the BCHN variant from the release page (authored by Fabien).
[WEBSITE] Remove the BCHN variant from the release page
Dec 29 2020, 18:40
majcosta commandeered D8707: [WEBSITE] Remove the BCHN variant from the release page.
Dec 29 2020, 18:21

Dec 28 2020

majcosta closed D8757: [backport#17674] tests: Add initialization order fiasco detection in Travis.
Dec 28 2020, 21:35
majcosta committed rABC929b49252f38: [backport#17674] tests: Add initialization order fiasco detection in Travis (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#17674] tests: Add initialization order fiasco detection in Travis
Dec 28 2020, 21:35
majcosta closed D8756: [backport#17205] ci: Enable address sanitizer (ASan) stack-use-after-return checking.
Dec 28 2020, 21:34
majcosta committed rABC6e9dc69ab31b: [backport#17205] ci: Enable address sanitizer (ASan) stack-use-after-return… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#17205] ci: Enable address sanitizer (ASan) stack-use-after-return…
Dec 28 2020, 21:34
majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

rebase

Dec 28 2020, 20:32

Dec 27 2020

majcosta accepted D8759: [BUILDBOT] Temporarly fix the 502 error with embedded shields.io link.
Dec 27 2020, 18:53

Dec 24 2020

majcosta closed D8752: [backport#17162] chain: Remove CBlockIndex::SetNull helper.
Dec 24 2020, 16:26
majcosta committed rABCca7abed8bb6c: [backport#17162] chain: Remove CBlockIndex::SetNull helper (authored by fanquake <fanquake@gmail.com>).
[backport#17162] chain: Remove CBlockIndex::SetNull helper
Dec 24 2020, 16:26
majcosta closed D8755: [backport#17328] GuessVerificationProgress: cap the ratio to 1.
Dec 24 2020, 16:08
majcosta committed rABCdc7db5ed938c: [backport#17328] GuessVerificationProgress: cap the ratio to 1 (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#17328] GuessVerificationProgress: cap the ratio to 1
Dec 24 2020, 16:08
majcosta closed D8754: [backport#16805] logs: add timing information to FlushStateToDisk().
Dec 24 2020, 16:07
majcosta committed rABC48b5e2d8d8ce: [backport#16805] logs: add timing information to FlushStateToDisk() (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#16805] logs: add timing information to FlushStateToDisk()
Dec 24 2020, 16:07
majcosta closed D8753: [backport#17242] refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache.
Dec 24 2020, 16:07
majcosta committed rABC9ca4736e58ae: [backport#17242] refactor: Remove unused cacheSigStore from… (authored by fanquake <fanquake@gmail.com>).
[backport#17242] refactor: Remove unused cacheSigStore from…
Dec 24 2020, 16:07
majcosta closed D8751: [backport#16852] gui: When BIP70 is disabled, get PaymentRequest merchant using string search.
Dec 24 2020, 16:06
majcosta committed rABC272c12f83d8f: [backport#16852] gui: When BIP70 is disabled, get PaymentRequest merchant using… (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#16852] gui: When BIP70 is disabled, get PaymentRequest merchant using…
Dec 24 2020, 16:06
majcosta closed D8750: [backport#16969] refactor: Remove Qt function to disable menu icons on macOS.
Dec 24 2020, 16:03
majcosta committed rABC75d4f4c0c883: [backport#16969] refactor: Remove Qt function to disable menu icons on macOS (authored by fanquake <fanquake@gmail.com>).
[backport#16969] refactor: Remove Qt function to disable menu icons on macOS
Dec 24 2020, 16:02
majcosta closed D8749: [backport#16677] gui: remove unused PlatformStyle::TextColorIcon.
Dec 24 2020, 16:01
majcosta committed rABC273af50e2a7d: [backport#16677] gui: remove unused PlatformStyle::TextColorIcon (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[backport#16677] gui: remove unused PlatformStyle::TextColorIcon
Dec 24 2020, 16:01
majcosta closed D8748: [backport#16612] qt: Remove menu icons.
Dec 24 2020, 16:00
majcosta committed rABCc7066157dac6: [backport#16612] qt: Remove menu icons (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[backport#16612] qt: Remove menu icons
Dec 24 2020, 16:00
majcosta closed D8747: [backport#17085] init: Change fallback locale to C.UTF-8.
Dec 24 2020, 16:00
majcosta committed rABCd7795abdf91b: [backport#17085] init: Change fallback locale to C.UTF-8 (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#17085] init: Change fallback locale to C.UTF-8
Dec 24 2020, 15:59
majcosta requested review of D8757: [backport#17674] tests: Add initialization order fiasco detection in Travis.
Dec 24 2020, 05:51
majcosta requested review of D8756: [backport#17205] ci: Enable address sanitizer (ASan) stack-use-after-return checking.
Dec 24 2020, 05:35
majcosta requested review of D8755: [backport#17328] GuessVerificationProgress: cap the ratio to 1.
Dec 24 2020, 05:14
majcosta requested review of D8754: [backport#16805] logs: add timing information to FlushStateToDisk().
Dec 24 2020, 05:08
majcosta requested review of D8753: [backport#17242] refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache.
Dec 24 2020, 04:50
majcosta updated the summary of D8752: [backport#17162] chain: Remove CBlockIndex::SetNull helper.
Dec 24 2020, 04:32
majcosta requested review of D8752: [backport#17162] chain: Remove CBlockIndex::SetNull helper.
Dec 24 2020, 04:30
majcosta requested review of D8751: [backport#16852] gui: When BIP70 is disabled, get PaymentRequest merchant using string search.
Dec 24 2020, 03:54
majcosta requested review of D8750: [backport#16969] refactor: Remove Qt function to disable menu icons on macOS.
Dec 24 2020, 03:34
majcosta requested review of D8749: [backport#16677] gui: remove unused PlatformStyle::TextColorIcon.
Dec 24 2020, 03:17
majcosta requested review of D8748: [backport#16612] qt: Remove menu icons.
Dec 24 2020, 03:16
majcosta requested review of D8747: [backport#17085] init: Change fallback locale to C.UTF-8.
Dec 24 2020, 02:59

Dec 23 2020

majcosta closed D8746: [gitian] add Marco's key.
Dec 23 2020, 18:21
majcosta committed rABC6d64a7b21edb: [gitian] add Marco's key (authored by majcosta).
[gitian] add Marco's key
Dec 23 2020, 18:21
majcosta requested review of D8746: [gitian] add Marco's key.
Dec 23 2020, 15:08
majcosta accepted D8734: Add webpage interaction to extension.
Dec 23 2020, 14:03
majcosta accepted D8745: Convert undo.h to new serialization framework.
Dec 23 2020, 13:31

Dec 22 2020

majcosta requested changes to D8745: Convert undo.h to new serialization framework.
Dec 22 2020, 19:28
majcosta accepted D8744: Make std::vector and prevector reuse the VectorFormatter logic.
Dec 22 2020, 18:17
majcosta accepted D8743: Add custom vector-element formatter.
Dec 22 2020, 17:55
majcosta accepted D8742: Add a constant for the maximum vector allocation (5 Mbyte).
Dec 22 2020, 16:45

Dec 21 2020

majcosta accepted D8733: Add Epoch Guards to CTXMemPoolEntry and CTxMemPool, make UpdateTransactionsFromBlock use Epochs.
Dec 21 2020, 21:08
majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

fixed misnamed variable on abc_feature_minerfund.py

Dec 21 2020, 20:58
majcosta planned changes to D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Dec 21 2020, 20:52
majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

addressed comment on reuse of test variables and added a test to ensure miner fund addresses with both supported prefixes behave the same

Dec 21 2020, 20:50
majcosta requested changes to D8733: Add Epoch Guards to CTXMemPoolEntry and CTxMemPool, make UpdateTransactionsFromBlock use Epochs.
Dec 21 2020, 18:58
majcosta updated the summary of D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Dec 21 2020, 18:24
majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

made 'bitcoincash:' prefix backward compatible for the time being and duplicated a few tests for it

Dec 21 2020, 18:12
majcosta accepted D8726: [net/refactor] Rework ThreadOpenConnections logic.
Dec 21 2020, 15:29
majcosta accepted D8695: Use rolling bloom filter of recent block tx's for AlreadyHave() check.
Dec 21 2020, 14:36
majcosta accepted D8707: [WEBSITE] Remove the BCHN variant from the release page.
Dec 21 2020, 14:28
majcosta requested changes to D8695: Use rolling bloom filter of recent block tx's for AlreadyHave() check.
Dec 21 2020, 14:19
majcosta accepted D8729: [net] Remove unnecessary default args on CNode constructor.
Dec 21 2020, 14:04
majcosta accepted D8728: [refactor] Remove IsOutboundDisconnectionCandidate.
Dec 21 2020, 14:03
majcosta accepted D8727: [net/refactor] Simplify multiple-connection checks.
Dec 21 2020, 14:02
majcosta requested changes to D8726: [net/refactor] Rework ThreadOpenConnections logic.
Dec 21 2020, 14:00
majcosta accepted D8725: [net] Fix bug where AddrFetch connections would be counted as outbound full relay.
Dec 21 2020, 13:54
majcosta accepted D8724: [net/refactor] Clarify logic for selecting connections in ThreadOpenConnections.
Dec 21 2020, 13:50
majcosta accepted D8723: [net/refactor] Remove fInbound flag from CNode.
Dec 21 2020, 13:46
majcosta accepted D8721: [net/refactor] Remove fFeeler flag from CNode.
Dec 21 2020, 13:39
majcosta accepted D8714: [net/refactor] Add feeler connections to ConnectionType enum.
Dec 21 2020, 13:20
majcosta accepted D8712: [net/refactor] Introduce an enum to distinguish type of connection.
Dec 21 2020, 12:58
majcosta accepted D8713: [net/refactor] Add manual connections to ConnectionType enum.
Dec 21 2020, 12:45
majcosta accepted D8711: scripted-diff: Rename OneShot to AddrFetch.
Dec 21 2020, 12:25
majcosta accepted D8710: fuzz: Stop nodes in process_message* fuzzers.
Dec 21 2020, 12:02
majcosta retitled D8710: fuzz: Stop nodes in process_message* fuzzers from fuzz: Stop nodes in process_message* fuzzers ``` Background is that I saw an integer overflow in net_processing #30629113 REDUCE cov: 25793 ft: 142917 corp: 3421/2417Kb lim: 4096 exec/s: 89 rss: 614Mb L: 1719/4096 MS: 1 EraseBytes... to fuzz: Stop nodes in process_message* fuzzers```Background is that I saw an integer overflow in net_processing#30629113 REDUCE cov: 25793 ft: 142917 corp: 3421/2417Kb lim: 4096exec/s: 89 rss: 614Mb L: 1719/4096 MS: 1 EraseBytes....
Dec 21 2020, 11:59

Dec 18 2020

majcosta requested changes to D8707: [WEBSITE] Remove the BCHN variant from the release page.

this page still shows the "BCHA: built by tech talent" box at the bottom

Dec 18 2020, 21:47
majcosta accepted D8705: [WEBSITE] Fetch documentation in ascending version order.
Dec 18 2020, 21:30
majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

addressed comments

Dec 18 2020, 19:37
majcosta accepted D8704: doc: update release notes with getaddressinfo label deprecation.
Dec 18 2020, 19:33
majcosta accepted D8703: test: getaddressinfo label deprecation test.
Dec 18 2020, 19:29
majcosta accepted D8702: rpc: deprecate getaddressinfo label field.
Dec 18 2020, 19:27
majcosta accepted D8701: test: remove getaddressinfo label tests.
Dec 18 2020, 19:23
majcosta accepted D8700: doc: address pr17578 review feedback.
Dec 18 2020, 19:18
majcosta accepted D8699: gui: Remove WalletView and BitcoinGUI circular dependency.
Dec 18 2020, 19:13
majcosta accepted D8698: gui: Add transactionClicked and coinsSent signals to WalletView.
Dec 18 2020, 19:03
majcosta accepted D8697: gui: Drop ShutdownWindow dependency to BitcoinGUI.
Dec 18 2020, 19:02
majcosta accepted D8696: gui: Drop BanTableModel dependency to ClientModel.
Dec 18 2020, 19:00
majcosta requested changes to D8695: Use rolling bloom filter of recent block tx's for AlreadyHave() check.
Dec 18 2020, 18:56

Dec 17 2020

majcosta accepted D8690: Fix benchmarks filters.
Dec 17 2020, 20:28
majcosta accepted D8689: gui: Shortcut to close ModalOverlay.
Dec 17 2020, 20:27
majcosta retitled D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node from [CashAddr] replace bitcoincash: prefix with abc: to [CashAddr] replace bitcoincash: prefix with abc: in the node.
Dec 17 2020, 20:18
majcosta retitled D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node from [CashAddr] set each network CashAddr prefixes in chainparams.cpp to [CashAddr] replace bitcoincash: prefix with abc:.
Dec 17 2020, 20:18
majcosta updated the summary of D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Dec 17 2020, 20:15
majcosta requested review of D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Dec 17 2020, 20:14
majcosta accepted D8691: Remove BCHN related automation.
Dec 17 2020, 20:02
majcosta accepted D8685: net: Add tests for failure on string parameters with embedded NUL characters.
Dec 17 2020, 13:44
majcosta accepted D8684: net: Avoid using C-style NUL-terminated strings in the netbase interface.
Dec 17 2020, 13:23
majcosta abandoned D8675: decouple miner fund from `bitcoincash:` prefix and fix test.

this is a bit pointless now

Dec 17 2020, 12:50
majcosta updated the diff for D8675: decouple miner fund from `bitcoincash:` prefix and fix test.

addressed feedback

Dec 17 2020, 12:08

Dec 16 2020

majcosta accepted D8678: Remove disabled prop from collapse panels as antd deprecated.
Dec 16 2020, 16:28
majcosta accepted D8677: Update antd to fix design issues.
Dec 16 2020, 12:36

Dec 15 2020

majcosta retitled D8675: decouple miner fund from `bitcoincash:` prefix and fix test from [minerfund] decouple miner fund from `bitcoincash:` prefix and fix test to decouple miner fund from `bitcoincash:` prefix and fix test.
Dec 15 2020, 22:37
First
Prev
Next