renaming value to sendAmountInBcha is already conflicting with BCH and sendBCHMock. if we're going to change things, it should be renaming the latter as not to be coupled with ticker/brand acronyms, not the other way around, otherwise if the latter change it's gonna be really confusing.

already in

oh, that's perfect, my bad then

my browser tab says "Hello from Build on BCHA | Build on BCHA", maybe we want to go with something shorter?

changed the revision summary, since this diff is obviously backporting both commits not just the first

ran locally, test failure is unrelated

elided comment of SegWit information and left a trail of crumbs for archival reasons

LGTM

I recommend using npm ci instead of npm i --legacy-peer-deps, since that'll give you a deterministic build according to the existing package-lock.json which is in the diff already

updated diff with changes that would've been in PR16426 (and renamed a lambda parameter to avoid a -Wshadow). this solved the build-debug error, but uncovered a TSAN warning. investigating that.

investigate failure

giving this a whirl

already done, abandoning

@bot build-debug

rebase

rebase

fix missing braces error for gcc-8

removed the last backward compatibility tests I missed the first time around.

missed some stuff in tests

cut all backwards compatibility changes from the patch, this is a pure prefix change now.

discussed off Phab, the wait_until import should be removed in PR19752