Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Thu, Nov 6

Fabien committed rABCf6f59226778d: test: don't throw from the destructor of DebugLogHelper (authored by Vasil Dimov <vd@FreeBSD.org>).
test: don't throw from the destructor of DebugLogHelper
Thu, Nov 6, 09:47
Fabien closed D18886: log: rate limiting followups.
Thu, Nov 6, 09:45
Fabien committed rABCf1f3f1b879cc: log: rate limiting followups (authored by Eugene Siegel <elzeigel@gmail.com>).
log: rate limiting followups
Thu, Nov 6, 09:45
Fabien accepted D18889: [metachronik] Patch CI by upgrading dep.
Thu, Nov 6, 08:29
Fabien updated the diff for D18886: log: rate limiting followups.

Add back unintentionally removed line

Thu, Nov 6, 08:09
Fabien closed D18885: refactor: use Span for SipHash::Write.
Thu, Nov 6, 08:07
Fabien committed rABC9c275618c64c: refactor: use Span for SipHash::Write (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
refactor: use Span for SipHash::Write
Thu, Nov 6, 08:07
Fabien committed rABCefcca6b16a3b: [CI] Bump ASAN timeout (authored by Fabien).
[CI] Bump ASAN timeout
Thu, Nov 6, 08:07
Fabien closed D18888: [CI] Bump ASAN timeout.
Thu, Nov 6, 08:07

Wed, Nov 5

Fabien requested review of D18888: [CI] Bump ASAN timeout.
Wed, Nov 5, 22:16
Fabien requested review of D18887: test: don't throw from the destructor of DebugLogHelper.
Wed, Nov 5, 22:13
Fabien requested review of D18886: log: rate limiting followups.
Wed, Nov 5, 22:04
Fabien accepted D18882: [metachronik, charts.e.cash] Correctly calculate cumulative agora usd volume.
Wed, Nov 5, 22:04
Fabien requested review of D18885: refactor: use Span for SipHash::Write.
Wed, Nov 5, 20:24
Fabien closed D18881: log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError.
Wed, Nov 5, 19:49
Fabien committed rABCadb30b7ab03d: log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo… (authored by Eugene Siegel <elzeigel@gmail.com>).
log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo…
Wed, Nov 5, 19:49
Fabien closed D18884: [chronik] Fix a -Wmissing-field-initializers warning in chronikbridge_tests.cpp.
Wed, Nov 5, 19:34
Fabien committed rABC8c8f4cc97336: [chronik] Fix a -Wmissing-field-initializers warning in chronikbridge_tests.cpp (authored by Fabien).
[chronik] Fix a -Wmissing-field-initializers warning in chronikbridge_tests.cpp
Wed, Nov 5, 19:34
Fabien accepted D18877: [validation] Make script error messages uniform for parallel/single validation.
Wed, Nov 5, 19:00
Fabien accepted D18876: [checkqueue] support user-defined return type through std::optional.

OK it's ugly but has the same behavior and will be reverted to the clean solution anyway

Wed, Nov 5, 18:56
Fabien added inline comments to D18870: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK().
Wed, Nov 5, 18:51
Fabien accepted D18870: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK().
Wed, Nov 5, 18:51
Fabien requested review of D18884: [chronik] Fix a -Wmissing-field-initializers warning in chronikbridge_tests.cpp.
Wed, Nov 5, 18:47
Fabien updated the diff for D18881: log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError.

Rebase to get c++20 for chronik

Wed, Nov 5, 16:59
Fabien closed D18875: Early logging improvements.
Wed, Nov 5, 16:51
Fabien closed D18873: log: Use steady clock for bench logging.
Wed, Nov 5, 16:51
Fabien closed D18874: refactor: Replace GetTimeMicros by SystemClock.
Wed, Nov 5, 16:51
Fabien committed rABCa57a19a7b4a0: refactor: Replace GetTimeMicros by SystemClock (authored by Fabien).
refactor: Replace GetTimeMicros by SystemClock
Wed, Nov 5, 16:51
Fabien committed rABC311f263c08e8: log: Use steady clock for bench logging (authored by MacroFake <falke.marco@gmail.com>).
log: Use steady clock for bench logging
Wed, Nov 5, 16:51
Fabien committed rABC3f84968a29c7: Early logging improvements (authored by Anthony Towns <aj@erisian.com.au>).
Early logging improvements
Wed, Nov 5, 16:51
Fabien closed D18868: [chronik] Bump the build to c++20.
Wed, Nov 5, 16:50
Fabien committed rABC4251281196e4: [chronik] Bump the build to c++20 (authored by Fabien).
[chronik] Bump the build to c++20
Wed, Nov 5, 16:50
Fabien planned changes to D18881: log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError.
Wed, Nov 5, 16:49
Fabien accepted D18880: [validation] merge all ConnectBlock debug logging code paths.
Wed, Nov 5, 16:49
Fabien accepted D18879: [validation] include all logged information in BlockValidationState.
Wed, Nov 5, 16:47
Fabien added a comment to D18876: [checkqueue] support user-defined return type through std::optional.

LGTM but the CI needs to run. Once a workaround is found it can be green

Wed, Nov 5, 16:46
Fabien accepted D18878: [validation] Add detailed txin/txout information for script error messages.
Wed, Nov 5, 16:44
Fabien added a comment to D18878: [validation] Add detailed txin/txout information for script error messages.

Macro likestamp:

Wed, Nov 5, 16:44
Fabien accepted D18872: Add std::optional support to Boost's equality check.
Wed, Nov 5, 16:29
Fabien accepted D18871: test: uint256 - Garbage suffixes and zero padding.
Wed, Nov 5, 16:27
Fabien requested changes to D18870: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK().
Wed, Nov 5, 16:26
Fabien requested review of D18881: log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError.
Wed, Nov 5, 16:21
Fabien requested review of D18875: Early logging improvements.
Wed, Nov 5, 14:12
Fabien updated the diff for D18874: refactor: Replace GetTimeMicros by SystemClock.

Rebase for CI

Wed, Nov 5, 14:05
Fabien updated the diff for D18873: log: Use steady clock for bench logging.

Remove unused var

Wed, Nov 5, 14:03
Fabien planned changes to D18873: log: Use steady clock for bench logging.
Wed, Nov 5, 13:46
Fabien planned changes to D18874: refactor: Replace GetTimeMicros by SystemClock.
Wed, Nov 5, 13:46
Fabien requested review of D18874: refactor: Replace GetTimeMicros by SystemClock.
Wed, Nov 5, 13:34
Fabien requested review of D18873: log: Use steady clock for bench logging.
Wed, Nov 5, 13:29
Fabien accepted D18869: Bump version to 0.32.2.
Wed, Nov 5, 11:18
teamcity awarded D18868: [chronik] Bump the build to c++20 a Haypence token.
Wed, Nov 5, 10:29
Fabien added a comment to D18868: [chronik] Bump the build to c++20.

@bot guix-linux guix-osx guix-win

Wed, Nov 5, 10:29
Fabien requested review of D18868: [chronik] Bump the build to c++20.
Wed, Nov 5, 10:29

Tue, Nov 4

Fabien accepted D18866: guix: use GCC 13.3.0 for base toolchain..
Tue, Nov 4, 19:04
Fabien accepted D18865: [depends] bump Makefile to c++20.
Tue, Nov 4, 19:03
Fabien accepted D18862: [cpp] move to c++20.
Tue, Nov 4, 13:20
Fabien added a comment to D18862: [cpp] move to c++20.
In D18862#430161, @PiRK wrote:

i rebased to check whether d18664 fixes all the seeder issues, but we still have a guix-osx issue to deal with.

Tue, Nov 4, 08:38
Fabien accepted D18864: [seeder] avoid creating copy in loop variable.

Macro likestamp:

Tue, Nov 4, 08:37
Fabien accepted D18863: bench: Avoid deprecated use of volatile +=.
Tue, Nov 4, 08:35
Fabien accepted D18861: refactor: Remove redundant checks in compat/assumptions.h.
Tue, Nov 4, 08:35

Mon, Nov 3

Fabien added a comment to D18862: [cpp] move to c++20.

There is also the chronik/CMakeLists.txt that needs to bump the version

Mon, Nov 3, 16:58
Fabien added a comment to D18862: [cpp] move to c++20.

@bot guix-linux guix-win guix-osx

Mon, Nov 3, 16:57
Fabien accepted D18858: kernel: De-globalize script execution cache hasher.
Mon, Nov 3, 09:01
Fabien accepted D18856: kernel: De-globalize script execution cache.
In D18856#430056, @PiRK wrote:

add lock annotation and add back compile time assertion for IsKeyInScriptCache and AddKeyInScriptCache

Mon, Nov 3, 08:45

Oct 31 2025

Fabien accepted D18859: Expose CSignatureCache class in header.
Oct 31 2025, 20:51
Fabien requested changes to D18856: kernel: De-globalize script execution cache.

The lock issue is due to missing clang annotations, if you add them you should be fine

Oct 31 2025, 20:50
Fabien accepted D18860: kernel: De-globalize signature cache.
Oct 31 2025, 20:40
Fabien requested changes to D18858: kernel: De-globalize script execution cache hasher.

Then you need to pass the hasher as a const ref and not copy it

Oct 31 2025, 17:40
Fabien added inline comments to D18860: kernel: De-globalize signature cache.
Oct 31 2025, 16:34
Fabien requested changes to D18859: Expose CSignatureCache class in header.
Oct 31 2025, 16:29
Fabien requested changes to D18858: kernel: De-globalize script execution cache hasher.

wrong commit

Oct 31 2025, 16:27
Fabien accepted D18857: [ecash-agora] Pin the dependencies with updated dockerfile.

TIL npm view

Oct 31 2025, 16:26
Fabien accepted D18855: validation: Don't error if maxsigcachesize exceeds uint32::max.
Oct 31 2025, 16:21
Fabien accepted D18854: [ecash-agora] Patch dockerfile again, bump version.
Oct 31 2025, 14:37
Fabien accepted D18853: [ecash-agora] Patch CI for prod install of ecash-wallet.
Oct 31 2025, 12:40
Fabien added inline comments to D18853: [ecash-agora] Patch CI for prod install of ecash-wallet.
Oct 31 2025, 08:34

Oct 30 2025

Fabien requested changes to D18853: [ecash-agora] Patch CI for prod install of ecash-wallet.
Oct 30 2025, 21:50
Fabien accepted D18849: script: (optimization) introduce sighash midstate caching.
Oct 30 2025, 20:55
Fabien accepted D18852: [ecash-agora] Specify ecash-wallet as a dep and not a dev dep.
Oct 30 2025, 20:52
Fabien accepted D18848: script: (refactor) prepare for introducing sighash midstate cache.
Oct 30 2025, 20:51
Fabien accepted D18851: test: add vectors for the SIGHASH single bug.
Oct 30 2025, 20:51
Fabien accepted D18850: [e.cash] Implement google analytics.
Oct 30 2025, 11:29
Fabien accepted D18837: [ecash-wallet] Properly construct postage tx to support serialization and server deser.
Oct 30 2025, 11:28
Fabien requested changes to D18850: [e.cash] Implement google analytics.
Oct 30 2025, 09:57
Fabien requested changes to D18849: script: (optimization) introduce sighash midstate caching.
Oct 30 2025, 09:54
Fabien added inline comments to D18848: script: (refactor) prepare for introducing sighash midstate cache.
Oct 30 2025, 09:33
Fabien requested changes to D18848: script: (refactor) prepare for introducing sighash midstate cache.
Oct 30 2025, 09:30
Fabien requested changes to D18837: [ecash-wallet] Properly construct postage tx to support serialization and server deser.
Oct 30 2025, 09:08
Fabien accepted D18848: script: (refactor) prepare for introducing sighash midstate cache.
Oct 30 2025, 08:52

Oct 29 2025

Fabien accepted D18845: [ecash-agora] take method only supports taking by the taking wallet.
Oct 29 2025, 10:28
Fabien accepted D18846: [ecash-agora] Patch CI tests by better organizing test wallet sats.
Oct 29 2025, 10:27

Oct 28 2025

Fabien accepted D18844: [ecash-lib] Patch ecash-agora CI deployments.
Oct 28 2025, 12:45
Fabien accepted D18843: init: cap -maxmempool and -dbcache on 32-bit systems.
Oct 28 2025, 11:07
Fabien accepted D18842: [ecash-agora] Add a cancel method to AgoraOffer that can use ecash-wallet to cancel a partial or oneshot offer.
Oct 28 2025, 08:38

Oct 27 2025

Fabien accepted D18833: [ecash-agora, ecash-wallet, ecash-lib] Add a new take method to the AgoraOffer class that automatically builds and broadcasts an acceptTx.
Oct 27 2025, 20:32
Fabien accepted D18841: [ecash-wallet] Return the sats selection strategy used to selectUtxos from the selectUtxos method.
Oct 27 2025, 20:32
Fabien added inline comments to D18833: [ecash-agora, ecash-wallet, ecash-lib] Add a new take method to the AgoraOffer class that automatically builds and broadcasts an acceptTx.
Oct 27 2025, 19:32
Fabien accepted D18840: [ecash-wallet] Export the BuiltAction class so it is available for ecash-agora take method.
Oct 27 2025, 19:31
Fabien accepted D18839: [ecash-wallet] Patch ts issue to stay consistent with defined interface.
Oct 27 2025, 17:19
Fabien accepted D18834: [ecash-wallet] Support chained txs to allow direct minting of NFTs without a fan-out tx.
Oct 27 2025, 14:32
First
Prev
Next