Page MenuHomePhabricator
Feed Advanced Search

Wed, Nov 19

Fabien committed rABC0c4d7cd8ab6d: [guix] Add the proof-manager-cli to the release (authored by Fabien).
[guix] Add the proof-manager-cli to the release
Wed, Nov 19, 08:43
Fabien requested changes to D18960: [Cashtab, chronik-client] Add and implement ws methods to support mobile app backgrounding.

I understand the problem but I don't think this is a good approach for several reasons:

  • It uses low level ws state that should be handled by chronik-client, if anything made accessible
  • We have a keepalive already, and websocket has pings which seems a better/cleaner option
  • You have events when the app goes to/resumes from background. Why do you need to check the ws status at all ? Can't you just blindly resubscribe? Do you get twice the notifications if subscribed twice to the same things ?
Wed, Nov 19, 08:32

Tue, Nov 18

Fabien accepted D18952: net: Serve blocks directly from disk when possible.
Tue, Nov 18, 20:56
Fabien added inline comments to D18958: [cmake] Add a target for the proof-manager-cli tool.
Tue, Nov 18, 20:46
Fabien accepted D18957: bench: add readblock benchmark.
Tue, Nov 18, 16:25
teamcity awarded D18959: [guix] Add the proof-manager-cli to the release a Haypence token.
Tue, Nov 18, 16:24
Fabien added a comment to D18959: [guix] Add the proof-manager-cli to the release.

@bot guix-linux guix-osx guix-win

Tue, Nov 18, 16:24
Fabien requested review of D18959: [guix] Add the proof-manager-cli to the release.
Tue, Nov 18, 16:22
Fabien requested review of D18958: [cmake] Add a target for the proof-manager-cli tool.
Tue, Nov 18, 16:21
Fabien updated the diff for D18956: [proof-manager-cli] Rename the proof-manager executable to proof-manager-cli.

Rename in tests

Tue, Nov 18, 16:13
Fabien planned changes to D18956: [proof-manager-cli] Rename the proof-manager executable to proof-manager-cli.
Tue, Nov 18, 16:12
Fabien requested review of D18956: [proof-manager-cli] Rename the proof-manager executable to proof-manager-cli.
Tue, Nov 18, 15:27
Fabien accepted D18953: [cashtab-faucet] Reduce XEC reward.
Tue, Nov 18, 14:42
Fabien accepted D18954: [cashtab-faucet] Tighten IP rate limits.
Tue, Nov 18, 14:41
Fabien added a comment to D18952: net: Serve blocks directly from disk when possible.

@bot build-ibd

Tue, Nov 18, 13:14
Fabien accepted D18951: [cashtab-faucet, cashtab] Use recaptcha v2 instead of v3 for harder challenges.
Tue, Nov 18, 12:38
Fabien accepted D18950: [Cashtab] Automatically update android app version from package dot json.
Tue, Nov 18, 10:56
Fabien accepted D18948: Use DataStream where possible.
Tue, Nov 18, 10:52
Fabien accepted D18947: streams: Add DataStream without ser-type and ser-version.
Tue, Nov 18, 10:45
Fabien added a comment to D18947: streams: Add DataStream without ser-type and ser-version.

@bot build-master build-chronik

Tue, Nov 18, 10:38
Fabien closed D18949: [cmake] Move the common rust configuration to its own file.
Tue, Nov 18, 08:57
Fabien committed rABC0ae62a8a7c4d: [cmake] Move the common rust configuration to its own file (authored by Fabien).
[cmake] Move the common rust configuration to its own file
Tue, Nov 18, 08:57

Mon, Nov 17

Fabien requested review of D18949: [cmake] Move the common rust configuration to its own file.
Mon, Nov 17, 16:08
Fabien accepted D18946: test: use a regexp in ecash-agora test.
Mon, Nov 17, 09:33
Fabien committed rABC797d9c6e632c: depends: Update Boost download link (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
depends: Update Boost download link
Mon, Nov 17, 08:52
Fabien closed D18945: depends: Update Boost download link.
Mon, Nov 17, 08:52
Fabien requested review of D18945: depends: Update Boost download link.
Mon, Nov 17, 08:48

Sat, Nov 15

Fabien closed D18935: [cmake] Remove Applications symlink in the OSX zip.
Sat, Nov 15, 20:53
Fabien committed rABCbf082129f98a: [cmake] Remove Applications symlink in the OSX zip (authored by Fabien).
[cmake] Remove Applications symlink in the OSX zip
Sat, Nov 15, 20:53
Fabien accepted D18944: remove unused RPCSerializationFlags() function.
Sat, Nov 15, 20:34
Fabien closed D18943: [website] Update the upgrade page after november 15 2025 activation.
Sat, Nov 15, 15:50
Fabien committed rABCWEB41989db30f2a: [website] Update the upgrade page after november 15 2025 activation (authored by Fabien).
[website] Update the upgrade page after november 15 2025 activation
Sat, Nov 15, 15:50
Fabien accepted D18941: Add checkpoints after the November 2025 network upgrade.
Sat, Nov 15, 15:08
Fabien requested review of D18943: [website] Update the upgrade page after november 15 2025 activation.
Sat, Nov 15, 15:08
Fabien accepted D18939: [e.cash] Update Upgrade page for completed upgrade - 2025-11-15.
Sat, Nov 15, 14:05
Fabien accepted D18938: [Cashtab] Use 64-bit ints for agora offers.
Sat, Nov 15, 14:00
Fabien accepted D18936: [Cashtab] Change the app id to com.cashtab.app.
Sat, Nov 15, 09:06

Fri, Nov 14

Fabien accepted D18931: [Cashtab] Add a script to build a signed release.
Fri, Nov 14, 13:50
Fabien requested review of D18935: [cmake] Remove Applications symlink in the OSX zip.
Fri, Nov 14, 13:47
Fabien accepted D18930: [test] A non-standard transaction which is also consensus-invalid should return the consensus error.
Fri, Nov 14, 12:09
Fabien accepted D18929: test: ensure reason is checked for invalid blocks rejection.
Fri, Nov 14, 12:08
Fabien requested changes to D18930: [test] A non-standard transaction which is also consensus-invalid should return the consensus error.
Fri, Nov 14, 10:08
Fabien added a comment to D18930: [test] A non-standard transaction which is also consensus-invalid should return the consensus error.

Same as D18929 the test plan is not good

Fri, Nov 14, 10:08
Fabien requested changes to D18929: test: ensure reason is checked for invalid blocks rejection.

The test plan is not covering the change

Fri, Nov 14, 10:07
Fabien accepted D18929: test: ensure reason is checked for invalid blocks rejection.
Fri, Nov 14, 10:07
Fabien accepted D18928: [test] add a test for a transaction failing specifically for scriptsig-not-pushonly.
Fri, Nov 14, 10:06
Fabien accepted D18927: test: refactor: deduplicate ECDSA signing for tx inputs.
Fri, Nov 14, 10:03
Fabien requested changes to D18931: [Cashtab] Add a script to build a signed release.
Fri, Nov 14, 09:56
Fabien accepted D18932: [ecash-wallet] Make sure that no specification of isMintBaton is treated the same as specifying false for isMintBaton.
Fri, Nov 14, 09:51

Thu, Nov 13

Fabien accepted D18925: [ecash-agora] Patch version bump for latest ecash-wallet dep.

Can this be automated ?

Thu, Nov 13, 08:18
Fabien added a comment to D18926: [cashtab-faucet] Tweak some recaptcha settings to see if it slows drain attacks.

if that doesn't work we should consider another kind of captcha

Thu, Nov 13, 08:18
Fabien accepted D18926: [cashtab-faucet] Tweak some recaptcha settings to see if it slows drain attacks.
Thu, Nov 13, 08:17

Wed, Nov 12

Fabien accepted D18924: [ecash-wallet] Remove consumed postage utxos in addFuelAndSign.
Wed, Nov 12, 21:55
Fabien accepted D18923: [Cashtab] Do not allow users to list Firma below the bid price.
Wed, Nov 12, 20:02
Fabien requested changes to D18924: [ecash-wallet] Remove consumed postage utxos in addFuelAndSign.
Wed, Nov 12, 19:53
Fabien accepted D18922: [e.cash] Remove instant exchange widgets.
Wed, Nov 12, 08:34
Fabien added a comment to D18922: [e.cash] Remove instant exchange widgets.

@bot preview-e.cash

Wed, Nov 12, 08:30

Tue, Nov 11

Fabien accepted D18920: [ecash-wallet] Do not add unnecessary postage.
Tue, Nov 11, 20:38
Fabien accepted D18867: [ecash-wallet, ecash-lib] Support chained XEC txs for XEC-only actions that would otherwise exceed the broadcast size limit.
Tue, Nov 11, 19:12
Fabien closed D18919: [e.cash] Remove Zergpool from the mining pool list.
Tue, Nov 11, 19:07
Fabien committed rABC980898b99b1e: [e.cash] Remove Zergpool from the mining pool list (authored by Fabien).
[e.cash] Remove Zergpool from the mining pool list
Tue, Nov 11, 19:07
Fabien added inline comments to D18867: [ecash-wallet, ecash-lib] Support chained XEC txs for XEC-only actions that would otherwise exceed the broadcast size limit.
Tue, Nov 11, 10:00
Fabien requested review of D18919: [e.cash] Remove Zergpool from the mining pool list.
Tue, Nov 11, 09:50

Mon, Nov 10

Fabien accepted D18918: [ecash-lib] Export new constants and interfaces to be used for chained txs in ecash-wallet.
Mon, Nov 10, 20:45
Fabien accepted D18917: [lint] enable FLY002 checks for the Electrum codebase.
Mon, Nov 10, 20:43
Fabien accepted D18915: [Cashtab] Add star shard.
Mon, Nov 10, 12:59
Fabien accepted D18913: [lint] replace flynt linter with ruff.
Mon, Nov 10, 12:57
Fabien accepted D18912: [lint] add a blank line after module level docstring in python files.
Mon, Nov 10, 12:52
Fabien accepted D18905: [lint] replace flake8 with ruff.
Mon, Nov 10, 12:51
Fabien accepted D18914: contrib: testgen: remove redundant base58 implementation.
Mon, Nov 10, 12:51
Fabien requested changes to D18867: [ecash-wallet, ecash-lib] Support chained XEC txs for XEC-only actions that would otherwise exceed the broadcast size limit.
  • would also split out the ecash-lib changes here into a separate diff with version bump and land that before this lands
Mon, Nov 10, 09:55
Fabien accepted D18907: [lint] Find function calls in default arguments.
Mon, Nov 10, 09:49
Fabien accepted D18906: [lint] remove isort linter, enable isort in ruff.
Mon, Nov 10, 09:43
Fabien requested changes to D18905: [lint] replace flake8 with ruff.
Mon, Nov 10, 09:37
Fabien accepted D18904: [lint] switch from Black to Ruff for python code formatting.
Mon, Nov 10, 09:23
Fabien accepted D18903: [lint] bump black to >=25.
Mon, Nov 10, 09:10

Fri, Nov 7

Fabien accepted D18911: [doc] Bump minimum GCC dependency.
Fri, Nov 7, 22:00
Fabien accepted D18910: [doc] Cleanup minimum supported Debian versions.
Fri, Nov 7, 22:00
Fabien requested changes to D18910: [doc] Cleanup minimum supported Debian versions.
Fri, Nov 7, 20:03
Fabien requested changes to D18903: [lint] bump black to >=25.

You need to update the CONTRIBUTING.md document accordingly

Fri, Nov 7, 15:19
Fabien accepted D18902: [e.cash] Add link to charts under explorer in tools menu.
Fri, Nov 7, 15:18
Fabien accepted D18899: guix: move *-check.py scripts under contrib/guix.
Fri, Nov 7, 14:08
Fabien accepted D18901: [metachronik] Remove CI and document prod deployments.
Fri, Nov 7, 13:40
Fabien accepted D18900: deps: bump lief to 0.16.6.
Fri, Nov 7, 13:36
Fabien added a comment to D18899: guix: move *-check.py scripts under contrib/guix.

why did you skip the linter ?

Fri, Nov 7, 13:33
Fabien accepted D18898: guix: remove test-security/symbol-check scripts.

NVM it's not the scripts but their tests which are worthless

Fri, Nov 7, 13:31
Fabien requested changes to D18898: guix: remove test-security/symbol-check scripts.

Please don't do this until we backported all the security improvements first. They serve as tests for these features in the meantime

Fri, Nov 7, 13:30

Thu, Nov 6

Fabien accepted D18896: test: fix constructor of msg_tx.
Thu, Nov 6, 20:16
Fabien accepted D18897: [metachronik] Another railway CI fix attempt.
Thu, Nov 6, 19:52
Fabien added inline comments to D18897: [metachronik] Another railway CI fix attempt.
Thu, Nov 6, 19:14
Fabien requested changes to D18867: [ecash-wallet, ecash-lib] Support chained XEC txs for XEC-only actions that would otherwise exceed the broadcast size limit.
Thu, Nov 6, 15:24
Fabien accepted D18894: rpc: include verbose reject-details field in testmempoolaccept response.
Thu, Nov 6, 14:53
Fabien accepted D18893: Bump version to 0.32.3.
Thu, Nov 6, 14:47
Fabien committed rABCWEBb09cf82527bb: [website] Update the upgrade banner for the Nov. 15 2025 upgrade (authored by Fabien).
[website] Update the upgrade banner for the Nov. 15 2025 upgrade
Thu, Nov 6, 14:47
Fabien closed D18895: [website] Update the upgrade banner for the Nov. 15 2025 upgrade.
Thu, Nov 6, 14:47
Fabien requested review of D18895: [website] Update the upgrade banner for the Nov. 15 2025 upgrade.
Thu, Nov 6, 14:40
Fabien accepted D18892: Remove broken and unused CDataStream methods.
Thu, Nov 6, 11:11
Fabien accepted D18891: test: Fix sanitizer suppresions in streams_tests.
Thu, Nov 6, 10:38
Fabien committed rABCa056c0d2ddd6: Add release notes for v0.32.2 (authored by Fabien).
Add release notes for v0.32.2
Thu, Nov 6, 10:01
Fabien closed D18887: test: don't throw from the destructor of DebugLogHelper.
Thu, Nov 6, 09:47