Page MenuHomePhabricator
Feed Advanced Search

Jan 7 2021

deadalnix updated the diff for D8812: [cashtab] Update webpack.

rebase

Jan 7 2021, 05:52
deadalnix updated the diff for D8814: [cashtab] Update file-loader and fs-extra.

rebase

Jan 7 2021, 05:51
deadalnix updated the diff for D8814: [cashtab] Update file-loader and fs-extra.

rebase

Jan 7 2021, 05:50
deadalnix updated the diff for D8813: [cashtab] Upgrade eslint.

rebase

Jan 7 2021, 05:46
deadalnix updated the diff for D8818: [cashtab] Upgrade mini-css-extract-plugin.

rebase

Jan 7 2021, 05:45
deadalnix closed D8817: [cashtab] Downgrade terser-webpack-plugin to use a supported version of webpack.
Jan 7 2021, 05:44
deadalnix committed rABCa4b9fcd7c15f: [cashtab] Downgrade terser-webpack-plugin to use a supported version of webpack (authored by deadalnix).
[cashtab] Downgrade terser-webpack-plugin to use a supported version of webpack
Jan 7 2021, 05:44
deadalnix closed D8816: Do not format autogenerated files.
Jan 7 2021, 05:43
deadalnix committed rABCcb1e74da0403: Do not format autogenerated files (authored by deadalnix).
Do not format autogenerated files
Jan 7 2021, 05:43
deadalnix closed D8815: [cashtab] Update fbt.
Jan 7 2021, 05:43
deadalnix committed rABCc34cf16f70f8: [cashtab] Update fbt (authored by deadalnix).
[cashtab] Update fbt
Jan 7 2021, 05:43
deadalnix requested review of D8818: [cashtab] Upgrade mini-css-extract-plugin.
Jan 7 2021, 05:37
deadalnix requested review of D8817: [cashtab] Downgrade terser-webpack-plugin to use a supported version of webpack.
Jan 7 2021, 05:25
deadalnix updated the diff for D8812: [cashtab] Update webpack.

Stay on webpack 4

Jan 7 2021, 05:13
deadalnix updated the diff for D8816: Do not format autogenerated files.

Remove useless prettierignore

Jan 7 2021, 02:35
deadalnix requested review of D8816: Do not format autogenerated files.
Jan 7 2021, 02:34
deadalnix requested review of D8815: [cashtab] Update fbt.
Jan 7 2021, 02:16
deadalnix requested review of D8814: [cashtab] Update file-loader and fs-extra.
Jan 7 2021, 01:56
deadalnix updated the diff for D8813: [cashtab] Upgrade eslint.

Remove typescript-eslint modules, as we don't use typescript

Jan 7 2021, 01:45
deadalnix requested review of D8813: [cashtab] Upgrade eslint.
Jan 7 2021, 01:38
deadalnix requested review of D8812: [cashtab] Update webpack.
Jan 7 2021, 01:17
deadalnix closed D8809: Downgrade react-test-renderer.
Jan 7 2021, 01:13
deadalnix committed rABC3eb41051dc53: Downgrade react-test-renderer (authored by deadalnix).
Downgrade react-test-renderer
Jan 7 2021, 01:12
deadalnix requested review of D8811: [cashtab] Upgrade node modules.
Jan 7 2021, 00:01
deadalnix added a comment to D8810: [cashtab] Fix fbt generating translation files.

There is no explanation as to what problem this solves and why does it solve it.

Jan 7 2021, 00:01
deadalnix requested changes to D8810: [cashtab] Fix fbt generating translation files.

There is no explanation as to what problem this solves and why does it solve it.

Jan 7 2021, 00:00

Jan 6 2021

deadalnix abandoned D8807: [cashtab] Move qrcode to react-qr-code.
Jan 6 2021, 23:52
deadalnix updated the diff for D8809: Downgrade react-test-renderer.

rebase

Jan 6 2021, 23:51
deadalnix requested review of D8809: Downgrade react-test-renderer.
Jan 6 2021, 22:29
deadalnix requested review of D8807: [cashtab] Move qrcode to react-qr-code.
Jan 6 2021, 18:05
deadalnix accepted D8765: Refactor from path 145/245 to path 1899 with migration support.
Jan 6 2021, 16:36
deadalnix closed D8780: Pass chain params explicitely to EncodeSecret and DecodeSecret.
Jan 6 2021, 00:04
deadalnix committed rABC9290166fe3a2: Pass chain params explicitely to EncodeSecret and DecodeSecret (authored by deadalnix).
Pass chain params explicitely to EncodeSecret and DecodeSecret
Jan 6 2021, 00:04

Jan 5 2021

deadalnix accepted D8786: Convert CCompactSize to proper formatter.
Jan 5 2021, 17:22
deadalnix accepted D8785: [CMAKE] Lower boost test suites verbosity.
Jan 5 2021, 17:08
deadalnix accepted D4150: Merge #12218: net: Move misbehaving logging to net logging category.
Jan 5 2021, 00:48

Jan 4 2021

deadalnix requested review of D8780: Pass chain params explicitely to EncodeSecret and DecodeSecret.
Jan 4 2021, 20:17
deadalnix closed D8769: [avalanche] Add an handy way to build the quorum in the test.
Jan 4 2021, 19:08
deadalnix committed rABC65dc830e7675: [avalanche] Add an handy way to build the quorum in the test (authored by deadalnix).
[avalanche] Add an handy way to build the quorum in the test
Jan 4 2021, 19:08

Jan 3 2021

deadalnix requested review of D8769: [avalanche] Add an handy way to build the quorum in the test.
Jan 3 2021, 23:54
deadalnix accepted D8768: Fix a violation of C++ standard rules that unions cannot be switched..
Jan 3 2021, 15:47

Jan 2 2021

deadalnix added inline comments to D8693: [CashTab] Expo - Initial setup with loading and webview. Working only on Android.
Jan 2 2021, 22:01
deadalnix requested changes to D8765: Refactor from path 145/245 to path 1899 with migration support.

It doesn't looks like there is a test for the migration, why?

Jan 2 2021, 20:52
deadalnix requested changes to D8673: Add -overridednsseed for testing DNS seed behavior.
Jan 2 2021, 20:42
deadalnix requested changes to D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

this patch needs to be several patches.

Jan 2 2021, 20:38
deadalnix accepted D8766: add: test that transactions expire from mempool.

More tests, always a win.

Jan 2 2021, 19:04
deadalnix accepted D8767: scripted-diff: Wallet: Rename incorrectly named *UsedDestination.
Jan 2 2021, 19:03

Dec 30 2020

deadalnix accepted D8764: gui: Fix race in WalletModel::pollBalanceChanged.
Dec 30 2020, 20:57
deadalnix accepted D8763: Get rid of VARINT default argument.
Dec 30 2020, 20:56

Dec 29 2020

deadalnix requested changes to D8762: [backport#16658] validation: Rename CheckInputs to CheckInputScripts.

What about the integration tests?

Dec 29 2020, 23:26

Dec 23 2020

deadalnix accepted D8695: Use rolling bloom filter of recent block tx's for AlreadyHave() check.
Dec 23 2020, 01:20
deadalnix added inline comments to D8695: Use rolling bloom filter of recent block tx's for AlreadyHave() check.
Dec 23 2020, 01:19

Dec 20 2020

deadalnix closed D8708: Properly use TxId in txindex.cpp.
Dec 20 2020, 17:14
deadalnix committed rABC0806684f9076: Properly use TxId in txindex.cpp (authored by deadalnix).
Properly use TxId in txindex.cpp
Dec 20 2020, 17:14
deadalnix closed D8709: Add a TSAN suppression for leveldb.
Dec 20 2020, 16:54
deadalnix committed rABC13d29eee30dc: Add a TSAN suppression for leveldb (authored by deadalnix).
Add a TSAN suppression for leveldb
Dec 20 2020, 16:54

Dec 19 2020

deadalnix requested review of D8709: Add a TSAN suppression for leveldb.
Dec 19 2020, 13:51
deadalnix requested changes to D8695: Use rolling bloom filter of recent block tx's for AlreadyHave() check.
Dec 19 2020, 13:17
deadalnix requested review of D8708: Properly use TxId in txindex.cpp.
Dec 19 2020, 05:54

Dec 17 2020

deadalnix accepted D8680: Revert "[GITIAN] Build for both chains".
Dec 17 2020, 14:17

Dec 16 2020

deadalnix requested changes to D8680: Revert "[GITIAN] Build for both chains".

Please check the build error

Dec 16 2020, 20:39
deadalnix accepted D8679: Refactor extension files to support updated antd.
Dec 16 2020, 20:39
deadalnix accepted D8682: Revert "[AUR] Add PKGBUILD files for the BCHN network variant".
Dec 16 2020, 20:38
deadalnix accepted D8681: Revert "Build the debian package for both chains".
Dec 16 2020, 20:38
deadalnix accepted D8683: Good bye BCH.
Dec 16 2020, 20:36
deadalnix requested changes to D8675: decouple miner fund from `bitcoincash:` prefix and fix test.
Dec 16 2020, 17:10

Dec 15 2020

deadalnix closed D8640: [cmake] Allow to configure the linker used..
Dec 15 2020, 16:29
deadalnix committed rABC9319f1edad63: [cmake] Allow to configure the linker used. (authored by deadalnix).
[cmake] Allow to configure the linker used.
Dec 15 2020, 16:29
deadalnix updated the diff for D8640: [cmake] Allow to configure the linker used..

Update as per comments

Dec 15 2020, 15:39
deadalnix updated the diff for D8640: [cmake] Allow to configure the linker used..

use gold by default with gcc, lld with clang

Dec 15 2020, 12:58
deadalnix requested changes to D8673: Add -overridednsseed for testing DNS seed behavior.
Dec 15 2020, 02:33
deadalnix requested changes to D5380: [seeder] Require good seeds to have latest checkpoint.

This looks good overall, but you really should refactor the state machine/message processing a bit. Most of the logic can stay similar.

Dec 15 2020, 02:31

Dec 14 2020

deadalnix accepted D8601: Re-enable SLPA transactions in CashTab and fix notification bug.
Dec 14 2020, 21:43
deadalnix closed D8670: Add a dumpcoins RPC to dump the coins available in the wallet.
Dec 14 2020, 00:10
deadalnix committed rABC67df722289af: Add a dumpcoins RPC to dump the coins available in the wallet (authored by deadalnix).
Add a dumpcoins RPC to dump the coins available in the wallet
Dec 14 2020, 00:10

Dec 13 2020

deadalnix updated the diff for D8670: Add a dumpcoins RPC to dump the coins available in the wallet.

Update test comment

Dec 13 2020, 17:24
deadalnix closed D8669: nits in the wallet and descriptor code.
Dec 13 2020, 17:21
deadalnix committed rABC5b0538e80eb3: nits in the wallet and descriptor code (authored by deadalnix).
nits in the wallet and descriptor code
Dec 13 2020, 17:21
deadalnix planned changes to D8671: Add a --descriptors option to various tests.

Broken tests

Dec 13 2020, 16:22
deadalnix updated the diff for D8670: Add a dumpcoins RPC to dump the coins available in the wallet.

Fix no wallet build

Dec 13 2020, 16:10
deadalnix updated the diff for D8671: Add a --descriptors option to various tests.

Fix lint in key.py

Dec 13 2020, 16:01
deadalnix planned changes to D8671: Add a --descriptors option to various tests.

There are a few lint error, but most importantly, a couple of test are broken.

Dec 13 2020, 15:59
deadalnix requested review of D8671: Add a --descriptors option to various tests.
Dec 13 2020, 15:59
deadalnix requested review of D8670: Add a dumpcoins RPC to dump the coins available in the wallet.
Dec 13 2020, 15:26
deadalnix requested review of D8669: nits in the wallet and descriptor code.
Dec 13 2020, 01:52
deadalnix updated the diff for D8640: [cmake] Allow to configure the linker used..

rebase

Dec 13 2020, 00:23
deadalnix closed D8667: wallet: allow transaction without change if keypool is empty.
Dec 13 2020, 00:22
deadalnix committed rABC0fa7d0acde05: wallet: allow transaction without change if keypool is empty (authored by Sjors Provoost <sjors@sprovoost.nl>).
wallet: allow transaction without change if keypool is empty
Dec 13 2020, 00:22

Dec 12 2020

deadalnix accepted D8668: Bump version to 0.22.10.
Dec 12 2020, 18:06
deadalnix accepted D8665: [backport#16044] qt: fix opening bitcoin.conf via Preferences on macOS.
Dec 12 2020, 16:17
deadalnix accepted D8664: [backport#16090] Qt: Add vertical spacer to peer detail widget.
Dec 12 2020, 16:16
deadalnix requested review of D8667: wallet: allow transaction without change if keypool is empty.
Dec 12 2020, 02:00

Dec 11 2020

deadalnix accepted D8644: refactor: Pass ArgsManager into functions that register args.

Sorry, I missed that. Thanks, good job.

Dec 11 2020, 17:29
deadalnix accepted D8646: Remove gArgs global from init.
Dec 11 2020, 17:28
deadalnix accepted D8663: init: Stop indexes on shutdown after ChainStateFlushed callback..
Dec 11 2020, 17:26
deadalnix accepted D6283: [seeder] Request headers from new connections.
Dec 11 2020, 17:25

Dec 10 2020

deadalnix accepted D8645: rpc: Make gettxoutsetinfo/GetUTXOStats interruptible.
Dec 10 2020, 15:43
deadalnix requested changes to D8646: Remove gArgs global from init.
Dec 10 2020, 15:39
deadalnix requested changes to D8644: refactor: Pass ArgsManager into functions that register args.

Make sure you update the seeder too.

Dec 10 2020, 15:37
deadalnix updated the diff for D8640: [cmake] Allow to configure the linker used..

Address comments

Dec 10 2020, 13:24