Page MenuHomePhabricator
Feed Advanced Search

May 6 2019

Herald added a reviewer for D2941: Backport dev notes on RPC: Restricted Project.
May 6 2019, 20:52
deadalnix updated the diff for D2002: Disallow using addresses in createmultisig.

Update as per request

May 6 2019, 20:43
deadalnix updated the diff for D2002: Disallow using addresses in createmultisig.

Update version numbers as expected and address other comments.

May 6 2019, 13:15
deadalnix planned changes to D2002: Disallow using addresses in createmultisig.

This was in pretty bad shape, I'll run a round of review myself before asking other to do so.

May 6 2019, 12:16
deadalnix updated the diff for D2002: Disallow using addresses in createmultisig.

Update with whatever I have

May 6 2019, 12:16

May 5 2019

deadalnix requested changes to D2925: test: Stop txindex thread before calling destructor.

Please merge that with the test and the creation go TxIndex. We do not benefit from commiting faulty code and then fixing it.

May 5 2019, 21:44
deadalnix accepted D2918: test: Plug memory leaks and stack-use-after-scope.
May 5 2019, 17:04
deadalnix added a comment to D2904: [index] Create new TxIndex class..

You also need to bring test/txindex_tests.cpp with it.

May 5 2019, 17:04
deadalnix requested changes to D2904: [index] Create new TxIndex class..

No space in PR12345. please fix description.

May 5 2019, 16:49
deadalnix requested changes to D2892: [CMAKE] Add an option to enable the glibc compatibility features.
May 5 2019, 16:48

May 4 2019

deadalnix accepted D2923: fix out-of-bounds memory write in key_tests.
May 4 2019, 18:26
deadalnix accepted D2795: Add additional unit tests for segwit recovery.
May 4 2019, 18:26
deadalnix accepted D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration.
May 4 2019, 17:50
deadalnix requested changes to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

If you don't need a new API, then don't change the API.

May 4 2019, 17:49
deadalnix updated subscribers of D2894: Fix memory leaks in qt/guiutil.cpp.

It does looks like @CCulianu 's patch and the patch you backport where intended to fix the same issue. The mix of both that you are proposing here makes zero sense.

May 4 2019, 17:48
deadalnix requested changes to D2894: Fix memory leaks in qt/guiutil.cpp.

Nos pace in PR12345 so this can be grepped or. Please edit description to reflect this.

May 4 2019, 17:42
deadalnix requested changes to D2918: test: Plug memory leaks and stack-use-after-scope.

And what about src/test/checkqueue_tests.cpp ?

May 4 2019, 17:41

Apr 24 2019

deadalnix requested changes to D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.
Apr 24 2019, 21:42
deadalnix requested changes to D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.
Apr 24 2019, 19:43

Apr 23 2019

deadalnix accepted D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.
Apr 23 2019, 20:53
deadalnix accepted D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.
Apr 23 2019, 20:53
deadalnix accepted D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.
Apr 23 2019, 20:50

Apr 22 2019

deadalnix accepted D2849: Use angle bracket in include for test (part 5).
Apr 22 2019, 18:39

Apr 20 2019

deadalnix accepted D2851: Nits in abc-high_priority_transaction.py.
Apr 20 2019, 21:08
deadalnix requested changes to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Apr 20 2019, 14:56
deadalnix accepted D2848: Use angle bracket in include for test (part 4).
Apr 20 2019, 14:51
deadalnix requested changes to D2849: Use angle bracket in include for test (part 5).
Apr 20 2019, 14:51
deadalnix accepted D2850: Use angle bracket in include for zmq.
Apr 20 2019, 14:50
deadalnix requested changes to D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.
Apr 20 2019, 14:49
deadalnix committed rABC2564826f8528: [schnorr] Refactor the signature process in reusable component (authored by deadalnix).
[schnorr] Refactor the signature process in reusable component
Apr 20 2019, 13:43
deadalnix closed D2457: [schnorr] Refactor the signature process in reusable component.
Apr 20 2019, 13:43
deadalnix committed rABC640cdb2cb6a8: Use angle bracket in rpcwallet and rpcdump (authored by deadalnix).
Use angle bracket in rpcwallet and rpcdump
Apr 20 2019, 13:29
deadalnix closed D2844: Use angle bracket in rpcwallet and rpcdump.
Apr 20 2019, 13:29

Apr 19 2019

deadalnix accepted D2843: Use angle bracket in include for test (part 3).
Apr 19 2019, 21:12
Herald added a reviewer for D2844: Use angle bracket in rpcwallet and rpcdump: Restricted Project.
Apr 19 2019, 20:56
deadalnix accepted D2841: Use angle bracket in include for tests (part 2).
Apr 19 2019, 19:23
deadalnix accepted D2839: Use angle bracket in include for tests (part 1).
Apr 19 2019, 16:54
deadalnix committed rABCf9731764dd39: Update seeds (authored by deadalnix).
Update seeds
Apr 19 2019, 16:43
deadalnix closed D2840: Update seeds.
Apr 19 2019, 16:43
deadalnix requested changes to D2839: Use angle bracket in include for tests (part 1).
Apr 19 2019, 14:35
deadalnix committed rABC58e83e2c1128: Remove the boost/algorithm/string/case_conv.hpp dependency (authored by 251 <13120787+251Labs@users.noreply.github.com>).
Remove the boost/algorithm/string/case_conv.hpp dependency
Apr 19 2019, 14:26
deadalnix closed D2825: Remove the boost/algorithm/string/case_conv.hpp dependency.
Apr 19 2019, 14:26
deadalnix committed rABC8080bab0d20c: scripted-diff: Replace NET_TOR with NET_ONION (authored by wodry <wodry@users.noreply.github.com>).
scripted-diff: Replace NET_TOR with NET_ONION
Apr 19 2019, 14:25
deadalnix closed D2824: scripted-diff: Replace NET_TOR with NET_ONION.
Apr 19 2019, 14:25
deadalnix committed rABC7333ed6b52ff: Log warning message when deprecated network name 'tor' is used (e.g. option… (authored by wodry <wodry@users.noreply.github.com>).
Log warning message when deprecated network name 'tor' is used (e.g. option…
Apr 19 2019, 14:24
deadalnix closed D2823: Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor).
Apr 19 2019, 14:24
deadalnix requested changes to D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration.
Apr 19 2019, 12:53
deadalnix accepted D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration.
Apr 19 2019, 12:52
deadalnix requested changes to D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.
Apr 19 2019, 12:51
deadalnix accepted D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp.
Apr 19 2019, 12:50
deadalnix accepted D2827: Added missing notes to release notes.
Apr 19 2019, 12:47
deadalnix accepted D2838: Use angle bracket in include for support.
Apr 19 2019, 12:46
deadalnix requested changes to D2839: Use angle bracket in include for tests (part 1).
Apr 19 2019, 12:46
deadalnix accepted D2837: Use angle bracket in include for script.
Apr 19 2019, 12:44
deadalnix accepted D2836: Use angle bracket in include for rpc.
Apr 19 2019, 12:43
deadalnix accepted D2835: Use angle bracket in include for primitives.
Apr 19 2019, 12:41
deadalnix committed rABC5530e49c1819: Remove Safe mode (authored by Andrew Chow <achow101-github@achow101.com>).
Remove Safe mode
Apr 19 2019, 12:28
deadalnix closed D2820: Remove Safe mode.
Apr 19 2019, 12:27
deadalnix requested review of D2823: Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor).

It's trivial enough, let's not redo everything that has been done for us.

Apr 19 2019, 12:25
Herald added a reviewer for D2840: Update seeds: Restricted Project.
Apr 19 2019, 12:22
deadalnix accepted D2826: Move interface -> interfaces.
Apr 19 2019, 12:09

Apr 18 2019

Herald added a reviewer for D2825: Remove the boost/algorithm/string/case_conv.hpp dependency: Restricted Project.
Apr 18 2019, 00:38
Herald added a reviewer for D2824: scripted-diff: Replace NET_TOR with NET_ONION: Restricted Project.
Apr 18 2019, 00:30
Herald added a reviewer for D2823: Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor): Restricted Project.
Apr 18 2019, 00:22

Apr 17 2019

deadalnix requested changes to D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration.
Apr 17 2019, 23:20
deadalnix requested changes to D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.
Apr 17 2019, 23:18
deadalnix accepted D2819: Remove direct bitcoin calls from qt/intro.cpp.
Apr 17 2019, 23:14
deadalnix requested changes to D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.
Apr 17 2019, 23:11
deadalnix requested changes to D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.
Apr 17 2019, 23:11
deadalnix requested changes to D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp.
Apr 17 2019, 23:08
Herald added a reviewer for D2820: Remove Safe mode: Restricted Project.
Apr 17 2019, 23:06
deadalnix committed rABC2cf668a35ebd: Use angle bracket in include for net and netbase (authored by deadalnix).
Use angle bracket in include for net and netbase
Apr 17 2019, 22:24
deadalnix closed D2812: Use angle bracket in include for net and netbase.
Apr 17 2019, 22:24
deadalnix accepted D2815: Remove direct bitcoin calls from qt/bitcoingui.cpp.
Apr 17 2019, 17:05
deadalnix accepted D2814: Remove direct bitcoin calls from qt/optionsmodel.cpp.
Apr 17 2019, 16:53
deadalnix accepted D2813: Remove direct bitcoin calls from qt/bitcoin.cpp.
Apr 17 2019, 16:11
deadalnix updated the diff for D2457: [schnorr] Refactor the signature process in reusable component.

dd a check for the point at infinity in secp256k1_schnorr_compute_sig

Apr 17 2019, 15:35
deadalnix added inline comments to D2457: [schnorr] Refactor the signature process in reusable component.
Apr 17 2019, 15:30
deadalnix updated the diff for D2002: Disallow using addresses in createmultisig.

Put that diff back in shape

Apr 17 2019, 15:12
Herald added a reviewer for D2812: Use angle bracket in include for net and netbase: Restricted Project.
Apr 17 2019, 12:36
deadalnix accepted D2766: Add Sent and Received information to the debug menu peer list.
Apr 17 2019, 12:11
deadalnix accepted D2809: Merge #12422: util: Make LockDirectory thread-safe, consistent.
Apr 17 2019, 12:01

Apr 16 2019

deadalnix accepted D2808: Merge #11904: Add a lock to the wallet directory.
Apr 16 2019, 22:56
deadalnix accepted D2803: blockfilter: add GCSFilter class.
Apr 16 2019, 22:53
deadalnix accepted D2806: Replace C compatibility headers by their C++ equivalent.
Apr 16 2019, 17:11
deadalnix requested changes to D2806: Replace C compatibility headers by their C++ equivalent.
Apr 16 2019, 15:34

Apr 15 2019

deadalnix added a reverting change for rABCf00d08b715e9: [LINTER] Integrate lint-locale-dependence.sh into arcanist: rABC6cd6a3ee3d67: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist".
Apr 15 2019, 14:13
deadalnix committed rABC6cd6a3ee3d67: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist" (authored by deadalnix).
Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist"
Apr 15 2019, 14:13
deadalnix closed D2804: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist".
Apr 15 2019, 14:13
deadalnix added a reverting change for rABCf00d08b715e9: [LINTER] Integrate lint-locale-dependence.sh into arcanist: D2804: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist".
Apr 15 2019, 13:04
Herald added a reviewer for D2804: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist": Restricted Project.
Apr 15 2019, 13:04
deadalnix accepted D2800: Extract CSipHasher to it's own file in crypto/ directory..
Apr 15 2019, 11:54
deadalnix added inline comments to D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.
Apr 15 2019, 11:53
deadalnix accepted D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.
Apr 15 2019, 11:53
deadalnix accepted D2764: [LINTER] Enforce custom coding standard for PHP files.
Apr 15 2019, 11:52
deadalnix requested changes to D2803: blockfilter: add GCSFilter class.
Apr 15 2019, 11:22

Apr 14 2019

deadalnix added inline comments to D1936: Move handling for `-maxtxfee` to the config object.
Apr 14 2019, 19:56
deadalnix requested changes to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Apr 14 2019, 19:51
deadalnix accepted D2802: Update release notes for 0.19.3 to include instructions for re-enabling deprecated signrawtransaction.
Apr 14 2019, 19:38
deadalnix accepted D2799: streams: Implement BitStreamReader/Writer classes..
Apr 14 2019, 19:38