There is no name collision, because this is what it is.
Feed Advanced Search
Oct 2 2019
Oct 2 2019
deadalnix requested changes to D4197: [CMAKE] Rename bitcoinconsensus target to avoid collision.
deadalnix requested changes to D4198: [CMAKE] Add the bitcoinconsensus library.
deadalnix added inline comments to D4198: [CMAKE] Add the bitcoinconsensus library.
deadalnix committed rABCc57daa89273c: utils: Convert Windows args to utf-8 string (authored by Chun Kuan Lee <ken2812221@gmail.com>).
utils: Convert Windows args to utf-8 string
Oct 1 2019
Oct 1 2019
deadalnix updated the diff for D4174: utils: Convert Windows args to utf-8 string.
rebase
deadalnix requested changes to D3694: Update the github issue template to include disclosure policy.
Out of my queue
deadalnix requested changes to D4190: Rename master key to seed.
deadalnix requested changes to D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Part of the PR are missing.
deadalnix requested changes to D4189: Remove redundant assignments (dead stores).
test plan.
deadalnix requested changes to D4192: validation: Pass tx pool reference into CheckSequenceLocks.
Test plan.
deadalnix updated the diff for D4188: Add native support for serializing char arrays without FLATDATA.
Add one missed removal of FLATDATA
deadalnix committed rABC93f8083a0621: Add static_assert to prevent VARINT(<signed value>) (authored by Russell Yanofsky <russ@yanofsky.org>).
Add static_assert to prevent VARINT(<signed value>)
deadalnix updated the diff for D4174: utils: Convert Windows args to utf-8 string.
rebase
deadalnix committed rABCc794bd6704d5: util: Replace boost::signals2 with std::function (authored by MarcoFalke <falke.marco@gmail.com>).
util: Replace boost::signals2 with std::function
Sep 28 2019
Sep 28 2019
deadalnix requested changes to D4177: Bump version to 0.20.4.
deadalnix requested changes to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.
Splitting the script diff part would make this way easier to review.
deadalnix requested changes to D4171: Merge #12560: [wallet] Upgrade path for non-HD wallets to HD.
This patch contains at least one serious blunder. In addition, the fact that the blunder passed through shows that the test plan is inadequate.
deadalnix added a comment to D4174: utils: Convert Windows args to utf-8 string.
I have no idea what's happening on CI, none of this is reproducing outside of CI.
deadalnix updated the diff for D4174: utils: Convert Windows args to utf-8 string.
try more shit
deadalnix requested changes to D4160: Merge #13176: Improve CRollingBloomFilter performance: replace modulus with FastMod.
The test plan is not appropriate.
deadalnix updated the diff for D4174: utils: Convert Windows args to utf-8 string.
Try something
deadalnix committed rABCe89f30d274e3: tiny refactor for ArgsManager (authored by AtsukiTak <takatomgoo@gmail.com>).
tiny refactor for ArgsManager
deadalnix committed rABC586ece932c74: Document RPC method aliasing (authored by Russell Yanofsky <russ@yanofsky.org>).
Document RPC method aliasing
deadalnix committed rABCb660a2d9f5a2: Add AssertLockHeld assertions in CWallet::ListCoins (authored by Russell Yanofsky <russ@yanofsky.org>).
Add AssertLockHeld assertions in CWallet::ListCoins
Sep 27 2019
Sep 27 2019
deadalnix committed rSTAGING3629bb51288f: Run miner_tests with fixed options (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Run miner_tests with fixed options
deadalnix committed rSTAGINGf4336441a5d8: Abstract out BlockAssembler options (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Abstract out BlockAssembler options
deadalnix committed rSTAGING5fe43f2303a1: wallet: Use shared pointer to retain wallet instance (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet: Use shared pointer to retain wallet instance
deadalnix committed rSTAGING630bb8df532e: scripted-diff: Replace boost::bind with std::bind (authored by deadalnix).
scripted-diff: Replace boost::bind with std::bind
deadalnix committed rSTAGING6615be98b28e: refactor: Use boost::scoped_connection in signal/slot, also prefer range-based… (authored by Chun Kuan Lee <ken2812221@gmail.com>).
refactor: Use boost::scoped_connection in signal/slot, also prefer range-based…
deadalnix committed rSTAGING00891cd619e5: Use TxId where apropriate in wallettests.cpp (authored by deadalnix).
Use TxId where apropriate in wallettests.cpp
deadalnix committed rSTAGING8d88b38a5747: scripted-diff: batch-recase BanMan variables (authored by Carl Dong <accounts@carldong.me>).
scripted-diff: batch-recase BanMan variables
deadalnix committed rSTAGING8ab0ff176909: banman: Add, use CBanEntry ctor that takes ban reason (authored by Carl Dong <accounts@carldong.me>).
banman: Add, use CBanEntry ctor that takes ban reason
deadalnix committed rSTAGING8c7329748182: banman: reformulate nBanUtil calculation (authored by Carl Dong <accounts@carldong.me>).
banman: reformulate nBanUtil calculation
deadalnix committed rSTAGING697f4827b1e5: banman: add thread annotations and mark members const where possible (authored by Cory Fields <cory-nospam-@coryfields.com>).
banman: add thread annotations and mark members const where possible
deadalnix committed rSTAGING40b7384bad21: scripted-diff: batch-rename BanMan members (authored by Cory Fields <cory-nospam-@coryfields.com>).
scripted-diff: batch-rename BanMan members
deadalnix committed rSTAGINGf4d2c86a92a8: net: move BanMan to its own files (authored by Cory Fields <cory-nospam-@coryfields.com>).
net: move BanMan to its own files
deadalnix committed rSTAGING1ca887fa7414: banman: pass the banfile path in (authored by Cory Fields <cory-nospam-@coryfields.com>).
banman: pass the banfile path in
deadalnix committed rSTAGINGb825b6de3913: banman: pass in default ban time as a parameter (authored by Cory Fields <cory-nospam-@coryfields.com>).
banman: pass in default ban time as a parameter
deadalnix committed rSTAGING47d52f2e501f: banman: create and split out banman (authored by Cory Fields <cory-nospam-@coryfields.com>).
banman: create and split out banman
Move util files to directory
deadalnix committed rSTAGING825e09ba4a76: Use C++11 default member initializers (authored by MarcoFalke <falke.marco@gmail.com>).
Use C++11 default member initializers
deadalnix committed rSTAGING4a43c7ee730f: Use std::make_unique more consistently (authored by deadalnix).
Use std::make_unique more consistently
Remove unecessary obj folder
deadalnix updated the test plan for D4174: utils: Convert Windows args to utf-8 string.
deadalnix requested changes to D4150: Merge #12218: net: Move misbehaving logging to net logging category.
I'm not talking about tests. Glancing quickly at net_processing.cpp, I found cases that would benefit from the same type of refactoring as done here that are not part of the orginal PR because the corresponding code doesn't exist in Core.
deadalnix added a comment to D4172: Moved Misbehaving() overload to header file.
This seems to me to be gratuitously moving away from core for no good reason. What's the reason?
deadalnix retitled D4170: Add AssertLockHeld assertions in CWallet::ListCoins from Add EXCLUSIVE_LOCKS_REQUIRED to CWallet::ListCoins to Add AssertLockHeld assertions in CWallet::ListCoins.
deadalnix updated the diff for D4170: Add AssertLockHeld assertions in CWallet::ListCoins.
Full PR
deadalnix requested changes to D3471: Merge #9868: Abstract out the command line options for block assembly.
This seems to be redundant now.
deadalnix added a comment to D3694: Update the github issue template to include disclosure policy.
Do you have some feedback from stackoverflow that this is not an appropriate place?
deadalnix requested changes to D4150: Merge #12218: net: Move misbehaving logging to net logging category.
There are several extra calls to Misbehaving from our codebase that require updating.
deadalnix requested changes to D4166: Merge #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety.
deadalnix requested changes to D4165: Merge #13284: gui: fix visual "overflow" of amount input..
Description
deadalnix requested changes to D4163: Include 0.19.x seeds until more nodes have upgraded.
Then contacting people to get them to upgrade seems like the actual path forward rather than stepping back.
Sep 26 2019
Sep 26 2019
deadalnix requested changes to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Please go over the file and add proper annotations instead of simply doing ssh over phabricator.
Sep 24 2019
Sep 24 2019
deadalnix requested changes to D3694: Update the github issue template to include disclosure policy.
deadalnix requested changes to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Clearly this patch wasn't adapted appropriately to our codebase.
deadalnix committed rABC3629bb51288f: Run miner_tests with fixed options (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Run miner_tests with fixed options
deadalnix committed rABCf4336441a5d8: Abstract out BlockAssembler options (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Abstract out BlockAssembler options
deadalnix requested changes to D4145: Avoid locking mutexes that are already held by the same thread.
The test plan is not apropriate. You need to test with clang to make sure the thread anotation are repsected, (gcc doesn't support this) and run the test suite on a debug build to check that AssertLockHeld doesn't trigger.