Page MenuHomePhabricator
Feed Advanced Search

Apr 19 2019

Fabien committed rABC34344c24c0d3: Use angle bracket in include for policy (authored by Fabien).
Use angle bracket in include for policy
Apr 19 2019, 19:51
Fabien closed D2834: Use angle bracket in include for policy.
Apr 19 2019, 19:50
Fabien committed rABC48c9a6b48259: Use angle bracket in include for crypto (authored by Fabien).
Use angle bracket in include for crypto
Apr 19 2019, 19:50
Fabien closed D2833: Use angle bracket in include for crypto.
Apr 19 2019, 19:50
Fabien committed rABC37a6f5c97d83: Use angle bracket in include for consensus (authored by Fabien).
Use angle bracket in include for consensus
Apr 19 2019, 19:49
Fabien closed D2832: Use angle bracket in include for consensus.
Apr 19 2019, 19:49
Fabien committed rABCdb4782146492: Use angle bracket in include for compat (authored by Fabien).
Use angle bracket in include for compat
Apr 19 2019, 19:48
Fabien closed D2831: Use angle bracket in include for compat.
Apr 19 2019, 19:48
Fabien committed rABC28a67dec3f83: Use angle bracket in include for bench (authored by Fabien).
Use angle bracket in include for bench
Apr 19 2019, 19:47
Fabien closed D2830: Use angle bracket in include for bench.
Apr 19 2019, 19:47
Herald added a reviewer for D2841: Use angle bracket in include for tests (part 2): deadalnix.
Apr 19 2019, 18:39
Fabien accepted D2826: Move interface -> interfaces.
Apr 19 2019, 18:19
Fabien updated the diff for D2839: Use angle bracket in include for tests (part 1).

Attempt to make the include order consistent in tests

Apr 19 2019, 15:20
Fabien updated the diff for D2839: Use angle bracket in include for tests (part 1).

System library included last

Apr 19 2019, 12:53
Fabien accepted D2823: Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor).
Apr 19 2019, 12:30
Herald added a reviewer for D2839: Use angle bracket in include for tests (part 1): deadalnix.
Apr 19 2019, 09:42
Herald added a reviewer for D2838: Use angle bracket in include for support: deadalnix.
Apr 19 2019, 08:48
Herald added a reviewer for D2837: Use angle bracket in include for script: deadalnix.
Apr 19 2019, 08:46
Herald added a reviewer for D2836: Use angle bracket in include for rpc: deadalnix.
Apr 19 2019, 08:42
Herald added a reviewer for D2835: Use angle bracket in include for primitives: deadalnix.
Apr 19 2019, 08:13
Fabien requested changes to D2826: Move interface -> interfaces.
Apr 19 2019, 08:05
Fabien accepted D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp.
Apr 19 2019, 07:11
Fabien added inline comments to D2827: Added missing notes to release notes.
Apr 19 2019, 07:01

Apr 18 2019

Herald added a reviewer for D2834: Use angle bracket in include for policy: deadalnix.
Apr 18 2019, 22:48
Herald added a reviewer for D2833: Use angle bracket in include for crypto: deadalnix.
Apr 18 2019, 22:47
Herald added a reviewer for D2832: Use angle bracket in include for consensus: deadalnix.
Apr 18 2019, 22:45
Herald added a reviewer for D2831: Use angle bracket in include for compat: deadalnix.
Apr 18 2019, 22:43
Herald added a reviewer for D2830: Use angle bracket in include for bench: deadalnix.
Apr 18 2019, 22:40
Fabien requested changes to D2827: Added missing notes to release notes.
Apr 18 2019, 22:29
Fabien accepted D2829: Updated manpages for 0.19.4 release.
Apr 18 2019, 22:10
Fabien accepted D2828: Updated chainparams for 0.19.4 release.
Apr 18 2019, 22:05
Fabien accepted D2827: Added missing notes to release notes.
Apr 18 2019, 21:57
Fabien updated the test plan for D2792: Add a build command to arcanist.
Apr 18 2019, 16:04
Fabien updated the diff for D2792: Add a build command to arcanist.

Rebase and add some more checks.
Move the build directory removal to the finalize() method so it can
be called by arc unit after the tests are run.

Apr 18 2019, 16:01
Fabien added inline comments to D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.
Apr 18 2019, 15:00
Fabien accepted D2825: Remove the boost/algorithm/string/case_conv.hpp dependency.
Apr 18 2019, 08:49
Fabien requested changes to D2823: Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor).

I found it, the unit test is added in D2825.
This is not core ordering, but you may want to rebase D2823 on top of D2825 so this change gets tested.

Apr 18 2019, 08:44
Fabien added a comment to D2823: Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor).

Can you point me to the test, I can't find it ?

Apr 18 2019, 08:32
Fabien accepted D2824: scripted-diff: Replace NET_TOR with NET_ONION.
Apr 18 2019, 08:27
Fabien added inline comments to D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.
Apr 18 2019, 08:15
Fabien requested changes to D2822: Remove direct bitcoin calls from qt/bantablemodel.cpp.
Apr 18 2019, 08:14
Fabien requested changes to D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.
Apr 18 2019, 07:54
Fabien accepted D2820: Remove Safe mode.
Apr 18 2019, 07:25
Fabien requested changes to D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp.
Apr 18 2019, 06:13
Fabien updated the diff for D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration.

Change configuration before removing the NDEBUG flag

Apr 18 2019, 06:02

Apr 17 2019

Fabien requested changes to D2002: Disallow using addresses in createmultisig.

Can you rename deprecated_rpc.py to rpc_deprecated.py to follow the new naming convention ?

Apr 17 2019, 18:18
Fabien accepted D2810: Merge #12630: Provide useful error message if datadir is not writable..
Apr 17 2019, 09:40
Fabien planned changes to D2541: [WIP] Integrate test_bitcoin with arcanist through arc unit.
Apr 17 2019, 09:09
Fabien planned changes to D2792: Add a build command to arcanist.
Apr 17 2019, 09:08

Apr 16 2019

Fabien accepted D2766: Add Sent and Received information to the debug menu peer list.
Apr 16 2019, 19:51
Fabien committed rABC2258df118678: Replace C compatibility headers by their C++ equivalent (authored by Fabien).
Replace C compatibility headers by their C++ equivalent
Apr 16 2019, 17:41
Fabien closed D2806: Replace C compatibility headers by their C++ equivalent.
Apr 16 2019, 17:40
Fabien updated the diff for D2806: Replace C compatibility headers by their C++ equivalent.

Don't update the C library

Apr 16 2019, 15:41
Herald added a reviewer for D2806: Replace C compatibility headers by their C++ equivalent: deadalnix.
Apr 16 2019, 13:58
Fabien updated the diff for D2735: Add scripted-diffs verification into arcanist.

Rebase, and lint

Apr 16 2019, 12:17
Fabien added inline comments to D2541: [WIP] Integrate test_bitcoin with arcanist through arc unit.
Apr 16 2019, 08:28
Fabien abandoned D2750: [CMAKE] Move .h files transformed from .ui to the form subdirectory.

Superseeded by D2786

Apr 16 2019, 08:09
Fabien committed rABC1187488597aa: [CMAKE] Move .h files transformed from .ui to the form subdirectory (authored by Fabien).
[CMAKE] Move .h files transformed from .ui to the form subdirectory
Apr 16 2019, 08:07
Fabien closed D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.
Apr 16 2019, 08:07
Fabien requested changes to D2766: Add Sent and Received information to the debug menu peer list.
Apr 16 2019, 07:54
Fabien accepted D2797: streams: Create VectorReader stream interface for vectors..
Apr 16 2019, 07:20
Fabien accepted D2799: streams: Implement BitStreamReader/Writer classes..
Apr 16 2019, 06:48

Apr 15 2019

Fabien accepted D2755: [secp256k1] add schnorr sign jni binding.
Apr 15 2019, 18:11
Fabien accepted D2804: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist".

I will search for the cause of the performance issue and re-enable it when it gets fixed

Apr 15 2019, 14:02
Fabien committed rABCdb99036786ac: [LINTER] Enforce custom coding standard for PHP files (authored by Fabien).
[LINTER] Enforce custom coding standard for PHP files
Apr 15 2019, 13:52
Fabien closed D2764: [LINTER] Enforce custom coding standard for PHP files.
Apr 15 2019, 13:52
Fabien updated the diff for D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.

Add double quotes

Apr 15 2019, 13:44
Fabien accepted D2793: Merge #11041: Add LookupBlockIndex.
Apr 15 2019, 07:48
Fabien updated the diff for D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.

Add a comment and set the directory relative to the CMAKE_CURRENT_BINARY_DIR

Apr 15 2019, 07:20

Apr 14 2019

Fabien accepted D2801: Merge #11838: qa: Add getrawtransaction in_active_chain=False test.
Apr 14 2019, 06:10

Apr 12 2019

Fabien added inline comments to D2792: Add a build command to arcanist.
Apr 12 2019, 16:02
Fabien updated the test plan for D2792: Add a build command to arcanist.
Apr 12 2019, 16:00
Fabien updated the diff for D2792: Add a build command to arcanist.

Remove most of the arguments, check the cmake and ninja are installed

Apr 12 2019, 15:59
Fabien requested changes to D2799: streams: Implement BitStreamReader/Writer classes..

There are tests missing for some edge cases: nbits < 0, =0, =64 and > 64

Apr 12 2019, 10:22
Fabien requested changes to D2797: streams: Create VectorReader stream interface for vectors..
Apr 12 2019, 09:39
Fabien accepted D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Apr 12 2019, 06:27
Fabien requested changes to D2793: Merge #11041: Add LookupBlockIndex.
Apr 12 2019, 06:17

Apr 11 2019

Fabien updated the summary of D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.
Apr 11 2019, 14:33
Fabien updated the diff for D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.

Hack the CMAKE_CURRENT_BINARY_DIR variable as suggested.

Apr 11 2019, 14:32
Fabien added inline comments to D2541: [WIP] Integrate test_bitcoin with arcanist through arc unit.
Apr 11 2019, 14:09
Fabien updated the diff for D2541: [WIP] Integrate test_bitcoin with arcanist through arc unit.

Add a missing newline at the end of .arcunit

Apr 11 2019, 14:02
Fabien updated the test plan for D2541: [WIP] Integrate test_bitcoin with arcanist through arc unit.
Apr 11 2019, 14:01
Fabien updated the diff for D2541: [WIP] Integrate test_bitcoin with arcanist through arc unit.

Complete rework.
This new proposal uses Ninja to find the dependencies and run the tests.
It is build upon the arc build command to ensure reproductible behavior.

Apr 11 2019, 14:00
Fabien updated the test plan for D2792: Add a build command to arcanist.
Apr 11 2019, 09:59
Fabien updated the diff for D2792: Add a build command to arcanist.

Move the default build directory to the configuration file.

Apr 11 2019, 09:58
Fabien updated the diff for D2792: Add a build command to arcanist.

Allow to set the buil dir at any level.
Change the default build dir to build-cmake.

Apr 11 2019, 08:46
Fabien updated the test plan for D2792: Add a build command to arcanist.
Apr 11 2019, 08:45
Fabien added inline comments to D2792: Add a build command to arcanist.
Apr 11 2019, 08:44

Apr 10 2019

Fabien updated the diff for D2792: Add a build command to arcanist.

Improve error messages

Apr 10 2019, 13:45
Fabien updated the test plan for D2792: Add a build command to arcanist.
Apr 10 2019, 13:44
Fabien updated the test plan for D2792: Add a build command to arcanist.
Apr 10 2019, 13:43
Herald added a reviewer for D2792: Add a build command to arcanist: deadalnix.
Apr 10 2019, 12:05

Apr 9 2019

Fabien accepted D2791: Fix increment in rpc/mining.cpp when coinbase tx is skipped.
Apr 9 2019, 19:35
Fabien committed rABC45660ed52203: Migrate MakeUnique to c++14 std::make_unique (authored by Fabien).
Migrate MakeUnique to c++14 std::make_unique
Apr 9 2019, 18:50
Fabien closed D2463: Migrate MakeUnique to c++14 std::make_unique.
Apr 9 2019, 18:49
Fabien requested review of D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.

The Qt5Widgets_UIC_EXECUTABLE variable is set by the find_package(Qt5Widget) which is searching for files according to the CMAKE_FIND_ROOT_PATH.
The platform files override the CMAKE_FIND_ROOT_PATH variable, so that cross compilation and gitian builds should be fine.

Apr 9 2019, 18:41
Fabien committed rABC49fa7d507420: Use c++14 generic std::rbegin() and std::rend() instead of class methods (authored by Fabien).
Use c++14 generic std::rbegin() and std::rend() instead of class methods
Apr 9 2019, 18:32
Fabien closed D2464: Use c++14 generic std::rbegin() and std::rend() instead of class methods.
Apr 9 2019, 18:32

Apr 8 2019

Fabien committed rABC4d5a8ec972e2: doc: update FreeBSD build guide for 12.0 (authored by fanquake <fanquake@gmail.com>).
doc: update FreeBSD build guide for 12.0
Apr 8 2019, 18:25
Fabien closed D2650: doc: update FreeBSD build guide for 12.0.
Apr 8 2019, 18:25