Revert dependency, now depends on D4257.

Revert diff dependency.

The test plan doesn't cover the change.

Attempt to make the interface more simple and clear.
The add_library_with_type() function manages adding a library with one type or
more (STATIC, SHARED or both) but let the caller deal with properties.
This makes it easier to apply some property to only the static or shared variant
of a library if both are added.

The test is failing.

Pick better names for the wrapper function and its cmake file.
Make the install_target() a function to separate its scope from the caller's.

Missing newline.

It's breaking the doc/Doxyfile.cmake.in template.
Please replace the line:
PROJECT_NUMBER = ${CLIENT_VERSION_MAJOR}.${CLIENT_VERSION_MINOR}.${CLIENT_VERSION_REVISION}
with:
PROJECT_NUMBER = ${bitcoin-abc_VERSION}
to fix it.

Should anything fail the script errors out immediately, but the user working tree may have been modified in between.
I think you should trap the error and restore the previous state to avoid confusing the user.

I'm sure you didn't run the test from the summary. Please make it clear that you are quoting core PR description.

Build with Clang to check for -Wthread-safety-warnings.

Rebase on top of D4185.

Maybe there should be an explicit notice of backport here, as the remaining parts of the PR are Travis related ?

I tried to reproduce on a fresh Debian Stretch, no success.
I will try to install the agent packages and run again.

Fix Invalid argument by passing the address of first vararg as a void *.
The same is done internally by the glibc, but the compatibility symbols seems
to complain when the full vararg list is passed.

Rebase on master (was on top of D4095, thus failing the symbol check with gitian on stretch).

Revert configure logic to wrap when needed.