Page MenuHomePhabricator
Feed Advanced Search

Sep 6 2021

majcosta accepted D10053: Move filtering banned addrs inside GetAddresses().
Sep 6 2021, 21:36
majcosta accepted D10057: Test addr response caching.
Sep 6 2021, 17:15
majcosta accepted D10056: Add addr permission flag enabling non-cached addr sharing.
Sep 6 2021, 17:12
majcosta accepted D10055: Cache responses to addr requests.
Sep 6 2021, 17:06
majcosta accepted D10054: Remove useless 2500 limit on AddrMan queries.
Sep 6 2021, 17:01
majcosta requested changes to D10053: Move filtering banned addrs inside GetAddresses().
Sep 6 2021, 16:59
majcosta accepted D10052: Remove Reference Links.
Sep 6 2021, 15:24
majcosta accepted D10051: rpc: RPCResult Type of MempoolEntryDescription should be OBJ..
Sep 6 2021, 15:21
majcosta accepted D10050: walletdb: Ensure that having no database handle is a failure.
Sep 6 2021, 15:19
majcosta accepted D10049: Remove BDB dummy databases.
Sep 6 2021, 15:19
majcosta accepted D10048: Introduce DummyDatabase and use it in the tests.
Sep 6 2021, 15:16
majcosta accepted D10036: walletdb: Move Db->open to BerkeleyDatabase::Open.
Sep 6 2021, 15:14
majcosta accepted D10047: Clean message_count and last_message.
Sep 6 2021, 15:10

Sep 3 2021

majcosta accepted D10035: walletdb: track database file use as m_refcount within BerkeleyDatabase.
Sep 3 2021, 18:11
majcosta accepted D10034: Combine BerkeleyEnvironment::Verify into BerkeleyDatabase::Verify.
Sep 3 2021, 18:08

Sep 2 2021

majcosta accepted D10026: [avalanche] Make gen_proof facility return the key object.
Sep 2 2021, 13:33
majcosta accepted D10025: walletdb: Introduce WalletDatabase abstract class.
Sep 2 2021, 13:29
majcosta accepted D10024: walletdb: Add BerkeleyDatabase::Open dummy function.
Sep 2 2021, 13:22
majcosta accepted D10023: walletdb: Introduce AddRef and RemoveRef functions.
Sep 2 2021, 13:21
majcosta accepted D10022: walletdb: Move BerkeleyDatabase::Flush(true) to Close().
Sep 2 2021, 13:16
majcosta accepted D10021: log: Avoid treating remote misbehvior as local system error.
Sep 2 2021, 13:08
majcosta accepted D10018: test: fix intermittent p2p_ibd_txrelay race, add test_framework.py#wait_until.
Sep 2 2021, 13:05

Sep 1 2021

majcosta accepted D10012: rename movie folder to animation.
Sep 1 2021, 12:37
majcosta accepted D10011: gui: Show permissions instead of whitelisted.
Sep 1 2021, 12:26
majcosta requested changes to D10010: rpc: Update server to use new RPCHelpMan.

tests

Sep 1 2021, 12:25
majcosta accepted D10009: rpc: Add option to hide RPCArg.
Sep 1 2021, 12:20
majcosta accepted D10008: rpc: Assert that passed arg names are equal to hardcoded ones.
Sep 1 2021, 12:18
majcosta accepted D10007: rpc: Add CRPCCommand constructor which takes RPCHelpMan.
Sep 1 2021, 12:18
majcosta accepted D10006: rpc: Check that left section is not multiline.
Sep 1 2021, 12:11
majcosta accepted D10005: qt: Get rid of cursor in out-of-focus labels.
Sep 1 2021, 10:46
majcosta accepted D10004: Call SHA256AutoDetect in benchmark setup.
Sep 1 2021, 10:45

Aug 31 2021

majcosta accepted D10000: [Website] Improved cashtab logos.
Aug 31 2021, 21:28
majcosta accepted D9998: [LINTER] Replace unsigned short with uint16_t.

tested, worked

Aug 31 2021, 18:22
majcosta added inline comments to D9928: Add AddInt63Overflow and SubInt63Overflow.
Aug 31 2021, 18:13
majcosta accepted D9997: Fix rebase issue that introduced a linter error.
Aug 31 2021, 17:48
majcosta accepted D9995: doc: Add non-thread-safe note to FeeFilterRounder::round().
Aug 31 2021, 14:01
majcosta accepted D9994: Disable the main window toolbar when the modal overlay is shown.
Aug 31 2021, 13:56
majcosta accepted D9993: [rpc] refactor: consolidate sendmany and sendtoaddress code.
Aug 31 2021, 13:54
majcosta accepted D9986: qt: increase console command max length.
Aug 31 2021, 10:37

Aug 30 2021

majcosta planned changes to D9975: avalanche: method to get std::vector<avalanche::Node> associated with a PeerId.
Aug 30 2021, 19:40
majcosta accepted D9983: wallet: Replace CDataStream& with CDataStream&& where appropriate.
Aug 30 2021, 17:31
majcosta accepted D9982: wallet: Remove confusing double return value ret+success.
Aug 30 2021, 17:25
majcosta accepted D9981: test: Test gettxouttsetinfo hash_type option.
Aug 30 2021, 17:22
majcosta accepted D9980: rpc: Add hash_type NONE to gettxoutsetinfo.
Aug 30 2021, 17:20
majcosta accepted D9979: rpc: gettxoutsetinfo can specify hash_type (only legacy option for now).
Aug 30 2021, 16:41
majcosta accepted D9978: refactor: Extract GetBogoSize function.
Aug 30 2021, 15:11
majcosta updated the diff for D9975: avalanche: method to get std::vector<avalanche::Node> associated with a PeerId.

the point of this is when a p2p node asks another for which nodes he has for a given proof

Aug 30 2021, 12:48
majcosta accepted D9974: refactor: Remove confusing OutputType::CHANGE_AUTO.
Aug 30 2021, 12:45
majcosta accepted D9976: remove use of getDefaultChangeType in paymentserver.cpp.
Aug 30 2021, 12:20
majcosta added a comment to D9974: refactor: Remove confusing OutputType::CHANGE_AUTO.

This is a backport of core#19336

Aug 30 2021, 11:46
majcosta requested changes to D9974: refactor: Remove confusing OutputType::CHANGE_AUTO.

make the changes to BIP70 related code in its own diff, so the backport is just the backport

Aug 30 2021, 11:42
majcosta requested review of D9975: avalanche: method to get std::vector<avalanche::Node> associated with a PeerId.
Aug 30 2021, 11:38
majcosta accepted D9973: doc: Remove outdated comment in TransactionTablePriv.
Aug 30 2021, 10:07
majcosta accepted D9966: refactor: Fix clang compile failure.
Aug 30 2021, 09:10

Aug 28 2021

majcosta accepted D9971: test: Show debug log on unit test failure.
Aug 28 2021, 08:22
majcosta accepted D9969: walletdb: Handle cursor internally.
Aug 28 2021, 08:22
majcosta accepted D9965: doc: Span pitfalls.
Aug 28 2021, 08:17

Aug 27 2021

majcosta requested changes to D9971: test: Show debug log on unit test failure.
Aug 27 2021, 21:15
majcosta accepted D9970: gui: change combiner for signals to optional_last_value.
Aug 27 2021, 21:07
majcosta requested changes to D9969: walletdb: Handle cursor internally.
Aug 27 2021, 21:05
majcosta accepted D9968: test: improve functional tests compatibility with BSD/macOS.
Aug 27 2021, 21:00
majcosta accepted D9967: wallet: Handle concurrent wallet loading.
Aug 27 2021, 20:56
majcosta requested changes to D9966: refactor: Fix clang compile failure.

tests failing

Aug 27 2021, 20:54
majcosta requested changes to D9965: doc: Span pitfalls.
Aug 27 2021, 20:49
majcosta accepted D9964: doc/REST-interface: Remove stale info.
Aug 27 2021, 20:44
majcosta accepted D9963: trivial: Suggested cleanups to surrounding code.
Aug 27 2021, 20:43
majcosta added a comment to D9962: wallet: Minimal fix to restore conflicted transaction notifications.

shouldn't the test for conflicted txns be on D9961?

Aug 27 2021, 20:39

Aug 26 2021

majcosta accepted D9960: doc: Switch scheduler to doxygen comments.
Aug 26 2021, 17:58
majcosta accepted D9959: scheduler: Replace stop(true) with StopWhenDrained().
Aug 26 2021, 17:57
majcosta accepted D9958: doc: Remove unused documentation about unimplemented features.
Aug 26 2021, 17:52
majcosta accepted D9957: doc: Switch boost::thread to std::thread in scheduler.
Aug 26 2021, 17:50
majcosta accepted D9956: test: Remove unused scheduler.h include from the common setup.
Aug 26 2021, 17:49
majcosta accepted D9955: scheduler: Remove unused REVERSE_LOCK.
Aug 26 2021, 17:48
majcosta accepted D9954: wallet: Check size after unserializing a pubkey.
Aug 26 2021, 17:45
majcosta accepted D9953: doc: add release note for bitcoin-cli -generate.
Aug 26 2021, 13:44
majcosta accepted D9952: Bump version to 0.24.1.
Aug 26 2021, 13:44
majcosta accepted D9951: remove [[mabye_unused]] annotation for GetWalletBalances.
Aug 26 2021, 07:32
majcosta accepted D9950: rpc: add missing space in JSON parsing error message, update test.
Aug 26 2021, 07:30
majcosta accepted D9949: test: add multiwallet tests for bitcoin-cli -generate.
Aug 26 2021, 07:30
majcosta accepted D9948: cli: add multiwallet capability to GetNewAddress and -generate.
Aug 26 2021, 07:29
majcosta accepted D9947: test: add tests for bitcoin-cli -generate.
Aug 26 2021, 07:27
majcosta accepted D9946: cli: create bitcoin-cli -generate command.
Aug 26 2021, 07:27
majcosta accepted D9945: cli: extract ParseResult() and ParseError().
Aug 26 2021, 07:24
majcosta accepted D9944: cli: create GenerateToAddressRequestHandler class.
Aug 26 2021, 07:22
majcosta accepted D9943: cli: create GetNewAddress().
Aug 26 2021, 07:21
majcosta accepted D9942: rpc: make generatetoaddress locals const.
Aug 26 2021, 07:20
majcosta accepted D9941: rpc: create rpc/mining.h, hoist default max tries values to constant.
Aug 26 2021, 07:19
majcosta accepted D9940: Change docs for walletcreatefundedpsbt RPC method.
Aug 26 2021, 07:15
majcosta accepted D9939: refactor: Make CScriptVisitor stateless.
Aug 26 2021, 07:13
majcosta accepted D9938: Make SeparatorStyle a scoped enum.
Aug 26 2021, 07:09
majcosta accepted D9937: Add means to handle negative capabilities in thread safety annotations.
Aug 26 2021, 07:07
majcosta accepted D9936: wallet: error if an explicit fee rate was given but the needed fee rate differed.
Aug 26 2021, 07:05

Aug 25 2021

majcosta accepted D9934: [tests] move generate_wif_key to wallet_util.py.
Aug 25 2021, 09:28
majcosta accepted D9933: gui: Add Close All Wallets action.
Aug 25 2021, 09:05
majcosta accepted D9932: qt: Display warnings as rich text.
Aug 25 2021, 08:55
majcosta accepted D9930: Always define the raii_event_tests test suite.
Aug 25 2021, 08:54
majcosta accepted D9929: wallet: Fix for exported confirmation field in payment to self transactions.
Aug 25 2021, 08:52
majcosta accepted D9927: [Cashtab] Bring extension in line with latest prod version.
Aug 25 2021, 08:45

Aug 24 2021

majcosta accepted D9926: qt: Ensure that ModalOverlay is resized properly.
Aug 24 2021, 16:36
majcosta accepted D9924: qt: Remove QFont warnings with QPA=minimal.
Aug 24 2021, 16:32