Page MenuHomePhabricator
Feed Advanced Search

Feb 5 2021

majcosta accepted D9180: [Cashtab] Apply BigNumber to all base unit calcs in sendBch.
Feb 5 2021, 22:16
majcosta accepted D9181: Fix the deserialization of CoinEntry.

tested locally, looks good

Feb 5 2021, 21:46
majcosta closed D9168: [backport#18587] gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged.
Feb 5 2021, 18:12
majcosta committed rABC94640cfde31c: [backport#18587] gui: Avoid wallet tryGetBalances calls in WalletModel… (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[backport#18587] gui: Avoid wallet tryGetBalances calls in WalletModel…
Feb 5 2021, 18:11
majcosta accepted D9178: Restore compatibility with old CSubNet serialization.
Feb 5 2021, 17:17
majcosta accepted D9176: net: change CNetAddr::ip to have flexible size.
Feb 5 2021, 17:11
majcosta accepted D9169: Serialization improvements step 6 (all except wallet/gui).
Feb 5 2021, 17:10

Feb 4 2021

majcosta updated the diff for D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.

update release notes

Feb 4 2021, 23:38
majcosta accepted D9177: [Cashtab] change hover text for wallet mgmt icons.
Feb 4 2021, 23:08
majcosta requested changes to D9176: net: change CNetAddr::ip to have flexible size.
Feb 4 2021, 23:05
majcosta accepted D9175: net: don't accept non-left-contiguous netmasks.
Feb 4 2021, 22:40
majcosta accepted D9174: [Docusaurus] Adding docker deployment files.
Feb 4 2021, 22:36
majcosta accepted D9172: net: save the network type explicitly in CNetAddr.
Feb 4 2021, 22:22
majcosta accepted D9171: net: improve encapsulation of CNetAddr.
Feb 4 2021, 22:16
majcosta accepted D9170: test: add two edge case tests for CSubNet.
Feb 4 2021, 22:15
majcosta requested changes to D9169: Serialization improvements step 6 (all except wallet/gui).
Feb 4 2021, 22:15
majcosta updated the diff for D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.

update for ecash

Feb 4 2021, 21:40
majcosta retitled D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node from [CashAddr] replace bitcoincash: prefix with abc: in the node to [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Feb 4 2021, 21:37
majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

*ecash

Feb 4 2021, 21:37
majcosta accepted D9167: [Cashtab] Incoming notifications use ticker variable.
Feb 4 2021, 15:43
majcosta requested review of D9168: [backport#18587] gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged.
Feb 4 2021, 15:39
majcosta accepted D9166: [Cashtab] Remove instance of toSatoshi from tx builder.
Feb 4 2021, 15:34
majcosta closed D9165: [backport#14848] docs: Fix broken Gmane URL in security-check.py.
Feb 4 2021, 14:36
majcosta committed rABCcdbeaa15bd6e: [backport#14848] docs: Fix broken Gmane URL in security-check.py (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#14848] docs: Fix broken Gmane URL in security-check.py
Feb 4 2021, 14:35
majcosta accepted D9161: [Cashtab] Remove mint artifact object of arrays style input.
Feb 4 2021, 14:34
majcosta requested review of D9165: [backport#14848] docs: Fix broken Gmane URL in security-check.py.
Feb 4 2021, 13:29
majcosta accepted D9163: util: remove unused c-string variant of atoi64().
Feb 4 2021, 12:56
majcosta closed D9162: [backport#18861] Do not answer GETDATA for to-be-announced tx.
Feb 4 2021, 12:46
majcosta accepted D9154: Make Hash[160] consume range-like objects.
Feb 4 2021, 12:46
majcosta committed rABCdb81f26de654: [backport#18861] Do not answer GETDATA for to-be-announced tx (authored by fanquake <fanquake@gmail.com>).
[backport#18861] Do not answer GETDATA for to-be-announced tx
Feb 4 2021, 12:46
majcosta closed D9156: [backport#16946] wallet: include a checksum of encrypted private keys.
Feb 4 2021, 12:45
majcosta committed rABCa7bb5a014c3b: [backport#16946] wallet: include a checksum of encrypted private keys (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#16946] wallet: include a checksum of encrypted private keys
Feb 4 2021, 12:45

Feb 3 2021

majcosta requested review of D9162: [backport#18861] Do not answer GETDATA for to-be-announced tx.
Feb 3 2021, 23:35
majcosta requested changes to D9161: [Cashtab] Remove mint artifact object of arrays style input.
Feb 3 2021, 23:17
majcosta added a comment to D9161: [Cashtab] Remove mint artifact object of arrays style input.

renaming value to sendAmountInBcha is already conflicting with BCH and sendBCHMock. if we're going to change things, it should be renaming the latter as not to be coupled with ticker/brand acronyms, not the other way around, otherwise if the latter change it's gonna be really confusing.

Feb 3 2021, 23:17
majcosta abandoned D9160: [Docusaurus] fix broken link to BCHA info page.

already in

Feb 3 2021, 22:57
majcosta accepted D9155: [Docs] MVP documentation.
Feb 3 2021, 22:57
majcosta accepted D9158: Do not bust cached npm-installed dependencies when source files change.

oh, that's perfect, my bad then

Feb 3 2021, 22:13
majcosta requested review of D9160: [Docusaurus] fix broken link to BCHA info page.
Feb 3 2021, 22:12
majcosta requested changes to D9155: [Docs] MVP documentation.

my browser tab says "Hello from Build on BCHA | Build on BCHA", maybe we want to go with something shorter?

Feb 3 2021, 22:09
majcosta requested changes to D9158: Do not bust cached npm-installed dependencies when source files change.
Feb 3 2021, 21:48
majcosta added inline comments to D9158: Do not bust cached npm-installed dependencies when source files change.
Feb 3 2021, 21:48
majcosta accepted D9159: Use npm ci instead of install for docker deployments.
Feb 3 2021, 21:45
majcosta accepted D9157: Do not bust cached apt-install'd dependencies when source files change.
Feb 3 2021, 21:44
majcosta requested changes to D9154: Make Hash[160] consume range-like objects.
Feb 3 2021, 20:47
majcosta requested review of D9156: [backport#16946] wallet: include a checksum of encrypted private keys.
Feb 3 2021, 20:45
majcosta accepted D9153: Make CHash256/CHash160 output to Span.
Feb 3 2021, 20:21
majcosta accepted D9152: Make MurmurHash3 consume Spans.
Feb 3 2021, 20:18
majcosta accepted D9151: Make CHash256 and CHash160 consume Spans.
Feb 3 2021, 20:16
majcosta accepted D9150: Make script/standard's BaseHash Span-convertible.
Feb 3 2021, 20:09
majcosta accepted D9149: Add MakeUCharSpan, to help constructing Span<[const] unsigned char>.
Feb 3 2021, 19:58
majcosta accepted D9148: Make uint256 Span-convertible by adding ::data().
Feb 3 2021, 19:13
majcosta accepted D9147: scripted-diff: rename base_blob::data to m_data.
Feb 3 2021, 17:12
majcosta accepted D9146: gui: Remove un-actionable TODO.
Feb 3 2021, 17:01
majcosta accepted D9145: Add test for param interaction b/w -blocksonly and -whitelistforcerelay.

changed the revision summary, since this diff is obviously backporting both commits not just the first

Feb 3 2021, 16:09
majcosta updated the summary of D9145: Add test for param interaction b/w -blocksonly and -whitelistforcerelay.
Feb 3 2021, 16:08
majcosta accepted D9135: refactor: Drop unused CBufferedFile::Seek().

ran locally, test failure is unrelated

Feb 3 2021, 05:45
majcosta accepted D9134: test: Fix fuzzer compilation on macOS.
Feb 3 2021, 05:31
majcosta accepted D9133: fuzz: add missing overrides to signature_checker.
Feb 3 2021, 05:30
majcosta accepted D9136: [Cashtab] Replace remaining instances of CashTab with Cashtab.
Feb 3 2021, 05:29
majcosta accepted D9132: tests: Add fuzzing harnesses for CAutoFile, CBufferedFile, LoadExternalBlockFile and other FILE* consumers.
Feb 3 2021, 05:29
majcosta accepted D9131: tests: Add fuzzing harness for AES{CBC,}256{Encrypt,Decrypt}, poly1305_auth, CHKDF_HMAC_SHA256_L32, ChaCha20 and ChaCha20Poly1305AEAD.
Feb 3 2021, 05:20

Feb 2 2021

majcosta accepted D9130: tests: Add fuzzing harness for BanMan.
Feb 2 2021, 22:04
majcosta accepted D9129: net: Use mockable time for ping/pong, add tests.
Feb 2 2021, 21:23
majcosta accepted D9128: psbt: Include and allow both non_witness_utxo and witness_utxo for segwit inputs.
Feb 2 2021, 16:57
majcosta closed D9115: [backport#18067] wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition.
Feb 2 2021, 16:55
majcosta committed rABC20fe6bd3a7b9: [backport#18067] wallet: Improve LegacyScriptPubKeyMan::CanProvide script… (authored by Samuel Dobson <dobsonsa68@gmail.com>).
[backport#18067] wallet: Improve LegacyScriptPubKeyMan::CanProvide script…
Feb 2 2021, 16:55

Feb 1 2021

majcosta updated the diff for D9115: [backport#18067] wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition.

elided comment of SegWit information and left a trail of crumbs for archival reasons

Feb 1 2021, 20:24
majcosta accepted D9126: scripted-diff: TxoutType C++11 scoped enum class.
Feb 1 2021, 18:51
majcosta accepted D9121: Span improvements.
Feb 1 2021, 18:28
majcosta accepted D9091: [Web - New] Adding cashtab-components source.

LGTM

Feb 1 2021, 18:14
majcosta closed D9114: [backport#14785] Scripts: Fix detection of copyright holders.
Feb 1 2021, 16:19
majcosta committed rABC77d8466cfa71: [backport#14785] Scripts: Fix detection of copyright holders (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#14785] Scripts: Fix detection of copyright holders
Feb 1 2021, 16:19

Jan 31 2021

majcosta requested review of D9115: [backport#18067] wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition.
Jan 31 2021, 07:46

Jan 29 2021

majcosta requested review of D9114: [backport#14785] Scripts: Fix detection of copyright holders.
Jan 29 2021, 20:45
majcosta requested changes to D9091: [Web - New] Adding cashtab-components source.
Jan 29 2021, 19:24
majcosta accepted D9112: rpcwallet: Replace pwallet-> with wallet..
Jan 29 2021, 17:14

Jan 28 2021

majcosta requested changes to D9091: [Web - New] Adding cashtab-components source.

I recommend using npm ci instead of npm i --legacy-peer-deps, since that'll give you a deterministic build according to the existing package-lock.json which is in the diff already

Jan 28 2021, 20:27
majcosta accepted D9108: util: Detect posix_fallocate() instead of assuming.
Jan 28 2021, 20:18
majcosta closed D9090: [ci] enable second_deadlock_stack for TSan.
Jan 28 2021, 15:44
majcosta committed rABCce2566d7e6fa: [ci] enable second_deadlock_stack for TSan (authored by majcosta).
[ci] enable second_deadlock_stack for TSan
Jan 28 2021, 15:44
majcosta closed D9092: [backport#18726] test: check misbehavior more independently in p2p_filter.py.
Jan 28 2021, 14:11
majcosta committed rABCa2a9c5790d5d: [backport#18726] test: check misbehavior more independently in p2p_filter.py (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#18726] test: check misbehavior more independently in p2p_filter.py
Jan 28 2021, 14:11

Jan 27 2021

majcosta requested review of D9092: [backport#18726] test: check misbehavior more independently in p2p_filter.py.
Jan 27 2021, 21:56
majcosta requested review of D9090: [ci] enable second_deadlock_stack for TSan.
Jan 27 2021, 20:17
majcosta accepted D9086: [docs] Improve commenting in ProcessGetData().
Jan 27 2021, 17:48
majcosta accepted D9085: [test] test that an invalid GETDATA doesn't prevent processing of future messages.
Jan 27 2021, 17:46
majcosta accepted D9084: [net processing] ignore unknown INV types in GETDATA messages.
Jan 27 2021, 17:46
majcosta accepted D9083: [net processing] ignore tx GETDATA from blocks-only peers.
Jan 27 2021, 17:40
majcosta accepted D9082: refactor: Apply override specifier consistently.
Jan 27 2021, 17:28
majcosta accepted D9081: wallet: Fix typo in assert that is compile-time true.
Jan 27 2021, 17:17
majcosta accepted D9080: doc: Fix typo in Coin doxygen comment.
Jan 27 2021, 16:46
majcosta accepted D9073: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction.
Jan 27 2021, 15:15
majcosta updated the summary of D9073: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction.
Jan 27 2021, 15:14
majcosta accepted D9078: Get rid of BindWallet.
Jan 27 2021, 15:07
majcosta accepted D9077: Disable CWalletTx copy constructor.
Jan 27 2021, 15:06
majcosta accepted D9076: Avoid copying CWalletTx in LoadToWallet.
Jan 27 2021, 15:00
majcosta accepted D9075: Get rid of unneeded CWalletTx::Init parameter.
Jan 27 2021, 14:57
majcosta accepted D9074: Remove CWalletTx merging logic from AddToWallet.
Jan 27 2021, 14:51

Jan 26 2021

majcosta accepted D9072: init: Remove boost from ThreadImport.
Jan 26 2021, 20:35