Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Apr 9 2019
Apr 9 2019
teamcity added a comment to D2790: Add functional tests for rejecting headers that build on invalid chains.
Fabien committed rABC45660ed52203: Migrate MakeUnique to c++14 std::make_unique (authored by Fabien).
Migrate MakeUnique to c++14 std::make_unique
teamcity added a comment to D2790: Add functional tests for rejecting headers that build on invalid chains.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D2790: Add functional tests for rejecting headers that build on invalid chains: Restricted Project.
Fabien requested review of D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.
The Qt5Widgets_UIC_EXECUTABLE variable is set by the find_package(Qt5Widget) which is searching for files according to the CMAKE_FIND_ROOT_PATH.
The platform files override the CMAKE_FIND_ROOT_PATH variable, so that cross compilation and gitian builds should be fine.
deadalnix committed rABCb5f4aa110a60: Use c++14 generic std::rbegin() and std::rend() instead of class methods (authored by Fabien).
Use c++14 generic std::rbegin() and std::rend() instead of class methods
This also depends on T569.
Apr 9 2019, 18:35 · Restricted Project
Fabien committed rABC49fa7d507420: Use c++14 generic std::rbegin() and std::rend() instead of class methods (authored by Fabien).
Use c++14 generic std::rbegin() and std::rend() instead of class methods
jasonbcox committed rABC40d52cfef267: Add functional tests for rejecting headers that build on invalid chains (authored by Matt Corallo <git@bluematt.me>).
Add functional tests for rejecting headers that build on invalid chains
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Fixed comment format.
floreslorca committed rABC951510874e5a: [secp256k1] refactor nativeECDSABuffer to a more generic name (authored by floreslorca).
[secp256k1] refactor nativeECDSABuffer to a more generic name
teamcity added a comment to D2777: Add functional tests for rejecting headers that build on invalid chains.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
jasonbcox updated the summary of D2777: Add functional tests for rejecting headers that build on invalid chains.
teamcity added a comment to D2777: Add functional tests for rejecting headers that build on invalid chains.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
jasonbcox updated the diff for D2777: Add functional tests for rejecting headers that build on invalid chains.
Rebase and test without D2645 as a dependency
deadalnix added a comment to D2777: Add functional tests for rejecting headers that build on invalid chains.
Is that possible to remove the dependency from that test so that it test current behavior, then add the change required to the test to test the new behavior in D2645 ? This way it is very apparent what behavior is changed.
schancel updated the summary of D1972: [Part 5 of 5] Add a CChainState class to clarify internal interfaces.
teamcity added a comment to D2789: Remove AlertNotify functionality, users should use log monitoring.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2789: Remove AlertNotify functionality, users should use log monitoring.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
schancel committed rABCa57aebfd30e6: [Part 4 of 5] Add a CChainState class to clarify internal interfaces (authored by Matt Corallo <git@bluematt.me>).
[Part 4 of 5] Add a CChainState class to clarify internal interfaces
teamcity added a comment to D2789: Remove AlertNotify functionality, users should use log monitoring.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
schancel updated the diff for D2789: Remove AlertNotify functionality, users should use log monitoring.
Fix typo in release notes
teamcity added a comment to D2789: Remove AlertNotify functionality, users should use log monitoring.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D2789: Remove AlertNotify functionality, users should use log monitoring: deadalnix.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.
Harbormaster failed remote builds in B5420: Diff 8008 for D2788: Remove unknown version warning from UpdateTip!
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
schancel committed rABC1201c8ad49e4: Remove unused depends list from `getblocktemplate` transactions (authored by schancel).
Remove unused depends list from `getblocktemplate` transactions
schancel committed rABC0043646b87d1: Remove unused parameter `validFeeEstimates` from `CTxMempool::addUnchecked` (authored by schancel).
Remove unused parameter `validFeeEstimates` from `CTxMempool::addUnchecked`
schancel committed rABCe3e4e04a390f: Fix comment in CheckInputs to match changed code (authored by schancel).
Fix comment in CheckInputs to match changed code
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Remove chain.h as an include from validation.h
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D2787: rpc: Handle `getinfo` locally in bitcoin-cli w/ `-getinfo`: Restricted Project.
nakihito added a parent task for T582: Backport Core PR 13341: T575: Backport Core PR 14532: reduce attack surface of RPC server.
nakihito removed a subtask for T575: Backport Core PR 14532: reduce attack surface of RPC server: T581: Backport Core PR 14206.
nakihito removed a parent task for T581: Backport Core PR 14206: T575: Backport Core PR 14532: reduce attack surface of RPC server.
Apr 8 2019
Apr 8 2019
jasonbcox committed rABC28ae6365839f: Merge #10493: Use range-based for loops (C++11) when looping over map elements (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #10493: Use range-based for loops (C++11) when looping over map elements
jasonbcox closed T577: Backport Core PR 10493, a subtask of T560: Backport Core PR 11041, as Resolved.
nakihito closed T584: Backport Core PR 12906, a subtask of T583: Backport Core PR 13190, as Invalid.
Duplicate of https://reviews.bitcoinabc.org/T417
teamcity added a comment to D2777: Add functional tests for rejecting headers that build on invalid chains.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
jasonbcox planned changes to D2645: Reject headers building on invalid chains by tracking invalidity.
D2777 doesn't adequately provide test coverage for this change. I will need to continue investigating to see why this is the case.
jasonbcox added a comment to D2777: Add functional tests for rejecting headers that build on invalid chains.
In D2777#65449, @deadalnix wrote:The test case do not seem to be corresponding to the modified code (which is an assertion failing).
In D2645 , you state that there is a bug fix related to that test case, and that this is why the code isn't like in the backport but it is still unclear what the bug is, what fixes it and if the test is actually testing anything.
It shouldn't be difficult to have the bug fix coming with the test as one diff, or have an explanation as to why this isn't possible in the diff.
In the current form, there are no way to review this reliably.
teamcity added a comment to D2777: Add functional tests for rejecting headers that build on invalid chains.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
jasonbcox updated the summary of D2777: Add functional tests for rejecting headers that build on invalid chains.
jasonbcox updated the summary of D2777: Add functional tests for rejecting headers that build on invalid chains.
jasonbcox updated the diff for D2777: Add functional tests for rejecting headers that build on invalid chains.
Removed assert which appears to be useless now.
deadalnix requested changes to D2786: [CMAKE] Move .h files transformed from .ui to the form subdirectory.
You will end up using the ui generator from the system even when not wanted (for instance for reproducible builds) with that construct.
jasonbcox added inline comments to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
jasonbcox updated the diff for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Remove unnecessary setting of blocksize
Fabien committed rABC4d5a8ec972e2: doc: update FreeBSD build guide for 12.0 (authored by fanquake <fanquake@gmail.com>).
doc: update FreeBSD build guide for 12.0
Fabien committed rABC3d178846ff10: FreeBSD: Document Python 3 requirement for 'gmake check' (authored by Murray Nesbitt <github@nesbitt.ca>).
FreeBSD: Document Python 3 requirement for 'gmake check'
Fabien committed rABC3b290495f311: doc: split FreeBSD build instructions out of build-unix.md (authored by steverusso <steverusso@protonmail.com>).
doc: split FreeBSD build instructions out of build-unix.md
Drop support for OpenBSD
Fabien committed rABCa48b9f299778: Make c++14 standard the default for compilation (authored by Fabien).
Make c++14 standard the default for compilation
teamcity added a comment to D2775: Merge #10493: Use range-based for loops (C++11) when looping over map elements.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2775: Merge #10493: Use range-based for loops (C++11) when looping over map elements.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
jasonbcox updated the diff for D2775: Merge #10493: Use range-based for loops (C++11) when looping over map elements.
Rebase