Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Jul 15 2019

teamcity added a comment to D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 15 2019, 22:17
markblundeberg updated the diff for D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..

for include order (and rebuild)

Jul 15 2019, 22:17
Nico Guiton <nico@bitframe.org> committed rABCc589bca17e1e: Merge #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY
Jul 15 2019, 21:56
Nico Guiton <nico@bitframe.org> closed D3660: Merge #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY.
Jul 15 2019, 21:55
Nico Guiton <nico@bitframe.org> committed rABC4f43f6abb432: Merge #11469: fix typo in comment of chain.cpp (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11469: fix typo in comment of chain.cpp
Jul 15 2019, 21:47
Nico Guiton <nico@bitframe.org> closed D3659: Merge #11469: fix typo in comment of chain.cpp.
Jul 15 2019, 21:47
jasonbcox accepted D3659: Merge #11469: fix typo in comment of chain.cpp.
Jul 15 2019, 21:14
jasonbcox accepted D3660: Merge #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY.
Jul 15 2019, 21:14
jasonbcox accepted D3665: wallet: Change output type globals to members.
Jul 15 2019, 21:13
teamcity added a comment to D3502: Added a script to generate chainparams constants header files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 15 2019, 21:13
jasonbcox retitled D3502: Added a script to generate chainparams constants header files from Added a script to generate bestchainparams header files to Added a script to generate chainparams constants header files.
Jul 15 2019, 21:08
teamcity added a comment to D3502: Added a script to generate chainparams constants header files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 15 2019, 21:07
jasonbcox updated the diff for D3502: Added a script to generate chainparams constants header files.
  • Naming changed to generate_chainparams_constants, etc.
  • Utilize existing python code where appropriate.
  • Support for partial updates.
  • Other changes according to feedback.
Jul 15 2019, 21:07
deadalnix committed rABC7cead03ca992: [wallet] Add change type to CCoinControl (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
[wallet] Add change type to CCoinControl
Jul 15 2019, 19:25
deadalnix closed D3662: [wallet] Add change type to CCoinControl.
Jul 15 2019, 19:24
deadalnix committed rABC79fdaf1e1e25: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH (authored by Sjors Provoost <sjors@sprovoost.nl>).
[wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH
Jul 15 2019, 19:20
deadalnix closed D3661: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH.
Jul 15 2019, 19:20
deadalnix committed rABC58bcb91efc72: [qt] receive tab: bech32 address opt-in checkbox (authored by Sjors Provoost <sjors@sprovoost.nl>).
[qt] receive tab: bech32 address opt-in checkbox
Jul 15 2019, 19:17
deadalnix closed D3664: [qt] receive tab: bech32 address opt-in checkbox.
Jul 15 2019, 19:17
teamcity added a comment to D3464: [rpc] Add logging RPC.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 15 2019, 18:27
nakihito updated the summary of D3464: [rpc] Add logging RPC.
Jul 15 2019, 18:19
teamcity added a comment to D3464: [rpc] Add logging RPC.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 15 2019, 18:18
nakihito updated the diff for D3464: [rpc] Add logging RPC.

Added PR11626 to make the logging rpc public.

Jul 15 2019, 18:18
nakihito requested review of D3656: Merge #10793: Changing &var[0] to var.data().
Jul 15 2019, 18:16
teamcity added a comment to D3656: Merge #10793: Changing &var[0] to var.data().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 15 2019, 18:14
teamcity added a comment to D3656: Merge #10793: Changing &var[0] to var.data().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 15 2019, 18:08
deadalnix committed rABC9a7c92d30b2c: Bech32 addresses in dumpwallet (authored by fivepiece <fivepiece@users.noreply.github.com>).
Bech32 addresses in dumpwallet
Jul 15 2019, 17:57
deadalnix closed D3663: Bech32 addresses in dumpwallet.
Jul 15 2019, 17:57
nakihito requested review of D3660: Merge #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY.
Jul 15 2019, 17:18
teamcity added a comment to D3660: Merge #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 15 2019, 17:17
nakihito requested review of D3671: Merge #10777: [tests] Avoid redundant assignments. Remove unused variables.
Jul 15 2019, 17:17
teamcity added a comment to D3671: Merge #10777: [tests] Avoid redundant assignments. Remove unused variables.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 15 2019, 17:15
nakihito requested review of D3658: Merge #10845: Remove unreachable code.
Jul 15 2019, 17:14
teamcity added a comment to D3658: Merge #10845: Remove unreachable code.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 15 2019, 17:13
nakihito requested review of D3659: Merge #11469: fix typo in comment of chain.cpp.
Jul 15 2019, 17:12
teamcity added a comment to D3659: Merge #11469: fix typo in comment of chain.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 15 2019, 17:11
teamcity added a comment to D3660: Merge #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 15 2019, 17:11
teamcity added a comment to D3656: Merge #10793: Changing &var[0] to var.data().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Jul 15 2019, 17:09
teamcity added a comment to D3671: Merge #10777: [tests] Avoid redundant assignments. Remove unused variables.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 15 2019, 17:09
teamcity added a comment to D3659: Merge #11469: fix typo in comment of chain.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 15 2019, 17:01
teamcity added a comment to D3658: Merge #10845: Remove unreachable code.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 15 2019, 17:01
teamcity added a comment to D3656: Merge #10793: Changing &var[0] to var.data().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 15 2019, 17:01
teamcity added a comment to D3661: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 15 2019, 16:54
jasonbcox accepted D3664: [qt] receive tab: bech32 address opt-in checkbox.
Jul 15 2019, 16:51
teamcity added a comment to D3661: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 15 2019, 16:48
jasonbcox accepted D3663: Bech32 addresses in dumpwallet.
Jul 15 2019, 16:43
Mengerian accepted D3675: [refactor multisig] remove redundant counters.

This makes the code more readable for me, so it seems like a good change.

Jul 15 2019, 16:42
teamcity added a comment to D3662: [wallet] Add change type to CCoinControl.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 15 2019, 16:39
jasonbcox accepted D3662: [wallet] Add change type to CCoinControl.
Jul 15 2019, 16:33
teamcity added a comment to D3662: [wallet] Add change type to CCoinControl.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 15 2019, 16:32
jasonbcox accepted D3661: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH.

Talked about it offline. This isn't about backporting for usefulness, but rather paring down ownership on parts of the codebase that we do not want to own at this time.

Jul 15 2019, 16:24
deadalnix accepted D3675: [refactor multisig] remove redundant counters.
Jul 15 2019, 16:20
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC96a1750db941: fix backported comment placement (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
fix backported comment placement
Jul 15 2019, 16:02
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3676: fix backported comment placement.
Jul 15 2019, 16:02
teamcity added a comment to D3676: fix backported comment placement.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 15 2019, 15:11
jasonbcox accepted D3676: fix backported comment placement.
Jul 15 2019, 15:06
teamcity added a comment to D3676: fix backported comment placement.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 15 2019, 15:05
markblundeberg created D3676: fix backported comment placement.
Jul 15 2019, 15:04
teamcity added a comment to D3675: [refactor multisig] remove redundant counters.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 15 2019, 01:16
teamcity added a comment to D3675: [refactor multisig] remove redundant counters.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 15 2019, 01:10
markblundeberg created D3675: [refactor multisig] remove redundant counters.
Jul 15 2019, 01:10
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC10b29ca11538: [refactor multisig] separate nullfail from stack cleanup (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
[refactor multisig] separate nullfail from stack cleanup
Jul 15 2019, 00:54
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3626: [refactor multisig] separate nullfail from stack cleanup.
Jul 15 2019, 00:53
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCce93d43bd963: [refactor multisig] move nulldummy check to front (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
[refactor multisig] move nulldummy check to front
Jul 15 2019, 00:52
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3673: [refactor multisig] move nulldummy check to front.
Jul 15 2019, 00:52
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC5e82569b10e0: [refactor multisig] make const values up front (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
[refactor multisig] make const values up front
Jul 15 2019, 00:48
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3625: [refactor multisig] make const values up front.
Jul 15 2019, 00:47
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCbe9526156bce: remove ComparisonTestFramework dependency from segwit recovery test (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
remove ComparisonTestFramework dependency from segwit recovery test
Jul 15 2019, 00:46
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3674: remove ComparisonTestFramework dependency from segwit recovery test.
Jul 15 2019, 00:46

Jul 14 2019

Mengerian added inline comments to D3625: [refactor multisig] make const values up front.
Jul 14 2019, 19:34
teamcity added a comment to D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 14 2019, 18:00
teamcity added a comment to D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 14 2019, 17:53
deadalnix updated the diff for D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..

Update cland-format to enforce the new style

Jul 14 2019, 17:53
deadalnix commandeered D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..
Jul 14 2019, 17:49
deadalnix accepted D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..
Jul 14 2019, 17:12
deadalnix accepted D3626: [refactor multisig] separate nullfail from stack cleanup.
Jul 14 2019, 17:06
deadalnix accepted D3673: [refactor multisig] move nulldummy check to front.
Jul 14 2019, 17:04
deadalnix accepted D3674: remove ComparisonTestFramework dependency from segwit recovery test.
Jul 14 2019, 16:56
markblundeberg added a comment to D3674: remove ComparisonTestFramework dependency from segwit recovery test.

Note that rejected and reconnect_p2p don't actually get used in this test; could probably be taken out. Initially I was thinking they might come in useful later, now I can't imagine that anything like that would be added.

Jul 14 2019, 15:52
Mengerian added inline comments to D3625: [refactor multisig] make const values up front.
Jul 14 2019, 05:14
teamcity added a comment to D3674: remove ComparisonTestFramework dependency from segwit recovery test.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 14 2019, 02:01
teamcity added a comment to D3674: remove ComparisonTestFramework dependency from segwit recovery test.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 14 2019, 01:55
markblundeberg created D3674: remove ComparisonTestFramework dependency from segwit recovery test.
Jul 14 2019, 01:55
teamcity added a comment to D3473: [refactor multisig] consolidate legacy mode logic.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 14 2019, 01:12
markblundeberg planned changes to D3473: [refactor multisig] consolidate legacy mode logic.
Jul 14 2019, 01:10
teamcity added a comment to D3473: [refactor multisig] consolidate legacy mode logic.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 14 2019, 01:06
markblundeberg updated the diff for D3473: [refactor multisig] consolidate legacy mode logic.

reworked into parents

Jul 14 2019, 01:05
teamcity added a comment to D3626: [refactor multisig] separate nullfail from stack cleanup.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 14 2019, 00:49
markblundeberg abandoned D3540: make check in parallel - turbo mode.
Jul 14 2019, 00:49
teamcity added a comment to D3626: [refactor multisig] separate nullfail from stack cleanup.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 14 2019, 00:44
teamcity added a comment to D3673: [refactor multisig] move nulldummy check to front.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 14 2019, 00:43
markblundeberg updated the diff for D3626: [refactor multisig] separate nullfail from stack cleanup.

reworked parents

Jul 14 2019, 00:43
teamcity added a comment to D3673: [refactor multisig] move nulldummy check to front.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 14 2019, 00:37
markblundeberg created D3673: [refactor multisig] move nulldummy check to front.
Jul 14 2019, 00:37
markblundeberg updated the summary of D3625: [refactor multisig] make const values up front.
Jul 14 2019, 00:23

Jul 13 2019

teamcity added a comment to D3625: [refactor multisig] make const values up front.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 13 2019, 23:57
teamcity added a comment to D3625: [refactor multisig] make const values up front.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 13 2019, 23:51
markblundeberg updated the diff for D3625: [refactor multisig] make const values up front.

update comments & remove unneeded empty line

Jul 13 2019, 23:51
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCc75026cc9771: CONTRIBUTING.md - update instructions on linting dependencies (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
CONTRIBUTING.md - update instructions on linting dependencies
Jul 13 2019, 23:41
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3672: CONTRIBUTING.md - update instructions on linting dependencies.
Jul 13 2019, 23:41
First
Prev
Next