Build Bitcoin-ABC / Diffs / Diff Testing started.
Sep 11 2019
I do not have these cases now. Grepping quickly it seems that wallet.h is the only remaining case now. In any case, considering you *KNOW* about it, why isn't it fixed after a month?
Update the release process doc.
If you want my opinion I would have simply set -x from the very beginning of the script (set -euxo pipefail) and only disable it around the sleep loop.
This script is intended to be run by the CI server, so every trace can be useful in case there is a bug in the script, and the detected parameters are no exception. This has a different purpose than an echo statement which is more of a UI for the script.
Sep 10 2019
Rebased + fixed up verbose logging (set -x) on the new script.
release-process.md needs updating
Rebased off D4029 and added comment changes.
Any reason for not porting the comments changes ?
Will rebase off D4026 soon.
- Removed --tag-commit as it's not necessary
- Minor improvements
- Lots of linting
Sep 9 2019
Added a note regarding various removals of deprecated features.
Clearing this off my queue. See Amaury's comment about CTOR.
Fixes according to feedback
Changed tests to call CreateNewBlock() with default params in as many places as possible. Improve existing tests so that a fallback empty block will not accidentally pass.