Page MenuHomePhabricator
Feed All Stories

Wed, Sep 11

teamcity added a comment to D4035: Remove redundant call to std::move.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Sep 11, 12:33
teamcity added a comment to D4034: Modify ContextualCheckBlockHeader to accept a CChainParam rather than a Config.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Sep 11, 12:32
teamcity added a comment to D4035: Remove redundant call to std::move.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Sep 11, 12:32
deadalnix created D4035: Remove redundant call to std::move.
Wed, Sep 11, 12:32
teamcity added a comment to D4034: Modify ContextualCheckBlockHeader to accept a CChainParam rather than a Config.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Sep 11, 12:25
deadalnix created D4034: Modify ContextualCheckBlockHeader to accept a CChainParam rather than a Config.
Wed, Sep 11, 12:25
deadalnix requested changes to D3750: Merge #12159: Use the character based overload for std::string::find..

I do not have these cases now. Grepping quickly it seems that wallet.h is the only remaining case now. In any case, considering you *KNOW* about it, why isn't it fixed after a month?

Wed, Sep 11, 12:18
teamcity added a comment to D4033: Remove ReadBlockFromDisk's dependency on Config.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Sep 11, 12:10
teamcity added a comment to D4033: Remove ReadBlockFromDisk's dependency on Config.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Sep 11, 12:02
deadalnix created D4033: Remove ReadBlockFromDisk's dependency on Config.
Wed, Sep 11, 12:02
deadalnix accepted D4028: [CMAKE] Move version to the top level CMakeLists.txt.
Wed, Sep 11, 11:56
deadalnix requested changes to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.
Wed, Sep 11, 11:54
teamcity added a comment to D4032: Remove dependency on Config from the PoW code.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Sep 11, 09:33
teamcity added a comment to D4032: Remove dependency on Config from the PoW code.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Sep 11, 09:24
deadalnix created D4032: Remove dependency on Config from the PoW code.
Wed, Sep 11, 09:24
teamcity added a comment to D4031: Use Consensus::Params in ContextualCheckTransaction and variations instead of Config.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Sep 11, 08:18
teamcity added a comment to D4030: Activate consensus rule based on consensus params rather than config.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Sep 11, 08:12
teamcity added a comment to D4031: Use Consensus::Params in ContextualCheckTransaction and variations instead of Config.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Sep 11, 08:09
deadalnix created D4031: Use Consensus::Params in ContextualCheckTransaction and variations instead of Config.
Wed, Sep 11, 08:09
teamcity added a comment to D4030: Activate consensus rule based on consensus params rather than config.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Sep 11, 08:04
deadalnix created D4030: Activate consensus rule based on consensus params rather than config.
Wed, Sep 11, 08:04
teamcity added a comment to D4028: [CMAKE] Move version to the top level CMakeLists.txt.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Wed, Sep 11, 06:35
teamcity added a comment to D4028: [CMAKE] Move version to the top level CMakeLists.txt.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Wed, Sep 11, 06:28
Fabien updated the diff for D4028: [CMAKE] Move version to the top level CMakeLists.txt.

Update the release process doc.

Wed, Sep 11, 06:27
Fabien requested changes to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

If you want my opinion I would have simply set -x from the very beginning of the script (set -euxo pipefail) and only disable it around the sleep loop.
This script is intended to be run by the CI server, so every trace can be useful in case there is a bug in the script, and the detected parameters are no exception. This has a different purpose than an echo statement which is more of a UI for the script.

Wed, Sep 11, 06:22
deadalnix requested changes to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Wed, Sep 11, 04:51

Tue, Sep 10

nakihito requested review of D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Tue, Sep 10, 21:26
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Sep 10, 21:12
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Sep 10, 21:05
teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Sep 10, 21:04
jasonbcox updated the diff for D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Rebased + fixed up verbose logging (set -x) on the new script.

Tue, Sep 10, 21:03
jasonbcox committed rABCa858653e5efc: Merge #12853: qa: Match full plain text by default (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12853: qa: Match full plain text by default
Tue, Sep 10, 20:56
jasonbcox closed D3914: Merge #12853: qa: Match full plain text by default.
Tue, Sep 10, 20:55
nakihito accepted D3914: Merge #12853: qa: Match full plain text by default.
Tue, Sep 10, 20:26
nakihito added inline comments to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Tue, Sep 10, 20:18
jasonbcox requested changes to D4028: [CMAKE] Move version to the top level CMakeLists.txt.

release-process.md needs updating

Tue, Sep 10, 19:54
jasonbcox accepted D4027: [CMAKE] Rename the top-level and `src/` cmake projects.
Tue, Sep 10, 19:53
jasonbcox requested changes to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Tue, Sep 10, 19:52
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Sep 10, 19:34
teamcity added a comment to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Sep 10, 19:27
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Sep 10, 19:22
nakihito updated the summary of D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Tue, Sep 10, 19:21
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Sep 10, 19:21
nakihito updated the diff for D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Rebased off D4029 and added comment changes.

Tue, Sep 10, 19:20
teamcity added a comment to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Sep 10, 19:18
nakihito created D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Tue, Sep 10, 19:17
jasonbcox closed D3809: Added a script to test seeds.
Tue, Sep 10, 18:00
jasonbcox committed rABC897c3e5839f4: Added a script to test seeds (authored by jasonbcox).
Added a script to test seeds
Tue, Sep 10, 18:00
jasonbcox committed rABC7e072905b98c: Added some release notes (authored by jasonbcox).
Added some release notes
Tue, Sep 10, 17:59
jasonbcox closed D4024: Added some release notes.
Tue, Sep 10, 17:59
teamcity added a comment to D4028: [CMAKE] Move version to the top level CMakeLists.txt.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Sep 10, 16:07
teamcity added a comment to D4027: [CMAKE] Rename the top-level and `src/` cmake projects.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Sep 10, 16:03
teamcity added a comment to D4028: [CMAKE] Move version to the top level CMakeLists.txt.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Sep 10, 15:54
Fabien created D4028: [CMAKE] Move version to the top level CMakeLists.txt.
Tue, Sep 10, 15:54
teamcity added a comment to D4027: [CMAKE] Rename the top-level and `src/` cmake projects.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Sep 10, 15:54
Fabien created D4027: [CMAKE] Rename the top-level and `src/` cmake projects.
Tue, Sep 10, 15:53
Fabien committed rABC89c6acf0d2f4: [CI] Improve error catching and build log verbosity (authored by Fabien).
[CI] Improve error catching and build log verbosity
Tue, Sep 10, 08:33
Fabien closed D3992: [CI] Improve error catching and build log verbosity.
Tue, Sep 10, 08:32
Fabien requested changes to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Any reason for not porting the comments changes ?

Tue, Sep 10, 06:42
Fabien accepted D4021: Merge #13149: Handle unsuccessful fseek(...):s.
Tue, Sep 10, 06:37
Fabien accepted D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.
Tue, Sep 10, 06:24
Fabien accepted D3914: Merge #12853: qa: Match full plain text by default.
Tue, Sep 10, 06:19
Fabien accepted D3809: Added a script to test seeds.
Tue, Sep 10, 06:19
Fabien accepted D4024: Added some release notes.
Tue, Sep 10, 06:17
teamcity added a comment to D4014: [CI] Make IBD a standard build configuration.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing passed.

Tue, Sep 10, 02:35
nakihito planned changes to D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
Tue, Sep 10, 01:21
nakihito added a comment to D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.

Will rebase off D4026 soon.

Tue, Sep 10, 01:14
teamcity added a comment to D3714: Added a script for creating Github release drafts.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Sep 10, 00:50
teamcity added a comment to D3714: Added a script for creating Github release drafts.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Sep 10, 00:38
jasonbcox planned changes to D3714: Added a script for creating Github release drafts.
Tue, Sep 10, 00:38
jasonbcox updated the diff for D3714: Added a script for creating Github release drafts.
  • Minor improvements
  • Lots of linting
Tue, Sep 10, 00:38
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Tue, Sep 10, 00:37
nakihito updated the summary of D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
Tue, Sep 10, 00:27
teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Tue, Sep 10, 00:26
nakihito created D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Tue, Sep 10, 00:26

Mon, Sep 9

teamcity added a comment to D4024: Added some release notes.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Sep 9, 22:24
teamcity added a comment to D4024: Added some release notes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Sep 9, 22:17
jasonbcox updated the diff for D4024: Added some release notes.

Added a note regarding various removals of deprecated features.

Mon, Sep 9, 22:17
jasonbcox requested changes to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Clearing this off my queue. See Amaury's comment about CTOR.

Mon, Sep 9, 22:07
jasonbcox requested changes to D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
Mon, Sep 9, 22:05
teamcity added a comment to D3809: Added a script to test seeds.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Sep 9, 21:53
teamcity added a comment to D3809: Added a script to test seeds.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Sep 9, 21:46
jasonbcox updated the diff for D3809: Added a script to test seeds.

Fixes according to feedback

Mon, Sep 9, 21:45
teamcity added a comment to D4025: Added empty block fallback to CreateNewBlock.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Sep 9, 20:35
teamcity added a comment to D4025: Added empty block fallback to CreateNewBlock.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Sep 9, 20:28
jasonbcox updated the diff for D4025: Added empty block fallback to CreateNewBlock.

Changed tests to call CreateNewBlock() with default params in as many places as possible. Improve existing tests so that a fallback empty block will not accidentally pass.

Mon, Sep 9, 20:28
teamcity added a comment to D4025: Added empty block fallback to CreateNewBlock.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Sep 9, 20:09
jasonbcox planned changes to D4025: Added empty block fallback to CreateNewBlock.
Mon, Sep 9, 20:05
teamcity added a comment to D4025: Added empty block fallback to CreateNewBlock.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Sep 9, 20:02
jasonbcox created D4025: Added empty block fallback to CreateNewBlock.
Mon, Sep 9, 20:02
Fabien requested changes to D3809: Added a script to test seeds.
Mon, Sep 9, 19:02
nakihito requested review of D3750: Merge #12159: Use the character based overload for std::string::find..
Mon, Sep 9, 18:25
Nico Guiton <nico@bitframe.org> committed rABC28c6e32e5d03: Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak
Mon, Sep 9, 18:18
Nico Guiton <nico@bitframe.org> closed D3542: Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak.
Mon, Sep 9, 18:18
teamcity added a comment to D4024: Added some release notes.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Sep 9, 18:14
Nico Guiton <nico@bitframe.org> committed rABC4dc32c990aa6: Merge #12928: qt: Initialize non-static class members that were previously… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12928: qt: Initialize non-static class members that were previously…
Mon, Sep 9, 18:11
Nico Guiton <nico@bitframe.org> closed D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.
Mon, Sep 9, 18:11
teamcity added a comment to D4024: Added some release notes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Mon, Sep 9, 18:07
jasonbcox created D4024: Added some release notes.
Mon, Sep 9, 18:07
teamcity added a comment to D3914: Merge #12853: qa: Match full plain text by default.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Mon, Sep 9, 17:51