Page MenuHomePhabricator
Feed All Stories

Jun 23 2020

Fabien planned changes to D6675: Do not review.
Jun 23 2020, 09:32
teamcity added a comment to D6675: Do not review.
Jun 23 2020, 09:31
Fabien updated the diff for D6675: Do not review.

Rebase

Jun 23 2020, 09:19
Fabien updated the diff for D6627: [CI] Add a build plan to run clang-tidy on the changed files.

Pass the clang-tidy binary to the script

Jun 23 2020, 09:19
Fabien planned changes to D6627: [CI] Add a build plan to run clang-tidy on the changed files.
Jun 23 2020, 09:10
teamcity added a comment to D6675: Do not review.
Jun 23 2020, 09:09
Fabien planned changes to D6675: Do not review.
Jun 23 2020, 08:53
Fabien updated the diff for D6675: Do not review.

Rebase due to D6676

Jun 23 2020, 08:52
Fabien updated the diff for D6627: [CI] Add a build plan to run clang-tidy on the changed files.

Rebase on top of D6676

Jun 23 2020, 08:52
Fabien added a comment to D6676: Revert "[CI] Install the latest wine version from the winehq repository".

@bot build-win64

Jun 23 2020, 08:50
Fabien requested review of D6676: Revert "[CI] Install the latest wine version from the winehq repository".
Jun 23 2020, 08:39
Fabien added a reverting change for D6639: [CI] Install the latest wine version from the winehq repository: D6676: Revert "[CI] Install the latest wine version from the winehq repository".
Jun 23 2020, 08:39
Fabien added a reverting change for rABCb25c0bf30ae0: [CI] Install the latest wine version from the winehq repository: D6676: Revert "[CI] Install the latest wine version from the winehq repository".
Jun 23 2020, 08:39
teamcity added a comment to D6675: Do not review.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Jun 23 2020, 07:37
teamcity added a comment to D6675: Do not review.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Jun 23 2020, 07:37
teamcity added a comment to D6675: Do not review.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Jun 23 2020, 07:37
teamcity added a comment to D6627: [CI] Add a build plan to run clang-tidy on the changed files.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Jun 23 2020, 07:36
Fabien planned changes to D6675: Do not review.
Jun 23 2020, 07:32
Fabien requested review of D6675: Do not review.
Jun 23 2020, 07:32
Fabien updated the diff for D6627: [CI] Add a build plan to run clang-tidy on the changed files.

Change "errors" to "issues" in the message and move the file to the build dir.

Jun 23 2020, 07:31
Fabien updated the diff for D6627: [CI] Add a build plan to run clang-tidy on the changed files.

Rebase

Jun 23 2020, 07:15
Fabien accepted D6626: [backport#15427 3/3] Add support for descriptors to utxoupdatepsbt.
Jun 23 2020, 07:13
Fabien accepted D6674: test: add invalid tx templates for use in functional tests.
Jun 23 2020, 07:13
Fabien accepted D6673: [refactor] rename stateDummy -> orphan_state.
Jun 23 2020, 06:53
deadalnix requested review of D6674: test: add invalid tx templates for use in functional tests.
Jun 23 2020, 01:24

Jun 22 2020

teamcity added a comment to D6673: [refactor] rename stateDummy -> orphan_state.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 22 2020, 23:34
teamcity updated the summary of D6673: [refactor] rename stateDummy -> orphan_state.
Jun 22 2020, 23:34
deadalnix requested review of D6673: [refactor] rename stateDummy -> orphan_state.
Jun 22 2020, 23:34
nakihito planned changes to D6283: [seeder] Request headers from new connections.
Jun 22 2020, 22:55
nakihito updated the diff for D6283: [seeder] Request headers from new connections.

Added includes for primitives/blockhash.h and chainparams.h.

Jun 22 2020, 22:55
nakihito planned changes to D5987: Start using Logger for seeder logging.
Jun 22 2020, 22:35
nakihito updated the diff for D5987: Start using Logger for seeder logging.

Changed initialization code and new options to more closely resemble InitLogging().

Jun 22 2020, 22:35
nakihito committed rABC85999eb1fe47: Merge #13418: Docs: More precise explanation of parameter onlynet (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #13418: Docs: More precise explanation of parameter onlynet
Jun 22 2020, 21:51
nakihito closed D6672: Merge #13418: Docs: More precise explanation of parameter onlynet.
Jun 22 2020, 21:50
deadalnix added a comment to D6627: [CI] Add a build plan to run clang-tidy on the changed files.

Can we see what CI reports?

Jun 22 2020, 21:48
deadalnix accepted D6626: [backport#15427 3/3] Add support for descriptors to utxoupdatepsbt.
Jun 22 2020, 21:47
deadalnix accepted D6666: [backport#10574] Remove includes in .cpp files for things the corresponding .h file already included.
Jun 22 2020, 21:42
Fabien accepted D6669: Merge #14051: [Tests] Make combine_logs.py handle multi-line logs.
Jun 22 2020, 21:02
Fabien accepted D6665: [backport#16512] rpc: Shuffle inputs and outputs after joining psbts.
Jun 22 2020, 20:50
Fabien accepted D6672: Merge #13418: Docs: More precise explanation of parameter onlynet.
Jun 22 2020, 20:42
teamcity closed T966: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
Jun 22 2020, 18:38
nakihito committed rABCedc303d7a396: Merge #13457: tests: Drop variadic macro (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13457: tests: Drop variadic macro
Jun 22 2020, 18:23
nakihito closed D6671: Merge #13457: tests: Drop variadic macro.
Jun 22 2020, 18:22
teamcity added a comment to D6672: Merge #13418: Docs: More precise explanation of parameter onlynet.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 22 2020, 18:20
teamcity updated the summary of D6672: Merge #13418: Docs: More precise explanation of parameter onlynet.
Jun 22 2020, 18:20
nakihito requested review of D6672: Merge #13418: Docs: More precise explanation of parameter onlynet.
Jun 22 2020, 18:20
jasonbcox accepted D6671: Merge #13457: tests: Drop variadic macro.
Jun 22 2020, 18:14
teamcity added a comment to D6671: Merge #13457: tests: Drop variadic macro.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 22 2020, 18:05
teamcity updated the summary of D6671: Merge #13457: tests: Drop variadic macro.
Jun 22 2020, 18:05
nakihito requested review of D6671: Merge #13457: tests: Drop variadic macro.
Jun 22 2020, 18:05
jasonbcox updated the summary of D6667: [DO NOT REVIEW] PATCH TEST 1.
Jun 22 2020, 17:34
jasonbcox planned changes to D6667: [DO NOT REVIEW] PATCH TEST 1.
Jun 22 2020, 17:33
jasonbcox updated the diff for D6667: [DO NOT REVIEW] PATCH TEST 1.

Rebase on D6669

Jun 22 2020, 17:33
jasonbcox updated the summary of D6669: Merge #14051: [Tests] Make combine_logs.py handle multi-line logs.
Jun 22 2020, 17:31
jasonbcox requested review of D6669: Merge #14051: [Tests] Make combine_logs.py handle multi-line logs.
Jun 22 2020, 17:30
jasonbcox planned changes to D6668: [DO NOT REVIEW] PATCH TEST 2.
Jun 22 2020, 16:55
jasonbcox requested review of D6668: [DO NOT REVIEW] PATCH TEST 2.
Jun 22 2020, 16:55
jasonbcox planned changes to D6667: [DO NOT REVIEW] PATCH TEST 1.
Jun 22 2020, 16:54
jasonbcox requested review of D6667: [DO NOT REVIEW] PATCH TEST 1.
Jun 22 2020, 16:54
teamcity added a comment to D6666: [backport#10574] Remove includes in .cpp files for things the corresponding .h file already included.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 22 2020, 11:46
teamcity updated the summary of D6666: [backport#10574] Remove includes in .cpp files for things the corresponding .h file already included.
Jun 22 2020, 11:46
majcosta requested review of D6666: [backport#10574] Remove includes in .cpp files for things the corresponding .h file already included.
Jun 22 2020, 11:46
teamcity triaged T966: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Unbreak Now! priority.
Jun 22 2020, 09:29
majcosta committed rABC355883604d02: [backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet… (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
[backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet…
Jun 22 2020, 09:09
majcosta closed D6664: [backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction.
Jun 22 2020, 09:08
majcosta committed rABCa06ba8d57a91: [backport#14935] tests: Test for expected return values when calling functions… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#14935] tests: Test for expected return values when calling functions…
Jun 22 2020, 09:08
majcosta closed D6663: [backport#14935] tests: Test for expected return values when calling functions returning a success code.
Jun 22 2020, 09:08
majcosta committed rABC06b3ec662d6f: [backport#16079] wallet_balance.py: Prevent edge cases (authored by Steven Roose <steven@stevenroose.org>).
[backport#16079] wallet_balance.py: Prevent edge cases
Jun 22 2020, 09:06
majcosta closed D6661: [backport#16079] wallet_balance.py: Prevent edge cases.
Jun 22 2020, 09:06
Fabien accepted D6663: [backport#14935] tests: Test for expected return values when calling functions returning a success code.
Jun 22 2020, 08:36
Fabien accepted D6660: [backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertParam tables.
Jun 22 2020, 08:36
majcosta updated the diff for D6626: [backport#15427 3/3] Add support for descriptors to utxoupdatepsbt.

removed additional segwit/bech32 references

Jun 22 2020, 08:31
teamcity added a comment to D6665: [backport#16512] rpc: Shuffle inputs and outputs after joining psbts.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 22 2020, 08:29
teamcity updated the summary of D6665: [backport#16512] rpc: Shuffle inputs and outputs after joining psbts.
Jun 22 2020, 08:29
majcosta requested review of D6665: [backport#16512] rpc: Shuffle inputs and outputs after joining psbts.
Jun 22 2020, 08:28
majcosta updated the diff for D6660: [backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertParam tables.

removed segwit references

Jun 22 2020, 08:27
majcosta updated the summary of D6663: [backport#14935] tests: Test for expected return values when calling functions returning a success code.
Jun 22 2020, 08:25
majcosta updated the diff for D6663: [backport#14935] tests: Test for expected return values when calling functions returning a success code.

squashed PR14969 into the diff for TSAN fix

Jun 22 2020, 08:24
Fabien accepted D6664: [backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction.
Jun 22 2020, 08:05
Fabien requested changes to D6663: [backport#14935] tests: Test for expected return values when calling functions returning a success code.
Jun 22 2020, 08:01
majcosta abandoned D6662: [backport#14953] test: Make g_insecure_rand_ctx thread_local.
Jun 22 2020, 07:46
majcosta added a comment to D6662: [backport#14953] test: Make g_insecure_rand_ctx thread_local.
Jun 22 2020, 07:45
Fabien requested changes to D6662: [backport#14953] test: Make g_insecure_rand_ctx thread_local.

NACK, see https://github.com/bitcoin/bitcoin/pull/14985, and also D3485 and D3628.

Jun 22 2020, 07:41
Fabien accepted D6661: [backport#16079] wallet_balance.py: Prevent edge cases.
Jun 22 2020, 07:39
Fabien requested changes to D6660: [backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertParam tables.
Jun 22 2020, 07:35
teamcity updated the summary of D6664: [backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction.
Jun 22 2020, 07:09
teamcity added a comment to D6664: [backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 22 2020, 07:09
majcosta requested review of D6664: [backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction.
Jun 22 2020, 07:08
teamcity added a comment to D6663: [backport#14935] tests: Test for expected return values when calling functions returning a success code.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 22 2020, 06:23
teamcity updated the summary of D6663: [backport#14935] tests: Test for expected return values when calling functions returning a success code.
Jun 22 2020, 06:23
majcosta requested review of D6663: [backport#14935] tests: Test for expected return values when calling functions returning a success code.
Jun 22 2020, 06:23
teamcity added a comment to D6662: [backport#14953] test: Make g_insecure_rand_ctx thread_local.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 22 2020, 06:08
teamcity updated the summary of D6662: [backport#14953] test: Make g_insecure_rand_ctx thread_local.
Jun 22 2020, 06:08
majcosta requested review of D6662: [backport#14953] test: Make g_insecure_rand_ctx thread_local.
Jun 22 2020, 06:08
teamcity added a comment to D6661: [backport#16079] wallet_balance.py: Prevent edge cases.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 22 2020, 05:07
teamcity updated the summary of D6661: [backport#16079] wallet_balance.py: Prevent edge cases.
Jun 22 2020, 05:07
majcosta requested review of D6661: [backport#16079] wallet_balance.py: Prevent edge cases.
Jun 22 2020, 05:06
teamcity added a comment to D6660: [backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertParam tables.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 22 2020, 04:52
teamcity updated the summary of D6660: [backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertParam tables.
Jun 22 2020, 04:52
majcosta requested review of D6660: [backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertParam tables.
Jun 22 2020, 04:52