Oct 25 2023
Minor editing fixes
Add point about ensuring the node has good connectivity
use a scope to avoid shadowing [init_status, init_error], remove the "continued" comments I missed, fix func duplication in logging, remove pointless and misplaced XXX comment
rename cs -> pchainstate
It seems a bit silly to add two new params to a function just for a log line, but I think it is best to stay close to the source material on this, to reduce head-scratching and git blaming on future backports..
Better wording
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41480 for the next 60 minutes.
@bot preview-e.cash
I think one more thing miner nodes should do is to ensure they have good connectivity with recommendations like:
- Make sure the node accepts inbound connections
- Make sure the node accepts both IPv4 and IPv6
- Make sure there is no restriction in the number of connections (no maxconnection config set)
- etc.
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41534 for the next 60 minutes.
use braces
Add source to commit message
quick note - if you end up going through with this you'll need to remove this button from SendToken.js as well
Worth noting this would be implemented at the point of pressing the register button and not when the user is inputting the alias name with each keystroke being parsed for validity. I can add it as a conditional text render in the registration confirmation modal (preparePreviewModal).
Oct 24 2023
Getting cargo build to work
Add type, remove unused params for handle_chronik_info
To do: Make a codeblock component, rather then using inline styles. that can be in another Diff though
Change example to mainnet
Minor edits per review comments
Add example of expected output from getblocktemplate
improve comments, remove unnecessary array
The alias registration input field now detects whether an input (without needing to click Register Alias) already has a pending tx for this wallet and renders a non-blocking warning.