This is just too big and unfortunately, too littered with errors to be trusted. Reviewing this kind of patches impose a very high cognitive load on the reviewer. This will need to improve or the review cycle is going to be very slow.

Sep 12 2019, 08:51

deadalnix accepted D3915: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages.

Sep 12 2019, 08:27

Fabien committed rABC43f64b728bb5: [CMAKE] Fix Linux64 toolchain name (authored by Fabien).

[CMAKE] Fix Linux64 toolchain name

Sep 12 2019, 08:26

Fabien closed D4038: [CMAKE] Fix Linux64 toolchain name.

Sep 12 2019, 08:26

deadalnix accepted D3856: Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock.

Sep 12 2019, 08:24

deadalnix accepted D3750: Merge #12159: Use the character based overload for std::string::find..

Sep 12 2019, 08:18

deadalnix committed rABCee8d40aec77e: Source the Excessive block size from BlockValidationOptions (authored by deadalnix).

Source the Excessive block size from BlockValidationOptions

Sep 12 2019, 08:16

deadalnix closed D4048: Source the Excessive block size from BlockValidationOptions.

Sep 12 2019, 08:16

teamcity added a comment to D4048: Source the Excessive block size from BlockValidationOptions.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 12 2019, 07:38

Fabien accepted D4048: Source the Excessive block size from BlockValidationOptions.

Sep 12 2019, 07:33

teamcity added a comment to D4048: Source the Excessive block size from BlockValidationOptions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 12 2019, 07:31

deadalnix updated the diff for D4048: Source the Excessive block size from BlockValidationOptions.

Build outside the loop

Sep 12 2019, 07:31

deadalnix added inline comments to D4048: Source the Excessive block size from BlockValidationOptions.

Sep 12 2019, 07:27

deadalnix added inline comments to D3968: Merge #12885: Reduce implementation code inside CScript.

Sep 12 2019, 07:26

deadalnix requested changes to D3968: Merge #12885: Reduce implementation code inside CScript.

Sep 12 2019, 07:25

Fabien added inline comments to D4049: Remove CheckBlock's dependency on Config.

Sep 12 2019, 07:25

deadalnix accepted D4038: [CMAKE] Fix Linux64 toolchain name.

Sep 12 2019, 07:17

Fabien requested changes to D4048: Source the Excessive block size from BlockValidationOptions.

Sep 12 2019, 07:07

teamcity added a comment to D4049: Remove CheckBlock's dependency on Config.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 12 2019, 07:07

teamcity added a comment to D4049: Remove CheckBlock's dependency on Config.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 12 2019, 06:58

deadalnix created D4049: Remove CheckBlock's dependency on Config.

Sep 12 2019, 06:58

Fabien accepted D4047: Merge #13983: rpc: Return more specific reject reason for submitblock.

Sep 12 2019, 06:38

Fabien requested changes to D4046: Merge #13399: rpc: Add submitheader.

Code looks good, but this deserves a release note.

Sep 12 2019, 06:27

Fabien accepted D4044: Fixes compilation of leveldb tests broken in D4004.

Sep 12 2019, 06:14

teamcity added a comment to D4048: Source the Excessive block size from BlockValidationOptions.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 12 2019, 06:03

teamcity added a comment to D4048: Source the Excessive block size from BlockValidationOptions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 12 2019, 05:55

deadalnix created D4048: Source the Excessive block size from BlockValidationOptions.

Sep 12 2019, 05:55

teamcity added a comment to D4014: [CI] Make IBD a standard build configuration.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing passed.

Sep 12 2019, 02:27

Sep 11 2019

teamcity added a comment to D4045: Revert change to ActivateBestChain() comments made in D1182.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 23:59

teamcity added a comment to D4045: Revert change to ActivateBestChain() comments made in D1182.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 23:50

nakihito updated the diff for D4045: Revert change to ActivateBestChain() comments made in D1182.

Removed punctuation at end of comment.

Sep 11 2019, 23:50

nakihito planned changes to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Sep 11 2019, 21:43

teamcity added a comment to D3856: Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 21:29

teamcity added a comment to D4047: Merge #13983: rpc: Return more specific reject reason for submitblock.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 21:24

teamcity added a comment to D4014: [CI] Make IBD a standard build configuration.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing started.

Sep 11 2019, 21:23

jasonbcox accepted D4045: Revert change to ActivateBestChain() comments made in D1182.

Sep 11 2019, 21:21

jasonbcox requested review of D3856: Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock.

Sep 11 2019, 21:19

teamcity added a comment to D3856: Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 21:19

jasonbcox updated the diff for D3856: Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock.

D4047 (T686) is ready for review. Consider it while reviewing this change and I will land the stack together once they're all green.

Sep 11 2019, 21:18

teamcity added a comment to D4047: Merge #13983: rpc: Return more specific reject reason for submitblock.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 21:16

jasonbcox created D4047: Merge #13983: rpc: Return more specific reject reason for submitblock.

Sep 11 2019, 21:16

teamcity added a comment to D4046: Merge #13399: rpc: Add submitheader.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 21:16

teamcity added a comment to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 21:11

teamcity added a comment to D4046: Merge #13399: rpc: Add submitheader.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 21:08

jasonbcox created D4046: Merge #13399: rpc: Add submitheader.

Sep 11 2019, 21:07

teamcity added a comment to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 20:57

nakihito planned changes to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.

Sep 11 2019, 20:56

nakihito updated the diff for D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.

Rebased off D4045.

Sep 11 2019, 20:56

teamcity added a comment to D4045: Revert change to ActivateBestChain() comments made in D1182.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 20:53

teamcity added a comment to D3750: Merge #12159: Use the character based overload for std::string::find..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 20:52

nakihito planned changes to D3935: Merge #11411: script: Change SignatureHash input index check to an assert..

Sep 11 2019, 20:43

teamcity added a comment to D4045: Revert change to ActivateBestChain() comments made in D1182.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 20:43

nakihito updated the summary of D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.

Sep 11 2019, 20:42

teamcity added a comment to D4045: Revert change to ActivateBestChain() comments made in D1182.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 20:41

teamcity added a comment to D4045: Revert change to ActivateBestChain() comments made in D1182.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 20:40

nakihito created D4045: Revert change to ActivateBestChain() comments made in D1182.

Sep 11 2019, 20:40

teamcity added a comment to D3750: Merge #12159: Use the character based overload for std::string::find..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 11 2019, 20:40

nakihito updated the diff for D3750: Merge #12159: Use the character based overload for std::string::find..

Fixed nit.

Sep 11 2019, 20:40

fpelliccioni committed rABC39e41a449cfb: Do not construct out-of-bound pointers in SHA2 code (authored by Pieter Wuille <pieter.wuille@gmail.com>).

Do not construct out-of-bound pointers in SHA2 code

Sep 11 2019, 20:32

fpelliccioni closed D4018: Do not construct out-of-bound pointers in SHA2 code.

Sep 11 2019, 20:32

jasonbcox accepted D4042: Merge #11220: Check specific validation error in miner tests.

Sep 11 2019, 20:31

jasonbcox requested changes to D3750: Merge #12159: Use the character based overload for std::string::find..

Sep 11 2019, 20:26

teamcity added a comment to D4018: Do not construct out-of-bound pointers in SHA2 code.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 11 2019, 20:19

nakihito planned changes to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Sep 11 2019, 20:12

All StoriesUse ResultsEdit QueryHide Query

Sep 12 2019

Sep 11 2019

All Stories
Use Results
Edit Query
Hide Query