Page MenuHomePhabricator
Feed All Stories

Nov 11 2019

deadalnix added inline comments to D4420: Output descriptors module.
Nov 11 2019, 14:30
deadalnix committed rABC11ca044a129f: Add scantxoutset RPC method (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Add scantxoutset RPC method
Nov 11 2019, 14:16
deadalnix closed D4357: Add scantxoutset RPC method.
Nov 11 2019, 14:16
Fabien requested changes to D4420: Output descriptors module.

LGTM excepted a few nits

Nov 11 2019, 13:12
teamcity added a comment to D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 11 2019, 12:30
teamcity added a comment to D4426: [CMAKE] Strip the osx bundle binary.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 11 2019, 12:20
teamcity added a comment to D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 11 2019, 12:15
Fabien updated the diff for D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Reduce the amount of dependencies required by rebasing on top of D4425.
Disable ccache for the build.

Nov 11 2019, 12:15
Fabien updated the summary of D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.
Nov 11 2019, 12:14
teamcity added a comment to D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 11 2019, 12:13
teamcity added a comment to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 11 2019, 12:13
teamcity added a comment to D4426: [CMAKE] Strip the osx bundle binary.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 11 2019, 12:12
Fabien created D4426: [CMAKE] Strip the osx bundle binary.
Nov 11 2019, 12:11
teamcity added a comment to D4425: [CMAKE] Avoid dependencies when building native bin during cross build.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 11 2019, 12:01
teamcity added a comment to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 11 2019, 11:56
Fabien updated the diff for D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Reduce the amount of dependencies required by rebasing on top of D4425.
Disable ccache for the build.

Nov 11 2019, 11:56
Fabien updated the summary of D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.
Nov 11 2019, 11:55
teamcity added a comment to D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 11 2019, 11:54
Fabien updated the diff for D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.

Reduce the amount of dependencies required by rebasing on top of D4425.
Disable ccache for the build.

Nov 11 2019, 11:54
Fabien updated the summary of D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.
Nov 11 2019, 11:52
teamcity added a comment to D4425: [CMAKE] Avoid dependencies when building native bin during cross build.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 11 2019, 11:51
Fabien created D4425: [CMAKE] Avoid dependencies when building native bin during cross build.
Nov 11 2019, 11:51
Fabien accepted D4357: Add scantxoutset RPC method.
Nov 11 2019, 11:28
teamcity added a comment to D4384: [CMAKE] Actually build the DMG image.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 11 2019, 10:20
teamcity added a comment to D4384: [CMAKE] Actually build the DMG image.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 11 2019, 10:03
Fabien planned changes to D4406: [CMAKE] Build a stripped version of the application bundle and use it.

I have another solution which can be more elegant to this problem, so moving this diff out of the review queue for now.

Nov 11 2019, 09:33
Fabien updated the diff for D4384: [CMAKE] Actually build the DMG image.

Rebase.

Nov 11 2019, 09:23
Fabien committed rABC755aac0bbfd6: [CMAKE] Install DLL to bin/ by default (authored by Fabien).
[CMAKE] Install DLL to bin/ by default
Nov 11 2019, 09:22
Fabien closed D4403: [CMAKE] Install DLL to bin/ by default.
Nov 11 2019, 09:22
Fabien committed rABC146f6e2a8079: [CMAKE] Complete the dist directory to prepare for the DMG image build (authored by Fabien).
[CMAKE] Complete the dist directory to prepare for the DMG image build
Nov 11 2019, 09:20
Fabien closed D4383: [CMAKE] Complete the dist directory to prepare for the DMG image build.
Nov 11 2019, 09:20
Fabien committed rABCa823d2833233: [CMAKE] Build the background dist image on native OSX (authored by Fabien).
[CMAKE] Build the background dist image on native OSX
Nov 11 2019, 09:19
Fabien closed D4382: [CMAKE] Build the background dist image on native OSX.
Nov 11 2019, 09:19
Fabien committed rABCa2e804693cdc: [CMAKE] Add the background image to the dist directory (authored by Fabien).
[CMAKE] Add the background image to the dist directory
Nov 11 2019, 09:19
Fabien closed D4381: [CMAKE] Add the background image to the dist directory.
Nov 11 2019, 09:18
Fabien committed rABCa89e8e99843f: [CMAKE] Create a distribution directory with translations (authored by Fabien).
[CMAKE] Create a distribution directory with translations
Nov 11 2019, 09:18
Fabien closed D4380: [CMAKE] Create a distribution directory with translations.
Nov 11 2019, 09:18
Fabien committed rABC21a33b011a58: [CMAKE] Prepare the application bundle for localization (authored by Fabien).
[CMAKE] Prepare the application bundle for localization
Nov 11 2019, 09:16
Fabien closed D4379: [CMAKE] Prepare the application bundle for localization.
Nov 11 2019, 09:16
teamcity added a comment to D4424: Add outputtype module.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 11 2019, 01:14
teamcity added a comment to D4424: Add outputtype module.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 11 2019, 01:04
deadalnix created D4424: Add outputtype module.
Nov 11 2019, 01:03

Nov 10 2019

teamcity added a comment to D4423: Get rid of ambiguous OutputType::NONE value.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 10 2019, 17:47
deadalnix added a comment to D4419: Modify CSeederNode to allow more testing.

You can include this with the test. It's not really possible to figure out if that is a good idea or not without having an idea of where this is going.

Nov 10 2019, 17:40
teamcity added a comment to D4423: Get rid of ambiguous OutputType::NONE value.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 10 2019, 17:36
deadalnix created D4423: Get rid of ambiguous OutputType::NONE value.
Nov 10 2019, 17:36
deadalnix requested changes to D4415: [CI] Allow to pass addditional arguments to bitcoind.
Nov 10 2019, 16:01
deadalnix requested changes to D4418: Add simple unit tests for parse_name().
Nov 10 2019, 15:50
Fabien requested review of D4406: [CMAKE] Build a stripped version of the application bundle and use it.
Nov 10 2019, 15:42
deadalnix requested changes to D4417: Add a separate executable for seeder tests.
Nov 10 2019, 15:32
deadalnix requested changes to D4300: Integrate gArgs and chainparams into the Seeder.
Nov 10 2019, 13:43
deadalnix added inline comments to D4406: [CMAKE] Build a stripped version of the application bundle and use it.
Nov 10 2019, 13:27
deadalnix requested changes to D4406: [CMAKE] Build a stripped version of the application bundle and use it.
Nov 10 2019, 13:05
deadalnix requested changes to D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Depending on system libs will cause the build to not be reproducible. You need to be using depends libs.

Nov 10 2019, 12:58
deadalnix requested changes to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

You need to be using the depends libs and not the system's.

Nov 10 2019, 12:57
deadalnix requested changes to D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.

You need to be using the libs from depends and not the system libs.

Nov 10 2019, 12:56
deadalnix accepted D4403: [CMAKE] Install DLL to bin/ by default.
Nov 10 2019, 12:55

Nov 9 2019

teamcity added a comment to D4422: Add descriptor reference documentation.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 9 2019, 23:16
teamcity added a comment to D4421: Swap in descriptors support into scantxoutset.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 9 2019, 23:03
teamcity added a comment to D4422: Add descriptor reference documentation.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 9 2019, 22:59
deadalnix created D4422: Add descriptor reference documentation.
Nov 9 2019, 22:59
teamcity added a comment to D4421: Swap in descriptors support into scantxoutset.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 9 2019, 22:53
deadalnix created D4421: Swap in descriptors support into scantxoutset.
Nov 9 2019, 22:53
teamcity added a comment to D4420: Output descriptors module.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 9 2019, 22:52
teamcity added a comment to D4420: Output descriptors module.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 9 2019, 22:43
deadalnix created D4420: Output descriptors module.
Nov 9 2019, 22:43
teamcity added a comment to D4357: Add scantxoutset RPC method.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 9 2019, 22:42
teamcity added a comment to D4357: Add scantxoutset RPC method.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 9 2019, 22:32
deadalnix updated the diff for D4357: Add scantxoutset RPC method.

Remove release notes. Will add them back when backporting PR13697 and PR14096

Nov 9 2019, 22:32
Harbormaster failed remote builds in B8047: Diff 14031 for D4357: Add scantxoutset RPC method!
Nov 9 2019, 22:28
teamcity added a comment to D4357: Add scantxoutset RPC method.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Nov 9 2019, 22:28
teamcity added a comment to D4357: Add scantxoutset RPC method.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 9 2019, 22:22
deadalnix updated the diff for D4357: Add scantxoutset RPC method.

Rebase

Nov 9 2019, 22:22
deadalnix added inline comments to D4357: Add scantxoutset RPC method.
Nov 9 2019, 22:22
deadalnix committed rABC39959c11347e: Add simple FlatSigningProvider (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Add simple FlatSigningProvider
Nov 9 2019, 19:56
deadalnix closed D4360: Add simple FlatSigningProvider.
Nov 9 2019, 19:56
deadalnix committed rABC2633916fbb90: Tests for PSBT (authored by Andrew Chow <achow101-github@achow101.com>).
Tests for PSBT
Nov 9 2019, 19:49
deadalnix closed D4353: Tests for PSBT.
Nov 9 2019, 19:49
deadalnix committed rABCf25d2ad300d9: Create wallet RPCs for PSBT (authored by Andrew Chow <achow101-github@achow101.com>).
Create wallet RPCs for PSBT
Nov 9 2019, 19:37
deadalnix closed D4352: Create wallet RPCs for PSBT.
Nov 9 2019, 19:37
jasonbcox committed rABC03d22b4335e1: Bump version to 0.20.7 (authored by jasonbcox).
Bump version to 0.20.7
Nov 9 2019, 19:13
jasonbcox closed D4414: Bump version to 0.20.7.
Nov 9 2019, 19:13
Fabien accepted D4353: Tests for PSBT.
Nov 9 2019, 17:24
Fabien accepted D4352: Create wallet RPCs for PSBT.
Nov 9 2019, 17:22
teamcity added a comment to D4353: Tests for PSBT.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 9 2019, 16:55
teamcity added a comment to D4353: Tests for PSBT.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 9 2019, 16:46
deadalnix updated the diff for D4353: Tests for PSBT.

Update as per comments

Nov 9 2019, 16:46
deadalnix added inline comments to D4353: Tests for PSBT.
Nov 9 2019, 16:40
teamcity added a comment to D4352: Create wallet RPCs for PSBT.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 9 2019, 16:10
teamcity added a comment to D4352: Create wallet RPCs for PSBT.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 9 2019, 15:59
deadalnix updated the diff for D4352: Create wallet RPCs for PSBT.

Address comments

Nov 9 2019, 15:59
teamcity added a comment to D4415: [CI] Allow to pass addditional arguments to bitcoind.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 9 2019, 10:05
teamcity added a comment to D4415: [CI] Allow to pass addditional arguments to bitcoind.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 9 2019, 09:51
Fabien updated the diff for D4415: [CI] Allow to pass addditional arguments to bitcoind.

Generalize to make passing other options available beside dbcache.
Take the set -u into account...

Nov 9 2019, 09:51
Fabien retitled D4415: [CI] Allow to pass addditional arguments to bitcoind from [CI] Allow to override the dbcache value to [CI] Allow to pass addditional arguments to bitcoind.
Nov 9 2019, 09:46
Fabien updated the test plan for D4415: [CI] Allow to pass addditional arguments to bitcoind.
Nov 9 2019, 09:31
Fabien added a comment to D4415: [CI] Allow to pass addditional arguments to bitcoind.

Yes good catch I forgot the set -u !

Nov 9 2019, 09:31
teamcity added a comment to D4417: Add a separate executable for seeder tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 9 2019, 02:16
teamcity added a comment to D4417: Add a separate executable for seeder tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 9 2019, 02:07
nakihito updated the diff for D4417: Add a separate executable for seeder tests.

Added copyright lines and cleaned up Makefile.

Nov 9 2019, 02:07