Page MenuHomePhabricator
Feed All Stories

Jun 6 2020

deadalnix accepted D6418: [backport#16839] scripted-diff: Remove g_connman, g_banman globals.
Jun 6 2020, 22:30
deadalnix requested changes to D6419: [backport#16839] Avoid using g_rpc_node global in wallet code.

What about src/rpc/blockchain.h ?

Jun 6 2020, 22:27
teamcity added a comment to D6421: [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 22:24
teamcity updated the summary of D6421: [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay.
Jun 6 2020, 22:24
majcosta requested review of D6421: [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay.
Jun 6 2020, 22:24
teamcity added a comment to D6420: [backport#15713 2/5] Introduce CWalletTx::SubmitMemoryPoolAndRelay.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 22:09
teamcity updated the summary of D6420: [backport#15713 2/5] Introduce CWalletTx::SubmitMemoryPoolAndRelay.
Jun 6 2020, 22:09
majcosta requested review of D6420: [backport#15713 2/5] Introduce CWalletTx::SubmitMemoryPoolAndRelay.
Jun 6 2020, 22:09
majcosta updated the summary of D6418: [backport#16839] scripted-diff: Remove g_connman, g_banman globals.
Jun 6 2020, 22:02
majcosta updated the summary of D6418: [backport#16839] scripted-diff: Remove g_connman, g_banman globals.
Jun 6 2020, 22:01
teamcity added a comment to D6419: [backport#16839] Avoid using g_rpc_node global in wallet code.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 22:01
teamcity updated the summary of D6419: [backport#16839] Avoid using g_rpc_node global in wallet code.
Jun 6 2020, 22:01
majcosta requested review of D6419: [backport#16839] Avoid using g_rpc_node global in wallet code.
Jun 6 2020, 22:01
teamcity updated the summary of D6418: [backport#16839] scripted-diff: Remove g_connman, g_banman globals.
Jun 6 2020, 21:59
teamcity added a comment to D6418: [backport#16839] scripted-diff: Remove g_connman, g_banman globals.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 21:59
majcosta requested review of D6418: [backport#16839] scripted-diff: Remove g_connman, g_banman globals.
Jun 6 2020, 21:59
majcosta committed rABC2b8b4bb8e962: [backport#16839] Pass NodeContext, ConnMan, BanMan references more places (authored by Russell Yanofsky <russ@yanofsky.org>).
[backport#16839] Pass NodeContext, ConnMan, BanMan references more places
Jun 6 2020, 19:59
majcosta closed D6409: [backport#16839] Pass NodeContext, ConnMan, BanMan references more places.
Jun 6 2020, 19:59
teamcity added a comment to D6417: net: Remove unused unsanitized user agent string CNode::strSubVer.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 19:16
teamcity updated the summary of D6417: net: Remove unused unsanitized user agent string CNode::strSubVer.
Jun 6 2020, 19:16
deadalnix requested review of D6417: net: Remove unused unsanitized user agent string CNode::strSubVer.
Jun 6 2020, 19:16
teamcity added a comment to D6416: Have importwallet use ImportPrivKeys and ImportScripts.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 18:30
teamcity updated the summary of D6416: Have importwallet use ImportPrivKeys and ImportScripts.
Jun 6 2020, 18:30
deadalnix requested review of D6416: Have importwallet use ImportPrivKeys and ImportScripts.
Jun 6 2020, 18:30
teamcity added a comment to D6415: Optionally allow ImportScripts to set script creation timestamp.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 18:25
teamcity updated the summary of D6415: Optionally allow ImportScripts to set script creation timestamp.
Jun 6 2020, 18:25
deadalnix requested review of D6415: Optionally allow ImportScripts to set script creation timestamp.
Jun 6 2020, 18:24
teamcity updated the summary of D6414: Have importaddress use ImportScripts and ImportScriptPubKeys.
Jun 6 2020, 18:01
teamcity added a comment to D6414: Have importaddress use ImportScripts and ImportScriptPubKeys.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 18:01
deadalnix requested review of D6414: Have importaddress use ImportScripts and ImportScriptPubKeys.
Jun 6 2020, 18:01
teamcity added a comment to D6413: Have importpubkey use CWallet's ImportScriptPubKeys and ImportPubKeys functions.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 17:56
teamcity updated the summary of D6413: Have importpubkey use CWallet's ImportScriptPubKeys and ImportPubKeys functions.
Jun 6 2020, 17:56
deadalnix requested review of D6413: Have importpubkey use CWallet's ImportScriptPubKeys and ImportPubKeys functions.
Jun 6 2020, 17:56
deadalnix updated the summary of D6412: Have importprivkey use CWallet's ImportPrivKeys, ImportScripts, and ImportScriptPubKeys.
Jun 6 2020, 17:27
teamcity updated the summary of D6412: Have importprivkey use CWallet's ImportPrivKeys, ImportScripts, and ImportScriptPubKeys.
Jun 6 2020, 17:25
teamcity added a comment to D6412: Have importprivkey use CWallet's ImportPrivKeys, ImportScripts, and ImportScriptPubKeys.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 17:25
deadalnix requested review of D6412: Have importprivkey use CWallet's ImportPrivKeys, ImportScripts, and ImportScriptPubKeys.
Jun 6 2020, 17:25
teamcity updated the summary of D6411: Log when an import is being skipped because we already have it.
Jun 6 2020, 17:04
teamcity added a comment to D6411: Log when an import is being skipped because we already have it.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 17:04
deadalnix requested review of D6411: Log when an import is being skipped because we already have it.
Jun 6 2020, 17:04
teamcity added a comment to D6410: Change ImportScriptPubKeys' internal to apply_label.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 16:41
teamcity updated the summary of D6410: Change ImportScriptPubKeys' internal to apply_label.
Jun 6 2020, 16:41
deadalnix requested review of D6410: Change ImportScriptPubKeys' internal to apply_label.
Jun 6 2020, 16:40
deadalnix accepted D6409: [backport#16839] Pass NodeContext, ConnMan, BanMan references more places.
Jun 6 2020, 16:37
teamcity added a comment to D6409: [backport#16839] Pass NodeContext, ConnMan, BanMan references more places.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 14:18
teamcity updated the summary of D6409: [backport#16839] Pass NodeContext, ConnMan, BanMan references more places.
Jun 6 2020, 14:18
majcosta requested review of D6409: [backport#16839] Pass NodeContext, ConnMan, BanMan references more places.
Jun 6 2020, 14:18
teamcity closed T922: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Resolved.
Jun 6 2020, 13:02
deadalnix committed rABC168db81b1d40: Change ismine to take a CWallet instead of CKeyStore (authored by Andrew Chow <achow101-github@achow101.com>).
Change ismine to take a CWallet instead of CKeyStore
Jun 6 2020, 12:59
deadalnix closed D6408: Change ismine to take a CWallet instead of CKeyStore.
Jun 6 2020, 12:59
majcosta committed rABC4a8e17632caf: [backport#15728] [wallet] Refactor CWalletTx::RelayWalletTransaction() (authored by John Newbery <john@johnnewbery.com>).
[backport#15728] [wallet] Refactor CWalletTx::RelayWalletTransaction()
Jun 6 2020, 12:59
majcosta closed D6406: [backport#15728] [wallet] Refactor CWalletTx::RelayWalletTransaction().
Jun 6 2020, 12:59
majcosta committed rABC323a3af1e70d: [backport#15452] GetKeyBirthTimes should return key ids, not destinations (authored by Gregory Sanders <gsanders87@gmail.com>).
[backport#15452] GetKeyBirthTimes should return key ids, not destinations
Jun 6 2020, 12:58
majcosta closed D6404: [backport#15452] GetKeyBirthTimes should return key ids, not destinations.
Jun 6 2020, 12:58
deadalnix committed rABC45be61fdcb2e: Move ismine to wallet module (authored by Andrew Chow <achow101-github@achow101.com>).
Move ismine to wallet module
Jun 6 2020, 12:55
deadalnix closed D6407: Move ismine to wallet module.
Jun 6 2020, 12:55
deadalnix accepted D6406: [backport#15728] [wallet] Refactor CWalletTx::RelayWalletTransaction().
Jun 6 2020, 12:54
majcosta committed rABCc971f3dc0f4e: [backport#14678] [wallet] remove redundant KeyOriginInfo access, already done… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#14678] [wallet] remove redundant KeyOriginInfo access, already done…
Jun 6 2020, 12:53
majcosta closed D6405: [backport#14678] [wallet] remove redundant KeyOriginInfo access, already done in CreateSig.
Jun 6 2020, 12:53
deadalnix accepted D6404: [backport#15452] GetKeyBirthTimes should return key ids, not destinations.
Jun 6 2020, 12:53
deadalnix accepted D6405: [backport#14678] [wallet] remove redundant KeyOriginInfo access, already done in CreateSig.
Jun 6 2020, 12:52
majcosta accepted D6408: Change ismine to take a CWallet instead of CKeyStore.
Jun 6 2020, 12:46
majcosta accepted D6407: Move ismine to wallet module.
Jun 6 2020, 12:28
teamcity added a comment to D6408: Change ismine to take a CWallet instead of CKeyStore.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 12:25
teamcity updated the summary of D6408: Change ismine to take a CWallet instead of CKeyStore.
Jun 6 2020, 12:25
deadalnix requested review of D6408: Change ismine to take a CWallet instead of CKeyStore.
Jun 6 2020, 12:25
teamcity updated the summary of D6407: Move ismine to wallet module.
Jun 6 2020, 12:09
teamcity added a comment to D6407: Move ismine to wallet module.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 12:09
deadalnix requested review of D6407: Move ismine to wallet module.
Jun 6 2020, 12:09
teamcity assigned T922: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. to majcosta.
Jun 6 2020, 11:18
teamcity triaged T922: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Unbreak Now! priority.
Jun 6 2020, 11:18
majcosta committed rABCf8e75cb4a84a: [backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated… (authored by Gregory Sanders <gsanders87@gmail.com>).
[backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated…
Jun 6 2020, 11:09
majcosta closed D6403: [backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated types.
Jun 6 2020, 11:09
teamcity added a comment to D6406: [backport#15728] [wallet] Refactor CWalletTx::RelayWalletTransaction().

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 11:08
teamcity updated the summary of D6406: [backport#15728] [wallet] Refactor CWalletTx::RelayWalletTransaction().
Jun 6 2020, 11:08
majcosta requested review of D6406: [backport#15728] [wallet] Refactor CWalletTx::RelayWalletTransaction().
Jun 6 2020, 11:08
deadalnix accepted D6403: [backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated types.
Jun 6 2020, 10:48
teamcity added a comment to D6405: [backport#14678] [wallet] remove redundant KeyOriginInfo access, already done in CreateSig.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 10:48
teamcity updated the summary of D6405: [backport#14678] [wallet] remove redundant KeyOriginInfo access, already done in CreateSig.
Jun 6 2020, 10:48
majcosta requested review of D6405: [backport#14678] [wallet] remove redundant KeyOriginInfo access, already done in CreateSig.
Jun 6 2020, 10:48
majcosta committed rABC3f4c090205bc: [backport#14821] Replace CAffectedKeysVisitor with descriptor based logic (authored by MeshCollider <dobsonsa68@gmail.com>).
[backport#14821] Replace CAffectedKeysVisitor with descriptor based logic
Jun 6 2020, 10:45
majcosta closed D6402: [backport#14821] Replace CAffectedKeysVisitor with descriptor based logic.
Jun 6 2020, 10:45
teamcity added a comment to D6404: [backport#15452] GetKeyBirthTimes should return key ids, not destinations.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 10:44
teamcity updated the summary of D6404: [backport#15452] GetKeyBirthTimes should return key ids, not destinations.
Jun 6 2020, 10:44
majcosta requested review of D6404: [backport#15452] GetKeyBirthTimes should return key ids, not destinations.
Jun 6 2020, 10:44
teamcity added a comment to D6403: [backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated types.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 10:43
teamcity updated the summary of D6403: [backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated types.
Jun 6 2020, 10:43
majcosta requested review of D6403: [backport#15452] Replace CScriptID and CKeyID in CTxDestination with dedicated types.
Jun 6 2020, 10:42
deadalnix committed rABC13a97f03d39f: Remove unused variable (authored by Suhas Daftuar <sdaftuar@gmail.com>).
Remove unused variable
Jun 6 2020, 10:42
deadalnix closed D6399: Remove unused variable.
Jun 6 2020, 10:42
deadalnix accepted D6402: [backport#14821] Replace CAffectedKeysVisitor with descriptor based logic.
Jun 6 2020, 10:41
deadalnix committed rABC0d451576ca38: Use BlockHash for vInventoryBlockToSend (authored by deadalnix).
Use BlockHash for vInventoryBlockToSend
Jun 6 2020, 10:38
deadalnix closed D6398: Use BlockHash for vInventoryBlockToSend.
Jun 6 2020, 10:38
teamcity added a comment to D6402: [backport#14821] Replace CAffectedKeysVisitor with descriptor based logic.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 10:14
teamcity updated the summary of D6402: [backport#14821] Replace CAffectedKeysVisitor with descriptor based logic.
Jun 6 2020, 10:14
majcosta requested review of D6402: [backport#14821] Replace CAffectedKeysVisitor with descriptor based logic.
Jun 6 2020, 10:14
teamcity closed T919: Build Bitcoin-ABC / Master / Health Checks / Bitcoin-ABC Check Seeds is broken. as Resolved.
Jun 6 2020, 03:02
nakihito accepted D6401: [refactor] Change tx_relay structure to be unique_ptr.
Jun 6 2020, 01:16
nakihito requested changes to D6400: [refactor] Move tx relay state to separate structure.
Jun 6 2020, 01:11
nakihito accepted D6398: Use BlockHash for vInventoryBlockToSend.
Jun 6 2020, 00:45