Page MenuHomePhabricator
Feed All Stories

Feb 23 2021

Fabien requested review of D9266: Bump version to 0.22.15.
Feb 23 2021, 20:18
majcosta accepted D9265: test: Add missing sync_blocks to wallet_hd.
Feb 23 2021, 18:31
majcosta accepted D9264: Limit scope of all global std::once_flag.
Feb 23 2021, 18:30
PiRK updated the summary of D9265: test: Add missing sync_blocks to wallet_hd.
Feb 23 2021, 17:33
PiRK updated the summary of D9265: test: Add missing sync_blocks to wallet_hd.
Feb 23 2021, 17:32
teamcity updated the summary of D9265: test: Add missing sync_blocks to wallet_hd.
Feb 23 2021, 17:32
PiRK requested review of D9265: test: Add missing sync_blocks to wallet_hd.
Feb 23 2021, 17:32
deadalnix closed D9263: Update links in CONTRIBUTE.md.
Feb 23 2021, 17:24
deadalnix committed rABCb9efc788c9be: Update links in CONTRIBUTE.md (authored by deadalnix).
Update links in CONTRIBUTE.md
Feb 23 2021, 17:24
PiRK updated the summary of D9264: Limit scope of all global std::once_flag.
Feb 23 2021, 17:17
teamcity updated the summary of D9264: Limit scope of all global std::once_flag.
Feb 23 2021, 17:15
PiRK requested review of D9264: Limit scope of all global std::once_flag.
Feb 23 2021, 17:15
majcosta accepted D9260: qt: Fix shutdown when waitfor* cmds are called from RPC console.
Feb 23 2021, 17:14
majcosta accepted D9261: test: Explain that a bug should be filed when the test fail.
Feb 23 2021, 17:08
majcosta accepted D9262: tests: implement base58_decode.
Feb 23 2021, 17:06
majcosta accepted D9263: Update links in CONTRIBUTE.md.
Feb 23 2021, 17:05
deadalnix requested review of D9263: Update links in CONTRIBUTE.md.
Feb 23 2021, 17:02
PiRK updated the diff for D9262: tests: implement base58_decode.

fix formatting (the linter did not find an elegant solution this time)

Feb 23 2021, 16:39
teamcity updated the summary of D9262: tests: implement base58_decode.
Feb 23 2021, 16:35
PiRK requested review of D9262: tests: implement base58_decode.
Feb 23 2021, 16:35
teamcity added a comment to D9261: test: Explain that a bug should be filed when the test fail.
Feb 23 2021, 16:34
teamcity updated the summary of D9261: test: Explain that a bug should be filed when the test fail.
Feb 23 2021, 16:27
PiRK requested review of D9261: test: Explain that a bug should be filed when the test fail.
Feb 23 2021, 16:27
teamcity added a comment to D9260: qt: Fix shutdown when waitfor* cmds are called from RPC console.
Feb 23 2021, 16:25
teamcity updated the summary of D9260: qt: Fix shutdown when waitfor* cmds are called from RPC console.
Feb 23 2021, 16:17
PiRK requested review of D9260: qt: Fix shutdown when waitfor* cmds are called from RPC console.
Feb 23 2021, 16:17
majcosta closed D9259: [backport#18637] coins: allow cache resize after init.
Feb 23 2021, 15:18
majcosta committed rABC8af6d9df957b: [backport#18637] coins: allow cache resize after init (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#18637] coins: allow cache resize after init
Feb 23 2021, 15:18
majcosta updated the test plan for D9259: [backport#18637] coins: allow cache resize after init.
Feb 23 2021, 15:04
majcosta updated the diff for D9259: [backport#18637] coins: allow cache resize after init.

modified comments pertaining to function arguments to not be reliant on a particular formatting (// to /* */)

Feb 23 2021, 14:58
PiRK accepted D9259: [backport#18637] coins: allow cache resize after init.

I'm not blocking on this, but FYI there are a bunch of same line comments in validation_chainstate_tests.cpp

Feb 23 2021, 14:08
majcosta updated the summary of D9259: [backport#18637] coins: allow cache resize after init.
Feb 23 2021, 13:50
majcosta updated the diff for D9259: [backport#18637] coins: allow cache resize after init.

fix -Werror=ignored-qualifiers

Feb 23 2021, 13:49
PiRK closed D9257: qt: Fix regression in TransactionTableModel.
Feb 23 2021, 12:55
PiRK committed rABC1efc1fd37759: qt: Fix regression in TransactionTableModel (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
qt: Fix regression in TransactionTableModel
Feb 23 2021, 12:54
PiRK closed D9254: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals..
Feb 23 2021, 12:54
PiRK committed rABC1730a7452cb7: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip… (authored by furszy <matiasfurszyfer@protonmail.com>).
BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip…
Feb 23 2021, 12:54
PiRK closed D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..
Feb 23 2021, 12:53
PiRK committed rABC9ad2859f2e58: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals. (authored by furszy <matiasfurszyfer@protonmail.com>).
Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals.
Feb 23 2021, 12:53
teamcity closed T1523: Build Bitcoin-ABC / Nightly Builds / Initial Block Download Tests / Initial Block Download w/o Checkpoints is broken. as Resolved.
Feb 23 2021, 12:22
teamcity added a comment to D9259: [backport#18637] coins: allow cache resize after init.
Feb 23 2021, 11:01
teamcity added a comment to D9259: [backport#18637] coins: allow cache resize after init.
Feb 23 2021, 10:56
teamcity added a comment to D9259: [backport#18637] coins: allow cache resize after init.
Feb 23 2021, 10:54
majcosta requested review of D9259: [backport#18637] coins: allow cache resize after init.
Feb 23 2021, 10:46
majcosta closed D9258: [buildbot] make bot link to backports of core-gui repo.
Feb 23 2021, 10:45
majcosta committed rABC5c69fab896b6: [buildbot] make bot link to backports of core-gui repo (authored by majcosta).
[buildbot] make bot link to backports of core-gui repo
Feb 23 2021, 10:45
majcosta closed T640: Backport Core PR 9856 as Resolved.
Feb 23 2021, 09:58 · Bootcamp, Restricted Project
majcosta accepted D9257: qt: Fix regression in TransactionTableModel.
Feb 23 2021, 09:40
majcosta accepted D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..
Feb 23 2021, 09:40
PiRK closed D9236: wallet: descriptor wallet cleanups.
Feb 23 2021, 09:36
PiRK committed rABCdaabc6926d49: wallet: descriptor wallet cleanups (authored by Andrew Chow <achow101-github@achow101.com>).
wallet: descriptor wallet cleanups
Feb 23 2021, 09:36
PiRK updated the diff for D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..

fix accidental revert of core#19132

Feb 23 2021, 09:26
PiRK updated the diff for D9257: qt: Fix regression in TransactionTableModel.

rebase

Feb 23 2021, 09:24
PiRK added a comment to D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..

now you reverted PR19132's changes completely

Feb 23 2021, 09:13
majcosta requested changes to D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..

now you reverted PR19132's changes completely

Feb 23 2021, 08:10
PiRK updated the diff for D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..

remove unnecessary line added accidentaly when fixing conflict

Feb 23 2021, 07:24
PiRK closed D9255: qt: Use parent-child relation to manage lifetime of OptionsModel object.
Feb 23 2021, 07:20
PiRK committed rABCf5235191842a: qt: Use parent-child relation to manage lifetime of OptionsModel object (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
qt: Use parent-child relation to manage lifetime of OptionsModel object
Feb 23 2021, 07:20
PiRK updated the summary of D9257: qt: Fix regression in TransactionTableModel.
Feb 23 2021, 07:16
PiRK accepted D9258: [buildbot] make bot link to backports of core-gui repo.
Feb 23 2021, 07:14
PiRK updated the diff for D9254: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals..

remove line accidentaly added while fixing a conflict

Feb 23 2021, 07:10
majcosta updated the test plan for D9258: [buildbot] make bot link to backports of core-gui repo.
Feb 23 2021, 00:45
majcosta updated the diff for D9258: [buildbot] make bot link to backports of core-gui repo.

updated backporting.md

Feb 23 2021, 00:04

Feb 22 2021

majcosta planned changes to D9258: [buildbot] make bot link to backports of core-gui repo.

fixing docs

Feb 22 2021, 23:35
majcosta updated the diff for D9258: [buildbot] make bot link to backports of core-gui repo.

added test cases and removed test cases that no longer apply (the number of digits in PRs are no longer in the code)

Feb 22 2021, 23:34
majcosta planned changes to D9258: [buildbot] make bot link to backports of core-gui repo.

making the tests happy

Feb 22 2021, 22:42
majcosta updated the summary of D9258: [buildbot] make bot link to backports of core-gui repo.
Feb 22 2021, 22:41
teamcity added a comment to D9258: [buildbot] make bot link to backports of core-gui repo.
Feb 22 2021, 22:40
majcosta requested review of D9258: [buildbot] make bot link to backports of core-gui repo.
Feb 22 2021, 22:39
PiRK updated the summary of D9257: qt: Fix regression in TransactionTableModel.
Feb 22 2021, 21:02
PiRK updated the summary of D9257: qt: Fix regression in TransactionTableModel.
Feb 22 2021, 21:00
majcosta added a comment to D9257: qt: Fix regression in TransactionTableModel.
In D9257#210616, @PiRK wrote:

Ok wigh core-gui. But something need to be done about the automatic " PRxxxx to URL" conversion.

Feb 22 2021, 20:59
PiRK updated the summary of D9257: qt: Fix regression in TransactionTableModel.
Feb 22 2021, 20:57
PiRK added a comment to D9257: qt: Fix regression in TransactionTableModel.

Ok wigh core-gui. But something need to be done about the automatic " PRxxxx to URL" conversion.

Feb 22 2021, 20:56
Joey King <joseph.roy.king@gmail.com> closed D9250: [Cashtab] Enable special features if wallet has specific eToken.
Feb 22 2021, 20:28
Joey King <joseph.roy.king@gmail.com> committed rABCcc5de5b703da: [Cashtab] Enable special features if wallet has specific eToken (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Enable special features if wallet has specific eToken
Feb 22 2021, 20:28
Fabien closed D9252: [CI] Use a new datadir when running the windows native tests.
Feb 22 2021, 20:23
Fabien committed rABC8a367f9ca7c7: [CI] Use a new datadir when running the windows native tests (authored by Fabien).
[CI] Use a new datadir when running the windows native tests
Feb 22 2021, 20:23
majcosta accepted D9250: [Cashtab] Enable special features if wallet has specific eToken.
Feb 22 2021, 20:22
bytesofman updated the diff for D9250: [Cashtab] Enable special features if wallet has specific eToken.

Implementing suggested changes

Feb 22 2021, 20:18
majcosta abandoned D8633: [refactor] use compile time string_view for DBKeys.

yea this ain't worth it

Feb 22 2021, 20:02
majcosta requested changes to D9250: [Cashtab] Enable special features if wallet has specific eToken.
Feb 22 2021, 19:50
majcosta requested changes to D9257: qt: Fix regression in TransactionTableModel.

we need to come up with a standard notation to ease automation of tagging the done backports in the bitcoin-core/gui repo, what about using Backport of core-gui PRxxxxxx?

Feb 22 2021, 18:53
majcosta accepted D9255: qt: Use parent-child relation to manage lifetime of OptionsModel object.
Feb 22 2021, 18:49
majcosta accepted D9254: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals..
Feb 22 2021, 18:41
majcosta closed D9251: [refactor] add alias for Schnorr signatures and remove size magic number.
Feb 22 2021, 18:38
majcosta committed rABCdf89383bb6ed: [refactor] add alias for Schnorr signatures and remove size magic number (authored by majcosta).
[refactor] add alias for Schnorr signatures and remove size magic number
Feb 22 2021, 18:38
majcosta accepted D9236: wallet: descriptor wallet cleanups.
Feb 22 2021, 18:36
majcosta requested changes to D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..
Feb 22 2021, 18:33
PiRK updated the summary of D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..
Feb 22 2021, 15:45
PiRK updated the diff for D9254: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals..

rebase

Feb 22 2021, 15:40
PiRK abandoned D9256: qt: lock cs_main, m_cached_tip_mutex in that order.

squasjed with D9253

Feb 22 2021, 15:39
PiRK updated the summary of D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..
Feb 22 2021, 15:38
PiRK updated the diff for D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..

squash D9253 and D9256

Feb 22 2021, 15:36
PiRK updated the summary of D9257: qt: Fix regression in TransactionTableModel.
Feb 22 2021, 15:19
teamcity updated the summary of D9257: qt: Fix regression in TransactionTableModel.
Feb 22 2021, 15:19
PiRK requested review of D9257: qt: Fix regression in TransactionTableModel.
Feb 22 2021, 15:18
teamcity updated the summary of D9256: qt: lock cs_main, m_cached_tip_mutex in that order.
Feb 22 2021, 15:04
PiRK requested review of D9256: qt: lock cs_main, m_cached_tip_mutex in that order.
Feb 22 2021, 15:04
teamcity added a comment to D9254: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals..
Feb 22 2021, 14:55