Page MenuHomePhabricator
Feed Advanced Search

Oct 15 2020

jasonbcox committed rABCWEBbac85b76fb06: Use new roadmap link (authored by jasonbcox).
Use new roadmap link
Oct 15 2020, 19:00
jasonbcox closed D7725: [CI] Do not wait too long for build logs to flush.
Oct 15 2020, 18:49
jasonbcox committed rABCc1ff352e013c: [CI] Do not wait too long for build logs to flush (authored by jasonbcox).
[CI] Do not wait too long for build logs to flush
Oct 15 2020, 18:49
jasonbcox requested review of D7942: Use new roadmap link.
Oct 15 2020, 17:29
jasonbcox updated the diff for D7725: [CI] Do not wait too long for build logs to flush.

Rebase

Oct 15 2020, 16:46
jasonbcox accepted D7939: [backport#17579] [refactor] Merge getreceivedby tally into GetReceived function.
Oct 15 2020, 16:38
jasonbcox closed D7920: [land-bot] Queue the HEAD revision by default.
Oct 15 2020, 16:38
jasonbcox committed rABCa6b0545ead7a: [land-bot] Queue the HEAD revision by default (authored by jasonbcox).
[land-bot] Queue the HEAD revision by default
Oct 15 2020, 16:38
jasonbcox requested review of D7940: [build-bot] Fix character escapes in ignore list.
Oct 15 2020, 16:29

Oct 14 2020

jasonbcox closed D7921: Merge #17251: net: SocketHandler logs peer id for close and disconnect.
Oct 14 2020, 22:13
jasonbcox committed rABC7fa3480bcc65: Merge #17251: net: SocketHandler logs peer id for close and disconnect (authored by fanquake <fanquake@gmail.com>).
Merge #17251: net: SocketHandler logs peer id for close and disconnect
Oct 14 2020, 22:13
jasonbcox requested review of D7921: Merge #17251: net: SocketHandler logs peer id for close and disconnect.
Oct 14 2020, 20:52
jasonbcox requested review of D7920: [land-bot] Queue the HEAD revision by default.
Oct 14 2020, 19:15
jasonbcox accepted D7917: [backport#14879]Add warning messages to the debug window.
Oct 14 2020, 17:09
jasonbcox accepted D7919: doc: add default bitcoin.conf locations.
Oct 14 2020, 17:06
jasonbcox closed D7911: [land-bot] Add basic test coverage.
Oct 14 2020, 16:29
jasonbcox committed rABC3b4e698c7e84: [land-bot] Add basic test coverage (authored by jasonbcox).
[land-bot] Add basic test coverage
Oct 14 2020, 16:29
jasonbcox accepted D7918: [CI] Add required packages for building and uploading a DEB file.
Oct 14 2020, 16:07
jasonbcox closed D7912: Merge #16470: test: Fail early on disconnect in mininode.wait_for_*.
Oct 14 2020, 15:54
jasonbcox committed rABC8fc318140dfd: Merge #16470: test: Fail early on disconnect in mininode.wait_for_* (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #16470: test: Fail early on disconnect in mininode.wait_for_*
Oct 14 2020, 15:54
jasonbcox accepted D7916: [WEBSITE] Don't special case 0.22.3 and always use xvfb-run.
Oct 14 2020, 15:39
jasonbcox accepted D7913: Don't enforce xvfb for generating the man pages.
Oct 14 2020, 15:31

Oct 13 2020

jasonbcox added inline comments to D7912: Merge #16470: test: Fail early on disconnect in mininode.wait_for_*.
Oct 13 2020, 23:24
jasonbcox requested review of D7912: Merge #16470: test: Fail early on disconnect in mininode.wait_for_*.
Oct 13 2020, 23:22
jasonbcox updated the summary of D7468: [land-bot] Add a sanity rebase after running smoke tests.
Oct 13 2020, 22:20
jasonbcox updated the diff for D7468: [land-bot] Add a sanity rebase after running smoke tests.

Make it more robust and add tests (now depends on D7911)

Oct 13 2020, 22:19
jasonbcox requested review of D7911: [land-bot] Add basic test coverage.
Oct 13 2020, 22:07
jasonbcox closed D7908: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase.
Oct 13 2020, 21:26
jasonbcox committed rABC8c361009afdd: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase
Oct 13 2020, 21:26
jasonbcox requested review of D7908: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase.
Oct 13 2020, 16:26
jasonbcox planned changes to D7899: Test patch; please ignore.
Oct 13 2020, 00:04
jasonbcox requested review of D7899: Test patch; please ignore.
Oct 13 2020, 00:04

Oct 12 2020

jasonbcox requested changes to D7897: [cleanup] Remove ranged for loops over OUTPUT_TYPES from PR17261.

While OUTPUT_TYPES is not itself useful, this patch is only going to induce merge conflicts. This trade-off does not seem worth it since it does not get rid of a substantial amount of code.

Oct 12 2020, 23:47
jasonbcox closed D7829: Bump version to 0.22.5.
Oct 12 2020, 23:00
jasonbcox committed rABC943fb252a21e: Bump version to 0.22.5 (authored by jasonbcox).
Bump version to 0.22.5
Oct 12 2020, 23:00
jasonbcox accepted D7896: [backport#15163] Correct units for "-dbcache" and "-prune".
Oct 12 2020, 22:23
jasonbcox added a comment to D7894: [Qt] Restore < Qt5.6 compatibility for addAction.

Is this change necessary given D7893 ?

Oct 12 2020, 22:15
jasonbcox accepted D7895: qt: Fix Window -> Minimize menu item on linux.
Oct 12 2020, 22:15

Oct 8 2020

jasonbcox accepted D7834: wallet: Prefer full destination groups in coin selection.
Oct 8 2020, 23:49
jasonbcox closed D7811: Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2].
Oct 8 2020, 23:13
jasonbcox committed rABCd899b47131c5: Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part…
Oct 8 2020, 23:13
jasonbcox closed D7810: Merge #18192: Bugfix: Wallet: Safely deal with change in the address book.
Oct 8 2020, 23:13
jasonbcox committed rABC082ae8450192: Merge #18192: Bugfix: Wallet: Safely deal with change in the address book (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #18192: Bugfix: Wallet: Safely deal with change in the address book
Oct 8 2020, 23:13
jasonbcox closed D7831: Cleanup superfluous newline.
Oct 8 2020, 22:33
jasonbcox committed rABC2179ddf0a598: Cleanup superfluous newline (authored by jasonbcox).
Cleanup superfluous newline
Oct 8 2020, 22:32
jasonbcox closed D7830: Remove archiving release notes from release process.
Oct 8 2020, 22:13
jasonbcox committed rABC9a3d5bcc7deb: Remove archiving release notes from release process (authored by jasonbcox).
Remove archiving release notes from release process
Oct 8 2020, 22:12
jasonbcox updated the diff for D7811: Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2].

Rebase

Oct 8 2020, 21:56
jasonbcox closed D7823: Cleanup unused old_label variable.
Oct 8 2020, 21:01
jasonbcox committed rABCba9b046e0fd1: Cleanup unused old_label variable (authored by jasonbcox).
Cleanup unused old_label variable
Oct 8 2020, 21:01
jasonbcox requested review of D7831: Cleanup superfluous newline.
Oct 8 2020, 20:25
jasonbcox requested review of D7830: Remove archiving release notes from release process.
Oct 8 2020, 20:24
jasonbcox requested review of D7829: Bump version to 0.22.5.
Oct 8 2020, 20:17
jasonbcox closed D7825: Some more release notes.
Oct 8 2020, 20:14
jasonbcox committed rABC866495d927d6: Some more release notes (authored by jasonbcox).
Some more release notes
Oct 8 2020, 20:14
jasonbcox closed D7827: [buildbot] Fix ref master to be full ref name.
Oct 8 2020, 19:16
jasonbcox committed rABCd9fd0b1a8163: [buildbot] Fix ref master to be full ref name (authored by jasonbcox).
[buildbot] Fix ref master to be full ref name
Oct 8 2020, 19:16
jasonbcox closed D7826: Merge #19756: tests: add sync_all to fix race condition in wallet groups test.
Oct 8 2020, 18:16
jasonbcox committed rABCb427253b0a2f: Merge #19756: tests: add sync_all to fix race condition in wallet groups test (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #19756: tests: add sync_all to fix race condition in wallet groups test
Oct 8 2020, 18:15
jasonbcox requested review of D7827: [buildbot] Fix ref master to be full ref name.
Oct 8 2020, 18:14
jasonbcox closed D7824: [buildbot] Fix getIgnoreList dangling arg.
Oct 8 2020, 17:59
jasonbcox committed rABC1fca0f0b7b2e: [buildbot] Fix getIgnoreList dangling arg (authored by jasonbcox).
[buildbot] Fix getIgnoreList dangling arg
Oct 8 2020, 17:59
jasonbcox requested review of D7826: Merge #19756: tests: add sync_all to fix race condition in wallet groups test.
Oct 8 2020, 17:58
jasonbcox requested review of D7825: Some more release notes.
Oct 8 2020, 17:49
jasonbcox updated the diff for D7824: [buildbot] Fix getIgnoreList dangling arg.

Fix copy-paste error

Oct 8 2020, 17:37
jasonbcox requested review of D7824: [buildbot] Fix getIgnoreList dangling arg.
Oct 8 2020, 17:05
jasonbcox closed D7813: [buildbot] Remove bot message about linking PRs.
Oct 8 2020, 16:16
jasonbcox committed rABC95104fc18bf9: [buildbot] Remove bot message about linking PRs (authored by jasonbcox).
[buildbot] Remove bot message about linking PRs
Oct 8 2020, 16:16
jasonbcox updated the diff for D7810: Merge #18192: Bugfix: Wallet: Safely deal with change in the address book.

Rebase on D7823

Oct 8 2020, 16:09
jasonbcox added inline comments to D7810: Merge #18192: Bugfix: Wallet: Safely deal with change in the address book.
Oct 8 2020, 16:05
jasonbcox requested review of D7823: Cleanup unused old_label variable.
Oct 8 2020, 16:05

Oct 7 2020

jasonbcox requested review of D7813: [buildbot] Remove bot message about linking PRs.
Oct 7 2020, 22:53
jasonbcox requested review of D7811: Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2].
Oct 7 2020, 20:44
jasonbcox requested review of D7810: Merge #18192: Bugfix: Wallet: Safely deal with change in the address book.
Oct 7 2020, 20:36
jasonbcox reassigned T1093: Backport script and key management improvements (PR17261) from jasonbcox to majcosta.
Oct 7 2020, 20:23 · Restricted Project
jasonbcox closed D7787: [buildbot] Introduce an ignore list for known flaky errors.
Oct 7 2020, 20:05
jasonbcox committed rABC9e32b347175d: [buildbot] Introduce an ignore list for known flaky errors (authored by jasonbcox).
[buildbot] Introduce an ignore list for known flaky errors
Oct 7 2020, 20:05
jasonbcox closed D7793: Fix release notes that got automated out of existence.
Oct 7 2020, 16:59
jasonbcox committed rABCca05a7160d20: Fix release notes that got automated out of existence (authored by jasonbcox).
Fix release notes that got automated out of existence
Oct 7 2020, 16:59
jasonbcox updated the diff for D7793: Fix release notes that got automated out of existence.

* -> + per feedback

Oct 7 2020, 16:20
jasonbcox updated the diff for D7793: Fix release notes that got automated out of existence.

Came up with a better solution that is more robust, fails when there is no version number found, and
does not introduce a new dependency.

Oct 7 2020, 16:05
jasonbcox updated the test plan for D7793: Fix release notes that got automated out of existence.
Oct 7 2020, 02:21
jasonbcox requested review of D7793: Fix release notes that got automated out of existence.
Oct 7 2020, 02:20
jasonbcox closed D7792: Fix passing of coin control in SendMoney().
Oct 7 2020, 01:18
jasonbcox committed rABC2fef637bd376: Fix passing of coin control in SendMoney() (authored by jasonbcox).
Fix passing of coin control in SendMoney()
Oct 7 2020, 01:18
jasonbcox accepted D7789: [backport#10842] Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching..
Oct 7 2020, 01:14
jasonbcox accepted D7790: [backport#11138] Compat: Simplify bswap_16 implementation.
Oct 7 2020, 01:13
jasonbcox accepted D7791: [backport#10691] Trivial: Properly comment about shutdown process in init.cpp file..
Oct 7 2020, 01:12
jasonbcox requested review of D7792: Fix passing of coin control in SendMoney().
Oct 7 2020, 00:14

Oct 6 2020

jasonbcox added a comment to T1094: Backport transaction cache fixes (PR17843).

The change is currently being drafted here: https://reviews.bitcoinabc.org/D7685 but there are test failures that need fixing before we proceed.

Oct 6 2020, 21:40 · Restricted Project
jasonbcox triaged T1094: Backport transaction cache fixes (PR17843) as High priority.
Oct 6 2020, 21:40 · Restricted Project
jasonbcox triaged T1093: Backport script and key management improvements (PR17261) as High priority.
Oct 6 2020, 21:35 · Restricted Project
jasonbcox triaged T1092: Unrevert coin selection changes as High priority.
Oct 6 2020, 21:32 · Restricted Project
jasonbcox accepted D7786: [CI] Remove the Openjdk 8 dependency.
Oct 6 2020, 20:34
jasonbcox requested changes to D7786: [CI] Remove the Openjdk 8 dependency.
Oct 6 2020, 18:04
jasonbcox closed T664: Automate version bumping, a subtask of T646: Release Automation, as Invalid.
Oct 6 2020, 18:00 · Restricted Project, Restricted Project
jasonbcox closed T664: Automate version bumping as Invalid.

The approach has changed significantly. While the spirit of this task is right, it's not really valid anymore.

Oct 6 2020, 18:00 · Restricted Project, Restricted Project
jasonbcox closed T656: Automate release page, a subtask of T646: Release Automation, as Resolved.
Oct 6 2020, 17:59 · Restricted Project, Restricted Project
jasonbcox closed T656: Automate release page as Resolved.
Oct 6 2020, 17:59 · Restricted Project, Restricted Project
jasonbcox closed T269: Create a `contrib/teamcity/build-cmake.sh`, a subtask of T248: Add cmake build to teamcity, as Resolved.
Oct 6 2020, 17:57