It is working now that you updated jest. Go for it.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Nov 29 2020
Nov 29 2020
deadalnix committed rABC3252c21e2856: Remove propagation delay for outbound peers (authored by deadalnix).
Remove propagation delay for outbound peers
In D8530#197660, @majcosta wrote:I can run the testplan on my Arch box.
On a debian buster machine running our CI script it fails a test and complains about Npm being <6. I can run the test plan after apt-get -t buster-backports install npm for 6.14.8 only.
Nov 28 2020
Nov 28 2020
deadalnix committed rABC040c153474e3: [avalanche] Keep track of stacked UTXOs to avoid double staking (authored by deadalnix).
[avalanche] Keep track of stacked UTXOs to avoid double staking
Fix a comment in net_processing.cpp
nits in protocol.h
deadalnix accepted D8543: [backport#13537] GUI: Peer table: Visualize inbound/outbound state for every row.
Nice use of unicode :)
Nov 27 2020
Nov 27 2020
deadalnix requested review of D8544: [avalanche] Keep track of stacked UTXOs to avoid double staking.
deadalnix committed rABC01a237133998: [avalanche] Keep the peer set up to date as the chain tip is updated. (authored by deadalnix).
[avalanche] Keep the peer set up to date as the chain tip is updated.
deadalnix committed rABCe2b03e3a9d07: [avalanche] Properly validate proof in peermanager.cpp (authored by deadalnix).
[avalanche] Properly validate proof in peermanager.cpp
deadalnix committed rABC2f2030ef8038: [avalanche] Use correct avalanche proofs instead of made up ones (authored by deadalnix).
[avalanche] Use correct avalanche proofs instead of made up ones
Nov 26 2020
Nov 26 2020
The test plan still cannot be executed as this.
deadalnix updated the summary of D8535: [avalanche] Keep the peer set up to date as the chain tip is updated..
deadalnix requested review of D8535: [avalanche] Keep the peer set up to date as the chain tip is updated..
This is adding temporal dependency. Th scheduler thread is already manually started, so that temporal dependency is 100% redundant.
Please don't start a project on outdated tech.
deadalnix requested review of D8533: [avalanche] Use correct avalanche proofs instead of made up ones.
deadalnix committed rABC8199ab3480bd: [avalanche] Check for height and coinbase of stakes (authored by deadalnix).
[avalanche] Check for height and coinbase of stakes
Nov 25 2020
Nov 25 2020
1/ Let the linter do its job.
2/ npm i plain doesn't work.
deadalnix requested changes to D8339: Move seed list vector operations into distinct compilation unit.
I have a hard time believing that you wrote that and said to yourself "this is rally the best that can be done here". You know better can be done.
deadalnix requested changes to D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.
deadalnix requested changes to D8525: Fix a potential data race between CConman and the PeerLogicValidation.
If that can only happen at startup, then locking at every use is clearly not the way to go.
There is clearly a dependency missing.
deadalnix added a comment to D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.
Sorry, I looked at the wrong PR. You need to explain or fix as per inline comments.
deadalnix requested changes to D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.
It seems like you have missing dependencies.
Nov 24 2020
Nov 24 2020
Nov 23 2020
Nov 23 2020
deadalnix committed rABC9e07ed780cf2: fix assert crash when specified change output spend size is unknown (authored by Gregory Sanders <gsanders87@gmail.com>).
fix assert crash when specified change output spend size is unknown
deadalnix requested review of D8500: fix assert crash when specified change output spend size is unknown.
deadalnix committed rABCf24e79e45b2a: tests: Add RPCOverloadWrapper which overloads some disabled RPCs (authored by Andrew Chow <achow101-github@achow101.com>).
tests: Add RPCOverloadWrapper which overloads some disabled RPCs
Fix a nit in wallet_keypool.py
deadalnix committed rABCc56157bd36df: [avalanche] Add facility to check proof against a view of the UTXO (authored by deadalnix).
[avalanche] Add facility to check proof against a view of the UTXO
deadalnix committed rABC12e963467450: Add primitive to generate random 160 bits numbers for tests (authored by deadalnix).
Add primitive to generate random 160 bits numbers for tests
Nov 22 2020
Nov 22 2020
deadalnix requested review of D8498: tests: Add RPCOverloadWrapper which overloads some disabled RPCs.
Small changes, but overall, LGTM.
deadalnix requested review of D8497: [avalanche] Add facility to check proof against a view of the UTXO.
Nov 21 2020
Nov 21 2020
deadalnix committed rABCc321c8ac8909: Functional tests for descriptor wallets (authored by Andrew Chow <achow101-github@achow101.com>).
Functional tests for descriptor wallets
deadalnix committed rABCecaa314bf7e7: add importdescriptors RPC and tests for native descriptor wallets (authored by Hugo Nguyen <hugh.hn@gmail.com>).
add importdescriptors RPC and tests for native descriptor wallets
deadalnix updated the diff for D8475: add importdescriptors RPC and tests for native descriptor wallets.
Update RPC doc
Restore use of 'sh(pkh(...))' in a test case.
Back to your plate, this clearly hasn't been thought through.
deadalnix committed rABC2cfbab661db6: Change wallet_encryption.py to use signmessage instead of dumpprivkey (authored by Andrew Chow <achow101-github@achow101.com>).
Change wallet_encryption.py to use signmessage instead of dumpprivkey
deadalnix committed rABCa0cf931d0918: Properly handle coinbase in proofbuilder (authored by deadalnix).
Properly handle coinbase in proofbuilder
teamcity awarded D8491: Properly handle coinbase in proofbuilder a Haypence token.
Also do it for Stake
deadalnix requested review of D8488: Change wallet_encryption.py to use signmessage instead of dumpprivkey.
Nov 20 2020
Nov 20 2020
deadalnix updated the diff for D8475: add importdescriptors RPC and tests for native descriptor wallets.
Fix flackyness