Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Dec 21 2020

majcosta accepted D8714: [net/refactor] Add feeler connections to ConnectionType enum.
Dec 21 2020, 13:20
majcosta accepted D8712: [net/refactor] Introduce an enum to distinguish type of connection.
Dec 21 2020, 12:58
majcosta accepted D8713: [net/refactor] Add manual connections to ConnectionType enum.
Dec 21 2020, 12:45
majcosta accepted D8711: scripted-diff: Rename OneShot to AddrFetch.
Dec 21 2020, 12:25
majcosta accepted D8710: fuzz: Stop nodes in process_message* fuzzers.
Dec 21 2020, 12:02
majcosta retitled D8710: fuzz: Stop nodes in process_message* fuzzers from fuzz: Stop nodes in process_message* fuzzers ``` Background is that I saw an integer overflow in net_processing #30629113 REDUCE cov: 25793 ft: 142917 corp: 3421/2417Kb lim: 4096 exec/s: 89 rss: 614Mb L: 1719/4096 MS: 1 EraseBytes... to fuzz: Stop nodes in process_message* fuzzers```Background is that I saw an integer overflow in net_processing#30629113 REDUCE cov: 25793 ft: 142917 corp: 3421/2417Kb lim: 4096exec/s: 89 rss: 614Mb L: 1719/4096 MS: 1 EraseBytes....
Dec 21 2020, 11:59

Dec 18 2020

majcosta requested changes to D8707: [WEBSITE] Remove the BCHN variant from the release page.

this page still shows the "BCHA: built by tech talent" box at the bottom

Dec 18 2020, 21:47
majcosta accepted D8705: [WEBSITE] Fetch documentation in ascending version order.
Dec 18 2020, 21:30
majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

addressed comments

Dec 18 2020, 19:37
majcosta accepted D8704: doc: update release notes with getaddressinfo label deprecation.
Dec 18 2020, 19:33
majcosta accepted D8703: test: getaddressinfo label deprecation test.
Dec 18 2020, 19:29
majcosta accepted D8702: rpc: deprecate getaddressinfo label field.
Dec 18 2020, 19:27
majcosta accepted D8701: test: remove getaddressinfo label tests.
Dec 18 2020, 19:23
majcosta accepted D8700: doc: address pr17578 review feedback.
Dec 18 2020, 19:18
majcosta accepted D8699: gui: Remove WalletView and BitcoinGUI circular dependency.
Dec 18 2020, 19:13
majcosta accepted D8698: gui: Add transactionClicked and coinsSent signals to WalletView.
Dec 18 2020, 19:03
majcosta accepted D8697: gui: Drop ShutdownWindow dependency to BitcoinGUI.
Dec 18 2020, 19:02
majcosta accepted D8696: gui: Drop BanTableModel dependency to ClientModel.
Dec 18 2020, 19:00
majcosta requested changes to D8695: Use rolling bloom filter of recent block tx's for AlreadyHave() check.
Dec 18 2020, 18:56

Dec 17 2020

majcosta accepted D8690: Fix benchmarks filters.
Dec 17 2020, 20:28
majcosta accepted D8689: gui: Shortcut to close ModalOverlay.
Dec 17 2020, 20:27
majcosta retitled D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node from [CashAddr] replace bitcoincash: prefix with abc: to [CashAddr] replace bitcoincash: prefix with abc: in the node.
Dec 17 2020, 20:18
majcosta retitled D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node from [CashAddr] set each network CashAddr prefixes in chainparams.cpp to [CashAddr] replace bitcoincash: prefix with abc:.
Dec 17 2020, 20:18
majcosta updated the summary of D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Dec 17 2020, 20:15
majcosta requested review of D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Dec 17 2020, 20:14
majcosta accepted D8691: Remove BCHN related automation.
Dec 17 2020, 20:02
majcosta accepted D8685: net: Add tests for failure on string parameters with embedded NUL characters.
Dec 17 2020, 13:44
majcosta accepted D8684: net: Avoid using C-style NUL-terminated strings in the netbase interface.
Dec 17 2020, 13:23
majcosta abandoned D8675: decouple miner fund from `bitcoincash:` prefix and fix test.

this is a bit pointless now

Dec 17 2020, 12:50
majcosta updated the diff for D8675: decouple miner fund from `bitcoincash:` prefix and fix test.

addressed feedback

Dec 17 2020, 12:08

Dec 16 2020

majcosta accepted D8678: Remove disabled prop from collapse panels as antd deprecated.
Dec 16 2020, 16:28
majcosta accepted D8677: Update antd to fix design issues.
Dec 16 2020, 12:36

Dec 15 2020

majcosta retitled D8675: decouple miner fund from `bitcoincash:` prefix and fix test from [minerfund] decouple miner fund from `bitcoincash:` prefix and fix test to decouple miner fund from `bitcoincash:` prefix and fix test.
Dec 15 2020, 22:37
majcosta retitled D8675: decouple miner fund from `bitcoincash:` prefix and fix test from [tests] decouple miner fund from `bitcoincash:` prefix and fix test to [minerfund] decouple miner fund from `bitcoincash:` prefix and fix test.
Dec 15 2020, 22:37
majcosta published D8675: decouple miner fund from `bitcoincash:` prefix and fix test for review.
Dec 15 2020, 22:33
majcosta accepted D8674: Make uploading the assets optional when creating a release draft.
Dec 15 2020, 12:51
majcosta added a comment to D8674: Make uploading the assets optional when creating a release draft.

that link is a 404 for me

Dec 15 2020, 12:27

Dec 13 2020

majcosta accepted D8670: Add a dumpcoins RPC to dump the coins available in the wallet.
Dec 13 2020, 17:32
majcosta requested changes to D8670: Add a dumpcoins RPC to dump the coins available in the wallet.
Dec 13 2020, 17:08
majcosta accepted D8669: nits in the wallet and descriptor code.
Dec 13 2020, 17:03
majcosta retitled D8669: nits in the wallet and descriptor code from nits in the wallet and descritor code to nits in the wallet and descriptor code.
Dec 13 2020, 16:31

Dec 12 2020

majcosta accepted D8667: wallet: allow transaction without change if keypool is empty.
Dec 12 2020, 21:27
majcosta closed D8664: [backport#16090] Qt: Add vertical spacer to peer detail widget.
Dec 12 2020, 20:58
majcosta committed rABCdbe10f3c47d8: [backport#16090] Qt: Add vertical spacer to peer detail widget (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#16090] Qt: Add vertical spacer to peer detail widget
Dec 12 2020, 20:58
majcosta closed D8665: [backport#16044] qt: fix opening bitcoin.conf via Preferences on macOS.
Dec 12 2020, 20:57
majcosta committed rABCa01b61c5f17d: [backport#16044] qt: fix opening bitcoin.conf via Preferences on macOS (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#16044] qt: fix opening bitcoin.conf via Preferences on macOS
Dec 12 2020, 20:57

Dec 11 2020

majcosta requested review of D8665: [backport#16044] qt: fix opening bitcoin.conf via Preferences on macOS.
Dec 11 2020, 19:27
majcosta requested review of D8664: [backport#16090] Qt: Add vertical spacer to peer detail widget.
Dec 11 2020, 18:56
majcosta closed D8660: [backport#16377 2/2][rpc] fundrawtransaction: add_inputs option to control automatic input adding.
Dec 11 2020, 17:26
majcosta committed rABC1b8a6cbb0522: [backport#16377 2/2][rpc] fundrawtransaction: add_inputs option to control… (authored by Sjors Provoost <sjors@sprovoost.nl>).
[backport#16377 2/2][rpc] fundrawtransaction: add_inputs option to control…
Dec 11 2020, 17:26
majcosta closed D8659: [backport#16377 1/2][rpc] walletcreatefundedpsbt: don't automatically append inputs.
Dec 11 2020, 17:25
majcosta committed rABCa3c6da56e3fc: [backport#16377 1/2][rpc] walletcreatefundedpsbt: don't automatically append… (authored by Sjors Provoost <sjors@sprovoost.nl>).
[backport#16377 1/2][rpc] walletcreatefundedpsbt: don't automatically append…
Dec 11 2020, 17:25
majcosta updated the summary of D8660: [backport#16377 2/2][rpc] fundrawtransaction: add_inputs option to control automatic input adding.
Dec 11 2020, 15:39
majcosta requested review of D8660: [backport#16377 2/2][rpc] fundrawtransaction: add_inputs option to control automatic input adding.
Dec 11 2020, 15:10
majcosta requested review of D8659: [backport#16377 1/2][rpc] walletcreatefundedpsbt: don't automatically append inputs.
Dec 11 2020, 15:09

Dec 10 2020

majcosta accepted D8648: refactor: Fix unreachable code in init arg checks.
Dec 10 2020, 20:23
majcosta accepted D8647: gui: Do not translate InitWarning messages in debug.log.
Dec 10 2020, 19:10
majcosta accepted D8643: test: Pass ArgsManager into getarg_tests.
Dec 10 2020, 15:09

Dec 9 2020

majcosta accepted D8639: test: Avoid accessing free'd memory in validation_chainstatemanager_tests.
Dec 9 2020, 16:15
majcosta requested review of D8633: [refactor] use compile time string_view for DBKeys.
Dec 9 2020, 13:02

Dec 8 2020

majcosta accepted D8629: Convert chain and blockfileinfo to new serialization.
Dec 8 2020, 15:23
majcosta accepted D8627: Convert VARINT to the formatter/Using approach.
Dec 8 2020, 15:08
majcosta accepted D8626: Add a generic approach for (de)serialization of objects using code in other classes.
Dec 8 2020, 15:04
majcosta closed D7041: [refactor] remove const CChainParams& object from CWallet.
Dec 8 2020, 15:00
majcosta committed rABCa1e3e13501c0: [refactor] remove const CChainParams& object from CWallet (authored by majcosta).
[refactor] remove const CChainParams& object from CWallet
Dec 8 2020, 15:00
majcosta accepted D8630: Work around GCC -Wmaybe-uninitialized false positive.
Dec 8 2020, 14:51
majcosta accepted D8628: Fix the functional tests on platforms using select() instead of poll().
Dec 8 2020, 14:27
majcosta closed D8203: [backport#16400] refactor: Rewrite AcceptToMemoryPoolWorker() using smaller parts.
Dec 8 2020, 14:02
majcosta committed rABC3b83c27d9a15: [backport#16400] refactor: Rewrite AcceptToMemoryPoolWorker() using smaller… (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#16400] refactor: Rewrite AcceptToMemoryPoolWorker() using smaller…
Dec 8 2020, 14:02
majcosta abandoned D5930: Test diff; please ignore.
Dec 8 2020, 00:12

Dec 7 2020

majcosta accepted D8622: Fix seeder linking due to missing dependency in libcommon.
Dec 7 2020, 22:00
majcosta updated the diff for D7041: [refactor] remove const CChainParams& object from CWallet.

rebase

Dec 7 2020, 19:09
majcosta updated the diff for D8203: [backport#16400] refactor: Rewrite AcceptToMemoryPoolWorker() using smaller parts.

addressed feedback and prefetched the next block's verify flags in order to make it a const member of Workspace

Dec 7 2020, 18:28
majcosta accepted D8619: gui: simplify wallet_model creation.
Dec 7 2020, 15:54
majcosta accepted D8615: walletdb: Move BDB specific things into bdb.{cpp/h}.
Dec 7 2020, 14:46
majcosta accepted D8618: Refactor: clean up PeriodicFlush().
Dec 7 2020, 13:55
majcosta accepted D8617: wallet: Move BerkeleyBatch static functions to BerkeleyDatabase.
Dec 7 2020, 13:51
majcosta accepted D8616: wallet: Remove boost from PeriodicFlush.
Dec 7 2020, 13:46

Dec 6 2020

majcosta accepted D8608: [CashTab] Only show console messages if test fails.
Dec 6 2020, 20:54

Dec 4 2020

majcosta added inline comments to D8605: Bump DEFAULT_MAX_PEER_CONNECTIONS to 4096.
Dec 4 2020, 19:52
majcosta accepted D8605: Bump DEFAULT_MAX_PEER_CONNECTIONS to 4096.
Dec 4 2020, 17:26
majcosta accepted D8599: Add a way to verify schnorr signatures from an array..

fair enough

Dec 4 2020, 16:01
majcosta accepted D8603: [avalanche] Fix race condition during destruction in poll_and_response test.
Dec 4 2020, 13:00
majcosta requested changes to D8599: Add a way to verify schnorr signatures from an array..
Dec 4 2020, 11:47

Dec 3 2020

majcosta accepted D8598: Add release notes about salvage changes.
Dec 3 2020, 20:11
majcosta accepted D8597: Move RecoverKeysOnlyFilter into RecoverDataBaseFile.
Dec 3 2020, 20:10
majcosta accepted D8596: Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h}.
Dec 3 2020, 19:56
majcosta accepted D8595: Make BerkeleyBatch::Recover and WalletBatch::RecoverKeysOnlyFilter standalone.
Dec 3 2020, 19:25
majcosta accepted D8594: Expose a version of ReadKeyValue and use it in RecoverKeysOnlyFilter.
Dec 3 2020, 19:07
majcosta accepted D8593: Move BerkeleyEnvironment::Salvage into BerkeleyBatch::Recover.
Dec 3 2020, 18:58
majcosta accepted D8592: walletdb: remove fAggressive from Salvage.
Dec 3 2020, 18:47
majcosta accepted D8591: walletdb: don't automatically salvage when corruption is detected.
Dec 3 2020, 18:24
majcosta accepted D8590: wallet: remove -salvagewallet.
Dec 3 2020, 18:17
majcosta accepted D8589: Add basic test for bitcoin-wallet salvage.
Dec 3 2020, 18:15
majcosta accepted D8588: wallettool: Add a salvage command.
Dec 3 2020, 18:11
majcosta updated the summary of D8588: wallettool: Add a salvage command.
Dec 3 2020, 18:10
majcosta accepted D8586: Remove g_rpc_chain global.
Dec 3 2020, 17:20
majcosta accepted D8585: [CI] Increase IBD timeout.
Dec 3 2020, 13:41
majcosta requested changes to D8586: Remove g_rpc_chain global.
Dec 3 2020, 13:41

Dec 2 2020

majcosta accepted D8580: [avalanche] Use more sensible banscores.
Dec 2 2020, 21:44
First
Prev
Next