Why not just check for IBD status in runEventLoop ? What benefit does all this complication achieves?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Apr 8 2021
Apr 7 2021
Apr 6 2021
Some open question, but this is better.
Apr 3 2021
What problem removing the distinction between master key and session key solves? It seems to me like it's making security of the whole thing worse for no good reason.
Apr 1 2021
The use case does not make sense. You don't want to have a long delegation chain for all the node one after the other anyways, you want to have a master key and delegate to each node. There is no point delegating to begin with if the master also have all the private key to which it is delegating. If you want to do that, you might as well distribute the master key instead of devising a complicated scheme that isn't any more secure.
You want to fix the proof size handling before moving on there, or you'll just multiply the point where this needs fixing.
Mar 30 2021
What problem is this solving?
Feb 23 2021
Jan 26 2021
rebase from hell
Jan 23 2021
Jan 22 2021
Jan 21 2021
Back to your queue due to test failures.
Jan 18 2021
The config is needed down the road is just saying nothing at all.
You say that it differs from the original by passing a config, but provide no reason as to why. It doesn't looks like to me that this difference is justified.
Jan 16 2021
Jan 14 2021
In D8899#204315, @PiRK wrote:I added a few tests, but now I 'm no longer sure that all situations described in the PR are possible. I don't know how to reasonably generate a CTransaction whose outputs would add up to an int64 overflow without any single one of the outputs being larger than MAX_MONEY.
It would require 439208192231 outputs.
Jan 13 2021
I know there isn't int he original code, but there should really be tests cases for this.
Jan 12 2021
Jan 11 2021
Address comments
rebase
Jan 10 2021
The requested change differ from the existing code style for a benefit that is at best elusive.
Remove debug logs
Jan 9 2021
Fix node version message (relay and extra entropy were reverted)
Jan 8 2021
Updated package-lock and rebase
In D8838#202946, @josephroyking wrote:I'm able to get npm install to work here with node v15.3.0 or v15.4.0 and npm v7.0.15 (but package-lock.json is different)
npm v7.3.0 runs into dependency issue without --legacy-peer-deps
What version of node and npm did you use for this diff?
Could you please run
cd cashtab/web rm -rf node_modules rm package-lock-json npm iand submit?
Check build failure
Jan 7 2021
If you need --legacy-peer-deps you have regressed something.
1/ I cannot reproduce, npm start works just fine on master.
2/ Knowing what the error is would help assert if the solution is appropriate.
Removed @testing-library/react-hooks because it has conflicts, and it doesn't seems liek it is used. It would be good to double check, because everything seems busted around here.