Page MenuHomePhabricator
Feed Advanced Search

Apr 8 2021

deadalnix accepted D9381: [SECP256K1] Extract the secret key from a keypair.
Apr 8 2021, 13:04
deadalnix accepted D9377: [SECP256K1] sage: Add script for generating scalar_split_lambda constants.
Apr 8 2021, 13:03
deadalnix accepted D9373: [SECP256K1] Don't use reserved identifiers memczero and benchmark_verify_t.
Apr 8 2021, 13:03

Apr 7 2021

deadalnix requested changes to D9368: [avalanche] move proof verification code to processor.cpp.
Apr 7 2021, 17:04
deadalnix requested changes to D9345: [avalanche] set a minimum amount for a proof.
Apr 7 2021, 15:40

Apr 6 2021

deadalnix added inline comments to D9371: [avalanche] delay executing avalanche event loop until IBD is done.
Apr 6 2021, 23:31
deadalnix requested changes to D9371: [avalanche] delay executing avalanche event loop until IBD is done.

Why not just check for IBD status in runEventLoop ? What benefit does all this complication achieves?

Apr 6 2021, 23:30
deadalnix requested changes to D9368: [avalanche] move proof verification code to processor.cpp.

Some open question, but this is better.

Apr 6 2021, 15:26

Apr 3 2021

deadalnix accepted D8673: Add -overridednsseed for testing DNS seed behavior.
Apr 3 2021, 20:39
deadalnix requested changes to D9345: [avalanche] set a minimum amount for a proof.
Apr 3 2021, 20:37
deadalnix requested changes to D9365: [avalanche] Add an option to import a delegation.

What problem removing the distinction between master key and session key solves? It seems to me like it's making security of the whole thing worse for no good reason.

Apr 3 2021, 19:57

Apr 1 2021

deadalnix requested changes to D9361: [avalanche] Build a stripped delegation to remove unnecessary levels.

The use case does not make sense. You don't want to have a long delegation chain for all the node one after the other anyways, you want to have a master key and delegate to each node. There is no point delegating to begin with if the master also have all the private key to which it is delegating. If you want to do that, you might as well distribute the master key instead of devising a complicated scheme that isn't any more secure.

Apr 1 2021, 12:28
deadalnix requested changes to D9345: [avalanche] set a minimum amount for a proof.
Apr 1 2021, 12:25
deadalnix accepted D9360: [avalanche] add an inventory type and a message for proofs.
Apr 1 2021, 12:23
deadalnix requested changes to D9364: [avalanche] start implementing reception of avaproof.

You want to fix the proof size handling before moving on there, or you'll just multiply the point where this needs fixing.

Apr 1 2021, 12:23

Mar 30 2021

deadalnix accepted D8899: Check for overflow when calculating sum of outputs.
Mar 30 2021, 16:17
deadalnix requested changes to D9360: [avalanche] add an inventory type and a message for proofs.
Mar 30 2021, 16:15
deadalnix requested changes to D9361: [avalanche] Build a stripped delegation to remove unnecessary levels.

What problem is this solving?

Mar 30 2021, 15:06

Feb 23 2021

deadalnix closed D9263: Update links in CONTRIBUTE.md.
Feb 23 2021, 17:24
deadalnix committed rABCb9efc788c9be: Update links in CONTRIBUTE.md (authored by deadalnix).
Update links in CONTRIBUTE.md
Feb 23 2021, 17:24
deadalnix requested review of D9263: Update links in CONTRIBUTE.md.
Feb 23 2021, 17:02

Jan 26 2021

deadalnix updated the diff for D8671: Add a --descriptors option to various tests.

rebase from hell

Jan 26 2021, 16:32

Jan 23 2021

deadalnix accepted D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 23 2021, 20:50
deadalnix accepted D9046: Add Trunk Based Development link to CONTRIBUTING.
Jan 23 2021, 00:25

Jan 22 2021

deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.
Jan 22 2021, 23:06
deadalnix abandoned D8811: [cashtab] Upgrade node modules.
Jan 22 2021, 23:00

Jan 21 2021

deadalnix accepted D9017: script: prevent UB when computing abs value for num opcode serialize.
Jan 21 2021, 20:52
deadalnix accepted D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.
Jan 21 2021, 20:51
deadalnix requested changes to D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

Back to your queue due to test failures.

Jan 21 2021, 18:12

Jan 18 2021

deadalnix requested changes to D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

The config is needed down the road is just saying nothing at all.

Jan 18 2021, 21:58
deadalnix requested changes to D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 18 2021, 17:03
deadalnix requested changes to D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

You say that it differs from the original by passing a config, but provide no reason as to why. It doesn't looks like to me that this difference is justified.

Jan 18 2021, 13:27
deadalnix accepted D8941: test: Replace boost::mutex with std::mutex.
Jan 18 2021, 13:26

Jan 16 2021

deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.
Jan 16 2021, 15:55

Jan 14 2021

deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.
In D8899#204315, @PiRK wrote:

I added a few tests, but now I 'm no longer sure that all situations described in the PR are possible. I don't know how to reasonably generate a CTransaction whose outputs would add up to an int64 overflow without any single one of the outputs being larger than MAX_MONEY.
It would require 439208192231 outputs.

Jan 14 2021, 02:51

Jan 13 2021

deadalnix closed D8901: [CashTab] Update react-copy-to-clipboard.
Jan 13 2021, 17:05
deadalnix committed rABCc17adeb89179: [CashTab] Update react-copy-to-clipboard (authored by deadalnix).
[CashTab] Update react-copy-to-clipboard
Jan 13 2021, 17:05
deadalnix accepted D8900: RPC: Fix more formatting nits.
Jan 13 2021, 14:58
deadalnix requested review of D8901: [CashTab] Update react-copy-to-clipboard.
Jan 13 2021, 14:50
deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.

I know there isn't int he original code, but there should really be tests cases for this.

Jan 13 2021, 14:22
deadalnix accepted D8762: [backport#16658] validation: Rename CheckInputs to CheckInputScripts.
Jan 13 2021, 14:21

Jan 12 2021

deadalnix accepted D8886: Update copyright year to 2021.
Jan 12 2021, 23:12
deadalnix accepted D8883: Limit decimal range of numbers ParseScript accepts.
Jan 12 2021, 15:54
deadalnix accepted D8882: util: Fail to parse space-only strings in ParseMoney(...) (instead of parsing as zero).
Jan 12 2021, 15:34
deadalnix closed D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..
Jan 12 2021, 11:35
deadalnix committed rABC42a8d3bc2caa: [avalanche] Initiate avalanche when the service bit is present and we have a… (authored by deadalnix).
[avalanche] Initiate avalanche when the service bit is present and we have a…
Jan 12 2021, 11:35
deadalnix accepted D8879: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps.
Jan 12 2021, 10:58
deadalnix accepted D8880: lockedpool: avoid sensitive data in core files (FreeBSD).
Jan 12 2021, 10:57

Jan 11 2021

deadalnix accepted D8877: [CI] Work around LCOV stupid behavior.
Jan 11 2021, 23:11
deadalnix updated the diff for D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..

Address comments

Jan 11 2021, 23:04
deadalnix added inline comments to D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..
Jan 11 2021, 20:26
deadalnix updated the diff for D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..

rebase

Jan 11 2021, 01:47
deadalnix closed D8861: [net] Add extra entropy to the version message.
Jan 11 2021, 01:34
deadalnix committed rABC9343802bc731: [net] Add extra entropy to the version message (authored by deadalnix).
[net] Add extra entropy to the version message
Jan 11 2021, 01:34

Jan 10 2021

deadalnix requested review of D8861: [net] Add extra entropy to the version message.

The requested change differ from the existing code style for a benefit that is at best elusive.

Jan 10 2021, 16:12
deadalnix updated the diff for D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..

Remove debug logs

Jan 10 2021, 03:20

Jan 9 2021

deadalnix requested review of D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..
Jan 9 2021, 23:44
deadalnix updated the diff for D8861: [net] Add extra entropy to the version message.

Fix node version message (relay and extra entropy were reverted)

Jan 9 2021, 23:19
deadalnix closed D8860: [test framework] Simplify version message handling.
Jan 9 2021, 22:03
deadalnix committed rABC3584de484d22: [test framework] Simplify version message handling (authored by deadalnix).
[test framework] Simplify version message handling
Jan 9 2021, 22:03
deadalnix updated the summary of D8861: [net] Add extra entropy to the version message.
Jan 9 2021, 22:03
deadalnix requested review of D8861: [net] Add extra entropy to the version message.
Jan 9 2021, 22:02
deadalnix requested review of D8860: [test framework] Simplify version message handling.
Jan 9 2021, 21:00
deadalnix closed D8850: [cashtab] Update to react 17.
Jan 9 2021, 15:54
deadalnix committed rABC1e0eb96c2ff0: [cashtab] Update to react 17 (authored by deadalnix).
[cashtab] Update to react 17
Jan 9 2021, 15:54

Jan 8 2021

deadalnix accepted D8845: rpc: Document an RPCResult for all calls; Enforce at compile time.
Jan 8 2021, 16:28
deadalnix accepted D8849: [cashtab] use npm ci instead of install on CI.
Jan 8 2021, 15:34
deadalnix requested review of D8850: [cashtab] Update to react 17.
Jan 8 2021, 15:29
deadalnix closed D8838: [cashtab] Upgrade webpack modules.
Jan 8 2021, 14:41
deadalnix committed rABC0dddb517c3f8: [cashtab] Upgrade webpack modules (authored by deadalnix).
[cashtab] Upgrade webpack modules
Jan 8 2021, 14:41
deadalnix requested review of D8838: [cashtab] Upgrade webpack modules.
Jan 8 2021, 14:00
deadalnix updated the diff for D8838: [cashtab] Upgrade webpack modules.

Updated package-lock and rebase

Jan 8 2021, 13:43
deadalnix added a comment to D8838: [cashtab] Upgrade webpack modules.
In D8838#202946, @josephroyking wrote:

I'm able to get npm install to work here with node v15.3.0 or v15.4.0 and npm v7.0.15 (but package-lock.json is different)

npm v7.3.0 runs into dependency issue without --legacy-peer-deps

What version of node and npm did you use for this diff?

Could you please run

cd cashtab/web
rm -rf node_modules
rm package-lock-json
npm i

and submit?

Jan 8 2021, 13:43
deadalnix closed D8841: [cashtab] Downgrade css-loader.
Jan 8 2021, 13:38
deadalnix committed rABCb1515370602b: [cashtab] Downgrade css-loader (authored by deadalnix).
[cashtab] Downgrade css-loader
Jan 8 2021, 13:38
deadalnix requested changes to D8845: rpc: Document an RPCResult for all calls; Enforce at compile time.

Check build failure

Jan 8 2021, 11:06
deadalnix accepted D8846: Fix mining to an invalid target + ensure that a new block has the correct hash internally in Python tests.
Jan 8 2021, 11:05
deadalnix requested changes to D8673: Add -overridednsseed for testing DNS seed behavior.
Jan 8 2021, 11:04
deadalnix accepted D8847: tests: simplify next_block() function in feature_block.
Jan 8 2021, 11:02
deadalnix accepted D8848: rand: remove getentropy() fallback for macOS < 10.12.
Jan 8 2021, 11:02

Jan 7 2021

deadalnix requested review of D8841: [cashtab] Downgrade css-loader.
Jan 7 2021, 21:05
deadalnix accepted D8828: [CASHTAB] Update the jest dependency.
Jan 7 2021, 18:57
deadalnix requested review of D8838: [cashtab] Upgrade webpack modules.
Jan 7 2021, 18:56
deadalnix accepted D8830: test: Add missing syncwithvalidationinterfacequeue.
Jan 7 2021, 15:45
deadalnix accepted D8829: Remove redundant type information from rpc docs.
Jan 7 2021, 15:44
deadalnix accepted D8831: util: HelpExampleRpc formatting fixup.
Jan 7 2021, 15:43
deadalnix requested changes to D8828: [CASHTAB] Update the jest dependency.

If you need --legacy-peer-deps you have regressed something.

Jan 7 2021, 15:39
deadalnix requested changes to D8825: css-loader to highest version without breaking npm start.

1/ I cannot reproduce, npm start works just fine on master.
2/ Knowing what the error is would help assert if the solution is appropriate.

Jan 7 2021, 14:41
deadalnix updated the diff for D8811: [cashtab] Upgrade node modules.

Removed @testing-library/react-hooks because it has conflicts, and it doesn't seems liek it is used. It would be good to double check, because everything seems busted around here.

Jan 7 2021, 06:12
deadalnix closed D8818: [cashtab] Upgrade mini-css-extract-plugin.
Jan 7 2021, 06:09
deadalnix committed rABC57dcf13a43d3: [cashtab] Upgrade mini-css-extract-plugin (authored by deadalnix).
[cashtab] Upgrade mini-css-extract-plugin
Jan 7 2021, 06:09
deadalnix closed D8819: [cashtab] Update css-loader.
Jan 7 2021, 06:08
deadalnix committed rABC3586bf69bd64: [cashtab] Update css-loader (authored by deadalnix).
[cashtab] Update css-loader
Jan 7 2021, 06:08
deadalnix closed D8814: [cashtab] Update file-loader and fs-extra.
Jan 7 2021, 06:07
deadalnix committed rABC77b7324561c4: [cashtab] Update file-loader and fs-extra (authored by deadalnix).
[cashtab] Update file-loader and fs-extra
Jan 7 2021, 06:07
deadalnix closed D8813: [cashtab] Upgrade eslint.
Jan 7 2021, 06:05
deadalnix committed rABCd8be8a399c7d: [cashtab] Upgrade eslint (authored by deadalnix).
[cashtab] Upgrade eslint
Jan 7 2021, 06:05
deadalnix closed D8812: [cashtab] Update webpack.
Jan 7 2021, 06:04
deadalnix committed rABC9f4ec7600822: [cashtab] Update webpack (authored by deadalnix).
[cashtab] Update webpack
Jan 7 2021, 06:04
deadalnix requested review of D8819: [cashtab] Update css-loader.
Jan 7 2021, 06:00