(no "pay too many")

You can't pay to many, but still can pay too much with aliases !

use constant for server url

improve error message and store server url as a constant

bump to latest published ecash-coinselect

Issue has already been patched in explorer.be.cash, in the future should check this first ... though good exercise and all to find where the issue is arising here

remove debug test change

tested with for i in {1..100} ; do ./test/functional/test_runner.py abc_p2p_avalanche_cooldown ; done
It seems to be reliable.

std::chrono::timepoint is not trivially copyable with all versions of the lib, so let'd drop the atomic. This variable is only accessed from the net thread anyway.

Attempt to fix the warning that I can't reproduce locally

gate the feature behind an activation flag, add the action also to the Wallet > Contacts menu

Please gate this feature behind a dev flag for now as aliases are not production ready yet.

some significant improvements available by getting rid of redundant state variables. Might want to think about how you want to implement this. We are getting into a complex review here.

remove line break, use determined variable in sumValues

assert check in sumValues, use native js array type checking with unit tested buffer support

@bot build-ibd

Will not land this until all the upgrade items are completed

typo nits

In D14542#326630, @Fabien wrote:

This does not add support for aliases, only add the type which is unused ?

Responding to feedback

This does not add support for aliases, only add the type which is unused ?

undo debugging patch