(Note that the functional test is identical to the prior version of this diff. This diff changes all externally-observable behaviour, and the follow ups just perform internal cleanup.)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 14 2019
Jun 14 2019
markblundeberg retitled D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests from remove Schnorr flag and clean up tests to remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.
rebase onto split parent
rebased onto split parent
rebased onto split-up schnorr removal diffs
markblundeberg added a revision to T653: Clean up past upgrades: D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.
rework into first of multiple parts
missed a few spots!
Jun 13 2019
Jun 13 2019
markblundeberg added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..
use GetId
markblundeberg added inline comments to D3310: Merge #14085: index: Fix for indexers skipping genesis block..
What I recall is that the new label commands that get added are sorted in correctly, and it's the existing label entries that are wrong. So we do want this Diff, and indeed some old code isn't cleaned up right.
Confirm (note: at this time the mainnet block is 9 confs old).
markblundeberg added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..
address comments
markblundeberg added inline comments to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.
markblundeberg added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.
take out accidental backported line
markblundeberg updated the summary of D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.
finally found the bug that was making tests fail! (D3312)
This should in principle work on master now, once rebased...
I tried backporting this one and I noticed that it produced duplicate entries for commands with "label" in the name, and I couldn't figure out why.... Is that still the case now? Can "examine bitcoin-cli help" be added to test plan?
markblundeberg added a comment to D3181: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning.
rebase for freshness
Jun 12 2019
Jun 12 2019
In D3270#77765, @deadalnix wrote:There is already logic to check if a push is minimal or not, duplicating indicate the approach is wrong.
Jun 11 2019
Jun 11 2019
markblundeberg added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.
still awful
Jun 10 2019
Jun 10 2019
markblundeberg added a comment to D3279: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json.
Hmm looks like transaction_tests.cpp (e.g., BOOST_AUTO_TEST_CASE(tx_invalid) comment) needs to be updated as well.
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
In D3270#77358, @jasonbcox wrote:Needs a summary. What's the goal here?
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
remove newline from timing.json
Jun 9 2019
Jun 9 2019
rebase for D3262 & tweak accordingly
update comment per suggestion
Probably going to abandon this. The motivation was to avoid using int for a bitfield as it has implementation-defined length, but I think I will just use use asserts / tests to get rid of weird platforms.
update per comments
In D3270#77156, @teamcity wrote:Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.
tweak names; add multisig test too
markblundeberg added inline comments to D3267: check negative CScriptNum.getint() and introduce new error code.
markblundeberg updated the summary of D3267: check negative CScriptNum.getint() and introduce new error code.
oops, missed the json tests somehow
Oopsie nope, this *was* tested already! ( in script_tests.json)
markblundeberg planned changes to D3267: check negative CScriptNum.getint() and introduce new error code.
Jun 8 2019
Jun 8 2019
markblundeberg added a comment to D3267: check negative CScriptNum.getint() and introduce new error code.
*sigh* this works on my local machine, I swear! =D
markblundeberg added a comment to D3267: check negative CScriptNum.getint() and introduce new error code.
rebase just to get another build (mystery teamcity fail)