Page MenuHomePhabricator
Feed Advanced Search

Apr 7 2020

deadalnix committed rSTAGINGd89645b02fe2: Kill AddKeypathToMap (authored by deadalnix).
Kill AddKeypathToMap
Apr 7 2020, 21:47
deadalnix committed rSTAGINGb386fce87d7b: Make SignPSBTInput operate on a private SignatureData object (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make SignPSBTInput operate on a private SignatureData object
Apr 7 2020, 21:47
deadalnix committed rSTAGING8a31c2afd39f: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool (authored by practicalswift <practicalswift@users.noreply.github.com>).
util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool
Apr 7 2020, 21:47
deadalnix committed rSTAGING0f0b515c75a8: Pass HD path data through SignatureData (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Pass HD path data through SignatureData
Apr 7 2020, 21:47
deadalnix committed rSTAGINGa3884c52a1cc: wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an… (authored by practicalswift <practicalswift@users.noreply.github.com>).
wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an…
Apr 7 2020, 21:47
deadalnix committed rSTAGINGf3f969bc3917: Implement key origin lookup in CWallet (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Implement key origin lookup in CWallet
Apr 7 2020, 21:47
deadalnix committed rSTAGING93aa869bfd7e: Generalize PublicOnlySigningProvider into HidingSigningProvider (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Generalize PublicOnlySigningProvider into HidingSigningProvider
Apr 7 2020, 21:47
deadalnix committed rSTAGINGe6c6db649672: Update valid PSBT test vectors so that they properly use the value 0 for… (authored by deadalnix).
Update valid PSBT test vectors so that they properly use the value 0 for…
Apr 7 2020, 21:46
deadalnix committed rSTAGINGba3dabfd5980: More tests of signer checks (authored by Andrew Chow <achow101-github@achow101.com>).
More tests of signer checks
Apr 7 2020, 21:46
deadalnix committed rSTAGINGd32a1d5f5fe6: Make SigningProvider expose key origin information (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make SigningProvider expose key origin information
Apr 7 2020, 21:45
deadalnix committed rSTAGING239e9c2a5517: [MOVEONLY] Move ParseHDKeypath to utilstrencodings (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[MOVEONLY] Move ParseHDKeypath to utilstrencodings
Apr 7 2020, 21:45
deadalnix committed rSTAGING961cb3f865d5: Introduce KeyOriginInfo for fingerprint + path (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Introduce KeyOriginInfo for fingerprint + path
Apr 7 2020, 21:45
deadalnix committed rSTAGING64b198f39284: Test that a non-witness script as witness utxo is not signed (authored by Andrew Chow <achow101-github@achow101.com>).
Test that a non-witness script as witness utxo is not signed
Apr 7 2020, 21:44
deadalnix committed rSTAGING0f2655706817: Use 72 byte dummy signatures when watching only inputs may be used (authored by Andrew Chow <achow101-github@achow101.com>).
Use 72 byte dummy signatures when watching only inputs may be used
Apr 7 2020, 21:44
deadalnix committed rSTAGING0f5488cfa05d: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR (authored by Andrew Chow <achow101-github@achow101.com>).
Use 71 byte signature for DUMMY_SIGNATURE_CREATOR
Apr 7 2020, 21:44
deadalnix committed rSTAGING1a5829a4b8bf: Always create 70 byte signatures with low R values (authored by Andrew Chow <achow101-github@achow101.com>).
Always create 70 byte signatures with low R values
Apr 7 2020, 21:44
deadalnix committed rSTAGINGd9e677821dc6: Additional sanity checks in SignPSBTInput (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Additional sanity checks in SignPSBTInput
Apr 7 2020, 21:44
deadalnix committed rSTAGING449bfe2bb4b2: Add missing braces on key.cpp (authored by deadalnix).
Add missing braces on key.cpp
Apr 7 2020, 21:43
deadalnix committed rSTAGING6baa2c0642de: Fix merging of global unknown data in PSBTs (authored by Andrew Chow <achow101-github@achow101.com>).
Fix merging of global unknown data in PSBTs
Apr 7 2020, 21:42
deadalnix committed rSTAGINGd395b70087cb: Check that PSBT keys are the correct length (authored by Andrew Chow <achow101-github@achow101.com>).
Check that PSBT keys are the correct length
Apr 7 2020, 21:42
deadalnix committed rSTAGING5b3bb8c4ef57: Add brace in bitcoin-tx.cpp (authored by deadalnix).
Add brace in bitcoin-tx.cpp
Apr 7 2020, 21:42
deadalnix committed rSTAGINGc453a23e9675: Add outputtype module (authored by Anthony Towns <aj@erisian.com.au>).
Add outputtype module
Apr 7 2020, 21:42
deadalnix committed rSTAGINGe8f1ceb01f0c: Fix PSBT error test vectors (authored by deadalnix).
Fix PSBT error test vectors
Apr 7 2020, 21:42
deadalnix committed rSTAGING98d6c5327761: Various nits in the ChainParams code. (authored by deadalnix).
Various nits in the ChainParams code.
Apr 7 2020, 21:41
deadalnix committed rSTAGING2ca660ddcf75: Various nits in cuckoocache.h (authored by deadalnix).
Various nits in cuckoocache.h
Apr 7 2020, 21:41
deadalnix committed rSTAGINGee04f3cbc3e5: Add descriptor reference documentation (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Add descriptor reference documentation
Apr 7 2020, 21:41
deadalnix committed rSTAGINGda453ae29215: Swap in descriptors support into scantxoutset (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Swap in descriptors support into scantxoutset
Apr 7 2020, 21:41
deadalnix committed rSTAGINGa3f767ce220d: Output descriptors module (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Output descriptors module
Apr 7 2020, 21:41
deadalnix committed rSTAGING28f918df531c: Fix unecessary copies in rpcwallet.cpp (authored by deadalnix).
Fix unecessary copies in rpcwallet.cpp
Apr 7 2020, 21:40
deadalnix committed rSTAGINGef4d3766839c: Get rid of ambiguous OutputType::NONE value (authored by Russell Yanofsky <russ@yanofsky.org>).
Get rid of ambiguous OutputType::NONE value
Apr 7 2020, 21:40
deadalnix committed rSTAGING11ca044a129f: Add scantxoutset RPC method (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Add scantxoutset RPC method
Apr 7 2020, 21:40
deadalnix committed rSTAGING39959c11347e: Add simple FlatSigningProvider (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Add simple FlatSigningProvider
Apr 7 2020, 21:40
deadalnix committed rSTAGING2633916fbb90: Tests for PSBT (authored by Andrew Chow <achow101-github@achow101.com>).
Tests for PSBT
Apr 7 2020, 21:39
deadalnix committed rSTAGINGf25d2ad300d9: Create wallet RPCs for PSBT (authored by Andrew Chow <achow101-github@achow101.com>).
Create wallet RPCs for PSBT
Apr 7 2020, 21:39
deadalnix committed rSTAGING6e5278d36615: Create utility RPCs for PSBT (authored by Andrew Chow <achow101-github@achow101.com>).
Create utility RPCs for PSBT
Apr 7 2020, 21:37
deadalnix committed rSTAGING8544daeee4b5: Add more methods to Span class (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Add more methods to Span class
Apr 7 2020, 21:37
deadalnix committed rSTAGINGa5afd2ec6fda: Fix comment layout in client.h (authored by deadalnix).
Fix comment layout in client.h
Apr 7 2020, 21:36
deadalnix committed rSTAGINGf47f339d04c8: Various fixups for PR13557 (authored by deadalnix).
Various fixups for PR13557
Apr 7 2020, 21:35
deadalnix committed rSTAGING91b535a574ca: SignPSBTInput wrapper function (authored by Andrew Chow <achow101-github@achow101.com>).
SignPSBTInput wrapper function
Apr 7 2020, 21:32
deadalnix committed rSTAGINGddf9cd8d0e84: Methods for interacting with PSBT structs (authored by Andrew Chow <achow101-github@achow101.com>).
Methods for interacting with PSBT structs
Apr 7 2020, 21:32
deadalnix committed rSTAGING9bbebfb295ae: Add pubkeys and whether input was witness to SignatureData (authored by Andrew Chow <achow101-github@achow101.com>).
Add pubkeys and whether input was witness to SignatureData
Apr 7 2020, 21:32
deadalnix committed rSTAGING961326309588: Implement PSBT Structures and un/serialization methods per BIP 174 (authored by Andrew Chow <achow101-github@achow101.com>).
Implement PSBT Structures and un/serialization methods per BIP 174
Apr 7 2020, 21:32
deadalnix committed rSTAGING664862e1af6c: Refactor transaction creation and transaction funding logic (authored by Andrew Chow <achow101-github@achow101.com>).
Refactor transaction creation and transaction funding logic
Apr 7 2020, 21:31
deadalnix committed rSTAGING4d6e498e3767: Decodehextx scripts sanity check (authored by Andrew Chow <achow101-github@achow101.com>).
Decodehextx scripts sanity check
Apr 7 2020, 21:26
deadalnix committed rSTAGINGaaf5c6a6a702: Do not cache version in cmake build (authored by deadalnix).
Do not cache version in cmake build
Apr 7 2020, 21:25
deadalnix updated the diff for D5675: [avalanche] Require that a pubkey is associated with each avalanche peer..

Update as per comments

Apr 7 2020, 14:57
deadalnix accepted D5679: [CMAKE] Enable DBus on Linux only.
Apr 7 2020, 14:53
deadalnix added inline comments to D5675: [avalanche] Require that a pubkey is associated with each avalanche peer..
Apr 7 2020, 14:48
deadalnix updated the diff for D5673: [avalanche] Start polling when we park of block because of reorg.

Address comments

Apr 7 2020, 14:45
deadalnix created D5681: Clean cache and tmp directory for instegration tests.
Apr 7 2020, 14:03
deadalnix added inline comments to D5673: [avalanche] Start polling when we park of block because of reorg.
Apr 7 2020, 02:49

Apr 6 2020

deadalnix requested review of D5678: [avalanche] Poll tip candidate rather than eagerly.
Apr 6 2020, 16:17
deadalnix committed rABCfe0f75643fbe: Pass CChainParams down to DisconnectTip (authored by deadalnix).
Pass CChainParams down to DisconnectTip
Apr 6 2020, 15:41
deadalnix closed D5677: Pass CChainParams down to DisconnectTip.
Apr 6 2020, 15:41
deadalnix committed rABC9864e9884d36: Pass CChainParams down to UpdateTip (authored by deadalnix).
Pass CChainParams down to UpdateTip
Apr 6 2020, 15:39
deadalnix closed D5676: Pass CChainParams down to UpdateTip.
Apr 6 2020, 15:39

Apr 5 2020

deadalnix created D5678: [avalanche] Poll tip candidate rather than eagerly.
Apr 5 2020, 15:51

Apr 4 2020

deadalnix created D5677: Pass CChainParams down to DisconnectTip.
Apr 4 2020, 23:23
deadalnix created D5676: Pass CChainParams down to UpdateTip.
Apr 4 2020, 23:07
deadalnix created D5675: [avalanche] Require that a pubkey is associated with each avalanche peer..
Apr 4 2020, 18:04

Apr 3 2020

deadalnix updated the diff for D5673: [avalanche] Start polling when we park of block because of reorg.

Remove unecessary code

Apr 3 2020, 22:39
deadalnix updated the diff for D5673: [avalanche] Start polling when we park of block because of reorg.

Remove code that was comented out

Apr 3 2020, 21:52
deadalnix updated the diff for D5673: [avalanche] Start polling when we park of block because of reorg.

Rebase

Apr 3 2020, 21:36
deadalnix accepted D5671: bump libevent to 2.1.11 in depends.
Apr 3 2020, 16:43
deadalnix requested changes to D5669: depends: Add Android NDK support.

Is there any plan to actually support this? Because in its urrent form, it's going to be broken by next week and the main effect will be to have slowed down the depends bid and added a ton of dependencies (in fact, if I arc patch this, depends build fail for me and I have no idea why, probably because I'm missing something needed for android?).

Apr 3 2020, 16:42
deadalnix accepted D5672: depends: fix boost mac cross build with clang 9+.
Apr 3 2020, 16:34
deadalnix created D5673: [avalanche] Start polling when we park of block because of reorg.
Apr 3 2020, 16:03
deadalnix requested changes to D5380: [seeder] Require good seeds to have latest checkpoint.
Apr 3 2020, 13:58
deadalnix accepted D5664: depends: add ability to skip building qrencode.
Apr 3 2020, 13:19
deadalnix accepted D5665: build: don't embed a build-id when building libdmg-hfsplus.
Apr 3 2020, 13:19
deadalnix accepted D5666: build: pass -dead_strip_dylibs to ld on macOS.
Apr 3 2020, 13:18
deadalnix accepted D5667: depends: don't configure xcb_proto.
Apr 3 2020, 13:18
deadalnix accepted D5668: depends: Consistent use of package variable.
Apr 3 2020, 13:18
deadalnix committed rABC7df20faa1c55: Fix invalid use a memory order relaxed (authored by deadalnix).
Fix invalid use a memory order relaxed
Apr 3 2020, 13:13
deadalnix closed D5662: Fix invalid use a memory order relaxed.
Apr 3 2020, 13:13
deadalnix accepted D5659: Reword confusing warning message in RPC linter.
Apr 3 2020, 00:18
deadalnix committed rABC494840354212: Add setexcessiveblock to vRPCConvertParams (authored by deadalnix).
Add setexcessiveblock to vRPCConvertParams
Apr 3 2020, 00:15
deadalnix closed D5661: Add setexcessiveblock to vRPCConvertParams.
Apr 3 2020, 00:15

Apr 2 2020

deadalnix created D5662: Fix invalid use a memory order relaxed.
Apr 2 2020, 23:07
deadalnix updated the diff for D5661: Add setexcessiveblock to vRPCConvertParams.

Update branch name

Apr 2 2020, 22:43
deadalnix created D5661: Add setexcessiveblock to vRPCConvertParams.
Apr 2 2020, 22:37
deadalnix accepted D5649: [LINTER] Remove trailing whitespaces.
Apr 2 2020, 22:03
deadalnix accepted D5660: Only pass --disable-dependency-tracking to packages that understand it.
Apr 2 2020, 22:00
deadalnix requested changes to D5630: Test Commit; Please Ignore.
Apr 2 2020, 21:59
deadalnix requested changes to D5659: Reword confusing warning message in RPC linter.

This should not be part of the error message. Would something like disconnectnode does X, while getavalanchekey does Y. really be too much to ask for? Also a mention of rpc/client.cpp somewhere so one doesn't need a phd is archeology to figure out what's up?

Apr 2 2020, 21:58
deadalnix accepted D5657: depends: qt: Fix C{,XX} pickup.
Apr 2 2020, 17:40
deadalnix committed rABC3521a5ed6462: Also track dependencies of native targets (authored by deadalnix).
Also track dependencies of native targets
Apr 2 2020, 17:36
deadalnix closed D5641: Also track dependencies of native targets.
Apr 2 2020, 17:36
deadalnix updated the diff for D5641: Also track dependencies of native targets.

Address comments

Apr 2 2020, 16:54
deadalnix accepted D5656: depends: qt: Fix {C{,XX},LD}FLAGS pickup.
Apr 2 2020, 16:54
deadalnix requested changes to D5649: [LINTER] Remove trailing whitespaces.
Apr 2 2020, 16:53
deadalnix accepted D5654: build: switch to upstream libdmg-hfsplus.
Apr 2 2020, 16:50
deadalnix accepted D5653: depends: latest config.guess and config.sub.
Apr 2 2020, 16:48
deadalnix accepted D5652: build: Add variable printing target to Makefiles.
Apr 2 2020, 16:47
deadalnix accepted D5650: build: remove redundant sed patching.
Apr 2 2020, 16:47
deadalnix accepted D5651: Add OpenSSL termios fix for musl libc.
Apr 2 2020, 16:46
deadalnix accepted D5655: depends: zlib: Move toolchain options to configure.
Apr 2 2020, 16:46
deadalnix requested changes to D5657: depends: qt: Fix C{,XX} pickup.

It has a change with toolchain.prf that is missing.

Apr 2 2020, 16:44
deadalnix added inline comments to D5641: Also track dependencies of native targets.
Apr 2 2020, 16:42
deadalnix accepted D4816: depends macOS: point --sysroot to SDK.
Apr 2 2020, 16:38